)]}'
{"id":"depot~2584","triplet_id":"depot~canon~Ided0bc04c6e80ddb23ba4693d61ac9e08b002d58","project":"depot","branch":"canon","hashtags":[],"change_id":"Ided0bc04c6e80ddb23ba4693d61ac9e08b002d58","subject":"feat(tazjin/rlox): Implement expression statements","status":"MERGED","created":"2021-03-02 21:53:26.000000000","updated":"2021-03-03 10:52:34.000000000","submitted":"2021-03-03 10:51:05.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2584","meta_rev_id":"6d57f4ffd227128f27d53da2774b55dee47ddea5","_number":2584,"virtual_id_number":2584,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-03-03 10:51:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-03-03 10:51:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-02 21:54:37.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"77aa88c3018d5c4c478557b3d60bc48d390ca284","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-02 21:53:26.000000000","message":"Uploaded patch set 1: Code-Review+2.","accounts_in_message":[],"_revision_number":1},{"id":"f49d00ea34090a6720b14758dee4d9e4aa3bcbd8","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-03-02 21:54:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/5289","accounts_in_message":[],"_revision_number":1},{"id":"94ca009b5ceb6a38ce53b4952064616ed628b8c3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-03 10:50:50.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"523cfcb6e7dcd709e85b48c7201468abaac6f890","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-03 10:51:05.000000000","message":"Change has been successfully rebased and submitted as ed3fce2b19fa0d28054382093b019967a9a16177","accounts_in_message":[],"_revision_number":3},{"id":"c5a3ae3fc628df45d1badeeb6829509eb11794de","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-03-03 10:52:21.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/5292","accounts_in_message":[],"_revision_number":2},{"id":"6d57f4ffd227128f27d53da2774b55dee47ddea5","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-03-03 10:52:34.000000000","message":"Patch Set 3:\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/5293","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ed3fce2b19fa0d28054382093b019967a9a16177","revisions":{"450ce93688be304d6c1f835f1c316591725ab638":{"kind":"REWORK","_number":1,"created":"2021-03-02 21:53:26.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/84/2584/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/84/2584/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/84/2584/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/84/2584/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/84/2584/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/84/2584/1"}}},"commit":{"parents":[{"commit":"c3d001b30216ab5a7709637069e35113ff983c64","subject":"feat(tazjin/rlox): Add support for print statement","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc3d001b30216ab5a7709637069e35113ff983c64"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-02 20:26:02.000000000","tz":120},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-02 21:52:36.000000000","tz":120},"subject":"feat(tazjin/rlox): Implement expression statements","message":"feat(tazjin/rlox): Implement expression statements\n\nThese aren\u0027t particularly useful without side effects, but one step at\na time.\n\nThis diverges slightly from the book, in that OpPop retains the last\nvalue it \"forgot\" from the stack in a special field on the\ninterpreter.\n\nThis makes it possible to return values from expression statements,\nwhich helps in cases where Lox is embedded as a scripting\nlanguage (please don\u0027t do this ever) or in tests.\n\nChange-Id: Ided0bc04c6e80ddb23ba4693d61ac9e08b002d58\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d450ce93688be304d6c1f835f1c316591725ab638"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d450ce93688be304d6c1f835f1c316591725ab638"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c3d001b30216ab5a7709637069e35113ff983c64","is_merged_in_target_branch":false,"change_id":"Ic3e7e722325c8784b848c0bcd573c2e51e123c40","change_number":2583,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"29b5d8d311fba4a2c53bd3afc600310cec2f059f":{"kind":"NO_CHANGE","_number":2,"created":"2021-03-03 10:50:50.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/84/2584/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/84/2584/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/84/2584/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/84/2584/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/84/2584/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/84/2584/2"}}},"commit":{"parents":[{"commit":"2cd77ea26d76b20ff820f1ebe5e77f1360f5d1f5","subject":"feat(tazjin/rlox): Add support for print statement","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2cd77ea26d76b20ff820f1ebe5e77f1360f5d1f5"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-02 20:26:02.000000000","tz":120},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2021-03-03 10:50:50.000000000","tz":0},"subject":"feat(tazjin/rlox): Implement expression statements","message":"feat(tazjin/rlox): Implement expression statements\n\nThese aren\u0027t particularly useful without side effects, but one step at\na time.\n\nThis diverges slightly from the book, in that OpPop retains the last\nvalue it \"forgot\" from the stack in a special field on the\ninterpreter.\n\nThis makes it possible to return values from expression statements,\nwhich helps in cases where Lox is embedded as a scripting\nlanguage (please don\u0027t do this ever) or in tests.\n\nChange-Id: Ided0bc04c6e80ddb23ba4693d61ac9e08b002d58\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d29b5d8d311fba4a2c53bd3afc600310cec2f059f"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d29b5d8d311fba4a2c53bd3afc600310cec2f059f"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2cd77ea26d76b20ff820f1ebe5e77f1360f5d1f5","is_merged_in_target_branch":true,"change_id":"Ic3e7e722325c8784b848c0bcd573c2e51e123c40","change_number":2583,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"},"ed3fce2b19fa0d28054382093b019967a9a16177":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2021-03-03 10:51:05.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/84/2584/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/84/2584/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/84/2584/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/84/2584/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/84/2584/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/84/2584/3"}}},"commit":{"parents":[{"commit":"2cd77ea26d76b20ff820f1ebe5e77f1360f5d1f5","subject":"feat(tazjin/rlox): Add support for print statement","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2cd77ea26d76b20ff820f1ebe5e77f1360f5d1f5"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-02 20:26:02.000000000","tz":120},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2021-03-03 10:51:05.000000000","tz":0},"subject":"feat(tazjin/rlox): Implement expression statements","message":"feat(tazjin/rlox): Implement expression statements\n\nThese aren\u0027t particularly useful without side effects, but one step at\na time.\n\nThis diverges slightly from the book, in that OpPop retains the last\nvalue it \"forgot\" from the stack in a special field on the\ninterpreter.\n\nThis makes it possible to return values from expression statements,\nwhich helps in cases where Lox is embedded as a scripting\nlanguage (please don\u0027t do this ever) or in tests.\n\nChange-Id: Ided0bc04c6e80ddb23ba4693d61ac9e08b002d58\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2584\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ded3fce2b19fa0d28054382093b019967a9a16177"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ded3fce2b19fa0d28054382093b019967a9a16177"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2cd77ea26d76b20ff820f1ebe5e77f1360f5d1f5","is_merged_in_target_branch":true,"change_id":"Ic3e7e722325c8784b848c0bcd573c2e51e123c40","change_number":2583,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}