)]}'
{"id":"depot~2592","triplet_id":"depot~canon~I618ce8f789cb59b3a9c5b79a13111ea6d00b2424","project":"depot","branch":"canon","hashtags":[],"change_id":"I618ce8f789cb59b3a9c5b79a13111ea6d00b2424","subject":"feat(tazjin/rlox): Implement global variable definition","status":"MERGED","created":"2021-03-05 19:06:52.000000000","updated":"2021-03-06 11:53:54.000000000","submitted":"2021-03-06 11:52:00.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2594","meta_rev_id":"d37fc554bafbaad991e8d5438b871583a715bd59","_number":2592,"virtual_id_number":2592,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-03-06 11:52:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-03-06 11:52:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-05 19:09:08.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"026e8f49e804f5ef0850c56c9fdb599beb059806","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-05 19:06:52.000000000","message":"Uploaded patch set 1: Code-Review+2.","accounts_in_message":[],"_revision_number":1},{"id":"95f48b4aed1d0358030c270b0184762bf47000b0","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-03-05 19:09:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/5311","accounts_in_message":[],"_revision_number":1},{"id":"884f4bbf4e2bd522c132e982eb3750801c22b619","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-05 19:48:11.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"723b497916c1dc4a796d7b1651d220bc0a868be2","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-03-05 19:49:32.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/5312","accounts_in_message":[],"_revision_number":2},{"id":"c7c69c8b2eefbfb7f708dc908dcd414ff35aacb8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-06 11:52:00.000000000","message":"Change has been successfully rebased and submitted as 29b2a547055ba1adaf3f0d79055b7d7657eb3a5e","accounts_in_message":[],"_revision_number":3},{"id":"d37fc554bafbaad991e8d5438b871583a715bd59","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-03-06 11:53:54.000000000","message":"Patch Set 3:\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/5323","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"29b2a547055ba1adaf3f0d79055b7d7657eb3a5e","revisions":{"cf7b4d3ef81f6459ed53bd0b202ff5a0f0950b42":{"kind":"REWORK","_number":1,"created":"2021-03-05 19:06:52.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/92/2592/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/92/2592/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/92/2592/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/92/2592/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/92/2592/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/92/2592/1"}}},"commit":{"parents":[{"commit":"0254f4ed8f0eaa2f8563fb113e52f3ad36a5f0ed","subject":"fix(tazjin/rlox): Resynchronise after panicking","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0254f4ed8f0eaa2f8563fb113e52f3ad36a5f0ed"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-05 15:48:07.000000000","tz":120},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-05 19:05:05.000000000","tz":120},"subject":"feat(tazjin/rlox): Implement global variable definition","message":"feat(tazjin/rlox): Implement global variable definition\n\nidentifier_str might look a bit overengineered, but we want to reuse\nthis bit of code and it needs a reference to the token from which to\npick the identifier.\n\nThe problem with this is that the token would be owned by self, but\nthe function needs to mutate (the interner), so this implementation is\nthe most straightforward way of acquiring and working with an\nimmutable reference to the token before interning the identifier.\n\nChange-Id: I618ce8f789cb59b3a9c5b79a13111ea6d00b2424\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcf7b4d3ef81f6459ed53bd0b202ff5a0f0950b42"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcf7b4d3ef81f6459ed53bd0b202ff5a0f0950b42"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"0254f4ed8f0eaa2f8563fb113e52f3ad36a5f0ed","is_merged_in_target_branch":false,"change_id":"I60939f7a2c523b6ca1e9782e58c97959da38cfff","change_number":2591,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"78c50efb4158d9b34a60e4befac62f7c37be1bda":{"kind":"REWORK","_number":2,"created":"2021-03-05 19:48:11.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/92/2592/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/92/2592/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/92/2592/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/92/2592/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/92/2592/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/92/2592/2"}}},"commit":{"parents":[{"commit":"cc77fe21682c53bd012728ac45684b8ff6f91668","subject":"refactor(tazjin/rlox): Refactor Compiler::consume into a macro","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcc77fe21682c53bd012728ac45684b8ff6f91668"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-05 15:48:07.000000000","tz":120},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-05 19:47:54.000000000","tz":120},"subject":"feat(tazjin/rlox): Implement global variable definition","message":"feat(tazjin/rlox): Implement global variable definition\n\nidentifier_str might look a bit overengineered, but we want to reuse\nthis bit of code and it needs a reference to the token from which to\npick the identifier.\n\nThe problem with this is that the token would be owned by self, but\nthe function needs to mutate (the interner), so this implementation is\nthe most straightforward way of acquiring and working with an\nimmutable reference to the token before interning the identifier.\n\nChange-Id: I618ce8f789cb59b3a9c5b79a13111ea6d00b2424\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d78c50efb4158d9b34a60e4befac62f7c37be1bda"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d78c50efb4158d9b34a60e4befac62f7c37be1bda"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"cc77fe21682c53bd012728ac45684b8ff6f91668","is_merged_in_target_branch":false,"change_id":"I5cda9e36d6833bd9c259f7d4d8340db6e783b4e8","change_number":2593,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"29b2a547055ba1adaf3f0d79055b7d7657eb3a5e":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2021-03-06 11:52:00.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/92/2592/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/92/2592/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/92/2592/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/92/2592/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/92/2592/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/92/2592/3"}}},"commit":{"parents":[{"commit":"b7b94335cc3b2d5650a385e1f4a439a7ef6d30ff","subject":"refactor(tazjin/rlox): Refactor Compiler::consume into a macro","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db7b94335cc3b2d5650a385e1f4a439a7ef6d30ff"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-05 15:48:07.000000000","tz":120},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2021-03-06 11:52:00.000000000","tz":0},"subject":"feat(tazjin/rlox): Implement global variable definition","message":"feat(tazjin/rlox): Implement global variable definition\n\nidentifier_str might look a bit overengineered, but we want to reuse\nthis bit of code and it needs a reference to the token from which to\npick the identifier.\n\nThe problem with this is that the token would be owned by self, but\nthe function needs to mutate (the interner), so this implementation is\nthe most straightforward way of acquiring and working with an\nimmutable reference to the token before interning the identifier.\n\nChange-Id: I618ce8f789cb59b3a9c5b79a13111ea6d00b2424\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2592\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d29b2a547055ba1adaf3f0d79055b7d7657eb3a5e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d29b2a547055ba1adaf3f0d79055b7d7657eb3a5e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b7b94335cc3b2d5650a385e1f4a439a7ef6d30ff","is_merged_in_target_branch":true,"change_id":"I5cda9e36d6833bd9c259f7d4d8340db6e783b4e8","change_number":2593,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}