)]}'
{"id":"depot~2593","triplet_id":"depot~canon~I5cda9e36d6833bd9c259f7d4d8340db6e783b4e8","project":"depot","branch":"canon","hashtags":[],"change_id":"I5cda9e36d6833bd9c259f7d4d8340db6e783b4e8","subject":"refactor(tazjin/rlox): Refactor Compiler::consume into a macro","status":"MERGED","created":"2021-03-05 19:48:11.000000000","updated":"2021-03-06 11:53:37.000000000","submitted":"2021-03-06 11:52:00.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2594","meta_rev_id":"0bdbeadede77966a55fb56abecd0542ce1044b54","_number":2593,"virtual_id_number":2593,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-03-06 11:52:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-03-06 11:52:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-05 19:49:45.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e71e20af35f791ab446a61f70beb6a2a16f6d742","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-05 19:48:11.000000000","message":"Uploaded patch set 1: Code-Review+2.","accounts_in_message":[],"_revision_number":1},{"id":"14e1a85d69357a0aca4114eb1588a7b553cb0346","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-03-05 19:49:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/5313","accounts_in_message":[],"_revision_number":1},{"id":"f5a5635f0d7074d4f2dda1662c7195c2497cc55a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-06 11:52:00.000000000","message":"Change has been successfully rebased and submitted as b7b94335cc3b2d5650a385e1f4a439a7ef6d30ff","accounts_in_message":[],"_revision_number":2},{"id":"0bdbeadede77966a55fb56abecd0542ce1044b54","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-03-06 11:53:37.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/5322","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b7b94335cc3b2d5650a385e1f4a439a7ef6d30ff","revisions":{"cc77fe21682c53bd012728ac45684b8ff6f91668":{"kind":"REWORK","_number":1,"created":"2021-03-05 19:48:11.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/93/2593/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/93/2593/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/93/2593/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/93/2593/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/93/2593/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/93/2593/1"}}},"commit":{"parents":[{"commit":"0254f4ed8f0eaa2f8563fb113e52f3ad36a5f0ed","subject":"fix(tazjin/rlox): Resynchronise after panicking","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0254f4ed8f0eaa2f8563fb113e52f3ad36a5f0ed"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-05 19:43:28.000000000","tz":120},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-05 19:45:40.000000000","tz":120},"subject":"refactor(tazjin/rlox): Refactor Compiler::consume into a macro","message":"refactor(tazjin/rlox): Refactor Compiler::consume into a macro\n\nMaking this function a macro instead makes it possible to match\narbitrary token kinds, even the ones that carry data, without changing\nthe syntax too much.\n\nChange-Id: I5cda9e36d6833bd9c259f7d4d8340db6e783b4e8\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcc77fe21682c53bd012728ac45684b8ff6f91668"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcc77fe21682c53bd012728ac45684b8ff6f91668"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"0254f4ed8f0eaa2f8563fb113e52f3ad36a5f0ed","is_merged_in_target_branch":false,"change_id":"I60939f7a2c523b6ca1e9782e58c97959da38cfff","change_number":2591,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"b7b94335cc3b2d5650a385e1f4a439a7ef6d30ff":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-03-06 11:52:00.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/93/2593/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/93/2593/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/93/2593/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/93/2593/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/93/2593/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/93/2593/2"}}},"commit":{"parents":[{"commit":"822e5ae57f8253e83d40b6a8d686d774b1500a3f","subject":"fix(tazjin/rlox): Resynchronise after panicking","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d822e5ae57f8253e83d40b6a8d686d774b1500a3f"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-05 19:43:28.000000000","tz":120},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2021-03-06 11:52:00.000000000","tz":0},"subject":"refactor(tazjin/rlox): Refactor Compiler::consume into a macro","message":"refactor(tazjin/rlox): Refactor Compiler::consume into a macro\n\nMaking this function a macro instead makes it possible to match\narbitrary token kinds, even the ones that carry data, without changing\nthe syntax too much.\n\nChange-Id: I5cda9e36d6833bd9c259f7d4d8340db6e783b4e8\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2593\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db7b94335cc3b2d5650a385e1f4a439a7ef6d30ff"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db7b94335cc3b2d5650a385e1f4a439a7ef6d30ff"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"822e5ae57f8253e83d40b6a8d686d774b1500a3f","is_merged_in_target_branch":true,"change_id":"I60939f7a2c523b6ca1e9782e58c97959da38cfff","change_number":2591,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}