)]}'
{"id":"depot~2594","triplet_id":"depot~canon~Id89b388268efad295f29978d767aa4b33c4ded14","project":"depot","branch":"canon","hashtags":[],"change_id":"Id89b388268efad295f29978d767aa4b33c4ded14","subject":"feat(tazjin/rlox): Implement global variable access","status":"MERGED","created":"2021-03-06 11:45:48.000000000","updated":"2021-03-06 11:54:07.000000000","submitted":"2021-03-06 11:52:00.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2594","meta_rev_id":"fbc4081bdc94af20e759b988060d0f0e1c2c399c","_number":2594,"virtual_id_number":2594,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-03-06 11:52:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-03-06 11:52:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-06 11:46:48.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c7a42acc7a173bf03739c6a9119916969cc5686f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-06 11:45:48.000000000","message":"Uploaded patch set 1: Code-Review+2.","accounts_in_message":[],"_revision_number":1},{"id":"b7e484a80fb30d38174e952553efb65fc414a0d5","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-03-06 11:46:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/5318","accounts_in_message":[],"_revision_number":1},{"id":"6f924f53f502f884c3efd48ddc86fba8c0be8472","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-03-06 11:52:00.000000000","message":"Change has been successfully rebased and submitted as 4162186a1963b0dcf3dc47946a1cd8ad81467ac4","accounts_in_message":[],"_revision_number":2},{"id":"fbc4081bdc94af20e759b988060d0f0e1c2c399c","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-03-06 11:54:07.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/5324","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4162186a1963b0dcf3dc47946a1cd8ad81467ac4","revisions":{"b7f73cf635d10ddc34da20b85895bae9dc5edfe6":{"kind":"REWORK","_number":1,"created":"2021-03-06 11:45:48.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/94/2594/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/94/2594/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/94/2594/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/94/2594/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/94/2594/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/94/2594/1"}}},"commit":{"parents":[{"commit":"78c50efb4158d9b34a60e4befac62f7c37be1bda","subject":"feat(tazjin/rlox): Implement global variable definition","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d78c50efb4158d9b34a60e4befac62f7c37be1bda"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-05 20:35:02.000000000","tz":120},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-05 20:35:02.000000000","tz":120},"subject":"feat(tazjin/rlox): Implement global variable access","message":"feat(tazjin/rlox): Implement global variable access\n\nThis also includes a fix for an issue where the identifiers of\nvariables were pushed onto the stack, which is incorrect.\n\nChange-Id: Id89b388268efad295f29978d767aa4b33c4ded14\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db7f73cf635d10ddc34da20b85895bae9dc5edfe6"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db7f73cf635d10ddc34da20b85895bae9dc5edfe6"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"78c50efb4158d9b34a60e4befac62f7c37be1bda","is_merged_in_target_branch":false,"change_id":"I618ce8f789cb59b3a9c5b79a13111ea6d00b2424","change_number":2592,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"4162186a1963b0dcf3dc47946a1cd8ad81467ac4":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-03-06 11:52:00.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/94/2594/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/94/2594/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/94/2594/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/94/2594/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/94/2594/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/94/2594/2"}}},"commit":{"parents":[{"commit":"29b2a547055ba1adaf3f0d79055b7d7657eb3a5e","subject":"feat(tazjin/rlox): Implement global variable definition","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d29b2a547055ba1adaf3f0d79055b7d7657eb3a5e"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-03-05 20:35:02.000000000","tz":120},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2021-03-06 11:52:00.000000000","tz":0},"subject":"feat(tazjin/rlox): Implement global variable access","message":"feat(tazjin/rlox): Implement global variable access\n\nThis also includes a fix for an issue where the identifiers of\nvariables were pushed onto the stack, which is incorrect.\n\nChange-Id: Id89b388268efad295f29978d767aa4b33c4ded14\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2594\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4162186a1963b0dcf3dc47946a1cd8ad81467ac4"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4162186a1963b0dcf3dc47946a1cd8ad81467ac4"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"29b2a547055ba1adaf3f0d79055b7d7657eb3a5e","is_merged_in_target_branch":true,"change_id":"I618ce8f789cb59b3a9c5b79a13111ea6d00b2424","change_number":2592,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"status":"CLOSED"}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Custom-Rule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Custom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["Custom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}