)]}'
{"tools/cheddar/src/tests.rs":[{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"61a09b0ec261c77c325ff7b3842b968a71d431f9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"use super::*;"},{"line_number":2,"context_line":"use std::io::BufReader;"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"// Markdown rendering expectation, ignoring leading and trailing"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"f3e04677_2776d9d5","line":1,"updated":"2021-03-27 15:49:44.000000000","message":"integration tests like this traditionally go in the `tests/` directory, not `src/`, yeah?","commit_id":"bc04217fa2493418af7543a966ebf9dbb2a02973"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"0a51f703d90faed4cac95bdaf84fb556026e177b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"use super::*;"},{"line_number":2,"context_line":"use std::io::BufReader;"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"// Markdown rendering expectation, ignoring leading and trailing"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"b8ecac2e_4a8d6a63","line":1,"in_reply_to":"209bf981_97a66706","updated":"2021-03-30 11:01:05.000000000","message":"I don\u0027t understand the question - they\u0027re in a submodule (crate::tests) of the internal API (crate). Is that not what you mean?","commit_id":"bc04217fa2493418af7543a966ebf9dbb2a02973"},{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"f4317c2a5b29704abdeacdf59e5ad5bbc08640f3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"use super::*;"},{"line_number":2,"context_line":"use std::io::BufReader;"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"// Markdown rendering expectation, ignoring leading and trailing"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"209bf981_97a66706","line":1,"in_reply_to":"4816ffac_004e129f","updated":"2021-03-28 17:07:30.000000000","message":"then shouldn\u0027t the tests go in the same module as that API?","commit_id":"bc04217fa2493418af7543a966ebf9dbb2a02973"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"4b7f8d474cb457784a4030574c9b97dd2633a0eb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"use super::*;"},{"line_number":2,"context_line":"use std::io::BufReader;"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"// Markdown rendering expectation, ignoring leading and trailing"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"c1af63f2_2ff74d5d","line":1,"in_reply_to":"85ce46ff_c8739f36","updated":"2021-03-30 22:51:22.000000000","message":"Running `cargo test` from //tools/cheddar finds zero tests, and copying the tests into the same file will get more messy.\n\nI\u0027d be more happy if `format_markdown` was public, and the tests exercising it were moved to //tools/cheddar/tests/integration_tests.rs`.\n\nThere\u0027s not much preventing `format_markdown` to be used as a library, except the silent lazy dependency on `BAT_SYNTAXES` (which we should document?)","commit_id":"bc04217fa2493418af7543a966ebf9dbb2a02973"},{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"f5d06634597c120ea11b3257bba7e6e08e254840","unresolved":true,"context_lines":[{"line_number":1,"context_line":"use super::*;"},{"line_number":2,"context_line":"use std::io::BufReader;"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"// Markdown rendering expectation, ignoring leading and trailing"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"85ce46ff_c8739f36","line":1,"in_reply_to":"b8ecac2e_4a8d6a63","updated":"2021-03-30 15:42:55.000000000","message":"sorry, I meant the same file.","commit_id":"bc04217fa2493418af7543a966ebf9dbb2a02973"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"7d57d459289467db96f73774a88cf35bc34dcd5a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"use super::*;"},{"line_number":2,"context_line":"use std::io::BufReader;"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"// Markdown rendering expectation, ignoring leading and trailing"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"3fdf8f3d_d75a2da2","line":1,"in_reply_to":"c1af63f2_2ff74d5d","updated":"2021-03-31 22:05:58.000000000","message":"We can turn it into a library, but that would be a separate CL - please consider filing a bug on b.tvl.fyi for it.\n\nI fixed the test discovery in the last patchset","commit_id":"bc04217fa2493418af7543a966ebf9dbb2a02973"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"d5c2d9ab1880a8cca3c31d946ead10f5e1891176","unresolved":true,"context_lines":[{"line_number":1,"context_line":"use super::*;"},{"line_number":2,"context_line":"use std::io::BufReader;"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"// Markdown rendering expectation, ignoring leading and trailing"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"4816ffac_004e129f","line":1,"in_reply_to":"f3e04677_2776d9d5","updated":"2021-03-27 15:52:36.000000000","message":"cheddar is not a library, it\u0027s a binary, and this tests the binaries internal API","commit_id":"bc04217fa2493418af7543a966ebf9dbb2a02973"}]}