)]}'
{"id":"depot~2861","triplet_id":"depot~canon~I3e3f203e0705e561e1a3392e8f75dbe273d5fa81","project":"depot","branch":"canon","hashtags":[],"change_id":"I3e3f203e0705e561e1a3392e8f75dbe273d5fa81","subject":"refactor(web/converse): Refactor first handlers to rouille","status":"MERGED","created":"2021-04-05 20:13:10.000000000","updated":"2021-04-20 10:49:06.000000000","submitted":"2021-04-20 10:44:57.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2861","meta_rev_id":"b54d409c429490def77726c7a81f1bca627f0a4f","_number":2861,"virtual_id_number":2861,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-04-20 10:44:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-04-20 10:44:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-05 20:15:11.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f3212b059c1f4750af3bae728ca901aa3cf93fce","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-04-05 20:13:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"84e098dddd76271b071815d83944831f55aad1d0","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-04-05 20:15:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/6190","accounts_in_message":[],"_revision_number":1},{"id":"83e674197f14991203f5e41a74ce967d07c6fbf5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-04-07 12:22:22.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"12097d29655dafcad5fb0a50b109397bb33bc05a","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-04-07 12:23:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/6223","accounts_in_message":[],"_revision_number":2},{"id":"e0f6a92faaab2a0dedf8044a90e4cbb10e3d277b","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-04-07 12:28:14.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"87d52481c9e88f606d6df44f30c01aa06d61004b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-04-10 22:41:46.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"bb890bcedbe2247e6ba3f75bf13d074b76616dbe","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-04-10 22:43:47.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/6411","accounts_in_message":[],"_revision_number":3},{"id":"bd9bec1dac364ef54a3ae96f6d3ea618dee5dc2a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-04-20 10:44:57.000000000","message":"Change has been successfully rebased and submitted as 929b38e8ae4d61340cbd70352663af8f6f2418cf\n\n2 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":4},{"id":"b54d409c429490def77726c7a81f1bca627f0a4f","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-04-20 10:49:06.000000000","message":"Patch Set 4:\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/6753","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"929b38e8ae4d61340cbd70352663af8f6f2418cf","revisions":{"648206d981f608c87673b2144fea30e62370f841":{"kind":"REWORK","_number":1,"created":"2021-04-05 20:13:10.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/61/2861/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/61/2861/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/61/2861/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/61/2861/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/61/2861/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/61/2861/1"}}},"commit":{"parents":[{"commit":"a87533695f3bede9c50476008c0513bea234c18b","subject":"fix(web/converse): Update to use mime_guess::from_path","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da87533695f3bede9c50476008c0513bea234c18b"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-04-05 20:09:31.000000000","tz":120},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-04-05 20:12:00.000000000","tz":120},"subject":"refactor(web/converse): Refactor first handlers to rouille","message":"refactor(web/converse): Refactor first handlers to rouille\n\nThis commit starts the refactoring process towards dropping actix (and\ntokio, ...). It builds, but at this commit, Converse does *not* work.\n\nI decided to commit to avoid more ridiculous diffs.\n\nIncluded changes:\n\n* Added dependency on rouille.\n\n* Refactored DbExecutor (formerly actix actor) to simply be a type\n  with a few methods. Most actor messages still exist as they are\n  being referred to by handlers.\n\n* Started refactoring two of the handlers (and their related renderer\n  functions) into Rouille\u0027s call scheme.\n\nImportant note: Rouille does not have safe session management out of\nthe box, and it will need to be implemented as this progresses.\n\nChange-Id: I3e3f203e0705e561e1a3392e8f75dbe273d5fa81\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d648206d981f608c87673b2144fea30e62370f841"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d648206d981f608c87673b2144fea30e62370f841"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a87533695f3bede9c50476008c0513bea234c18b","is_merged_in_target_branch":true,"change_id":"I8af286c6b1ee7c25c153f1209d094ae4f5eb53cc","change_number":2860,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f78e4d5d550fe926c1bd1e175c0f51d2c6307181":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-04-07 12:22:22.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/61/2861/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/61/2861/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/61/2861/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/61/2861/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/61/2861/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/61/2861/2"}}},"commit":{"parents":[{"commit":"6d008f64120cba617f729ddf4e1dd0a1a0d6cfd5","subject":"feat(gerrit-tvl): add Buildkite-backed Checks plugin implementation","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6d008f64120cba617f729ddf4e1dd0a1a0d6cfd5"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-04-05 20:09:31.000000000","tz":120},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2021-04-07 12:22:22.000000000","tz":0},"subject":"refactor(web/converse): Refactor first handlers to rouille","message":"refactor(web/converse): Refactor first handlers to rouille\n\nThis commit starts the refactoring process towards dropping actix (and\ntokio, ...). It builds, but at this commit, Converse does *not* work.\n\nI decided to commit to avoid more ridiculous diffs.\n\nIncluded changes:\n\n* Added dependency on rouille.\n\n* Refactored DbExecutor (formerly actix actor) to simply be a type\n  with a few methods. Most actor messages still exist as they are\n  being referred to by handlers.\n\n* Started refactoring two of the handlers (and their related renderer\n  functions) into Rouille\u0027s call scheme.\n\nImportant note: Rouille does not have safe session management out of\nthe box, and it will need to be implemented as this progresses.\n\nChange-Id: I3e3f203e0705e561e1a3392e8f75dbe273d5fa81\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df78e4d5d550fe926c1bd1e175c0f51d2c6307181"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df78e4d5d550fe926c1bd1e175c0f51d2c6307181"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6d008f64120cba617f729ddf4e1dd0a1a0d6cfd5","is_merged_in_target_branch":true,"change_id":"I7025a1c6d0d0afa000a9df4682133e03824ea10d","change_number":2881,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"},"8efd4af553b278bd552d7e3610baab367a78df89":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2021-04-10 22:41:46.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/61/2861/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/61/2861/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/61/2861/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/61/2861/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/61/2861/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/61/2861/3"}}},"commit":{"parents":[{"commit":"726eff80f131e81e56faf4b6273ffe74e862e7ab","subject":"fix(glittershark/system): Build yerenSystem in CI","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d726eff80f131e81e56faf4b6273ffe74e862e7ab"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-04-05 20:09:31.000000000","tz":120},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2021-04-10 22:41:46.000000000","tz":0},"subject":"refactor(web/converse): Refactor first handlers to rouille","message":"refactor(web/converse): Refactor first handlers to rouille\n\nThis commit starts the refactoring process towards dropping actix (and\ntokio, ...). It builds, but at this commit, Converse does *not* work.\n\nI decided to commit to avoid more ridiculous diffs.\n\nIncluded changes:\n\n* Added dependency on rouille.\n\n* Refactored DbExecutor (formerly actix actor) to simply be a type\n  with a few methods. Most actor messages still exist as they are\n  being referred to by handlers.\n\n* Started refactoring two of the handlers (and their related renderer\n  functions) into Rouille\u0027s call scheme.\n\nImportant note: Rouille does not have safe session management out of\nthe box, and it will need to be implemented as this progresses.\n\nChange-Id: I3e3f203e0705e561e1a3392e8f75dbe273d5fa81\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8efd4af553b278bd552d7e3610baab367a78df89"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8efd4af553b278bd552d7e3610baab367a78df89"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"726eff80f131e81e56faf4b6273ffe74e862e7ab","is_merged_in_target_branch":true,"change_id":"I0abe56f0a1f18e4e542cb458dfcdf81e8a0ddc01","change_number":2923,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"},"929b38e8ae4d61340cbd70352663af8f6f2418cf":{"kind":"REWORK","_number":4,"created":"2021-04-20 10:44:57.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/61/2861/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/61/2861/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/61/2861/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/61/2861/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/61/2861/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/61/2861/4"}}},"commit":{"parents":[{"commit":"54f59a5cc5835932c62c0f2d58712e30c248da4d","subject":"feat(ops/modules/www): Disable FLoC tracking for all TVL pages","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d54f59a5cc5835932c62c0f2d58712e30c248da4d"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-04-05 20:09:31.000000000","tz":120},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2021-04-20 10:44:57.000000000","tz":0},"subject":"refactor(web/converse): Refactor first handlers to rouille","message":"refactor(web/converse): Refactor first handlers to rouille\n\nThis commit starts the refactoring process towards dropping actix (and\ntokio, ...). It builds, but at this commit, Converse does *not* work.\n\nI decided to commit to avoid more ridiculous diffs.\n\nIncluded changes:\n\n* Added dependency on rouille.\n\n* Refactored DbExecutor (formerly actix actor) to simply be a type\n  with a few methods. Most actor messages still exist as they are\n  being referred to by handlers.\n\n* Started refactoring two of the handlers (and their related renderer\n  functions) into Rouille\u0027s call scheme.\n\nImportant note: Rouille does not have safe session management out of\nthe box, and it will need to be implemented as this progresses.\n\nChange-Id: I3e3f203e0705e561e1a3392e8f75dbe273d5fa81\nReviewed-on: https://cl.tvl.fyi/c/depot/+/2861\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d929b38e8ae4d61340cbd70352663af8f6f2418cf"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d929b38e8ae4d61340cbd70352663af8f6f2418cf"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"54f59a5cc5835932c62c0f2d58712e30c248da4d","is_merged_in_target_branch":true,"change_id":"I2fa6e31ca10835a206673b858594fa071e729d82","change_number":3020,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}