)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"af485cc67581c42c7aef614f2f8d7be46434ed27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"201a8d1d_376160a9","updated":"2021-04-10 20:50:56.000000000","message":"haven\u0027t reviewed everything (just took a look at //third_party and //users/glittershark) but what I did see LGTM","commit_id":"e0a23ccbfe8998a62cdba9b7d1cb3eb93063f96f"}],"ops/nixos/default.nix":[{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"6d69b3d526ebbe691028b07716afdbe7f77d35d8","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"let"},{"line_number":12,"context_line":"  inherit (lib) findFirst isAttrs;"},{"line_number":13,"context_line":"  nixos \u003d import \"${pkgs.path}/nixos\";"},{"line_number":14,"context_line":"in rec {"},{"line_number":15,"context_line":"  whitby \u003d import ./whitby/default.nix args;"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-nix","patch_set":28,"id":"853594b4_55c57c5a","line":13,"updated":"2021-04-10 20:50:24.000000000","message":"This should be `third_party.nixos` then?","commit_id":"e0a23ccbfe8998a62cdba9b7d1cb3eb93063f96f"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"3854ae484f02274aace0b307e5bcd8a582014a9e","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"let"},{"line_number":12,"context_line":"  inherit (lib) findFirst isAttrs;"},{"line_number":13,"context_line":"  nixos \u003d import \"${pkgs.path}/nixos\";"},{"line_number":14,"context_line":"in rec {"},{"line_number":15,"context_line":"  whitby \u003d import ./whitby/default.nix args;"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-nix","patch_set":28,"id":"9d853b5b_db340bd1","line":13,"in_reply_to":"853594b4_55c57c5a","updated":"2021-04-10 20:53:35.000000000","message":"Done","commit_id":"e0a23ccbfe8998a62cdba9b7d1cb3eb93063f96f"}],"third_party/nix/default.nix":[{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"6d69b3d526ebbe691028b07716afdbe7f77d35d8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"args@{"},{"line_number":2,"context_line":"  depot ? (import ../.. {})"},{"line_number":3,"context_line":", pkgs ? depot.third_party"},{"line_number":4,"context_line":", lib"},{"line_number":5,"context_line":", buildType ? \"release\""},{"line_number":6,"context_line":", depotPath ? ../.."}],"source_content_type":"text/x-nix","patch_set":28,"id":"a544684d_e41f0c47","line":3,"updated":"2021-04-10 20:50:24.000000000","message":"should be `depot.third_party.nixpkgs`.","commit_id":"e0a23ccbfe8998a62cdba9b7d1cb3eb93063f96f"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"3854ae484f02274aace0b307e5bcd8a582014a9e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"args@{"},{"line_number":2,"context_line":"  depot ? (import ../.. {})"},{"line_number":3,"context_line":", pkgs ? depot.third_party"},{"line_number":4,"context_line":", lib"},{"line_number":5,"context_line":", buildType ? \"release\""},{"line_number":6,"context_line":", depotPath ? ../.."}],"source_content_type":"text/x-nix","patch_set":28,"id":"1b58c782_11834b99","line":3,"in_reply_to":"a544684d_e41f0c47","updated":"2021-04-10 20:53:35.000000000","message":"Done","commit_id":"e0a23ccbfe8998a62cdba9b7d1cb3eb93063f96f"}],"third_party/nixpkgs/default.nix":[{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"6d69b3d526ebbe691028b07716afdbe7f77d35d8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"in import nixpkgsSrc {"},{"line_number":49,"context_line":"  config.allowUnfree \u003d true;"},{"line_number":50,"context_line":"  config.allowBroken \u003d true;"},{"line_number":51,"context_line":"  overlays \u003d ["},{"line_number":52,"context_line":"    stableOverlay"},{"line_number":53,"context_line":"    depot.third_party.overlays.tvl"},{"line_number":54,"context_line":"    depot.third_party.overlays.haskell"}],"source_content_type":"text/x-nix","patch_set":28,"id":"23968986_7a00e4cc","line":51,"updated":"2021-04-10 20:50:24.000000000","message":"Could be interesting to experiment with `crossOverlays` here, maybe this will reduce rebuilds required for ifd in haskellPackages?","commit_id":"e0a23ccbfe8998a62cdba9b7d1cb3eb93063f96f"}],"third_party/overlays/haskell/default.nix":[{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"6d69b3d526ebbe691028b07716afdbe7f77d35d8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    # generic-arbitrary \u003d appendPatch hsSuper.generic-arbitrary"},{"line_number":12,"context_line":"    #   [ ./patches/generic-arbitrary-export-garbitrary.patch ];"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    # random \u003d dontCheck (hsSuper.callHackageDirect {"},{"line_number":15,"context_line":"    #   pkg \u003d \"random\";"},{"line_number":16,"context_line":"    #   ver \u003d \"1.2.0\";"},{"line_number":17,"context_line":"    #   sha256 \u003d \"06s3mmqbsfwv09j2s45qnd66nrxfp9280gnl9ng8yh128pfr7bjh\";"}],"source_content_type":"text/x-nix","patch_set":25,"id":"a44e1e7f_11b90001","line":14,"updated":"2021-04-10 20:50:24.000000000","message":"random \u003d dontCheck super.random_1_2_0; works, but that\u0027s for another CL or CL/2921.","commit_id":"3e42187045e2f3e264c60fab6f3c379099d5583b"}],"third_party/overlays/tvl.nix":[{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"6d69b3d526ebbe691028b07716afdbe7f77d35d8","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  # Use LLVM 11"},{"line_number":22,"context_line":"  llvmPackages \u003d self.llvmPackages_11;"},{"line_number":23,"context_line":"  clangStdenv \u003d self.llvmPackages_11.stdenv;"},{"line_number":24,"context_line":"  clang-tools \u003d (super.clang-tools.override {"},{"line_number":25,"context_line":"    llvmPackages \u003d self.llvmPackages_11;"},{"line_number":26,"context_line":"  });"}],"source_content_type":"text/x-nix","patch_set":28,"id":"eecf66f2_dbc96931","line":23,"updated":"2021-04-10 20:50:24.000000000","message":"This is probably not necessary, as `clangStdenv \u003d if stdenv.cc.isClang then stdenv else lowPrio llvmPackages.stdenv;`.","commit_id":"e0a23ccbfe8998a62cdba9b7d1cb3eb93063f96f"}],"users/glittershark/pkgs/fprintd/default.nix":[{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"af485cc67581c42c7aef614f2f8d7be46434ed27","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    config.allowUnfree \u003d true;"},{"line_number":6,"context_line":"    overlays \u003d [(self: super: {"},{"line_number":7,"context_line":"      # TODO(grfn): Can we not override this here? It bootstraps"},{"line_number":8,"context_line":"      # rustc, builds firefox, and many other things."},{"line_number":9,"context_line":"      gcc \u003d super.gcc9;"},{"line_number":10,"context_line":"    })];"},{"line_number":11,"context_line":"  };"}],"source_content_type":"text/x-nix","patch_set":28,"id":"59c43070_e370987e","line":8,"updated":"2021-04-10 20:50:56.000000000","message":"I\u0027ll look into it: https://b.tvl.fyi/issues/115","commit_id":"e0a23ccbfe8998a62cdba9b7d1cb3eb93063f96f"}],"users/tazjin/dt/default.nix":[{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"1d2f2934e59c9dd4d89e5c481a1e89aa54eeefc8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{ depot, pkgs, ... }:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"let stdenv \u003d with pkgs; overrideCC clangStdenv clang_11;"},{"line_number":4,"context_line":"in stdenv.mkDerivation {"},{"line_number":5,"context_line":"  name \u003d \"dt\";"},{"line_number":6,"context_line":"  src \u003d ./.;"}],"source_content_type":"text/x-nix","patch_set":31,"id":"c48b43fd_588601e4","line":3,"updated":"2021-04-10 21:16:14.000000000","message":"This should be exactly our clangStdenv (for a follow up).","commit_id":"863928f610f1d76a266a72e2de19d75a98ba2214"}]}