)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"change_message_id":"197dcdeb4dd2d667159dc9a54fc9e0c62f81c369","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3dbafb03_dfa1ac81","updated":"2021-05-22 20:34:02.000000000","message":"I don\u0027t think it really matters, but making a correct shortlink implementation is kinda hard, because you kinda want to try to make sure that shortlink pattern matches don\u0027t overlap with previous replacements.\n\nOTOH... whatever","commit_id":"31be0397c8a84ea36ddab3db62c012d683f437ee"}],"tools/cheddar/src/lib.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"e536388c1f64d70674a7674aedc6ed24802a0ce2","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    // Currently only bug links (e.g. b/123) and CL links (e.g."},{"line_number":76,"context_line":"    // cl/345) are supported. Coincidentally these have the same"},{"line_number":77,"context_line":"    // format, which makes the initial implementation easy."},{"line_number":78,"context_line":"    static ref SHORTLINK: Regex \u003d Regex::new(\"\\\\b(?P\u003ctype\u003eb|cl)/(?P\u003cdest\u003e\\\\d+)\\\\b\").unwrap();"},{"line_number":79,"context_line":"}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"// HTML fragment used when rendering inline blocks in Markdown documents."}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"2ee790ae_b447bebc","side":"PARENT","line":78,"updated":"2021-05-03 20:06:37.000000000","message":"This would probably be easier understandable if squashed with the previous commit, as it mostly changes everything introduced here.\n\nAlso, I\u0027m still inclined to say that below TVL_LINKS code should live in tools/cheddar/src/bin/cheddar.rs, not the library.\n\nShameless selfishness, but I\u0027d like to use cheddar as a library, outside TVL context.\n\nOnce there\u0027s other entrypoints into cheddar library code (and they are in TVL context), we could think about sharing these regexes across these entrypoints, but I\u0027d really prefer if lib.rs could be somewhat agnostic.","commit_id":"8f5c0b8eb5a79b5c577a077be44ac584178c45e8"},{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"415f0b48a48416e6e0bc2460aeca19042f650d32","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    // Currently only bug links (e.g. b/123) and CL links (e.g."},{"line_number":76,"context_line":"    // cl/345) are supported. Coincidentally these have the same"},{"line_number":77,"context_line":"    // format, which makes the initial implementation easy."},{"line_number":78,"context_line":"    static ref SHORTLINK: Regex \u003d Regex::new(\"\\\\b(?P\u003ctype\u003eb|cl)/(?P\u003cdest\u003e\\\\d+)\\\\b\").unwrap();"},{"line_number":79,"context_line":"}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"// HTML fragment used when rendering inline blocks in Markdown documents."}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"1800b4c2_36c8f051","side":"PARENT","line":78,"in_reply_to":"2a613083_57ec8a29","updated":"2021-05-05 13:09:00.000000000","message":"\u003e I want `format_markdown` to always do The Right Thing.\n\nWhy not make it configurable in some variant of `format_markdown_xyz` and `format_markdown` always uses the default TVL configuration (which would also be exposed).","commit_id":"8f5c0b8eb5a79b5c577a077be44ac584178c45e8"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"8daf6a56712a5486a6394e0b782b1576c0ec9fc8","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    // Currently only bug links (e.g. b/123) and CL links (e.g."},{"line_number":76,"context_line":"    // cl/345) are supported. Coincidentally these have the same"},{"line_number":77,"context_line":"    // format, which makes the initial implementation easy."},{"line_number":78,"context_line":"    static ref SHORTLINK: Regex \u003d Regex::new(\"\\\\b(?P\u003ctype\u003eb|cl)/(?P\u003cdest\u003e\\\\d+)\\\\b\").unwrap();"},{"line_number":79,"context_line":"}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"// HTML fragment used when rendering inline blocks in Markdown documents."}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"df0b6311_2458821f","side":"PARENT","line":78,"in_reply_to":"2ee790ae_b447bebc","updated":"2021-05-03 20:17:47.000000000","message":"\u003e This would probably be easier understandable if squashed with the previous commit, as it mostly changes everything introduced here.\n\nI can squash them, but the previous one is more about the regex and the tests introduced, not about the extra complexity of making the links generic. No strong opinion but the current commit chain is how this evolved in practice.\n\n\u003e Also, I\u0027m still inclined to say that below TVL_LINKS code should live in tools/cheddar/src/bin/cheddar.rs, not the library.\n\nI pretty strongly disagree with this. This library is \"TVL first\", and we shouldn\u0027t need to build additional stuff around it to make sure it is reusable within our ecosystem. Inside of the depot, I want `format_markdown` to always do The Right Thing. The API for using an alternative set of shortlinks adds support for external use-cases without shortlinks (which are likely also going to be rare).","commit_id":"8f5c0b8eb5a79b5c577a077be44ac584178c45e8"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"6faaff5ecb185674b595600e4101aab8afbcefe4","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    // Currently only bug links (e.g. b/123) and CL links (e.g."},{"line_number":76,"context_line":"    // cl/345) are supported. Coincidentally these have the same"},{"line_number":77,"context_line":"    // format, which makes the initial implementation easy."},{"line_number":78,"context_line":"    static ref SHORTLINK: Regex \u003d Regex::new(\"\\\\b(?P\u003ctype\u003eb|cl)/(?P\u003cdest\u003e\\\\d+)\\\\b\").unwrap();"},{"line_number":79,"context_line":"}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"// HTML fragment used when rendering inline blocks in Markdown documents."}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"2a613083_57ec8a29","side":"PARENT","line":78,"in_reply_to":"df0b6311_2458821f","updated":"2021-05-05 11:43:58.000000000","message":"The other commit is merged at this point, so I\u0027m marking this as resolved.","commit_id":"8f5c0b8eb5a79b5c577a077be44ac584178c45e8"}]}