)]}'
{"id":"depot~3433","triplet_id":"depot~canon~I2cdf09f67916527d2337f4bfb578749aeac51a6a","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2021-08-26 17:45:59.000000000","reason":"sterni replied on the change"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2021-08-26 20:33:52.000000000","reason":"Change was submitted"},"1000005":{"account":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"last_update":"2021-08-26 20:33:52.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2021-08-26 20:33:52.000000000","reason":"Change was submitted"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2021-08-26 19:09:05.000000000","reason":"grfn replied on the change"},"1000013":{"account":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"last_update":"2021-08-26 20:33:52.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I2cdf09f67916527d2337f4bfb578749aeac51a6a","subject":"feat(readTree): Add support for path-dependent args filtering","status":"MERGED","created":"2021-08-26 16:44:37.000000000","updated":"2021-08-26 20:36:02.000000000","submitted":"2021-08-26 20:33:52.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"3433","meta_rev_id":"7720cf947bb8bbc56034dc6a1f7e78693a273d33","_number":3433,"virtual_id_number":3433,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-26 20:33:52.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-08-26 20:33:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-08-26 20:33:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-26 16:46:01.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-26 17:35:16.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"state":"REVIEWER"},{"updated":"2021-08-26 17:35:16.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2021-08-26 17:35:16.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2021-08-26 17:41:14.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"state":"REVIEWER"},{"updated":"2021-08-26 18:44:52.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"state":"REVIEWER"}],"messages":[{"id":"c471624bc6b61a860cfe284d4c18f84de67adbe6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-08-26 16:44:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d13497223a80d14e1a541f5f1d72cb394e0d86ec","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-08-26 16:46:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/8112","accounts_in_message":[],"_revision_number":1},{"id":"6e4948610f1db33419dcc5c10be97a4bc5683b78","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-08-26 17:31:57.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"06a5777e6a1da1be55c27053d05729ee90623c6c","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-08-26 17:33:25.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/8122","accounts_in_message":[],"_revision_number":2},{"id":"c8f7efe46ac27f1f8b55344d83bfa45001e2b156","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-08-26 17:45:59.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"7a4170471bdf1c41560523611e8c7d053c6a6cb9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-08-26 17:57:23.000000000","message":"Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2.","accounts_in_message":[],"_revision_number":3},{"id":"4e55939f1509b7c0305e37d08ce975134846b8bd","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-08-26 17:59:38.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/8126","accounts_in_message":[],"_revision_number":3},{"id":"06d1a040de9f99a86498c59badbc431f8ceb8a3e","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2021-08-26 19:09:05.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"7ef64248715f932ef893864099ecfbbdd1059bbc","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2021-08-26 20:32:06.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"b9976d57450e53524be62077bff4dbbf05ecbafd","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-08-26 20:33:52.000000000","message":"Change has been successfully rebased and submitted as 8b851956ad3adab52c0740d6d9353d3900613fe3","accounts_in_message":[],"_revision_number":4},{"id":"7720cf947bb8bbc56034dc6a1f7e78693a273d33","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-08-26 20:36:02.000000000","message":"Patch Set 4:\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/8137","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"8b851956ad3adab52c0740d6d9353d3900613fe3","revisions":{"7bb43b610055691123c86a3b15ad326aaccf9043":{"kind":"REWORK","_number":1,"created":"2021-08-26 16:44:37.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/33/3433/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/33/3433/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3433/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3433/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3433/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/33/3433/1"}}},"commit":{"parents":[{"commit":"60b25b49de6107c1840cc7502dccdf5c00235849","subject":"fix(ops/pipelines/depot): Buildkite branches use full ref names","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d60b25b49de6107c1840cc7502dccdf5c00235849"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-08-26 16:41:50.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-08-26 16:41:50.000000000","tz":180},"subject":"feat(readTree): Add support for path-dependent args filtering","message":"feat(readTree): Add support for path-dependent args filtering\n\nAdds another argument to readTree itself which can be passed when\nimporting readTree (e.g. in our default.nix) to filter the arguments\npassed to a target based on that target\u0027s location in the tree.\n\nThis is intentionally not yet mentioned in the docs, and also\nintentionally implemented in such a way that the API surface of\nreadTree doesn\u0027t change. The reason for this is that I want to figure\nout whether these filter functions are actually useful, e.g. within\ndepot by filtering user-folder passing, and then refactor the readTree\nAPI to find a public way of exposing this as part of the readTree\nfunction itself (and not its import).\n\nRelates to b/143.\n\nChange-Id: I2cdf09f67916527d2337f4bfb578749aeac51a6a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7bb43b610055691123c86a3b15ad326aaccf9043"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7bb43b610055691123c86a3b15ad326aaccf9043"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"60b25b49de6107c1840cc7502dccdf5c00235849","is_merged_in_target_branch":true,"change_id":"Ia1c67b99282fb8fd0e4d22e997535170f0326e33","change_number":3432,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"1a56afd382c38512941c2f41464e5a7983179b0a":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-08-26 17:31:57.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/33/3433/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/33/3433/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3433/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3433/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3433/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/33/3433/2"}}},"commit":{"parents":[{"commit":"cd4c532ed3136f1244937a45c0ed83611f307e06","subject":"chore(web/tvl): Move TVL static assets out of //users/tazjin","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcd4c532ed3136f1244937a45c0ed83611f307e06"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-08-26 16:41:50.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-08-26 17:31:55.000000000","tz":180},"subject":"feat(readTree): Add support for path-dependent args filtering","message":"feat(readTree): Add support for path-dependent args filtering\n\nAdds another argument to readTree itself which can be passed when\nimporting readTree (e.g. in our default.nix) to filter the arguments\npassed to a target based on that target\u0027s location in the tree.\n\nThis is intentionally not yet mentioned in the docs, and also\nintentionally implemented in such a way that the API surface of\nreadTree doesn\u0027t change. The reason for this is that I want to figure\nout whether these filter functions are actually useful, e.g. within\ndepot by filtering user-folder passing, and then refactor the readTree\nAPI to find a public way of exposing this as part of the readTree\nfunction itself (and not its import).\n\nRelates to b/143.\n\nChange-Id: I2cdf09f67916527d2337f4bfb578749aeac51a6a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1a56afd382c38512941c2f41464e5a7983179b0a"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1a56afd382c38512941c2f41464e5a7983179b0a"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"cd4c532ed3136f1244937a45c0ed83611f307e06","is_merged_in_target_branch":false,"change_id":"Ifb9d61aa8ec2cab549e25de3a3dfbbd08f3d336c","change_number":3435,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"ca04a655d50fbbabb06609c822cc26b605040e5d":{"kind":"NO_CHANGE","_number":3,"created":"2021-08-26 17:57:23.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/33/3433/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/33/3433/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3433/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3433/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3433/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/33/3433/3"}}},"commit":{"parents":[{"commit":"da0b3307565bdec0d67014b0de8be71d90789762","subject":"chore(web/tvl): Move TVL static assets out of //users/tazjin","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dda0b3307565bdec0d67014b0de8be71d90789762"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-08-26 16:41:50.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-08-26 17:57:21.000000000","tz":180},"subject":"feat(readTree): Add support for path-dependent args filtering","message":"feat(readTree): Add support for path-dependent args filtering\n\nAdds another argument to readTree itself which can be passed when\nimporting readTree (e.g. in our default.nix) to filter the arguments\npassed to a target based on that target\u0027s location in the tree.\n\nThis is intentionally not yet mentioned in the docs, and also\nintentionally implemented in such a way that the API surface of\nreadTree doesn\u0027t change. The reason for this is that I want to figure\nout whether these filter functions are actually useful, e.g. within\ndepot by filtering user-folder passing, and then refactor the readTree\nAPI to find a public way of exposing this as part of the readTree\nfunction itself (and not its import).\n\nRelates to b/143.\n\nChange-Id: I2cdf09f67916527d2337f4bfb578749aeac51a6a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dca04a655d50fbbabb06609c822cc26b605040e5d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dca04a655d50fbbabb06609c822cc26b605040e5d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"da0b3307565bdec0d67014b0de8be71d90789762","is_merged_in_target_branch":true,"change_id":"Ifb9d61aa8ec2cab549e25de3a3dfbbd08f3d336c","change_number":3435,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"8b851956ad3adab52c0740d6d9353d3900613fe3":{"kind":"REWORK","_number":4,"created":"2021-08-26 20:33:52.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/33/3433/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/33/3433/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3433/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3433/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3433/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/33/3433/4"}}},"commit":{"parents":[{"commit":"d857d5ad685e41c24f376fa16182588e938624d0","subject":"refactor(gs/system): Remove chupacabra","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd857d5ad685e41c24f376fa16182588e938624d0"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-08-26 16:41:50.000000000","tz":180},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2021-08-26 20:33:52.000000000","tz":0},"subject":"feat(readTree): Add support for path-dependent args filtering","message":"feat(readTree): Add support for path-dependent args filtering\n\nAdds another argument to readTree itself which can be passed when\nimporting readTree (e.g. in our default.nix) to filter the arguments\npassed to a target based on that target\u0027s location in the tree.\n\nThis is intentionally not yet mentioned in the docs, and also\nintentionally implemented in such a way that the API surface of\nreadTree doesn\u0027t change. The reason for this is that I want to figure\nout whether these filter functions are actually useful, e.g. within\ndepot by filtering user-folder passing, and then refactor the readTree\nAPI to find a public way of exposing this as part of the readTree\nfunction itself (and not its import).\n\nRelates to b/143.\n\nChange-Id: I2cdf09f67916527d2337f4bfb578749aeac51a6a\nReviewed-on: https://cl.tvl.fyi/c/depot/+/3433\nTested-by: BuildkiteCI\nReviewed-by: grfn \u003cgrfn@gws.fyi\u003e\nReviewed-by: sterni \u003csternenseemann@systemli.org\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8b851956ad3adab52c0740d6d9353d3900613fe3"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8b851956ad3adab52c0740d6d9353d3900613fe3"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"d857d5ad685e41c24f376fa16182588e938624d0","is_merged_in_target_branch":true,"change_id":"I8e549b8397777a01404bd84c10c195e80f281744","change_number":3431,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}