)]}'
{"id":"depot~3498","triplet_id":"depot~canon~I633c1fc96026d137b451bb604ef92be32571a0f5","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2021-09-08 17:58:53.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2021-09-08 17:58:53.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2021-09-08 17:58:53.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I633c1fc96026d137b451bb604ef92be32571a0f5","subject":"refactor(readTree): Pass all readTree parameters as function args","status":"MERGED","created":"2021-09-08 15:18:41.000000000","updated":"2021-09-08 18:01:28.000000000","submitted":"2021-09-08 17:58:53.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"3498","meta_rev_id":"835a74892b36562f7f1790cc5485a566e76789a8","_number":3498,"virtual_id_number":3498,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-09-08 17:58:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-08 17:58:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-08 15:18:52.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-08 15:38:47.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"state":"REVIEWER"},{"updated":"2021-09-08 15:38:47.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2021-09-08 16:11:18.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"}],"messages":[{"id":"100a82b7abb15decca716775a88d80281f9f5f58","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-09-08 15:18:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"794170652c7767e1dcef7a1e291018dc425dab42","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-09-08 15:18:52.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/8281","accounts_in_message":[],"_revision_number":1},{"id":"ad6fca4896eff5c0844fc65f6abdc33c34a8c1a9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-09-08 15:29:07.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3d89b1f9d3579db89903ff0fd8e809d1e801bd3e","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-09-08 15:29:18.000000000","message":"Patch Set 2: Verified-1\n\nBuild of patchset 2 failed: https://buildkite.com/tvl/depot/builds/8282","accounts_in_message":[],"_revision_number":2},{"id":"e1e4ce82b95d0a351dfe6c971a2ffe086fd6abc8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-09-08 15:33:06.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"9b2e1e19c62a15b53a1fb6cb589c2adc4b2b9116","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-09-08 15:33:18.000000000","message":"Patch Set 3: Verified-1\n\nBuild of patchset 3 failed: https://buildkite.com/tvl/depot/builds/8285","accounts_in_message":[],"_revision_number":3},{"id":"3b4bb760286d0dfbe335c6d9fdd9856f3b2cbc78","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-09-08 15:35:48.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"38c575d57627ebe6a9bc2be1150097b58bca0b18","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-09-08 15:37:58.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/8288","accounts_in_message":[],"_revision_number":4},{"id":"2de39db0b781e51d5f82c17f7238212c688dbcf3","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-09-08 15:42:19.000000000","message":"Patch Set 4:\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/8291","accounts_in_message":[],"_revision_number":4},{"id":"6c4226f24928dc6043043e7a138dc1b989a81959","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2021-09-08 16:11:18.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"69500dae7b7519ff71def2db31e1eaf446e0c816","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-09-08 17:58:53.000000000","message":"Change has been successfully rebased and submitted as aedde913d125737f81e63edbc7481e886b0a4f2d","accounts_in_message":[],"_revision_number":5},{"id":"835a74892b36562f7f1790cc5485a566e76789a8","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-09-08 18:01:28.000000000","message":"Patch Set 5:\n\nBuild of patchset 5 passed: https://buildkite.com/tvl/depot/builds/8293","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"aedde913d125737f81e63edbc7481e886b0a4f2d","revisions":{"0e3a4b48f9bfa0bf57e05a7f7f6e12a5923cbae2":{"kind":"REWORK","_number":1,"created":"2021-09-08 15:18:41.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/98/3498/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/3498/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/3498/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/3498/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/3498/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/3498/1"}}},"commit":{"parents":[{"commit":"4c4aa8e4136dfbfd6f8c8c0979f1d91236a44346","subject":"fix(gs/home): Hardcode home directory","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4c4aa8e4136dfbfd6f8c8c0979f1d91236a44346"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-09-08 15:16:11.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-09-08 15:18:36.000000000","tz":180},"subject":"refactor(readTree): Pass all readTree parameters as function args","message":"refactor(readTree): Pass all readTree parameters as function args\n\nInstead of having a mix of depot-passed args (for the filter) and args\nto the readTree function itself, make everything a single attribute\nset of arguments passed to the function.\n\nThis also makes it a bit easier to extend this in the future.\n\nChange-Id: I633c1fc96026d137b451bb604ef92be32571a0f5\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0e3a4b48f9bfa0bf57e05a7f7f6e12a5923cbae2"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0e3a4b48f9bfa0bf57e05a7f7f6e12a5923cbae2"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"4c4aa8e4136dfbfd6f8c8c0979f1d91236a44346","is_merged_in_target_branch":true,"change_id":"I920a0c546f4c06d0429534d116465e8f732218e7","change_number":3495,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"dd2e0f57517709eb43de46f91841b7c7e7d7209f":{"kind":"REWORK","_number":2,"created":"2021-09-08 15:29:07.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/98/3498/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/3498/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/3498/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/3498/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/3498/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/3498/2"}}},"commit":{"parents":[{"commit":"4c4aa8e4136dfbfd6f8c8c0979f1d91236a44346","subject":"fix(gs/home): Hardcode home directory","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4c4aa8e4136dfbfd6f8c8c0979f1d91236a44346"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-09-08 15:16:11.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-09-08 15:26:50.000000000","tz":180},"subject":"refactor(readTree): Pass all readTree parameters as function args","message":"refactor(readTree): Pass all readTree parameters as function args\n\nInstead of having a mix of depot-passed args (for the filter) and args\nto the readTree function itself, make everything a single attribute\nset of arguments passed to the function.\n\nThis also makes it a bit easier to extend this in the future.\n\nChange-Id: I633c1fc96026d137b451bb604ef92be32571a0f5\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddd2e0f57517709eb43de46f91841b7c7e7d7209f"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddd2e0f57517709eb43de46f91841b7c7e7d7209f"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"4c4aa8e4136dfbfd6f8c8c0979f1d91236a44346","is_merged_in_target_branch":true,"change_id":"I920a0c546f4c06d0429534d116465e8f732218e7","change_number":3495,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"8f3a1c0fd8fa0023a77de0772a6eee6a70a6a2d0":{"kind":"REWORK","_number":3,"created":"2021-09-08 15:33:06.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/98/3498/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/3498/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/3498/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/3498/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/3498/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/3498/3"}}},"commit":{"parents":[{"commit":"4c4aa8e4136dfbfd6f8c8c0979f1d91236a44346","subject":"fix(gs/home): Hardcode home directory","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4c4aa8e4136dfbfd6f8c8c0979f1d91236a44346"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-09-08 15:16:11.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-09-08 15:33:02.000000000","tz":180},"subject":"refactor(readTree): Pass all readTree parameters as function args","message":"refactor(readTree): Pass all readTree parameters as function args\n\nInstead of having a mix of depot-passed args (for the filter) and args\nto the readTree function itself, make everything a single attribute\nset of arguments passed to the function.\n\nThis also makes it a bit easier to extend this in the future.\n\nChange-Id: I633c1fc96026d137b451bb604ef92be32571a0f5\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8f3a1c0fd8fa0023a77de0772a6eee6a70a6a2d0"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8f3a1c0fd8fa0023a77de0772a6eee6a70a6a2d0"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"4c4aa8e4136dfbfd6f8c8c0979f1d91236a44346","is_merged_in_target_branch":true,"change_id":"I920a0c546f4c06d0429534d116465e8f732218e7","change_number":3495,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"30a553993635fa0699fee1eec68a4020b18782b0":{"kind":"REWORK","_number":4,"created":"2021-09-08 15:35:48.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/98/3498/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/3498/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/3498/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/3498/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/3498/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/3498/4"}}},"commit":{"parents":[{"commit":"4c4aa8e4136dfbfd6f8c8c0979f1d91236a44346","subject":"fix(gs/home): Hardcode home directory","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4c4aa8e4136dfbfd6f8c8c0979f1d91236a44346"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-09-08 15:16:11.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-09-08 15:35:45.000000000","tz":180},"subject":"refactor(readTree): Pass all readTree parameters as function args","message":"refactor(readTree): Pass all readTree parameters as function args\n\nInstead of having a mix of depot-passed args (for the filter) and args\nto the readTree function itself, make everything a single attribute\nset of arguments passed to the function.\n\nThis also makes it a bit easier to extend this in the future.\n\nChange-Id: I633c1fc96026d137b451bb604ef92be32571a0f5\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d30a553993635fa0699fee1eec68a4020b18782b0"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d30a553993635fa0699fee1eec68a4020b18782b0"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"4c4aa8e4136dfbfd6f8c8c0979f1d91236a44346","is_merged_in_target_branch":true,"change_id":"I920a0c546f4c06d0429534d116465e8f732218e7","change_number":3495,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"aedde913d125737f81e63edbc7481e886b0a4f2d":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2021-09-08 17:58:53.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/98/3498/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/3498/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/3498/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/3498/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/3498/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/3498/5"}}},"commit":{"parents":[{"commit":"4c4aa8e4136dfbfd6f8c8c0979f1d91236a44346","subject":"fix(gs/home): Hardcode home directory","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4c4aa8e4136dfbfd6f8c8c0979f1d91236a44346"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-09-08 15:16:11.000000000","tz":180},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2021-09-08 17:58:53.000000000","tz":0},"subject":"refactor(readTree): Pass all readTree parameters as function args","message":"refactor(readTree): Pass all readTree parameters as function args\n\nInstead of having a mix of depot-passed args (for the filter) and args\nto the readTree function itself, make everything a single attribute\nset of arguments passed to the function.\n\nThis also makes it a bit easier to extend this in the future.\n\nChange-Id: I633c1fc96026d137b451bb604ef92be32571a0f5\nReviewed-on: https://cl.tvl.fyi/c/depot/+/3498\nTested-by: BuildkiteCI\nReviewed-by: grfn \u003cgrfn@gws.fyi\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003daedde913d125737f81e63edbc7481e886b0a4f2d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003daedde913d125737f81e63edbc7481e886b0a4f2d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"4c4aa8e4136dfbfd6f8c8c0979f1d91236a44346","is_merged_in_target_branch":true,"change_id":"I920a0c546f4c06d0429534d116465e8f732218e7","change_number":3495,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Code-Review-from-owners","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review-from-owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review-from-owners\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review-from-owners\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}