)]}'
{"id":"depot~3502","triplet_id":"depot~canon~I9b488a440368091ed42d707ba4124f592a64bd86","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2021-09-09 12:52:16.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I9b488a440368091ed42d707ba4124f592a64bd86","subject":"refactor(nix/readTree): use throw instead of assertMsg","status":"MERGED","created":"2021-09-08 21:52:13.000000000","updated":"2021-09-09 12:54:00.000000000","submitted":"2021-09-09 12:52:16.000000000","submitter":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"3502","meta_rev_id":"f355d5b367eb2f3f07bfde5cc5986b2ce5cf5e60","_number":3502,"virtual_id_number":3502,"owner":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-09-09 12:52:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-09 12:52:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-08 21:53:32.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-08 22:05:59.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"}],"messages":[{"id":"ca461e9dd5c6169d1749c2b5fb04d3bf6bd94007","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-09-08 21:52:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"55a1cd36f95f1bbd973f45d8d40d8729fa7c30dc","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-09-08 21:53:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/8301","accounts_in_message":[],"_revision_number":1},{"id":"edce387c0294a06769f459e808b21904c2d8794a","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-09-08 22:05:59.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3b35a79db8b13c133a7febd887a4bc852872dd3b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-09-08 22:23:38.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"410356f4249d55ac29549e20c7b1830aeca0aaa4","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-09-08 22:25:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/8306","accounts_in_message":[],"_revision_number":2},{"id":"0caee3c89a29c606974ff601095c62bb3cd49730","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-09-09 12:52:16.000000000","message":"Change has been successfully rebased and submitted as 5f9c85a1b53dc025398e00263f87bf87a16950d3\n\n1 is the latest approved patch-set.\nThe change was submitted with unreviewed changes in the following files:\n\nThe name of the file: nix/readTree/default.nix\nInsertions: 1, Deletions: 1.\n\n```\n@@ -7:12, +7:18 @@\n-  # Optionally accepts an argument `argsFilter` on import, which is a\n-  # function that receives the current tree location (as a list of\n-  # strings) and the argument set and can arbitrarily modify it.\n-  { argsFilter ? (x: _parts: x)\n-  , ... }:\n+  # Called with an attribute set taking the following arguments:\n+  #\n+  #   path: Path to a directory from which to start reading the tree.\n+  #\n+  #   args: Argument set to pass to each imported file.\n+  #\n+  #   filter: Function to filter `args` based on the tree location. This should\n+  #           be a function of the form `args -\u003e location -\u003e args`, where the\n+  #           location is a list of strings representing the path components of\n+  #           the current readTree target. Optional.\n+  { ... }:\n\n@@ -55:56, +61:62 @@\n-    importWithMark \u003d args: path: parts:\n+    importWithMark \u003d args: path: parts: filter:\n\n@@ -62:63, +68:69 @@\n-          else importedFile (argsFilter (argsWithPath args parts) parts);\n+          else importedFile (filter (argsWithPath args parts) parts);\n\n@@ -71:72, +77:78 @@\n-    readTree \u003d { args, initPath, rootDir, parts }:\n+    readTree \u003d { args, initPath, rootDir, parts, argsFilter }:\n\n@@ -78:79, +84:85 @@\n-          else importWithMark args initPath parts;\n+          else importWithMark args initPath parts argsFilter;\n\n@@ +97:98 @@\n+            inherit argsFilter;\n\n@@ -102:103, +109:110 @@\n-          value \u003d importWithMark args p (parts ++ [ c ]);\n+          value \u003d importWithMark args p (parts ++ [ c ]) argsFilter;\n\n@@ -109:114, +116:127 @@\n-    __functor \u003d _: args: initPath: readTree {\n-      inherit args initPath;\n-      rootDir \u003d true;\n-      parts \u003d [];\n-    };\n+    __functor \u003d _:\n+      { path\n+      , args\n+      , filter ? (x: _parts: x) }:\n+        readTree {\n+          inherit args;\n+          argsFilter \u003d filter;\n+          initPath \u003d path;\n+          rootDir \u003d true;\n+          parts \u003d [];\n+        };\n\n```\n","accounts_in_message":[],"_revision_number":3},{"id":"f355d5b367eb2f3f07bfde5cc5986b2ce5cf5e60","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-09-09 12:54:00.000000000","message":"Patch Set 3:\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/8319","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"5f9c85a1b53dc025398e00263f87bf87a16950d3","revisions":{"9a7ad75a6751a58a7454abff61a9334f53fde96e":{"kind":"REWORK","_number":1,"created":"2021-09-08 21:52:13.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/02/3502/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/02/3502/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/02/3502/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/02/3502/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/02/3502/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/02/3502/1"}}},"commit":{"parents":[{"commit":"69805fb3a154e8fbf9af52c819adcd1346f8f16c","subject":"feat(users/sterni/emacs): install bqn-mode","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d69805fb3a154e8fbf9af52c819adcd1346f8f16c"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-09-08 21:50:11.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-09-08 21:52:06.000000000","tz":120},"subject":"refactor(nix/readTree): use throw instead of assertMsg","message":"refactor(nix/readTree): use throw instead of assertMsg\n\nThis gives a slightly prettier error message and won\u0027t leak the error\nmessage when builtins.tryEval is used. Currently an error message from\nthe tests is always part of the pipeline evaluation log.\n\nChange-Id: I9b488a440368091ed42d707ba4124f592a64bd86\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9a7ad75a6751a58a7454abff61a9334f53fde96e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9a7ad75a6751a58a7454abff61a9334f53fde96e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"69805fb3a154e8fbf9af52c819adcd1346f8f16c","is_merged_in_target_branch":false,"change_id":"I8429f09525e7ca78893b62f6efb8037687ac36a3","change_number":3494,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"0e015e5faa3492bdf866699e3a53009dde08ac16":{"kind":"REWORK","_number":2,"created":"2021-09-08 22:23:38.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/02/3502/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/02/3502/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/02/3502/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/02/3502/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/02/3502/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/02/3502/2"}}},"commit":{"parents":[{"commit":"0f9850d728974fefb16ac535cf0e5fc03074baeb","subject":"feat(users/sterni/emacs): install bqn-mode","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0f9850d728974fefb16ac535cf0e5fc03074baeb"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-09-08 21:50:11.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-09-08 22:23:27.000000000","tz":120},"subject":"refactor(nix/readTree): use throw instead of assertMsg","message":"refactor(nix/readTree): use throw instead of assertMsg\n\nThis gives a slightly prettier error message and won\u0027t leak the error\nmessage when builtins.tryEval is used. Currently an error message from\nthe tests is always part of the pipeline evaluation log.\n\nChange-Id: I9b488a440368091ed42d707ba4124f592a64bd86\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0e015e5faa3492bdf866699e3a53009dde08ac16"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0e015e5faa3492bdf866699e3a53009dde08ac16"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"0f9850d728974fefb16ac535cf0e5fc03074baeb","is_merged_in_target_branch":false,"change_id":"I8429f09525e7ca78893b62f6efb8037687ac36a3","change_number":3494,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"5f9c85a1b53dc025398e00263f87bf87a16950d3":{"kind":"REWORK","_number":3,"created":"2021-09-09 12:52:16.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/02/3502/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/02/3502/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/02/3502/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/02/3502/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/02/3502/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/02/3502/3"}}},"commit":{"parents":[{"commit":"fab7dd62f48ba0ee312ccd92b54446cd9bfa8e94","subject":"feat(users/sterni/emacs): install bqn-mode","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfab7dd62f48ba0ee312ccd92b54446cd9bfa8e94"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-09-08 21:50:11.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-09-09 12:52:16.000000000","tz":0},"subject":"refactor(nix/readTree): use throw instead of assertMsg","message":"refactor(nix/readTree): use throw instead of assertMsg\n\nThis gives a slightly prettier error message and won\u0027t leak the error\nmessage when builtins.tryEval is used. Currently an error message from\nthe tests is always part of the pipeline evaluation log.\n\nChange-Id: I9b488a440368091ed42d707ba4124f592a64bd86\nReviewed-on: https://cl.tvl.fyi/c/depot/+/3502\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5f9c85a1b53dc025398e00263f87bf87a16950d3"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5f9c85a1b53dc025398e00263f87bf87a16950d3"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"fab7dd62f48ba0ee312ccd92b54446cd9bfa8e94","is_merged_in_target_branch":true,"change_id":"I8429f09525e7ca78893b62f6efb8037687ac36a3","change_number":3494,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Code-Review-from-owners","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review-from-owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review-from-owners\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review-from-owners\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}