)]}'
{"id":"depot~3533","triplet_id":"depot~canon~I2df4fab9b0299b3a2b5d3005508c79b2d9796039","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2021-09-11 16:00:12.000000000","reason":"Change was submitted"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2021-09-11 15:59:22.000000000","reason":"grfn replied on the change"}},"hashtags":[],"change_id":"I2df4fab9b0299b3a2b5d3005508c79b2d9796039","subject":"refactor(grfn/xanthous): avoid unnecessary recompilation","status":"MERGED","created":"2021-09-11 14:28:39.000000000","updated":"2021-09-11 16:01:49.000000000","submitted":"2021-09-11 16:00:12.000000000","submitter":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"3533","meta_rev_id":"1f7b60d5d72efa4649919198abbebeb25cd6c7d6","_number":3533,"virtual_id_number":3533,"owner":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-11 16:00:12.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-09-11 16:00:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-11 16:00:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-11 14:28:51.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2021-09-11 14:29:54.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-11 15:57:05.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"}],"messages":[{"id":"1154e543081e27c8c8c915f64e958a40fd60691c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-09-11 14:28:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"33748d5c9dbaaf59819ab3103e519bccb2b76494","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-09-11 14:29:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/8376","accounts_in_message":[],"_revision_number":1},{"id":"d42f896d101ac5b3844120b6cf03be3cd23fdba7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-09-11 14:47:30.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"769c14de3b4fa10fe1658e80f22e1bcc1a205d69","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-09-11 14:48:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/8381","accounts_in_message":[],"_revision_number":2},{"id":"74785dd7e0139ae2d4ab4d1119ae46754d019019","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-09-11 15:57:05.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"23e8661a3e8a6a1cfa3463af8349a817748b4c2a","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2021-09-11 15:59:22.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"6ff4808c9c828382d8b72e2733452e6b2406dcf8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-09-11 16:00:12.000000000","message":"Change has been successfully rebased and submitted as 2f750e4a14be68f275f6fe23995eb9a994e0f5de","accounts_in_message":[],"_revision_number":3},{"id":"1f7b60d5d72efa4649919198abbebeb25cd6c7d6","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-09-11 16:01:49.000000000","message":"Patch Set 3:\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/8384","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"2f750e4a14be68f275f6fe23995eb9a994e0f5de","revisions":{"3d0fdffec5668ff8aa8ccf2de1e921c75a1030db":{"kind":"REWORK","_number":1,"created":"2021-09-11 14:28:39.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/33/3533/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/33/3533/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3533/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3533/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3533/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/33/3533/1"}}},"commit":{"parents":[{"commit":"83b5edf6dc6d9cb2b45e2ed9a8198cf48983f079","subject":"chore(3p): bump NixOS channels to 2021-09-11","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d83b5edf6dc6d9cb2b45e2ed9a8198cf48983f079"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-09-11 14:23:38.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-09-11 14:23:38.000000000","tz":120},"subject":"refactor(grfn/xanthous): avoid unnecessary recompilation","message":"refactor(grfn/xanthous): avoid unnecessary recompilation\n\nhpack is a bit dumb when generating the list of modules for a cabal\nfile\u0027s component if multiple of them live in the same directory.\nSpecifically it seems to assume that all modules in the source-dirs\nof a particular component are also necessary for its compilation.\n\nThis is quite bad in the case of xanthous since both library and\nexecutable have source-dirs: src, so all modules will be compiled\ntwice: Once for the library and then again for the executable\ndespite it depending on the library (actually 4 times in total\nsince we need to build a unprofiled and profiled object for each\nmodule…).\n\nTo fix this we just move Main.hs into its own directory and change\nthe executable\u0027s source-dirs, so hpack doesn\u0027t get confused anymore.\nSince all components now have their own source-dirs, unnecessary\nredundant compilation should be down to 0. The diff of the cabal\nfile shows quite nicely how many module recompilation we\u0027ve gotten\nrid of.\n\nChange-Id: I2df4fab9b0299b3a2b5d3005508c79b2d9796039\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3d0fdffec5668ff8aa8ccf2de1e921c75a1030db"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3d0fdffec5668ff8aa8ccf2de1e921c75a1030db"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"83b5edf6dc6d9cb2b45e2ed9a8198cf48983f079","is_merged_in_target_branch":false,"change_id":"I3556d1f4c41fdaa40017cfe21c389ec121127b0c","change_number":3532,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"b073c6ca34506961d70039492846df5f33f06921":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-09-11 14:47:30.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/33/3533/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/33/3533/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3533/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3533/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3533/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/33/3533/2"}}},"commit":{"parents":[{"commit":"c8dae01e1265af33651563d85c2d088d1e24145e","subject":"chore(3p): bump NixOS channels to 2021-09-11","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc8dae01e1265af33651563d85c2d088d1e24145e"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-09-11 14:23:38.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-09-11 14:47:24.000000000","tz":120},"subject":"refactor(grfn/xanthous): avoid unnecessary recompilation","message":"refactor(grfn/xanthous): avoid unnecessary recompilation\n\nhpack is a bit dumb when generating the list of modules for a cabal\nfile\u0027s component if multiple of them live in the same directory.\nSpecifically it seems to assume that all modules in the source-dirs\nof a particular component are also necessary for its compilation.\n\nThis is quite bad in the case of xanthous since both library and\nexecutable have source-dirs: src, so all modules will be compiled\ntwice: Once for the library and then again for the executable\ndespite it depending on the library (actually 4 times in total\nsince we need to build a unprofiled and profiled object for each\nmodule…).\n\nTo fix this we just move Main.hs into its own directory and change\nthe executable\u0027s source-dirs, so hpack doesn\u0027t get confused anymore.\nSince all components now have their own source-dirs, unnecessary\nredundant compilation should be down to 0. The diff of the cabal\nfile shows quite nicely how many module recompilation we\u0027ve gotten\nrid of.\n\nChange-Id: I2df4fab9b0299b3a2b5d3005508c79b2d9796039\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db073c6ca34506961d70039492846df5f33f06921"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db073c6ca34506961d70039492846df5f33f06921"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c8dae01e1265af33651563d85c2d088d1e24145e","is_merged_in_target_branch":false,"change_id":"I3556d1f4c41fdaa40017cfe21c389ec121127b0c","change_number":3532,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"2f750e4a14be68f275f6fe23995eb9a994e0f5de":{"kind":"REWORK","_number":3,"created":"2021-09-11 16:00:12.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/33/3533/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/33/3533/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3533/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3533/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/33/3533/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/33/3533/3"}}},"commit":{"parents":[{"commit":"a63057414df62f2b680692018fddbcbeae32f15f","subject":"chore(3p): bump NixOS channels to 2021-09-11","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da63057414df62f2b680692018fddbcbeae32f15f"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-09-11 14:23:38.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-09-11 16:00:12.000000000","tz":0},"subject":"refactor(grfn/xanthous): avoid unnecessary recompilation","message":"refactor(grfn/xanthous): avoid unnecessary recompilation\n\nhpack is a bit dumb when generating the list of modules for a cabal\nfile\u0027s component if multiple of them live in the same directory.\nSpecifically it seems to assume that all modules in the source-dirs\nof a particular component are also necessary for its compilation.\n\nThis is quite bad in the case of xanthous since both library and\nexecutable have source-dirs: src, so all modules will be compiled\ntwice: Once for the library and then again for the executable\ndespite it depending on the library (actually 4 times in total\nsince we need to build a unprofiled and profiled object for each\nmodule…).\n\nTo fix this we just move Main.hs into its own directory and change\nthe executable\u0027s source-dirs, so hpack doesn\u0027t get confused anymore.\nSince all components now have their own source-dirs, unnecessary\nredundant compilation should be down to 0. The diff of the cabal\nfile shows quite nicely how many module recompilation we\u0027ve gotten\nrid of.\n\nChange-Id: I2df4fab9b0299b3a2b5d3005508c79b2d9796039\nReviewed-on: https://cl.tvl.fyi/c/depot/+/3533\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\nReviewed-by: grfn \u003cgrfn@gws.fyi\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2f750e4a14be68f275f6fe23995eb9a994e0f5de"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2f750e4a14be68f275f6fe23995eb9a994e0f5de"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a63057414df62f2b680692018fddbcbeae32f15f","is_merged_in_target_branch":true,"change_id":"I3556d1f4c41fdaa40017cfe21c389ec121127b0c","change_number":3532,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Code-Review-from-owners","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review-from-owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review-from-owners\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review-from-owners\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}