)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000039,"name":"cschilling","email":"christian.schilling.de@gmail.com","username":"cschilling"},"change_message_id":"4c9fbb1cdde484d3bf6f24c440723280b3bc11ac","unresolved":true,"context_lines":[{"line_number":22,"context_line":"Please refer to the documentation for josh for more information on"},{"line_number":23,"context_line":"available kinds of josh filters."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Josh state is kept in a systemd state directory in /var/lib/josh and"},{"line_number":26,"context_line":"backed up to Restic. Backing this up is necessary, as josh uses"},{"line_number":27,"context_line":"stateful information to do things like tracking merges and rewriting"},{"line_number":28,"context_line":"history per subtree appropriately to avoid cloned repositories ending"},{"line_number":29,"context_line":"up in peculiar states."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: I156f0298c2aa42e3bdbf5a0e86109070d640c56e"},{"line_number":32,"context_line":"Reviewed-on: https://cl.tvl.fyi/c/depot/+/3563"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"21ddd6be_523ec13d","line":29,"range":{"start_line":25,"start_character":0,"end_line":29,"end_character":22},"updated":"2021-09-17 07:09:06.000000000","message":"Backing up the state is not really necessary. There are no \"peculiar states\" that could happen if that data gets lost.\nThe only reason to keep it between runs is to improve performance after a restart.","commit_id":"ec38839c337654637c05af81db1b6f6afdec9102"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"228816d898666740a7084c827bc2ca756c1f8a51","unresolved":true,"context_lines":[{"line_number":22,"context_line":"Please refer to the documentation for josh for more information on"},{"line_number":23,"context_line":"available kinds of josh filters."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Josh state is kept in a systemd state directory in /var/lib/josh and"},{"line_number":26,"context_line":"backed up to Restic. Backing this up is necessary, as josh uses"},{"line_number":27,"context_line":"stateful information to do things like tracking merges and rewriting"},{"line_number":28,"context_line":"history per subtree appropriately to avoid cloned repositories ending"},{"line_number":29,"context_line":"up in peculiar states."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: I156f0298c2aa42e3bdbf5a0e86109070d640c56e"},{"line_number":32,"context_line":"Reviewed-on: https://cl.tvl.fyi/c/depot/+/3563"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"e0956dd7_9cc92987","line":29,"range":{"start_line":25,"start_character":0,"end_line":29,"end_character":22},"in_reply_to":"21ddd6be_523ec13d","updated":"2021-09-18 11:12:50.000000000","message":"Interesting, I was under the impression that state is retained for making sure that merges or changes to workspace definitions yield the same hashes. Are all the transformations reproducible?\n\nKeeping it between runs is fine anyways, but not having to back it up might be useful.","commit_id":"ec38839c337654637c05af81db1b6f6afdec9102"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"2c23f60117fc354b1d06c9b83172ca70547b4d88","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Please refer to the documentation for josh for more information on"},{"line_number":23,"context_line":"available kinds of josh filters."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Josh state is kept in a systemd state directory in /var/lib/josh and"},{"line_number":26,"context_line":"backed up to Restic. Backing this up is necessary, as josh uses"},{"line_number":27,"context_line":"stateful information to do things like tracking merges and rewriting"},{"line_number":28,"context_line":"history per subtree appropriately to avoid cloned repositories ending"},{"line_number":29,"context_line":"up in peculiar states."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: I156f0298c2aa42e3bdbf5a0e86109070d640c56e"},{"line_number":32,"context_line":"Reviewed-on: https://cl.tvl.fyi/c/depot/+/3563"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"44f08522_a880244a","line":29,"range":{"start_line":25,"start_character":0,"end_line":29,"end_character":22},"in_reply_to":"cbd06cde_573c29e4","updated":"2021-09-24 15:25:25.000000000","message":"Okay cool, thanks for the explanation!","commit_id":"ec38839c337654637c05af81db1b6f6afdec9102"},{"author":{"_account_id":1000039,"name":"cschilling","email":"christian.schilling.de@gmail.com","username":"cschilling"},"change_message_id":"c7e895dd223de1c5409ee6f117515a195951eb6e","unresolved":true,"context_lines":[{"line_number":22,"context_line":"Please refer to the documentation for josh for more information on"},{"line_number":23,"context_line":"available kinds of josh filters."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Josh state is kept in a systemd state directory in /var/lib/josh and"},{"line_number":26,"context_line":"backed up to Restic. Backing this up is necessary, as josh uses"},{"line_number":27,"context_line":"stateful information to do things like tracking merges and rewriting"},{"line_number":28,"context_line":"history per subtree appropriately to avoid cloned repositories ending"},{"line_number":29,"context_line":"up in peculiar states."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: I156f0298c2aa42e3bdbf5a0e86109070d640c56e"},{"line_number":32,"context_line":"Reviewed-on: https://cl.tvl.fyi/c/depot/+/3563"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"cbd06cde_573c29e4","line":29,"range":{"start_line":25,"start_character":0,"end_line":29,"end_character":22},"in_reply_to":"e0956dd7_9cc92987","updated":"2021-09-19 14:26:04.000000000","message":"All transformations are reproducible. It\u0027s always sha_y \u003d f(sha_x). Merges and also workspace definitions are part of the shas.\nThe only thing that is stored on disk is a lookup table to find sha_y quicker for a given f and sha_x. (And the objects those sha\u0027s refer to, but those are also computed as a pure functions of objects in the upsteam repo)","commit_id":"ec38839c337654637c05af81db1b6f6afdec9102"}],"ops/machines/whitby/default.nix":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"54264f08c78edc21bc1b12a4eee9f47ca4df74a0","unresolved":true,"context_lines":[{"line_number":389,"context_line":"  # Regularly back up whitby to Google Cloud Storage."},{"line_number":390,"context_line":"  systemd.services.restic \u003d {"},{"line_number":391,"context_line":"    description \u003d \"Backups to Google Cloud Storage\";"},{"line_number":392,"context_line":"    script \u003d \"${pkgs.restic}/bin/restic backup /var/lib/gerrit /var/backup/postgresql /var/lib/grafana /var/lib/znc /var/html/deploys.tvl.fyi /var/lib/josh\";"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    environment \u003d {"},{"line_number":395,"context_line":"      GOOGLE_PROJECT_ID \u003d \"tazjins-infrastructure\";"}],"source_content_type":"text/x-nix","patch_set":11,"id":"b270514f_5bc5d9bf","line":392,"updated":"2021-09-16 17:37:47.000000000","message":"might be time to lib.concatStringsSep \" \" [\n  …\n]\n\nhere.","commit_id":"073604821d50f3a1bbc7aea45afb1f505d245ac3"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"b63c9170ebe6da1b4feb96dfd4e306fe89beafb5","unresolved":false,"context_lines":[{"line_number":389,"context_line":"  # Regularly back up whitby to Google Cloud Storage."},{"line_number":390,"context_line":"  systemd.services.restic \u003d {"},{"line_number":391,"context_line":"    description \u003d \"Backups to Google Cloud Storage\";"},{"line_number":392,"context_line":"    script \u003d \"${pkgs.restic}/bin/restic backup /var/lib/gerrit /var/backup/postgresql /var/lib/grafana /var/lib/znc /var/html/deploys.tvl.fyi /var/lib/josh\";"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    environment \u003d {"},{"line_number":395,"context_line":"      GOOGLE_PROJECT_ID \u003d \"tazjins-infrastructure\";"}],"source_content_type":"text/x-nix","patch_set":11,"id":"da096be4_e7ed9895","line":392,"in_reply_to":"7a71256c_c811acc9","updated":"2021-09-16 19:17:20.000000000","message":"cl/3565","commit_id":"073604821d50f3a1bbc7aea45afb1f505d245ac3"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"44acd5d790a996d2216de65320a5647542e170d8","unresolved":true,"context_lines":[{"line_number":389,"context_line":"  # Regularly back up whitby to Google Cloud Storage."},{"line_number":390,"context_line":"  systemd.services.restic \u003d {"},{"line_number":391,"context_line":"    description \u003d \"Backups to Google Cloud Storage\";"},{"line_number":392,"context_line":"    script \u003d \"${pkgs.restic}/bin/restic backup /var/lib/gerrit /var/backup/postgresql /var/lib/grafana /var/lib/znc /var/html/deploys.tvl.fyi /var/lib/josh\";"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    environment \u003d {"},{"line_number":395,"context_line":"      GOOGLE_PROJECT_ID \u003d \"tazjins-infrastructure\";"}],"source_content_type":"text/x-nix","patch_set":11,"id":"ee760bb5_e3c94f51","line":392,"in_reply_to":"b270514f_5bc5d9bf","updated":"2021-09-16 18:32:35.000000000","message":"Already filed as https://b.tvl.fyi/issues/147","commit_id":"073604821d50f3a1bbc7aea45afb1f505d245ac3"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"97a30e88e3a9ae35c6b19a651c7eedb9a4fd2295","unresolved":true,"context_lines":[{"line_number":389,"context_line":"  # Regularly back up whitby to Google Cloud Storage."},{"line_number":390,"context_line":"  systemd.services.restic \u003d {"},{"line_number":391,"context_line":"    description \u003d \"Backups to Google Cloud Storage\";"},{"line_number":392,"context_line":"    script \u003d \"${pkgs.restic}/bin/restic backup /var/lib/gerrit /var/backup/postgresql /var/lib/grafana /var/lib/znc /var/html/deploys.tvl.fyi /var/lib/josh\";"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    environment \u003d {"},{"line_number":395,"context_line":"      GOOGLE_PROJECT_ID \u003d \"tazjins-infrastructure\";"}],"source_content_type":"text/x-nix","patch_set":11,"id":"7a71256c_c811acc9","line":392,"in_reply_to":"ee760bb5_e3c94f51","updated":"2021-09-16 18:38:56.000000000","message":"That\u0027s a followup cleanup - this is about splitting this into multiple lines, while b/147 isn\u0027t fixed.","commit_id":"073604821d50f3a1bbc7aea45afb1f505d245ac3"}],"ops/modules/www/code.tvl.fyi.nix":[{"author":{"_account_id":1000039,"name":"cschilling","email":"christian.schilling.de@gmail.com","username":"cschilling"},"change_message_id":"4c9fbb1cdde484d3bf6f24c440723280b3bc11ac","unresolved":true,"context_lines":[{"line_number":20,"context_line":"            alias ${depot.tvix.docs.svg}/component-flow.svg;"},{"line_number":21,"context_line":"        }"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        # Git operations on depot.git hit josh"},{"line_number":24,"context_line":"        location /depot.git {"},{"line_number":25,"context_line":"            proxy_pass http://localhost:${toString config.services.depot.git-serving.joshPort};"},{"line_number":26,"context_line":"        }"}],"source_content_type":"text/x-nix","patch_set":12,"id":"4879122d_18ad7eb4","line":23,"updated":"2021-09-17 07:09:06.000000000","message":"Josh serves some extra things under paths starting with /~/ it would be good to have them exposed as well:\n\n/~/graphql/...\n   A GraphQL API to introspect the repo without cloning it.\n\n/~/graphiql/...\n   A UI to test out graphql queries and look at auto generated API reference.\n\n/~/browse/... (and some more)\n   A (very much work in progess) repo browser.","commit_id":"ec38839c337654637c05af81db1b6f6afdec9102"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"228816d898666740a7084c827bc2ca756c1f8a51","unresolved":false,"context_lines":[{"line_number":20,"context_line":"            alias ${depot.tvix.docs.svg}/component-flow.svg;"},{"line_number":21,"context_line":"        }"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        # Git operations on depot.git hit josh"},{"line_number":24,"context_line":"        location /depot.git {"},{"line_number":25,"context_line":"            proxy_pass http://localhost:${toString config.services.depot.git-serving.joshPort};"},{"line_number":26,"context_line":"        }"}],"source_content_type":"text/x-nix","patch_set":12,"id":"fff03f6c_6bfb23a1","line":23,"in_reply_to":"4879122d_18ad7eb4","updated":"2021-09-18 11:12:50.000000000","message":"I\u0027ve opened b/148 for this, thanks!","commit_id":"ec38839c337654637c05af81db1b6f6afdec9102"}]}