)]}'
{"id":"depot~3605","triplet_id":"depot~canon~If31f62dea7ce688fd1b9050204e9378019775f2b","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2021-09-21 11:26:48.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2021-09-21 11:36:52.000000000","reason":"tazjin replied on the change"}},"hashtags":[],"change_id":"If31f62dea7ce688fd1b9050204e9378019775f2b","subject":"chore(3p/git): Unvendor git and track patches instead","status":"MERGED","created":"2021-09-21 10:04:33.000000000","updated":"2022-09-11 17:44:00.000000000","submitted":"2021-09-21 11:37:06.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"3605","meta_rev_id":"6f0947c6cc5662839df17b0432259d029c37320c","_number":3605,"virtual_id_number":3605,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":2,"date":"2022-09-11 17:44:00.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:buildkite~result","value":1,"date":"2021-09-21 11:31:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-21 10:04:36.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-09-21 10:10:51.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-21 11:23:51.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"state":"REVIEWER"}],"messages":[{"id":"2207fd7f59ab5925640379f6038dc38c7f28ce75","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-09-21 10:04:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"324443c8e6f06b35c1dd93a058b336d4e12c67c4","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-09-21 10:04:36.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 of cl/3605: https://buildkite.com/tvl/depot/builds/8598","accounts_in_message":[],"_revision_number":1},{"id":"3756b9289b3a3a843bd76bd36433e3615337b8a7","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-09-21 10:10:51.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/8598","accounts_in_message":[],"_revision_number":1},{"id":"124fb1eb33bcc0eda0643b6b0ada97ed50d1b4dc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-09-21 11:17:25.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"4108d8ffda07f0ecbc3ce5cca8cc0d7a1d9ee1a3","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-09-21 11:17:27.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 of cl/3605: https://buildkite.com/tvl/depot/builds/8618","accounts_in_message":[],"_revision_number":2},{"id":"552849058988ca9d7616e3dd2217654252aea71e","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-09-21 11:19:22.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/8618","accounts_in_message":[],"_revision_number":2},{"id":"423645b240654aad5a2d1ca6970c612c680242fd","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-09-21 11:26:48.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ef56665df3e3b9ca2a2c0176b05e5b9ec2044cdb","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-09-21 11:27:57.000000000","message":"Patch Set 2: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"39fc1be26a8c3ed5463245e782c388379bece630","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-09-21 11:28:07.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"82c7f216d6e41f0e996bf77bfec71258de6b24fd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-09-21 11:29:40.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"79d2c7abb8821f832efdbb90a4ba261e55ef3588","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-09-21 11:29:43.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 of cl/3605: https://buildkite.com/tvl/depot/builds/8619","accounts_in_message":[],"_revision_number":3},{"id":"11ef355bf37ee2152c92ba2bea4865a198d01bc8","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-09-21 11:31:37.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/8619","accounts_in_message":[],"_revision_number":3},{"id":"4f12081287a46acdf122a30c72ea6ed9c5381d1a","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-09-21 11:36:52.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"4f864551d62e99258589787a7a601a964531d3e2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-09-21 11:37:06.000000000","message":"Change has been successfully merged\n\n2 is the latest approved patch-set.\nThe change was submitted with unreviewed changes in the following files:\n\nThe name of the file: third_party/cgit/default.nix\nInsertions: 6, Deletions: 3.\n\n```\n@@ -21:24, +21:27 @@\n-    # Give cgit the git source tree from the depot. Note that the\n-    # versions should be kept in sync (see the Makefile for the current\n-    # git version).\n+    # Give cgit the git source tree including depot patches. Note that\n+    # the version expected by cgit should be kept in sync with the\n+    # version available in nixpkgs.\n+    #\n+    # TODO(tazjin): Add an assert for this somewhere so we notice it on\n+    # channel bumps.\n\n```\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"43b1791ec601732ac31195df96781a848360a9ac","revisions":{"3490e2dc9029a49d96286e6409d828f6127a0eaa":{"kind":"REWORK","_number":1,"created":"2021-09-21 10:04:33.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/05/3605/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/05/3605/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/05/3605/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/05/3605/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/05/3605/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/05/3605/1"}}},"commit":{"parents":[{"commit":"766677748d167d565e1f280a0daea710b2ee8db3","subject":"fix(3p/overlays/tvl): Add fix for Steam web view issue","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d766677748d167d565e1f280a0daea710b2ee8db3"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-09-21 10:03:01.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-09-21 10:04:28.000000000","tz":180},"subject":"chore(3p/git): Unvendor git and track patches instead","message":"chore(3p/git): Unvendor git and track patches instead\n\nThis was vendored a long time ago under the expectation that keeping\nit in sync with cgit would be easier this way, but it has proven not\nto be a big issue.\n\nOn the other hand, a vendored copy of git is an annoying maintenance\nburden. It is much easier to rebase the single (dottime) patch that we\nhave.\n\nThis removes the vendored copy of git and instead passes the git\nsource code to cgit via `pkgs.srcOnly`, which includes the applied\npatch so that cgit can continue rendering dottime.\n\nChange-Id: If31f62dea7ce688fd1b9050204e9378019775f2b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3490e2dc9029a49d96286e6409d828f6127a0eaa"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3490e2dc9029a49d96286e6409d828f6127a0eaa"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"766677748d167d565e1f280a0daea710b2ee8db3","is_merged_in_target_branch":true,"change_id":"Id47f87396ad5e46c98080c7910d337d2643bcbd5","change_number":3604,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"c58cae73305789ab0084ae6b6f0da365c2a5a531":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-09-21 11:17:25.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/05/3605/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/05/3605/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/05/3605/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/05/3605/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/05/3605/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/05/3605/2"}}},"commit":{"parents":[{"commit":"2d8e7dc9d9c38127ec4ebd13aee8e8f586a43318","subject":"chore(3p/cgit): git: update to v2.32.0","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2d8e7dc9d9c38127ec4ebd13aee8e8f586a43318"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-09-21 10:03:01.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-09-21 11:17:19.000000000","tz":180},"subject":"chore(3p/git): Unvendor git and track patches instead","message":"chore(3p/git): Unvendor git and track patches instead\n\nThis was vendored a long time ago under the expectation that keeping\nit in sync with cgit would be easier this way, but it has proven not\nto be a big issue.\n\nOn the other hand, a vendored copy of git is an annoying maintenance\nburden. It is much easier to rebase the single (dottime) patch that we\nhave.\n\nThis removes the vendored copy of git and instead passes the git\nsource code to cgit via `pkgs.srcOnly`, which includes the applied\npatch so that cgit can continue rendering dottime.\n\nChange-Id: If31f62dea7ce688fd1b9050204e9378019775f2b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc58cae73305789ab0084ae6b6f0da365c2a5a531"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc58cae73305789ab0084ae6b6f0da365c2a5a531"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2d8e7dc9d9c38127ec4ebd13aee8e8f586a43318","is_merged_in_target_branch":true,"change_id":"I9c37205af2e67d03f9cdd3d39e4fbd611bfa7288","change_number":3616,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"43b1791ec601732ac31195df96781a848360a9ac":{"kind":"REWORK","_number":3,"created":"2021-09-21 11:29:40.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/05/3605/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/05/3605/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/05/3605/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/05/3605/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/05/3605/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/05/3605/3"}}},"commit":{"parents":[{"commit":"2d8e7dc9d9c38127ec4ebd13aee8e8f586a43318","subject":"chore(3p/cgit): git: update to v2.32.0","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2d8e7dc9d9c38127ec4ebd13aee8e8f586a43318"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-09-21 10:03:01.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2021-09-21 11:29:35.000000000","tz":180},"subject":"chore(3p/git): Unvendor git and track patches instead","message":"chore(3p/git): Unvendor git and track patches instead\n\nThis was vendored a long time ago under the expectation that keeping\nit in sync with cgit would be easier this way, but it has proven not\nto be a big issue.\n\nOn the other hand, a vendored copy of git is an annoying maintenance\nburden. It is much easier to rebase the single (dottime) patch that we\nhave.\n\nThis removes the vendored copy of git and instead passes the git\nsource code to cgit via `pkgs.srcOnly`, which includes the applied\npatch so that cgit can continue rendering dottime.\n\nChange-Id: If31f62dea7ce688fd1b9050204e9378019775f2b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d43b1791ec601732ac31195df96781a848360a9ac"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d43b1791ec601732ac31195df96781a848360a9ac"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2d8e7dc9d9c38127ec4ebd13aee8e8f586a43318","is_merged_in_target_branch":true,"change_id":"I9c37205af2e67d03f9cdd3d39e4fbd611bfa7288","change_number":3616,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Code-Review-from-owners","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review-from-owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review-from-owners\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review-from-owners\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}