)]}'
{"id":"depot~3701","triplet_id":"depot~canon~I7b64579fe96451547babe070fd35db398581e49d","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2021-10-10 10:03:03.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2021-10-09 22:39:22.000000000","reason":"removed on reply"},"1000000":{"account":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"last_update":"2021-10-07 20:30:14.000000000","reason":"lukegb replied on the change"}},"hashtags":[],"change_id":"I7b64579fe96451547babe070fd35db398581e49d","subject":"fix(3p): resolve linker issues with clang-compiled C++ packages","status":"MERGED","created":"2021-10-07 20:07:30.000000000","updated":"2021-10-10 10:05:04.000000000","submitted":"2021-10-10 10:03:03.000000000","submitter":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"3705","meta_rev_id":"de1fd21075c43257c83c75fe4767e509504b12bc","_number":3701,"virtual_id_number":3701,"owner":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-10-10 10:03:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-10-10 10:03:03.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-10-10 10:03:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-07 20:07:31.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-10-07 20:07:51.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"state":"REVIEWER"},{"updated":"2021-10-07 20:07:51.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2021-10-07 20:12:08.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"bbf5a6194de62d298f806dea303e98157dbdf456","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-10-07 20:07:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ea18508a5ae7714bc02d90977d0e03a7ed41f432","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-10-07 20:07:31.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 of cl/3701: https://buildkite.com/tvl/depot/builds/8798","accounts_in_message":[],"_revision_number":1},{"id":"92bcb2d72478e690f692a6785b12a8ce6140d8d8","tag":"autogenerated:gerrit:setReadyForReview","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-10-07 20:07:43.000000000","message":"Set Ready For Review","accounts_in_message":[],"_revision_number":1},{"id":"3e14bdc30055c9c96cf199625876ab41be18d728","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-10-07 20:12:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/8798","accounts_in_message":[],"_revision_number":1},{"id":"2dce3b0724d490810d105a39f0ea072b5791738e","author":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"date":"2021-10-07 20:30:14.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"2e46264e094becb37af6691a9815d97a0da6a36e","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2021-10-09 22:39:22.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"80487d29c1a5be8f976b7e8ed293debe46665ab1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2021-10-10 10:03:03.000000000","message":"Change has been successfully rebased and submitted as 04f7cc3880912abb738d3d3bc20e7622a211f25e","accounts_in_message":[],"_revision_number":2},{"id":"2c495f0a1e2f0015d9d1cc2b876879e8d504424a","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-10-10 10:03:04.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 of cl/3701: https://buildkite.com/tvl/depot/builds/8806","accounts_in_message":[],"_revision_number":2},{"id":"de1fd21075c43257c83c75fe4767e509504b12bc","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-10-10 10:05:04.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/8806","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"04f7cc3880912abb738d3d3bc20e7622a211f25e","revisions":{"b7c4f58677ac31e0c1a64a293f32a3720b1e71fd":{"kind":"REWORK","_number":1,"created":"2021-10-07 20:07:30.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/01/3701/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/01/3701/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/01/3701/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/01/3701/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/01/3701/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/01/3701/1"}}},"commit":{"parents":[{"commit":"26f0ba5464131630db06dcbba5b445516b95c2ff","subject":"refactor(web): use static.tvl.{fyi|su} for static assets","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d26f0ba5464131630db06dcbba5b445516b95c2ff"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-10-07 19:57:09.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-10-07 20:07:28.000000000","tz":120},"subject":"fix(3p): resolve linker issues with clang-compiled C++ packages","message":"fix(3p): resolve linker issues with clang-compiled C++ packages\n\nThe point where this broke is likely when llvmPackages_11.stdenv started\nrespecting stdenv.hostPlatform.linker and thus using GNU binutils\u0027\nld.bfd for linking. That linker can\u0027t deal with clang\u0027s C++ ABI.\n\nTo fix this we introduce a modified version of llvmPackages_11.stdenv\nwhich uses llvmPackages_11.bintools for linking purposes (I also aim to\nupstream this in some form, but am not sure about the details atm, so\nwe\u0027ll just do this in the tvl overlay for now). This is the precondition\nfor getting our C++ packages in //third_party to work\nagain. Additionally the following fixes were necessary:\n\n* abseil-cpp needed to be updated (by overriding the version from\n  nixpkgs for now, since I can\u0027t update the subtree on my own) to\n  fulfill grpc\u0027s requirements (grpc 1.41.0 needs abseil-cpp LTS\n  20210324).\n\n* gtest needs a patch from nixpkgs which fixes the path to its include\n  directory for CMake.\n\n* We need to build re2 with clang as well, otherwise linking will fail.\n\nFixes b/132.\n\nChange-Id: I7b64579fe96451547babe070fd35db398581e49d\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db7c4f58677ac31e0c1a64a293f32a3720b1e71fd"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db7c4f58677ac31e0c1a64a293f32a3720b1e71fd"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"26f0ba5464131630db06dcbba5b445516b95c2ff","is_merged_in_target_branch":true,"change_id":"Ia882dd37ceae9d047cd81cf1eb37a856b339643a","change_number":3682,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"04f7cc3880912abb738d3d3bc20e7622a211f25e":{"kind":"REWORK","_number":2,"created":"2021-10-10 10:03:03.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/01/3701/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/01/3701/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/01/3701/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/01/3701/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/01/3701/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/01/3701/2"}}},"commit":{"parents":[{"commit":"ac17de3cbd2c5bcb1d12992c2fe5c6a554ab4716","subject":"chore(tazjin/tverskoy): Timezone -\u003e Europe/Stockholm","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dac17de3cbd2c5bcb1d12992c2fe5c6a554ab4716"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-10-07 19:57:09.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2021-10-10 10:03:03.000000000","tz":0},"subject":"fix(3p): resolve linker issues with clang-compiled C++ packages","message":"fix(3p): resolve linker issues with clang-compiled C++ packages\n\nThe point where this broke is likely when llvmPackages_11.stdenv started\nrespecting stdenv.hostPlatform.linker and thus using GNU binutils\u0027\nld.bfd for linking. That linker can\u0027t deal with clang\u0027s C++ ABI.\n\nTo fix this we introduce a modified version of llvmPackages_11.stdenv\nwhich uses llvmPackages_11.bintools for linking purposes (I also aim to\nupstream this in some form, but am not sure about the details atm, so\nwe\u0027ll just do this in the tvl overlay for now). This is the precondition\nfor getting our C++ packages in //third_party to work\nagain. Additionally the following fixes were necessary:\n\n* abseil-cpp needed to be updated (by overriding the version from\n  nixpkgs for now, since I can\u0027t update the subtree on my own) to\n  fulfill grpc\u0027s requirements (grpc 1.41.0 needs abseil-cpp LTS\n  20210324).\n\n* gtest needs a patch from nixpkgs which fixes the path to its include\n  directory for CMake.\n\n* We need to build re2 with clang as well, otherwise linking will fail.\n\nFixes b/132.\n\nChange-Id: I7b64579fe96451547babe070fd35db398581e49d\nReviewed-on: https://cl.tvl.fyi/c/depot/+/3701\nTested-by: BuildkiteCI\nReviewed-by: lukegb \u003clukegb@tvl.fyi\u003e\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d04f7cc3880912abb738d3d3bc20e7622a211f25e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d04f7cc3880912abb738d3d3bc20e7622a211f25e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ac17de3cbd2c5bcb1d12992c2fe5c6a554ab4716","is_merged_in_target_branch":true,"change_id":"I8247ac6c15d3ee89e902737f160d5f0acae707bd","change_number":3703,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Code-Review-from-owners","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review-from-owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review-from-owners\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review-from-owners\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}