)]}'
{"id":"depot~3885","triplet_id":"depot~canon~I01a11ce4bd448c25a818c886825e4fad56dffe03","project":"depot","branch":"canon","hashtags":[],"change_id":"I01a11ce4bd448c25a818c886825e4fad56dffe03","subject":"fix(gs/xanthous): Check for reaching destination in AI","status":"MERGED","created":"2021-11-20 21:40:45.000000000","updated":"2021-11-20 21:51:27.000000000","submitted":"2021-11-20 21:49:30.000000000","submitter":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"3885","meta_rev_id":"96771dd0b8aba98840311e965e69f332ce032754","_number":3885,"virtual_id_number":3885,"owner":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-20 21:49:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-20 21:49:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-20 21:40:46.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-11-20 21:47:15.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3bd4599707ea190591115238aa509466c825440f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2021-11-20 21:40:45.000000000","message":"Uploaded patch set 1: Code-Review+2.","accounts_in_message":[],"_revision_number":1},{"id":"45f3766cec91f17ac58dadb2d0a6e5499bb9db16","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-11-20 21:40:46.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 of cl/3885: https://buildkite.com/tvl/depot/builds/9310","accounts_in_message":[],"_revision_number":1},{"id":"8256e50df97bde2b976958a4e74e127e300f4bf7","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-11-20 21:47:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/9310","accounts_in_message":[],"_revision_number":1},{"id":"3ef9c84bccc93ec88e2a3e9b8cae2151f01a5632","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2021-11-20 21:49:30.000000000","message":"Change has been successfully rebased and submitted as 21c218542c4e602fb22b6b6fd529307ff3e8f457","accounts_in_message":[],"_revision_number":2},{"id":"0796534714725db32f31b2a5315203d08b52f34e","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-11-20 21:49:31.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 of cl/3885: https://buildkite.com/tvl/depot/builds/9316","accounts_in_message":[],"_revision_number":2},{"id":"96771dd0b8aba98840311e965e69f332ce032754","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2021-11-20 21:51:27.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/9316","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"21c218542c4e602fb22b6b6fd529307ff3e8f457","revisions":{"5f94081bc620f5c58a4f1bab6beac72acf32746b":{"kind":"REWORK","_number":1,"created":"2021-11-20 21:40:45.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/85/3885/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/85/3885/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/85/3885/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/85/3885/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/85/3885/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/85/3885/1"}}},"commit":{"parents":[{"commit":"3e256b4947b3381f2f8275dc4f9a630199bf87d4","subject":"chore(3p): bump NixOS channels to 2021-11-16","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3e256b4947b3381f2f8275dc4f9a630199bf87d4"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2021-11-20 21:39:35.000000000","tz":-300},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2021-11-20 21:39:35.000000000","tz":-300},"subject":"fix(gs/xanthous): Check for reaching destination in AI","message":"fix(gs/xanthous): Check for reaching destination in AI\n\nBecause floating points, it\u0027s possible that a creature has reached their\ndestination even if the *progress* to that destination is at 0 - if that\nhappens, they should pick a new destination regardless. This fixes the\nissue where creatures would occasionally get \"stuck\" and never move\nafter wandering around for a bit.\n\nChange-Id: I01a11ce4bd448c25a818c886825e4fad56dffe03\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5f94081bc620f5c58a4f1bab6beac72acf32746b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5f94081bc620f5c58a4f1bab6beac72acf32746b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3e256b4947b3381f2f8275dc4f9a630199bf87d4","is_merged_in_target_branch":true,"change_id":"I95572427b041f7a406bee214f5819a698d681661","change_number":3882,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"21c218542c4e602fb22b6b6fd529307ff3e8f457":{"kind":"REWORK","_number":2,"created":"2021-11-20 21:49:30.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/85/3885/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/85/3885/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/85/3885/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/85/3885/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/85/3885/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/85/3885/2"}}},"commit":{"parents":[{"commit":"ed0447ea0d246c576b66dc38910106831300ed82","subject":"chore(gs/emacs): Update org\u003c-\u003ejira state mapping","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ded0447ea0d246c576b66dc38910106831300ed82"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2021-11-20 21:39:35.000000000","tz":-300},"committer":{"name":"grfn","email":"grfn@gws.fyi","date":"2021-11-20 21:49:30.000000000","tz":0},"subject":"fix(gs/xanthous): Check for reaching destination in AI","message":"fix(gs/xanthous): Check for reaching destination in AI\n\nBecause floating points, it\u0027s possible that a creature has reached their\ndestination even if the *progress* to that destination is at 0 - if that\nhappens, they should pick a new destination regardless. This fixes the\nissue where creatures would occasionally get \"stuck\" and never move\nafter wandering around for a bit.\n\nChange-Id: I01a11ce4bd448c25a818c886825e4fad56dffe03\nReviewed-on: https://cl.tvl.fyi/c/depot/+/3885\nReviewed-by: grfn \u003cgrfn@gws.fyi\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d21c218542c4e602fb22b6b6fd529307ff3e8f457"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d21c218542c4e602fb22b6b6fd529307ff3e8f457"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ed0447ea0d246c576b66dc38910106831300ed82","is_merged_in_target_branch":true,"change_id":"If941c0237f5291bebe201e22cc74484f17b148ae","change_number":3884,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Code-Review-from-owners","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review-from-owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review-from-owners\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review-from-owners\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}