)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"e64fe2a8a7eb93fca16d50ef0aecd0c1950ad159","unresolved":false,"context_lines":[{"line_number":19,"context_line":"https://gerrit-review.googlesource.com/Documentation/json.html#patchSet"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Note that an argument can be made that we should do the exact opposite"},{"line_number":22,"context_line":"- stop carrying over \u0027Verified\u0027 at all and always build all patchsets."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"I think this depends on whether we intend to use commit metadata in CI"},{"line_number":25,"context_line":"runs at all. Adding a few people to the review for opinions."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f3583f53_d0f671d4","line":22,"updated":"2022-01-13 01:02:04.000000000","message":"Thought about this a bit, and actually I don\u0027t think we *should* use commit message metadata in builds, since our commit message linting is relatively straightforward to do via prolog submit rules.\n\nGiven the current evaluation performance (rather poor) I think this change is a relatively cheap way of saving a little bit of time on no-op builds.","commit_id":"d9f445c8ee4aaa563065f6edd71aef91f60c1050"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000043,"name":"asmundo","display_name":"Åsmund","email":"asmundo@gmail.com","username":"asmundo"},"change_message_id":"6979ab2e2331677f1f2e083005681b1b74ca2a6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1b2ceebc_855155a1","updated":"2022-01-13 08:40:17.000000000","message":"As long as all we can assume that all that is executed is nix derivations this is a good idea. But at the moment when there are something is not inside a nix derivation it should be possible to skip this type of optimization. These are often less stable.. ","commit_id":"d9f445c8ee4aaa563065f6edd71aef91f60c1050"}],"ops/besadii/main.go":[{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"89addaf6017fa19db4281f820e202c501c15fcf9","unresolved":true,"context_lines":[{"line_number":362,"context_line":"\tflag.Parse()"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"\t// Ignore patchsets which do not contain code changes"},{"line_number":365,"context_line":"\tif kind \u003d\u003d \"NO_CODE_CHANGE\" {"},{"line_number":366,"context_line":"\t\treturn nil, nil"},{"line_number":367,"context_line":"\t}"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-go","patch_set":2,"id":"497410ba_6782319b","line":365,"range":{"start_line":365,"start_character":13,"end_line":365,"end_character":27},"updated":"2022-01-12 14:59:51.000000000","message":"Shouldn\u0027t we ignore `NOCH_CHANGE` as well?","commit_id":"2aa8fa748036bc1d2f0469412558f1e38b34d519"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"7dd90b5b056f0645ec586a84dd18c50aecf95892","unresolved":false,"context_lines":[{"line_number":362,"context_line":"\tflag.Parse()"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"\t// Ignore patchsets which do not contain code changes"},{"line_number":365,"context_line":"\tif kind \u003d\u003d \"NO_CODE_CHANGE\" {"},{"line_number":366,"context_line":"\t\treturn nil, nil"},{"line_number":367,"context_line":"\t}"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-go","patch_set":2,"id":"39751b7a_141e7207","line":365,"range":{"start_line":365,"start_character":13,"end_line":365,"end_character":27},"in_reply_to":"497410ba_6782319b","updated":"2022-01-12 16:13:50.000000000","message":"Done","commit_id":"2aa8fa748036bc1d2f0469412558f1e38b34d519"}]}
