)]}'
{"id":"depot~491","triplet_id":"depot~master~I5779db8dbf7b7ced109c26b940f721d237d60785","project":"depot","branch":"master","hashtags":[],"change_id":"I5779db8dbf7b7ced109c26b940f721d237d60785","subject":"refactor(cheddar): Pass references readers \u0026 writers into renderers","status":"MERGED","created":"2020-06-19 02:36:19.000000000","updated":"2020-06-19 03:10:04.000000000","submitted":"2020-06-19 02:49:41.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":18,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"492","meta_rev_id":"60348bdf9769399b2023c24ba37102d32820231a","_number":491,"virtual_id_number":491,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-06-19 02:49:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-06-19 02:49:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-19 02:40:31.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2020-06-19 02:43:46.000000000","updated_by":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"reviewer":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"state":"CC"},{"updated":"2020-06-19 02:49:24.000000000","updated_by":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"reviewer":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"state":"REVIEWER"}],"messages":[{"id":"3fdd1e2f3d646d0034b60205a98adb2b23a51221","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-06-19 02:36:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9b081ad5c5c4a260893db5678e417cebf342b7b9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-06-19 02:37:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8b539f294032c6ad7025b6bec111fccf891604a6","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-06-19 02:40:31.000000000","message":"Patch Set 2: Code-Review-1\n\n(3 comments)\n\nstylistic nits but functionality seems sensible","accounts_in_message":[],"_revision_number":2},{"id":"9d169acb4681c21af319d50cde25ebe177e474cb","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-06-19 02:42:11.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"3c72affe605f9068fbcbbf602ed480a1c4490db5","author":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"date":"2020-06-19 02:44:41.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e4038d5d109ea4bd4b17ec056ffce37e67fe1ea0","author":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"date":"2020-06-19 02:45:01.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9aa0b1b7b8630fc105e39a9c8c2151dab0dc3ef1","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-06-19 02:45:38.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"444b76cc578cbb12033664bce83e53e3a33c5019","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-06-19 02:46:14.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"acf5de6fd0e17c6933697d32c0f392abf8619f38","author":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"date":"2020-06-19 02:49:24.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ff5fa14902482a5524e8d8f55a874119ae34a53f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-06-19 02:49:41.000000000","message":"Change has been successfully rebased and submitted as d1524a5a6ff7e07469ec226376f51d99e3a01a96 by tazjin","accounts_in_message":[],"_revision_number":3},{"id":"60348bdf9769399b2023c24ba37102d32820231a","author":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"date":"2020-06-19 03:10:04.000000000","message":"Patch Set 3:\n\n(9 comments)","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"d1524a5a6ff7e07469ec226376f51d99e3a01a96","revisions":{"a2264c3b7329cca1133b33a4d9599f206a92af7d":{"kind":"REWORK","_number":1,"created":"2020-06-19 02:36:19.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/91/491/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/91/491/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/91/491/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/91/491/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/91/491/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/91/491/1"}}},"commit":{"parents":[{"commit":"4496c48f1ac47b0746e8b7588ea0e2fb01922f26","subject":"feat(tazjin/frog): Install lutris","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4496c48f1ac47b0746e8b7588ea0e2fb01922f26"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-06-19 02:35:05.000000000","tz":60},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-06-19 02:35:05.000000000","tz":60},"subject":"refactor(cheddar): Pass references readers \u0026 writers into renderers","message":"refactor(cheddar): Pass references readers \u0026 writers into renderers\n\nThis paves the way for using other things than stdin/stdout as\nsources/sinks, which is required for example for implementing a\nsyntect_server replacement based on cheddar.\n\nChange-Id: I5779db8dbf7b7ced109c26b940f721d237d60785\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da2264c3b7329cca1133b33a4d9599f206a92af7d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da2264c3b7329cca1133b33a4d9599f206a92af7d"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"4496c48f1ac47b0746e8b7588ea0e2fb01922f26","is_merged_in_target_branch":false,"change_id":"I337ffe42007e6c30022719f3564a400a84ddd0e0","change_number":490,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"accff7bf4fb1dc01a2129667b334f02a6dab4540":{"kind":"REWORK","_number":2,"created":"2020-06-19 02:37:09.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/91/491/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/91/491/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/91/491/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/91/491/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/91/491/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/91/491/2"}}},"commit":{"parents":[{"commit":"4496c48f1ac47b0746e8b7588ea0e2fb01922f26","subject":"feat(tazjin/frog): Install lutris","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4496c48f1ac47b0746e8b7588ea0e2fb01922f26"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-06-19 02:35:05.000000000","tz":60},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-06-19 02:37:04.000000000","tz":60},"subject":"refactor(cheddar): Pass references readers \u0026 writers into renderers","message":"refactor(cheddar): Pass references readers \u0026 writers into renderers\n\nThis paves the way for using other things than stdin/stdout as\nsources/sinks, which is required for example for implementing a\nsyntect_server replacement based on cheddar.\n\nChange-Id: I5779db8dbf7b7ced109c26b940f721d237d60785\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003daccff7bf4fb1dc01a2129667b334f02a6dab4540"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003daccff7bf4fb1dc01a2129667b334f02a6dab4540"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"4496c48f1ac47b0746e8b7588ea0e2fb01922f26","is_merged_in_target_branch":false,"change_id":"I337ffe42007e6c30022719f3564a400a84ddd0e0","change_number":490,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"d1524a5a6ff7e07469ec226376f51d99e3a01a96":{"kind":"REWORK","_number":3,"created":"2020-06-19 02:49:41.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/91/491/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/91/491/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/91/491/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/91/491/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/91/491/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/91/491/3"}}},"commit":{"parents":[{"commit":"9b5b88ae6c8e4700d96aac134a1d64af4a89f6d5","subject":"feat(web/tvl): Add nyanotech to tvl graph","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9b5b88ae6c8e4700d96aac134a1d64af4a89f6d5"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-06-19 02:35:05.000000000","tz":60},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2020-06-19 02:49:41.000000000","tz":0},"subject":"refactor(cheddar): Pass references readers \u0026 writers into renderers","message":"refactor(cheddar): Pass references readers \u0026 writers into renderers\n\nThis paves the way for using other things than stdin/stdout as\nsources/sinks, which is required for example for implementing a\nsyntect_server replacement based on cheddar.\n\nChange-Id: I5779db8dbf7b7ced109c26b940f721d237d60785\nReviewed-on: https://cl.tvl.fyi/c/depot/+/491\nReviewed-by: glittershark \u003cgrfn@gws.fyi\u003e\nReviewed-by: lukegb \u003clukegb@tvl.fyi\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd1524a5a6ff7e07469ec226376f51d99e3a01a96"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd1524a5a6ff7e07469ec226376f51d99e3a01a96"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9b5b88ae6c8e4700d96aac134a1d64af4a89f6d5","is_merged_in_target_branch":false,"change_id":"I3ce5184c688f75c3f7207023cd284cd5a1edd93d","change_number":489,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}}]}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}