)]}'
{"id":"depot~503","triplet_id":"depot~master~I48e75db55b5f793342fc898093629e437f58dcb2","project":"depot","branch":"master","hashtags":[],"change_id":"I48e75db55b5f793342fc898093629e437f58dcb2","subject":"feat(emacs-pkgs/tvl): Add magit shortcuts for reviews \u0026 co","status":"MERGED","created":"2020-06-19 15:58:21.000000000","updated":"2020-06-19 17:54:46.000000000","submitted":"2020-06-19 17:54:46.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"505","meta_rev_id":"ab6313158fff32c8fbd055194da565ad87cceed2","_number":503,"virtual_id_number":503,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-06-19 17:54:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-19 15:58:36.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"}],"messages":[{"id":"b8ccd1f4e40881a633f8db67b60854d65917c0bf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-06-19 15:58:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"49b7ae95a6b9828190bb225ebb823edc5baa1b46","tag":"autogenerated:gerrit:setAssignee","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-06-19 15:59:04.000000000","message":"Assignee added: glittershark \u003cgrfn@gws.fyi\u003e","accounts_in_message":[],"_revision_number":1},{"id":"d23e636cd4dd84f942527b5bbd02ddb347feec15","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-06-19 16:03:39.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"adedc6a093927f87d2f30c100508c35516c627aa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-06-19 16:23:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ab265e741651b655e775b3a63de7b3624ab0a5cd","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-06-19 16:23:40.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"7bed5b43960695fd3f74e846288c01acd1a4840e","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-06-19 16:35:51.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ab6313158fff32c8fbd055194da565ad87cceed2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-06-19 17:54:46.000000000","message":"Change has been successfully rebased and submitted as e7f8bdd548a7347759c8704f4293daacf1277581 by tazjin","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"e7f8bdd548a7347759c8704f4293daacf1277581","revisions":{"9dc5f95d769a04fb3864ac941853cb7ac6d1a27e":{"kind":"REWORK","_number":1,"created":"2020-06-19 15:58:21.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/03/503/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/03/503/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/03/503/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/03/503/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/03/503/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/03/503/1"}}},"commit":{"parents":[{"commit":"b72d23207552a79bcb8623b85415fa4ededd3ecc","subject":"fix(buildTypedGo): Pass correct arguments to .package","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db72d23207552a79bcb8623b85415fa4ededd3ecc"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-06-19 15:51:31.000000000","tz":60},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-06-19 15:58:11.000000000","tz":60},"subject":"feat(emacs-pkgs/tvl): Add magit shortcuts for reviews \u0026 co","message":"feat(emacs-pkgs/tvl): Add magit shortcuts for reviews \u0026 co\n\nIntroduces two new shortcuts in the magit popup for pushing:\n\n* R: Push for review\n* S: Push to submit\n\nThe existing \"P\" command remains, but has been renamed to\n\"rubberstamp\" and documented with a warning.\n\nTo make this work across people\u0027s different setups, customisation\noptions for TVL-specific code are being added.\n\nChange-Id: I48e75db55b5f793342fc898093629e437f58dcb2\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9dc5f95d769a04fb3864ac941853cb7ac6d1a27e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9dc5f95d769a04fb3864ac941853cb7ac6d1a27e"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"b72d23207552a79bcb8623b85415fa4ededd3ecc","is_merged_in_target_branch":false,"change_id":"I535e084e7b3195628609bb43e382e450bc0003ba","change_number":497,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"09e38634f6e1d3947a08358eaed6bea3f64d7943":{"kind":"REWORK","_number":2,"created":"2020-06-19 16:23:26.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/03/503/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/03/503/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/03/503/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/03/503/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/03/503/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/03/503/2"}}},"commit":{"parents":[{"commit":"b72d23207552a79bcb8623b85415fa4ededd3ecc","subject":"fix(buildTypedGo): Pass correct arguments to .package","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db72d23207552a79bcb8623b85415fa4ededd3ecc"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-06-19 15:51:31.000000000","tz":60},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-06-19 16:22:31.000000000","tz":60},"subject":"feat(emacs-pkgs/tvl): Add magit shortcuts for reviews \u0026 co","message":"feat(emacs-pkgs/tvl): Add magit shortcuts for reviews \u0026 co\n\nIntroduces two new shortcuts in the magit popup for pushing:\n\n* R: Push for review\n* S: Push to submit\n\nThe existing \"P\" command remains, but has been renamed to\n\"rubberstamp\" and documented with a warning.\n\nTo make this work across people\u0027s different setups, customisation\noptions for TVL-specific code are being added.\n\nChange-Id: I48e75db55b5f793342fc898093629e437f58dcb2\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d09e38634f6e1d3947a08358eaed6bea3f64d7943"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d09e38634f6e1d3947a08358eaed6bea3f64d7943"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"b72d23207552a79bcb8623b85415fa4ededd3ecc","is_merged_in_target_branch":false,"change_id":"I535e084e7b3195628609bb43e382e450bc0003ba","change_number":497,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"e7f8bdd548a7347759c8704f4293daacf1277581":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2020-06-19 17:54:46.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/03/503/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/03/503/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/03/503/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/03/503/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/03/503/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/03/503/3"}}},"commit":{"parents":[{"commit":"b72d23207552a79bcb8623b85415fa4ededd3ecc","subject":"fix(buildTypedGo): Pass correct arguments to .package","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db72d23207552a79bcb8623b85415fa4ededd3ecc"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-06-19 15:51:31.000000000","tz":60},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2020-06-19 17:54:46.000000000","tz":0},"subject":"feat(emacs-pkgs/tvl): Add magit shortcuts for reviews \u0026 co","message":"feat(emacs-pkgs/tvl): Add magit shortcuts for reviews \u0026 co\n\nIntroduces two new shortcuts in the magit popup for pushing:\n\n* R: Push for review\n* S: Push to submit\n\nThe existing \"P\" command remains, but has been renamed to\n\"rubberstamp\" and documented with a warning.\n\nTo make this work across people\u0027s different setups, customisation\noptions for TVL-specific code are being added.\n\nChange-Id: I48e75db55b5f793342fc898093629e437f58dcb2\nReviewed-on: https://cl.tvl.fyi/c/depot/+/503\nReviewed-by: glittershark \u003cgrfn@gws.fyi\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de7f8bdd548a7347759c8704f4293daacf1277581"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de7f8bdd548a7347759c8704f4293daacf1277581"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"b72d23207552a79bcb8623b85415fa4ededd3ecc","is_merged_in_target_branch":false,"change_id":"I535e084e7b3195628609bb43e382e450bc0003ba","change_number":497,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}}]}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}