)]}'
{"web/panettone/src/authentication.lisp":[{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"29a6fe516f667966f2a052007a5dc8ec006957a7","unresolved":true,"context_lines":[{"line_number":110,"context_line":"                                :user dn"},{"line_number":111,"context_line":"                                :pass password))"},{"line_number":112,"context_line":"           (code-sym (nth-value 1 (ldap:bind conn))))"},{"line_number":113,"context_line":"      (ldap:unbind conn) ;; unbinds \u0026 closes connection"},{"line_number":114,"context_line":"      (when (equalp code-sym \u0027trivial-ldap:success)"},{"line_number":115,"context_line":"        user))))"}],"source_content_type":"text/x-common-lisp","patch_set":2,"id":"05c2aad5_33fff88e","line":113,"updated":"2022-02-03 14:50:56.000000000","message":"shouldn\u0027t this be handling errors somehow?","commit_id":"3a226aa2613960b5b083e59864fc7a6254871d00"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"23d0106dc007919f202a1fca2577ad8a6443b799","unresolved":true,"context_lines":[{"line_number":110,"context_line":"                                :user dn"},{"line_number":111,"context_line":"                                :pass password))"},{"line_number":112,"context_line":"           (code-sym (nth-value 1 (ldap:bind conn))))"},{"line_number":113,"context_line":"      (ldap:unbind conn) ;; unbinds \u0026 closes connection"},{"line_number":114,"context_line":"      (when (equalp code-sym \u0027trivial-ldap:success)"},{"line_number":115,"context_line":"        user))))"}],"source_content_type":"text/x-common-lisp","patch_set":2,"id":"4e1c29c1_88120da5","line":113,"in_reply_to":"05c2aad5_33fff88e","updated":"2022-02-06 10:52:01.000000000","message":"afaict there is no way to get to this line without `conn` being an LDAP connection object (as it would fail on ldap:new-ldap above)\n\nthe function will always succeed if passed a real connection, because it unbinds in a \"fire\u0026forget\" style and then attempts to close the socket, so any remote errors would be ignored\n\nif the socket closes during the lookup I think that\u0027s an error we\u0027d want to have bubbled up.\n\ntl;dr - i think this is fine","commit_id":"3a226aa2613960b5b083e59864fc7a6254871d00"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"16fdb0ee68a96f26876428494942b48e7363784d","unresolved":true,"context_lines":[{"line_number":110,"context_line":"                                :user dn"},{"line_number":111,"context_line":"                                :pass password))"},{"line_number":112,"context_line":"           (code-sym (nth-value 1 (ldap:bind conn))))"},{"line_number":113,"context_line":"      (ldap:unbind conn) ;; unbinds \u0026 closes connection"},{"line_number":114,"context_line":"      (when (equalp code-sym \u0027trivial-ldap:success)"},{"line_number":115,"context_line":"        user))))"}],"source_content_type":"text/x-common-lisp","patch_set":2,"id":"4e78e33f_1c448410","line":113,"in_reply_to":"2542b4f9_5178bee2","updated":"2022-02-07 16:51:33.000000000","message":"Any errors that happen in ldap:bind are already bubbled up (and not handled there either), so this CL doesn\u0027t have an effect on that.","commit_id":"3a226aa2613960b5b083e59864fc7a6254871d00"},{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"5d28b9d8b35ef7509695c4b31fb22b9827ef3fb4","unresolved":true,"context_lines":[{"line_number":110,"context_line":"                                :user dn"},{"line_number":111,"context_line":"                                :pass password))"},{"line_number":112,"context_line":"           (code-sym (nth-value 1 (ldap:bind conn))))"},{"line_number":113,"context_line":"      (ldap:unbind conn) ;; unbinds \u0026 closes connection"},{"line_number":114,"context_line":"      (when (equalp code-sym \u0027trivial-ldap:success)"},{"line_number":115,"context_line":"        user))))"}],"source_content_type":"text/x-common-lisp","patch_set":2,"id":"2542b4f9_5178bee2","line":113,"in_reply_to":"4e1c29c1_88120da5","updated":"2022-02-07 16:48:09.000000000","message":"I meant errors that happen between creating the conn and unbinding it; I\u0027m reaching for the equivalent of a \"finally\" here","commit_id":"3a226aa2613960b5b083e59864fc7a6254871d00"},{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"b35770d4f9fd465ef90c72067df9c9869d4e567f","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                                :user dn"},{"line_number":111,"context_line":"                                :pass password))"},{"line_number":112,"context_line":"           (code-sym (nth-value 1 (ldap:bind conn))))"},{"line_number":113,"context_line":"      (ldap:unbind conn) ;; unbinds \u0026 closes connection"},{"line_number":114,"context_line":"      (when (equalp code-sym \u0027trivial-ldap:success)"},{"line_number":115,"context_line":"        user))))"}],"source_content_type":"text/x-common-lisp","patch_set":2,"id":"52458192_b9214ef9","line":113,"in_reply_to":"4e78e33f_1c448410","updated":"2022-02-07 17:12:38.000000000","message":"Done","commit_id":"3a226aa2613960b5b083e59864fc7a6254871d00"}]}