)]}'
{"id":"depot~5631","triplet_id":"depot~canon~I3054b0839f46465e8a5ce0da52a87357c7d77128","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2022-05-18 15:27:36.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2022-05-18 15:26:52.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I3054b0839f46465e8a5ce0da52a87357c7d77128","subject":"fix(3p/cgit): Fix bad free in cgit_diff_tree","status":"MERGED","created":"2022-05-18 15:25:05.000000000","updated":"2022-05-18 15:27:36.000000000","submitted":"2022-05-18 15:27:36.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"5631","meta_rev_id":"960a39a6e3dc7de3f9ffa4bc6e68e7c099d4777e","_number":5631,"virtual_id_number":5631,"owner":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-05-18 15:27:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-18 15:27:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-18 15:27:36.000000000","_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-05-18 15:25:06.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-05-18 15:26:04.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2022-05-18 15:26:42.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-05-18 15:27:36.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2d3d7fb49f1434ca2e6fdef22b009278250b0a1e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-05-18 15:25:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0a8c7c66a6ad16ec05f7ffac21efe1ab35560f8d","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-05-18 15:25:06.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/13646","accounts_in_message":[],"_revision_number":1},{"id":"6fe1c771fc79dc4df715b378e70661510877a223","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-05-18 15:26:04.000000000","message":"Patch Set 1: Autosubmit+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a9824348707d455b2fb8495455e8f0481ca80196","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-05-18 15:26:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/13646","accounts_in_message":[],"_revision_number":1},{"id":"f8a9996ec0e451b424dd7685a85f3bee952170c6","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-05-18 15:26:52.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"960a39a6e3dc7de3f9ffa4bc6e68e7c099d4777e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2022-05-18 15:27:36.000000000","message":"Change has been successfully rebased and submitted as e579aa66030bde44f2b0f7d3031c08af0f7d3a3c","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e579aa66030bde44f2b0f7d3031c08af0f7d3a3c","revisions":{"9095cd6c75236957d9c5cf9df3b663ed407e1259":{"kind":"REWORK","_number":1,"created":"2022-05-18 15:25:05.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/31/5631/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/31/5631/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/31/5631/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/31/5631/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/31/5631/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/31/5631/1"}}},"commit":{"parents":[{"commit":"045cf244b51a90bfd7d67ba9d3e60ac950ba5c65","subject":"chore(ops/secrets): add key for tazjin/zamalek","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d045cf244b51a90bfd7d67ba9d3e60ac950ba5c65"}]}],"author":{"name":"June McEnroe","email":"june@causal.agency","date":"2022-05-17 21:50:53.000000000","tz":0},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-05-18 15:23:39.000000000","tz":120},"subject":"fix(3p/cgit): Fix bad free in cgit_diff_tree","message":"fix(3p/cgit): Fix bad free in cgit_diff_tree\n\nSince git commit 244c27242f44e6b88e3a381c90bde08d134c274b,\n\n\u003e diff.[ch]: have diff_free() call clear_pathspec(opts.pathspec)\n\ncalling diff_flush calls free(3) on opts.pathspec.items, so it can\u0027t\nbe a pointer to a stack variable.\n\n(cherry-picked from commit\nhttps://git.causal.agency/cgit-pink/commit/?id\u003dcc167887f1ee6907103533187ff9679f01006a1f)\n\nChange-Id: I3054b0839f46465e8a5ce0da52a87357c7d77128\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9095cd6c75236957d9c5cf9df3b663ed407e1259"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9095cd6c75236957d9c5cf9df3b663ed407e1259"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"045cf244b51a90bfd7d67ba9d3e60ac950ba5c65","is_merged_in_target_branch":true,"change_id":"Ieb2fe49a67940d7cfbd261edbe10d0a8577a466d","change_number":5628,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"e579aa66030bde44f2b0f7d3031c08af0f7d3a3c":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-05-18 15:27:36.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/31/5631/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/31/5631/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/31/5631/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/31/5631/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/31/5631/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/31/5631/2"}}},"commit":{"parents":[{"commit":"045cf244b51a90bfd7d67ba9d3e60ac950ba5c65","subject":"chore(ops/secrets): add key for tazjin/zamalek","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d045cf244b51a90bfd7d67ba9d3e60ac950ba5c65"}]}],"author":{"name":"June McEnroe","email":"june@causal.agency","date":"2022-05-17 21:50:53.000000000","tz":0},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2022-05-18 15:27:36.000000000","tz":0},"subject":"fix(3p/cgit): Fix bad free in cgit_diff_tree","message":"fix(3p/cgit): Fix bad free in cgit_diff_tree\n\nSince git commit 244c27242f44e6b88e3a381c90bde08d134c274b,\n\n\u003e diff.[ch]: have diff_free() call clear_pathspec(opts.pathspec)\n\ncalling diff_flush calls free(3) on opts.pathspec.items, so it can\u0027t\nbe a pointer to a stack variable.\n\n(cherry-picked from commit\nhttps://git.causal.agency/cgit-pink/commit/?id\u003dcc167887f1ee6907103533187ff9679f01006a1f)\n\nChange-Id: I3054b0839f46465e8a5ce0da52a87357c7d77128\nReviewed-on: https://cl.tvl.fyi/c/depot/+/5631\nAutosubmit: sterni \u003csternenseemann@systemli.org\u003e\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de579aa66030bde44f2b0f7d3031c08af0f7d3a3c"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de579aa66030bde44f2b0f7d3031c08af0f7d3a3c"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"045cf244b51a90bfd7d67ba9d3e60ac950ba5c65","is_merged_in_target_branch":true,"change_id":"Ieb2fe49a67940d7cfbd261edbe10d0a8577a466d","change_number":5628,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Code-Review-from-owners","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review-from-owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review-from-owners\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review-from-owners\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}