)]}'
{"id":"depot~5761","triplet_id":"depot~canon~Id847c794bb279be909c5426953c4fe13c2493343","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2022-05-28 11:35:42.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2022-05-28 11:32:53.000000000","reason":"removed on reply"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2022-05-28 11:35:42.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Id847c794bb279be909c5426953c4fe13c2493343","subject":"fix(nix/utils): remove predicates based on symlink heuristic","status":"MERGED","created":"2022-05-28 11:31:55.000000000","updated":"2022-05-28 11:35:42.000000000","submitted":"2022-05-28 11:35:42.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"5761","meta_rev_id":"41ec6bddcf62f111517082d8315c189c53c332c5","_number":5761,"virtual_id_number":5761,"owner":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-05-28 11:35:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-28 11:35:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-28 11:35:42.000000000","_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-05-28 11:31:56.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-05-28 11:32:08.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2022-05-28 11:32:08.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2022-05-28 11:33:09.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-05-28 11:35:42.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cc6dce7e0d53bf7c075493c16413785197757f3e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-05-28 11:31:55.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"d64db4721d5418dd4a0c4ffb7fea4b85480e02a7","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-05-28 11:31:56.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/13923","accounts_in_message":[],"_revision_number":1},{"id":"6bd4735b2b2abd55c6dc9a78e2c3ab27d3307e19","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-05-28 11:32:53.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5081fe28d2dc69bcdedd58dba7402cea6fedf152","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-05-28 11:33:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/13923","accounts_in_message":[],"_revision_number":1},{"id":"faf9c157ec2fb28c625cd4344c74953df7babc02","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2022-05-28 11:33:42.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"68032c3975ef4333bf66027f85da577244363178","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-05-28 11:33:54.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/13924","accounts_in_message":[],"_revision_number":2},{"id":"7e2e13359513cca48d7c1f3ee34acb8c2ab1d8cd","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-05-28 11:35:30.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/13924","accounts_in_message":[],"_revision_number":2},{"id":"41ec6bddcf62f111517082d8315c189c53c332c5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2022-05-28 11:35:42.000000000","message":"Change has been successfully rebased and submitted as a6367b4bdcd126354d29eedee29f5de6c9703524\n\n1 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"a6367b4bdcd126354d29eedee29f5de6c9703524","revisions":{"73d8e6a1c7c15f3507bfbd2e23c1d3af67f4b851":{"kind":"REWORK","_number":1,"created":"2022-05-28 11:31:55.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/61/5761/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/61/5761/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/61/5761/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/61/5761/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/61/5761/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/61/5761/1"}}},"commit":{"parents":[{"commit":"deb8796cc5237ef856463c0b6d02212c6ca5249e","subject":"feat(wpcarro/tarasco): firewall.checkReversePath \u003d loose","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddeb8796cc5237ef856463c0b6d02212c6ca5249e"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-05-28 11:28:37.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-05-28 11:31:41.000000000","tz":120},"subject":"fix(nix/utils): remove predicates based on symlink heuristic","message":"fix(nix/utils): remove predicates based on symlink heuristic\n\nDue to [nix#6579] the heuristic which allowed us to determine if a\nsymlink points to a directory is not reliable – if restrict-eval is\nenabled it _will_ return wrong results. Until upstream resolves\nthis (and we backport the patch) it is probably best to not expose this\nfunctionality at all.\n\n[nix#6579]: https://github.com/NixOS/nix/issues/6579\n\nChange-Id: Id847c794bb279be909c5426953c4fe13c2493343\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d73d8e6a1c7c15f3507bfbd2e23c1d3af67f4b851"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d73d8e6a1c7c15f3507bfbd2e23c1d3af67f4b851"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"deb8796cc5237ef856463c0b6d02212c6ca5249e","is_merged_in_target_branch":true,"change_id":"Ia44100f5a3cd12fbf9fd10dbf40bef10805aff12","change_number":5749,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"55d6603c324096c22dabddce632e712f7efe9660":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-05-28 11:33:42.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/61/5761/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/61/5761/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/61/5761/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/61/5761/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/61/5761/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/61/5761/2"}}},"commit":{"parents":[{"commit":"c06d47b7878aa4d90c51294fb76a66184870e12b","subject":"chore(ops/sourcegraph): Bump to 3.34.2","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc06d47b7878aa4d90c51294fb76a66184870e12b"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-05-28 11:28:37.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2022-05-28 11:33:42.000000000","tz":0},"subject":"fix(nix/utils): remove predicates based on symlink heuristic","message":"fix(nix/utils): remove predicates based on symlink heuristic\n\nDue to [nix#6579] the heuristic which allowed us to determine if a\nsymlink points to a directory is not reliable – if restrict-eval is\nenabled it _will_ return wrong results. Until upstream resolves\nthis (and we backport the patch) it is probably best to not expose this\nfunctionality at all.\n\n[nix#6579]: https://github.com/NixOS/nix/issues/6579\n\nChange-Id: Id847c794bb279be909c5426953c4fe13c2493343\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d55d6603c324096c22dabddce632e712f7efe9660"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d55d6603c324096c22dabddce632e712f7efe9660"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c06d47b7878aa4d90c51294fb76a66184870e12b","is_merged_in_target_branch":true,"change_id":"I865335006a091986f8a98e4d5da7161a25e948d9","change_number":5754,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"},"a6367b4bdcd126354d29eedee29f5de6c9703524":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2022-05-28 11:35:42.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/61/5761/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/61/5761/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/61/5761/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/61/5761/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/61/5761/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/61/5761/3"}}},"commit":{"parents":[{"commit":"c06d47b7878aa4d90c51294fb76a66184870e12b","subject":"chore(ops/sourcegraph): Bump to 3.34.2","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc06d47b7878aa4d90c51294fb76a66184870e12b"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-05-28 11:28:37.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2022-05-28 11:35:42.000000000","tz":0},"subject":"fix(nix/utils): remove predicates based on symlink heuristic","message":"fix(nix/utils): remove predicates based on symlink heuristic\n\nDue to [nix#6579] the heuristic which allowed us to determine if a\nsymlink points to a directory is not reliable – if restrict-eval is\nenabled it _will_ return wrong results. Until upstream resolves\nthis (and we backport the patch) it is probably best to not expose this\nfunctionality at all.\n\n[nix#6579]: https://github.com/NixOS/nix/issues/6579\n\nChange-Id: Id847c794bb279be909c5426953c4fe13c2493343\nReviewed-on: https://cl.tvl.fyi/c/depot/+/5761\nTested-by: BuildkiteCI\nAutosubmit: sterni \u003csternenseemann@systemli.org\u003e\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da6367b4bdcd126354d29eedee29f5de6c9703524"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da6367b4bdcd126354d29eedee29f5de6c9703524"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c06d47b7878aa4d90c51294fb76a66184870e12b","is_merged_in_target_branch":true,"change_id":"I865335006a091986f8a98e4d5da7161a25e948d9","change_number":5754,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Code-Review-from-owners","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review-from-owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review-from-owners\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review-from-owners\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}