)]}'
{"id":"depot~5786","triplet_id":"depot~refs%2Fmeta%2Fconfig~I6bdcd9be19afc1aece5f3eb98b88156477f1f17b","project":"depot","branch":"refs/meta/config","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2022-05-29 11:01:44.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2022-05-29 11:08:57.000000000","reason":"Change was submitted"},"1000004":{"account":{"_account_id":1000004,"name":"isomer","email":"isomer@tvl.fyi","username":"isomer"},"last_update":"2022-05-29 11:08:57.000000000","reason":"Change was submitted"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2022-05-29 11:08:57.000000000","reason":"Change was submitted"},"1000046":{"account":{"_account_id":1000046,"name":"fogti","email":"fogti+devel@ytrizja.de","username":"fogti"},"last_update":"2022-05-29 11:08:57.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6bdcd9be19afc1aece5f3eb98b88156477f1f17b","subject":"feat(rules.pl): Only allow autosubmit for owner or clbot","status":"MERGED","created":"2022-05-29 00:29:07.000000000","updated":"2022-05-29 11:08:57.000000000","submitted":"2022-05-29 11:08:57.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"5786","meta_rev_id":"125d641afae21b7eb314a9fc701e2a830861b2da","_number":5786,"virtual_id_number":5786,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-05-29 11:08:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0,"optional":true},"Autosubmit":{"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}]}},"removable_reviewers":[{"_account_id":1000004,"name":"isomer","email":"isomer@tvl.fyi","username":"isomer"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000046,"name":"fogti","email":"fogti+devel@ytrizja.de","username":"fogti"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000004,"name":"isomer","email":"isomer@tvl.fyi","username":"isomer"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000046,"name":"fogti","email":"fogti+devel@ytrizja.de","username":"fogti"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-05-29 00:29:35.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000004,"name":"isomer","email":"isomer@tvl.fyi","username":"isomer"},"state":"REVIEWER"},{"updated":"2022-05-29 00:29:35.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000046,"name":"fogti","email":"fogti+devel@ytrizja.de","username":"fogti"},"state":"REVIEWER"},{"updated":"2022-05-29 00:29:35.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2022-05-29 00:29:35.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"state":"REVIEWER"}],"messages":[{"id":"8be7a3137244bcbf0aa83c064a36ab33e7efb62a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-05-29 00:29:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5449a39623feb7d5914297ab7614564af31d99a0","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-05-29 11:01:44.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"125d641afae21b7eb314a9fc701e2a830861b2da","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-05-29 11:08:57.000000000","message":"Change has been successfully rebased and submitted as 42565f4a11ef232d7c2462b8a42e9b0453f62b04","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"42565f4a11ef232d7c2462b8a42e9b0453f62b04","revisions":{"7dec049ce1b6f99dad2f806c8fbab0d34c7d6e7d":{"kind":"REWORK","_number":1,"created":"2022-05-29 00:29:07.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/86/5786/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/86/5786/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/86/5786/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/86/5786/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/86/5786/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/86/5786/1"}}},"commit":{"parents":[{"commit":"cf24ba0b0c374b401be7104e43fc313d3d005ded","subject":"feat(rules.pl): Allow changes to refs/meta/config without CI","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcf24ba0b0c374b401be7104e43fc313d3d005ded"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-05-29 00:25:36.000000000","tz":120},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-05-29 00:25:36.000000000","tz":120},"subject":"feat(rules.pl): Only allow autosubmit for owner or clbot","message":"feat(rules.pl): Only allow autosubmit for owner or clbot\n\nThe autosubmit label can currently lead to submission of changes that\nwere uploaded by someone other than clbot or the owner of the change,\nsee b/167.\n\nThis could lead to situations where a malicious user could inject code\ninto a CL that is in the process of being autosubmitted.\n\nWith this change, the Autosubmit label is only allowed after checking\nthe uploader of the patchset.\n\nThis was tested through the submit rule testing SSH interface, however\nwe can\u0027t test whether this actually has the desired effect that way.\nIt\u0027s possible that the `may(_)` option only affects the UI state, for\nexample, but not the actual label on the change (if present).\n\nWe will only find out by merging it ...\n\nIt should also be noted that the implementation is a bit ugly because\nGerrit\u0027s Prolog does not have an append/3 function and I had to pick\nbetween reimplementing that or letting the new predicate do the\nappending.\n\nChange-Id: I6bdcd9be19afc1aece5f3eb98b88156477f1f17b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7dec049ce1b6f99dad2f806c8fbab0d34c7d6e7d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7dec049ce1b6f99dad2f806c8fbab0d34c7d6e7d"}]},"parents_data":[{"branch_name":"refs/meta/config","commit_id":"cf24ba0b0c374b401be7104e43fc313d3d005ded","is_merged_in_target_branch":true,"change_id":"Id3c7416478d985e99533dbafbd430f4ae008a837","change_number":5235,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/meta/config"},"42565f4a11ef232d7c2462b8a42e9b0453f62b04":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-05-29 11:08:57.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/86/5786/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/86/5786/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/86/5786/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/86/5786/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/86/5786/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/86/5786/2"}}},"commit":{"parents":[{"commit":"cf24ba0b0c374b401be7104e43fc313d3d005ded","subject":"feat(rules.pl): Allow changes to refs/meta/config without CI","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcf24ba0b0c374b401be7104e43fc313d3d005ded"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-05-29 00:25:36.000000000","tz":120},"committer":{"name":"tazjin","email":"tazjin@tvl.su","date":"2022-05-29 11:08:57.000000000","tz":0},"subject":"feat(rules.pl): Only allow autosubmit for owner or clbot","message":"feat(rules.pl): Only allow autosubmit for owner or clbot\n\nThe autosubmit label can currently lead to submission of changes that\nwere uploaded by someone other than clbot or the owner of the change,\nsee b/167.\n\nThis could lead to situations where a malicious user could inject code\ninto a CL that is in the process of being autosubmitted.\n\nWith this change, the Autosubmit label is only allowed after checking\nthe uploader of the patchset.\n\nThis was tested through the submit rule testing SSH interface, however\nwe can\u0027t test whether this actually has the desired effect that way.\nIt\u0027s possible that the `may(_)` option only affects the UI state, for\nexample, but not the actual label on the change (if present).\n\nWe will only find out by merging it ...\n\nIt should also be noted that the implementation is a bit ugly because\nGerrit\u0027s Prolog does not have an append/3 function and I had to pick\nbetween reimplementing that or letting the new predicate do the\nappending.\n\nChange-Id: I6bdcd9be19afc1aece5f3eb98b88156477f1f17b\nReviewed-on: https://cl.tvl.fyi/c/depot/+/5786\nReviewed-by: sterni \u003csternenseemann@systemli.org\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d42565f4a11ef232d7c2462b8a42e9b0453f62b04"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d42565f4a11ef232d7c2462b8a42e9b0453f62b04"}]},"parents_data":[{"branch_name":"refs/meta/config","commit_id":"cf24ba0b0c374b401be7104e43fc313d3d005ded","is_merged_in_target_branch":true,"change_id":"Id3c7416478d985e99533dbafbd430f4ae008a837","change_number":5235,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/meta/config"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Code-Review-from-owners","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"MAY"},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}}]}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review-from-owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review-from-owners\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review-from-owners\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}