)]}'
{"id":"depot~6421","triplet_id":"depot~canon~I679f93a59a4daeacfe40f4012263cfb7bc05034e","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2022-09-08 09:36:52.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2022-09-08 13:36:14.000000000","reason":"tazjin replied on the change"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2022-09-08 13:36:26.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"eta","email":"tvl@eta.st","username":"eta"},"last_update":"2022-09-08 13:36:26.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I679f93a59a4daeacfe40f4012263cfb7bc05034e","subject":"refactor(tvix/eval): refactor locals to use an enum for phantoms","status":"MERGED","created":"2022-09-07 21:10:29.000000000","updated":"2022-09-08 13:36:26.000000000","submitted":"2022-09-08 13:36:26.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6422","meta_rev_id":"577949ef6f2ed03c0cb000bb530cb58f0e1a2d27","_number":6421,"virtual_id_number":6421,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-08 13:36:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-08 13:36:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000008,"name":"eta","email":"tvl@eta.st","username":"eta"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000008,"name":"eta","email":"tvl@eta.st","username":"eta"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-07 21:10:29.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000008,"name":"eta","email":"tvl@eta.st","username":"eta"},"state":"REVIEWER"},{"updated":"2022-09-07 21:10:29.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"state":"REVIEWER"},{"updated":"2022-09-07 21:10:29.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2022-09-07 21:10:31.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-09-07 21:13:40.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4bc2bb825b93c128d7fc43016a18f6651e01dd73","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-07 21:10:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d119093f759ec7f0b8dfd50de12a7f658216f3d6","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-07 21:10:31.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/15750","accounts_in_message":[],"_revision_number":1},{"id":"1c562fd308708545b3b8d506c457845be4955c0d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-07 21:13:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/15750","accounts_in_message":[],"_revision_number":1},{"id":"eaece061443ea559abc997549d827761a9119991","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-08 08:26:41.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"f6b1889184390c21fe25271822392429f4caed46","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-08 08:45:40.000000000","message":"Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2.","accounts_in_message":[],"_revision_number":3},{"id":"ca4e72d16eb2032eec6cc99f5818de75ec09050f","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-09-08 09:36:52.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"1d2c0033b6cfc6c7fdca40341589119700074a95","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-08 12:59:06.000000000","message":"Uploaded patch set 4: New patch set was added with same tree, parent, and commit message as Patch Set 3.","accounts_in_message":[],"_revision_number":4},{"id":"3f8856cffcb2c9f08bb7686e274be9c7b8bf7e94","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-08 13:36:14.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"577949ef6f2ed03c0cb000bb530cb58f0e1a2d27","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-08 13:36:26.000000000","message":"Change has been successfully rebased and submitted as 9973ddfcba57e1a2d1a72351814210ab652bd860\n\n3 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"9973ddfcba57e1a2d1a72351814210ab652bd860","revisions":{"e447610e70ee7376e4014ce2bd63f9eceddb9442":{"kind":"REWORK","_number":1,"created":"2022-09-07 21:10:29.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/21/6421/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/21/6421/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/21/6421/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/21/6421/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/21/6421/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/21/6421/1"}}},"commit":{"parents":[{"commit":"b872e8912fb1f5fa30d9f77e4cafac96705800c1","subject":"refactor(tvix/eval): always pass slot to compiler methods","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db872e8912fb1f5fa30d9f77e4cafac96705800c1"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-02 21:26:32.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-07 21:09:06.000000000","tz":180},"subject":"refactor(tvix/eval): refactor locals to use an enum for phantoms","message":"refactor(tvix/eval): refactor locals to use an enum for phantoms\n\nInstead of using sentinel values and an additional bool, this tracks\nthe identifier of a local as an enum that is either a statically known\nname, or a phantom.\n\nTo make this work correctly some more locals related logic has been\nencapsulated in the `scope` module, which is a good thing (that\u0027s the\ngoal).\n\nPhantom values are now not initialised by default, but the only\ncurrent call site of phantoms (`with` expression compilation) performs\nthe initialisation right away.\n\nThis commit changes no actual functionality right now, but paves the\nway for fixing an issue related to `let` bodies.\n\nChange-Id: I679f93a59a4daeacfe40f4012263cfb7bc05034e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de447610e70ee7376e4014ce2bd63f9eceddb9442"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de447610e70ee7376e4014ce2bd63f9eceddb9442"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b872e8912fb1f5fa30d9f77e4cafac96705800c1","is_merged_in_target_branch":false,"change_id":"I46bf67a4cf5cb96e4874dffd0e3fb07c551d44f0","change_number":6420,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"d9d4949b3d8fa70a57dd7e94f7a0c4cf1ad27955":{"kind":"NO_CHANGE","_number":2,"created":"2022-09-08 08:26:41.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/21/6421/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/21/6421/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/21/6421/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/21/6421/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/21/6421/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/21/6421/2"}}},"commit":{"parents":[{"commit":"03b80ac899246b9ec694d39ed8777262199f431a","subject":"refactor(tvix/eval): always pass slot to compiler methods","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d03b80ac899246b9ec694d39ed8777262199f431a"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-02 21:26:32.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-08 07:59:26.000000000","tz":180},"subject":"refactor(tvix/eval): refactor locals to use an enum for phantoms","message":"refactor(tvix/eval): refactor locals to use an enum for phantoms\n\nInstead of using sentinel values and an additional bool, this tracks\nthe identifier of a local as an enum that is either a statically known\nname, or a phantom.\n\nTo make this work correctly some more locals related logic has been\nencapsulated in the `scope` module, which is a good thing (that\u0027s the\ngoal).\n\nPhantom values are now not initialised by default, but the only\ncurrent call site of phantoms (`with` expression compilation) performs\nthe initialisation right away.\n\nThis commit changes no actual functionality right now, but paves the\nway for fixing an issue related to `let` bodies.\n\nChange-Id: I679f93a59a4daeacfe40f4012263cfb7bc05034e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd9d4949b3d8fa70a57dd7e94f7a0c4cf1ad27955"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd9d4949b3d8fa70a57dd7e94f7a0c4cf1ad27955"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"03b80ac899246b9ec694d39ed8777262199f431a","is_merged_in_target_branch":false,"change_id":"I46bf67a4cf5cb96e4874dffd0e3fb07c551d44f0","change_number":6420,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"25c0bd262898731c4cf75def63ed9a9929d647a0":{"kind":"NO_CHANGE","_number":3,"created":"2022-09-08 08:45:40.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/21/6421/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/21/6421/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/21/6421/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/21/6421/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/21/6421/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/21/6421/3"}}},"commit":{"parents":[{"commit":"e72be8c72440bf2cf639d1603f85d9d82db1366d","subject":"refactor(tvix/eval): always pass slot to compiler methods","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de72be8c72440bf2cf639d1603f85d9d82db1366d"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-02 21:26:32.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-08 08:45:22.000000000","tz":180},"subject":"refactor(tvix/eval): refactor locals to use an enum for phantoms","message":"refactor(tvix/eval): refactor locals to use an enum for phantoms\n\nInstead of using sentinel values and an additional bool, this tracks\nthe identifier of a local as an enum that is either a statically known\nname, or a phantom.\n\nTo make this work correctly some more locals related logic has been\nencapsulated in the `scope` module, which is a good thing (that\u0027s the\ngoal).\n\nPhantom values are now not initialised by default, but the only\ncurrent call site of phantoms (`with` expression compilation) performs\nthe initialisation right away.\n\nThis commit changes no actual functionality right now, but paves the\nway for fixing an issue related to `let` bodies.\n\nChange-Id: I679f93a59a4daeacfe40f4012263cfb7bc05034e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d25c0bd262898731c4cf75def63ed9a9929d647a0"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d25c0bd262898731c4cf75def63ed9a9929d647a0"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e72be8c72440bf2cf639d1603f85d9d82db1366d","is_merged_in_target_branch":false,"change_id":"I46bf67a4cf5cb96e4874dffd0e3fb07c551d44f0","change_number":6420,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"6aaa9b67b3c9a87e3dd870903f2c5831a7e3470b":{"kind":"NO_CHANGE","_number":4,"created":"2022-09-08 12:59:06.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/21/6421/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/21/6421/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/21/6421/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/21/6421/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/21/6421/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/21/6421/4"}}},"commit":{"parents":[{"commit":"a7c4230ca96ba7d85732a1068e1f504e48c0c3fc","subject":"refactor(tvix/eval): always pass slot to compiler methods","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da7c4230ca96ba7d85732a1068e1f504e48c0c3fc"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-02 21:26:32.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-08 12:58:15.000000000","tz":180},"subject":"refactor(tvix/eval): refactor locals to use an enum for phantoms","message":"refactor(tvix/eval): refactor locals to use an enum for phantoms\n\nInstead of using sentinel values and an additional bool, this tracks\nthe identifier of a local as an enum that is either a statically known\nname, or a phantom.\n\nTo make this work correctly some more locals related logic has been\nencapsulated in the `scope` module, which is a good thing (that\u0027s the\ngoal).\n\nPhantom values are now not initialised by default, but the only\ncurrent call site of phantoms (`with` expression compilation) performs\nthe initialisation right away.\n\nThis commit changes no actual functionality right now, but paves the\nway for fixing an issue related to `let` bodies.\n\nChange-Id: I679f93a59a4daeacfe40f4012263cfb7bc05034e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6aaa9b67b3c9a87e3dd870903f2c5831a7e3470b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6aaa9b67b3c9a87e3dd870903f2c5831a7e3470b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a7c4230ca96ba7d85732a1068e1f504e48c0c3fc","is_merged_in_target_branch":false,"change_id":"I46bf67a4cf5cb96e4874dffd0e3fb07c551d44f0","change_number":6420,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"9973ddfcba57e1a2d1a72351814210ab652bd860":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2022-09-08 13:36:26.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/21/6421/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/21/6421/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/21/6421/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/21/6421/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/21/6421/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/21/6421/5"}}},"commit":{"parents":[{"commit":"7bc6e5984dfd1f8717e28bbbcb97e078b6039558","subject":"refactor(tvix/eval): always pass slot to compiler methods","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7bc6e5984dfd1f8717e28bbbcb97e078b6039558"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-02 21:26:32.000000000","tz":180},"committer":{"name":"tazjin","email":"tazjin@tvl.su","date":"2022-09-08 13:36:26.000000000","tz":0},"subject":"refactor(tvix/eval): refactor locals to use an enum for phantoms","message":"refactor(tvix/eval): refactor locals to use an enum for phantoms\n\nInstead of using sentinel values and an additional bool, this tracks\nthe identifier of a local as an enum that is either a statically known\nname, or a phantom.\n\nTo make this work correctly some more locals related logic has been\nencapsulated in the `scope` module, which is a good thing (that\u0027s the\ngoal).\n\nPhantom values are now not initialised by default, but the only\ncurrent call site of phantoms (`with` expression compilation) performs\nthe initialisation right away.\n\nThis commit changes no actual functionality right now, but paves the\nway for fixing an issue related to `let` bodies.\n\nChange-Id: I679f93a59a4daeacfe40f4012263cfb7bc05034e\nReviewed-on: https://cl.tvl.fyi/c/depot/+/6421\nReviewed-by: sterni \u003csternenseemann@systemli.org\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9973ddfcba57e1a2d1a72351814210ab652bd860"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9973ddfcba57e1a2d1a72351814210ab652bd860"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"7bc6e5984dfd1f8717e28bbbcb97e078b6039558","is_merged_in_target_branch":true,"change_id":"I46bf67a4cf5cb96e4874dffd0e3fb07c551d44f0","change_number":6420,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Code-Review-from-owners","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review-from-owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review-from-owners\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review-from-owners\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}