)]}'
{"id":"depot~6719","triplet_id":"depot~canon~I46642e6da5eac7c0883cdce860622cdba04cd12b","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2022-09-21 14:23:46.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2022-09-21 14:11:07.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2022-09-21 14:23:46.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I46642e6da5eac7c0883cdce860622cdba04cd12b","subject":"fix(tvix/eval): implement C++ Nix version part comparison algorithm","status":"MERGED","created":"2022-09-21 11:58:33.000000000","updated":"2022-09-21 14:23:46.000000000","submitted":"2022-09-21 14:23:46.000000000","submitter":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6722","meta_rev_id":"f5ff5320dfae3cca88e69d70ff668f42a55cd1c3","_number":6719,"virtual_id_number":6719,"owner":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-21 14:23:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-21 14:23:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"reviewers":{"CC":[{"_account_id":1000065,"name":"Thomas Frank","email":"thomas@franks-im-web.de","username":"thofrank"}],"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-21 11:58:38.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-09-21 11:59:00.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000065,"name":"Thomas Frank","email":"thomas@franks-im-web.de","username":"thofrank"},"state":"CC"},{"updated":"2022-09-21 11:59:00.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2022-09-21 11:59:00.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2022-09-21 12:00:53.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e0c014e4fa85a60e3f9603cbd012ff0ae8b7f998","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-09-21 11:58:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"eac4ae611ca55c948eb2d6a0b7f447bea7dc9920","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-21 11:58:38.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/16652","accounts_in_message":[],"_revision_number":1},{"id":"e9b88a4c5a67fc0fcabc49b3c7e62ab5e9abf793","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-09-21 11:59:00.000000000","message":"\u003cGERRIT_ACCOUNT_1000010\u003e, who was added as reviewer owns the following files:\n* tvix/eval/src/builtins/versions.rs\n\n\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* tvix/eval/src/builtins/versions.rs\n","accounts_in_message":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":1},{"id":"6fd005d2d696cb6e1c3ad17d56b76bd836f75c27","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-21 12:00:53.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/16652","accounts_in_message":[],"_revision_number":1},{"id":"4ee509f24d9bd9c889e8e7ad1bd4d7d845cc685a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-09-21 12:04:48.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8eab3d1b4cda1180f742ac7f521a62bac833d230","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-21 12:04:49.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/16655","accounts_in_message":[],"_revision_number":2},{"id":"9e89ed80eb2c23fe7aa040b16fd8bd5edd0b7774","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-21 12:06:43.000000000","message":"Patch Set 2: Verified-1\n\nBuild of patchset 2 failed: https://buildkite.com/tvl/depot/builds/16655","accounts_in_message":[],"_revision_number":2},{"id":"929f222ed966acf903229d16eae7ee42d91d1de2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-09-21 12:13:37.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"22b13b1a72e9196fc30e2f3f190ae6dbae0c4a8c","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-21 12:13:38.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/16657","accounts_in_message":[],"_revision_number":3},{"id":"d9597bee815fec6ba09d1fc7bedff2230281a734","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-21 12:15:31.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/16657","accounts_in_message":[],"_revision_number":3},{"id":"78864be67c11991cea458e5959f1ce8c8cd43900","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-09-21 13:08:29.000000000","message":"Uploaded patch set 4: New patch set was added with same tree, parent tree, and commit message as Patch Set 3.","accounts_in_message":[],"_revision_number":4},{"id":"7d87d270ce714d064c63c55391827c23a724d69b","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-21 14:11:07.000000000","message":"Patch Set 4: Code-Review+2\n\n(1 comment)\n\nBy voting Code-Review+2 the following files are now code-owner approved by \u003cGERRIT_ACCOUNT_1000001\u003e:\n* tvix/eval/src/builtins/versions.rs\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":4},{"id":"f5ff5320dfae3cca88e69d70ff668f42a55cd1c3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-09-21 14:23:46.000000000","message":"Change has been successfully rebased and submitted as 9a8a6a33f9265a3844e91f2c1aab0b28ac46decf","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"9a8a6a33f9265a3844e91f2c1aab0b28ac46decf","revisions":{"b1754c3a4e5c4c34bd007b7eb9993fc9a5171da1":{"kind":"REWORK","_number":1,"created":"2022-09-21 11:58:33.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/19/6719/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/19/6719/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/19/6719/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/19/6719/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/19/6719/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/19/6719/1"}}},"commit":{"parents":[{"commit":"331212fe0a4cf8c4085218a3a1ab91d830e1641c","subject":"test(tvix/eval): add test cases for builtins.splitVersion","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d331212fe0a4cf8c4085218a3a1ab91d830e1641c"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-09-21 11:44:12.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-09-21 11:58:30.000000000","tz":120},"subject":"fix(tvix/eval): implement C++ Nix version part comparison algorithm","message":"fix(tvix/eval): implement C++ Nix version part comparison algorithm\n\nThis is based on the [relevant code] in C++ Nix. Our version has more\nbranches because the C++ one only checks if it is less than or not, so\ncan save handling a few cases. We on the other hand, can avoid calling\nthe algorithm twice. It\u0027d be nice to implement proptests for this in the\nfuture and to make sure that this weird little algorithm doesn\u0027t violate\nthe Ord laws.\n\n[relevant code]: https://github.com/NixOS/nix/blob/cd35bbbeef72375873e396b9ffed14a4638693a8/src/libstore/names.cc#L81-L94\n\nChange-Id: I46642e6da5eac7c0883cdce860622cdba04cd12b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db1754c3a4e5c4c34bd007b7eb9993fc9a5171da1"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db1754c3a4e5c4c34bd007b7eb9993fc9a5171da1"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"331212fe0a4cf8c4085218a3a1ab91d830e1641c","is_merged_in_target_branch":false,"change_id":"I60648f6c5cea34d19afb5ced3e98051201190a78","change_number":6711,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"dff2a6f019a03ccdacaa565933b1eacc97dc6295":{"kind":"REWORK","_number":2,"created":"2022-09-21 12:04:48.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/19/6719/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/19/6719/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/19/6719/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/19/6719/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/19/6719/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/19/6719/2"}}},"commit":{"parents":[{"commit":"331212fe0a4cf8c4085218a3a1ab91d830e1641c","subject":"test(tvix/eval): add test cases for builtins.splitVersion","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d331212fe0a4cf8c4085218a3a1ab91d830e1641c"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-09-21 11:44:12.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-09-21 12:03:55.000000000","tz":120},"subject":"fix(tvix/eval): implement C++ Nix version part comparison algorithm","message":"fix(tvix/eval): implement C++ Nix version part comparison algorithm\n\nThis is based on the [relevant code] in C++ Nix. Our version has more\nbranches because the C++ one only checks if it is less than or not, so\ncan save handling a few cases. We on the other hand, can avoid calling\nthe algorithm twice. It\u0027d be nice to implement proptests for this in the\nfuture and to make sure that this weird little algorithm doesn\u0027t violate\nthe Ord laws.\n\n[relevant code]: https://github.com/NixOS/nix/blob/cd35bbbeef72375873e396b9ffed14a4638693a8/src/libstore/names.cc#L81-L94\n\nChange-Id: I46642e6da5eac7c0883cdce860622cdba04cd12b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddff2a6f019a03ccdacaa565933b1eacc97dc6295"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddff2a6f019a03ccdacaa565933b1eacc97dc6295"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"331212fe0a4cf8c4085218a3a1ab91d830e1641c","is_merged_in_target_branch":false,"change_id":"I60648f6c5cea34d19afb5ced3e98051201190a78","change_number":6711,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"07689535a4ff6132c5280538095d782ffb539dd5":{"kind":"REWORK","_number":3,"created":"2022-09-21 12:13:37.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/19/6719/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/19/6719/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/19/6719/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/19/6719/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/19/6719/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/19/6719/3"}}},"commit":{"parents":[{"commit":"331212fe0a4cf8c4085218a3a1ab91d830e1641c","subject":"test(tvix/eval): add test cases for builtins.splitVersion","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d331212fe0a4cf8c4085218a3a1ab91d830e1641c"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-09-21 11:44:12.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-09-21 12:13:02.000000000","tz":120},"subject":"fix(tvix/eval): implement C++ Nix version part comparison algorithm","message":"fix(tvix/eval): implement C++ Nix version part comparison algorithm\n\nThis is based on the [relevant code] in C++ Nix. Our version has more\nbranches because the C++ one only checks if it is less than or not, so\ncan save handling a few cases. We on the other hand, can avoid calling\nthe algorithm twice. It\u0027d be nice to implement proptests for this in the\nfuture and to make sure that this weird little algorithm doesn\u0027t violate\nthe Ord laws.\n\n[relevant code]: https://github.com/NixOS/nix/blob/cd35bbbeef72375873e396b9ffed14a4638693a8/src/libstore/names.cc#L81-L94\n\nChange-Id: I46642e6da5eac7c0883cdce860622cdba04cd12b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d07689535a4ff6132c5280538095d782ffb539dd5"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d07689535a4ff6132c5280538095d782ffb539dd5"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"331212fe0a4cf8c4085218a3a1ab91d830e1641c","is_merged_in_target_branch":false,"change_id":"I60648f6c5cea34d19afb5ced3e98051201190a78","change_number":6711,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"3477e98895ed03611bed4f6226ac405aec25390a":{"kind":"NO_CHANGE","_number":4,"created":"2022-09-21 13:08:29.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/19/6719/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/19/6719/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/19/6719/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/19/6719/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/19/6719/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/19/6719/4"}}},"commit":{"parents":[{"commit":"e9e06b8bae9b4f55ace0e8e6b6ae5e77de4c8e71","subject":"test(tvix/eval): add test cases for builtins.splitVersion","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de9e06b8bae9b4f55ace0e8e6b6ae5e77de4c8e71"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-09-21 11:44:12.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-09-21 13:08:27.000000000","tz":120},"subject":"fix(tvix/eval): implement C++ Nix version part comparison algorithm","message":"fix(tvix/eval): implement C++ Nix version part comparison algorithm\n\nThis is based on the [relevant code] in C++ Nix. Our version has more\nbranches because the C++ one only checks if it is less than or not, so\ncan save handling a few cases. We on the other hand, can avoid calling\nthe algorithm twice. It\u0027d be nice to implement proptests for this in the\nfuture and to make sure that this weird little algorithm doesn\u0027t violate\nthe Ord laws.\n\n[relevant code]: https://github.com/NixOS/nix/blob/cd35bbbeef72375873e396b9ffed14a4638693a8/src/libstore/names.cc#L81-L94\n\nChange-Id: I46642e6da5eac7c0883cdce860622cdba04cd12b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3477e98895ed03611bed4f6226ac405aec25390a"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3477e98895ed03611bed4f6226ac405aec25390a"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e9e06b8bae9b4f55ace0e8e6b6ae5e77de4c8e71","is_merged_in_target_branch":true,"change_id":"I60648f6c5cea34d19afb5ced3e98051201190a78","change_number":6711,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"9a8a6a33f9265a3844e91f2c1aab0b28ac46decf":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2022-09-21 14:23:46.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/19/6719/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/19/6719/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/19/6719/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/19/6719/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/19/6719/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/19/6719/5"}}},"commit":{"parents":[{"commit":"e9e06b8bae9b4f55ace0e8e6b6ae5e77de4c8e71","subject":"test(tvix/eval): add test cases for builtins.splitVersion","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de9e06b8bae9b4f55ace0e8e6b6ae5e77de4c8e71"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-09-21 11:44:12.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-09-21 14:23:46.000000000","tz":0},"subject":"fix(tvix/eval): implement C++ Nix version part comparison algorithm","message":"fix(tvix/eval): implement C++ Nix version part comparison algorithm\n\nThis is based on the [relevant code] in C++ Nix. Our version has more\nbranches because the C++ one only checks if it is less than or not, so\ncan save handling a few cases. We on the other hand, can avoid calling\nthe algorithm twice. It\u0027d be nice to implement proptests for this in the\nfuture and to make sure that this weird little algorithm doesn\u0027t violate\nthe Ord laws.\n\n[relevant code]: https://github.com/NixOS/nix/blob/cd35bbbeef72375873e396b9ffed14a4638693a8/src/libstore/names.cc#L81-L94\n\nChange-Id: I46642e6da5eac7c0883cdce860622cdba04cd12b\nReviewed-on: https://cl.tvl.fyi/c/depot/+/6719\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9a8a6a33f9265a3844e91f2c1aab0b28ac46decf"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9a8a6a33f9265a3844e91f2c1aab0b28ac46decf"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e9e06b8bae9b4f55ace0e8e6b6ae5e77de4c8e71","is_merged_in_target_branch":true,"change_id":"I60648f6c5cea34d19afb5ced3e98051201190a78","change_number":6711,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}