)]}'
{"id":"depot~6747","triplet_id":"depot~canon~I12f1e786c0030c85107b1aa409bd49adb5465546","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2022-09-22 23:06:29.000000000","reason":"\u003cGERRIT_ACCOUNT_1000034\u003e replied on the change","reason_account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2022-09-22 23:07:14.000000000","reason":"Change was submitted"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2022-09-22 23:07:14.000000000","reason":"Change was submitted"},"1000013":{"account":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"last_update":"2022-09-22 23:07:14.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I12f1e786c0030c85107b1aa409bd49adb5465546","subject":"fix(tvix/eval): support string identifiers in inherits","status":"MERGED","created":"2022-09-22 21:44:30.000000000","updated":"2022-09-22 23:07:14.000000000","submitted":"2022-09-22 23:07:14.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6748","meta_rev_id":"5184ce5c96071d357efbc12fca981cd2ff03a884","_number":6747,"virtual_id_number":6747,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-22 23:07:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-22 23:07:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-22 21:44:31.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-09-22 21:47:06.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-09-22 21:52:59.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"state":"REVIEWER"},{"updated":"2022-09-22 21:52:59.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2022-09-22 21:52:59.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"state":"REVIEWER"}],"messages":[{"id":"17191ea7ed00f5535e99d1c1bed118d2431d7440","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-22 21:44:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7e4f88fc68a5edba1b99c9fe69d514b38c03610d","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-22 21:44:31.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/16683","accounts_in_message":[],"_revision_number":1},{"id":"bc2ff077169f13e95c2d43d11cc202db876853ec","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-22 21:47:06.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/16683","accounts_in_message":[],"_revision_number":1},{"id":"69d722d696fa87b2375268a64bdb18e065a0dd8c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-22 21:48:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"560a13c68ead43a4963f2ae492427478b9e4a85a","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-22 21:48:07.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/16684","accounts_in_message":[],"_revision_number":2},{"id":"3abd0aaf98826b67337b999eab655c6f10a0425d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-22 21:51:22.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/16684","accounts_in_message":[],"_revision_number":2},{"id":"8b1fc361a210e08ca93f863a2b8d28663f2cb16d","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-22 21:52:59.000000000","message":"\u003cGERRIT_ACCOUNT_1000034\u003e, who was added as reviewer owns the following files:\n* tvix/eval/Cargo.lock\n* tvix/eval/Cargo.toml\n* tvix/eval/src/compiler/attrs.rs\n* tvix/eval/src/compiler/mod.rs\n* tvix/eval/src/compiler/scope.rs\n* tvix/eval/src/tests/tvix_tests/eval-okay-inherit-string-ident.exp\n* tvix/eval/src/tests/tvix_tests/eval-okay-inherit-string-ident.nix\n\n\u003cGERRIT_ACCOUNT_1000010\u003e, who was added as reviewer owns the following files:\n* tvix/eval/Cargo.lock\n* tvix/eval/Cargo.toml\n* tvix/eval/src/compiler/attrs.rs\n* tvix/eval/src/compiler/mod.rs\n* tvix/eval/src/compiler/scope.rs\n* tvix/eval/src/tests/tvix_tests/eval-okay-inherit-string-ident.exp\n* tvix/eval/src/tests/tvix_tests/eval-okay-inherit-string-ident.nix\n","accounts_in_message":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"_revision_number":2},{"id":"a62d17121a5b8392f69d2ba212c9b583288143b3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-22 22:18:43.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"59ed61c440d9aca2aef7f730f96c0b4ed4d10c71","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-22 22:18:44.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/16688","accounts_in_message":[],"_revision_number":3},{"id":"90b2dfbf6a3f5b058433830e6d78af5fcd6a7972","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-22 22:20:49.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/16688","accounts_in_message":[],"_revision_number":3},{"id":"5e30865d6b13f545e83b945e6890984bf4230348","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-09-22 23:00:30.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"510a040d0a9c348c7aad1e05e9bfa072d213a2c2","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-22 23:04:28.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"06cf9ecbc1a53df41a370c8e9dbd29c51f45be2f","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-09-22 23:06:29.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)\n\nBy voting Code-Review+2 the following files are now code-owner approved by \u003cGERRIT_ACCOUNT_1000034\u003e:\n* tvix/eval/Cargo.lock\n* tvix/eval/Cargo.toml\n* tvix/eval/src/compiler/attrs.rs\n* tvix/eval/src/compiler/mod.rs\n* tvix/eval/src/compiler/scope.rs\n* tvix/eval/src/tests/tvix_tests/eval-okay-inherit-string-ident.exp\n* tvix/eval/src/tests/tvix_tests/eval-okay-inherit-string-ident.nix\n","accounts_in_message":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}],"_revision_number":3},{"id":"5184ce5c96071d357efbc12fca981cd2ff03a884","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-22 23:07:14.000000000","message":"Change has been successfully rebased and submitted as c46025d52011632b9e53bc96cc115c1d74bfbf7a","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"c46025d52011632b9e53bc96cc115c1d74bfbf7a","revisions":{"c5f1bee24aab12b637b7c46d15707c81f4144c4b":{"kind":"REWORK","_number":1,"created":"2022-09-22 21:44:30.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/47/6747/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/47/6747/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6747/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6747/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6747/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/47/6747/1"}}},"commit":{"parents":[{"commit":"890bbf9b1fba98ac9791eaacaf594492e7ead662","subject":"feat(tvix/eval): Support builtins.lessThan","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d890bbf9b1fba98ac9791eaacaf594492e7ead662"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-22 21:31:40.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-22 21:31:40.000000000","tz":180},"subject":"fix(tvix/eval): support string identifiers in inherits","message":"fix(tvix/eval): support string identifiers in inherits\n\nThis updates rnix-parser to a version where inherits provide an\niterator over `ast::Attr` instead of `ast::Ident`, which mirrors the\nbehaviour of Nix (inherits can have (statically known) strings as\ntheir identifiers).\n\nThis actually required some fairly significant code reshuffling in the\ncompiler, as there was an implicit assumption in many places that we\nwould have an `ast::Ident` node available when dealing with variable\naccess (which is then explicitly only not true in this case).\n\nChange-Id: I12f1e786c0030c85107b1aa409bd49adb5465546\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc5f1bee24aab12b637b7c46d15707c81f4144c4b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc5f1bee24aab12b637b7c46d15707c81f4144c4b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"890bbf9b1fba98ac9791eaacaf594492e7ead662","is_merged_in_target_branch":true,"change_id":"I9c93fa4db0f5a1fc8b56928ea144676f79247de1","change_number":6557,"patch_set_number":9,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"4719fdf8a265a55997db490716b3631fd677baf0":{"kind":"REWORK","_number":2,"created":"2022-09-22 21:48:06.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/47/6747/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/47/6747/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6747/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6747/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6747/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/47/6747/2"}}},"commit":{"parents":[{"commit":"890bbf9b1fba98ac9791eaacaf594492e7ead662","subject":"feat(tvix/eval): Support builtins.lessThan","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d890bbf9b1fba98ac9791eaacaf594492e7ead662"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-22 21:31:40.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-22 21:47:30.000000000","tz":180},"subject":"fix(tvix/eval): support string identifiers in inherits","message":"fix(tvix/eval): support string identifiers in inherits\n\nThis updates rnix-parser to a version where inherits provide an\niterator over `ast::Attr` instead of `ast::Ident`, which mirrors the\nbehaviour of Nix (inherits can have (statically known) strings as\ntheir identifiers).\n\nThis actually required some fairly significant code reshuffling in the\ncompiler, as there was an implicit assumption in many places that we\nwould have an `ast::Ident` node available when dealing with variable\naccess (which is then explicitly only not true in this case).\n\nChange-Id: I12f1e786c0030c85107b1aa409bd49adb5465546\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4719fdf8a265a55997db490716b3631fd677baf0"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4719fdf8a265a55997db490716b3631fd677baf0"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"890bbf9b1fba98ac9791eaacaf594492e7ead662","is_merged_in_target_branch":true,"change_id":"I9c93fa4db0f5a1fc8b56928ea144676f79247de1","change_number":6557,"patch_set_number":9,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"a4e0d34f5eb7e928f799fdda109c233f717394f7":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2022-09-22 22:18:43.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/47/6747/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/47/6747/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6747/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6747/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6747/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/47/6747/3"}}},"commit":{"parents":[{"commit":"3fec7185f42b53288f27ab3889490b0aef046149","subject":"chore(3p/sources): Bump channels \u0026 overlays","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3fec7185f42b53288f27ab3889490b0aef046149"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-22 21:31:40.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-22 22:18:40.000000000","tz":180},"subject":"fix(tvix/eval): support string identifiers in inherits","message":"fix(tvix/eval): support string identifiers in inherits\n\nThis updates rnix-parser to a version where inherits provide an\niterator over `ast::Attr` instead of `ast::Ident`, which mirrors the\nbehaviour of Nix (inherits can have (statically known) strings as\ntheir identifiers).\n\nThis actually required some fairly significant code reshuffling in the\ncompiler, as there was an implicit assumption in many places that we\nwould have an `ast::Ident` node available when dealing with variable\naccess (which is then explicitly only not true in this case).\n\nChange-Id: I12f1e786c0030c85107b1aa409bd49adb5465546\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da4e0d34f5eb7e928f799fdda109c233f717394f7"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da4e0d34f5eb7e928f799fdda109c233f717394f7"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3fec7185f42b53288f27ab3889490b0aef046149","is_merged_in_target_branch":true,"change_id":"I4bf85e65ceb2ed405290e3a2df2e5e4dabef1e80","change_number":6746,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"c46025d52011632b9e53bc96cc115c1d74bfbf7a":{"kind":"REWORK","_number":4,"created":"2022-09-22 23:07:14.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/47/6747/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/47/6747/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6747/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6747/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6747/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/47/6747/4"}}},"commit":{"parents":[{"commit":"ee0b89c4029fe027174018c14dcf7fcff342c8bf","subject":"test(tvix/eval): test word behavior in builtins.compareVersions","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dee0b89c4029fe027174018c14dcf7fcff342c8bf"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-22 21:31:40.000000000","tz":180},"committer":{"name":"tazjin","email":"tazjin@tvl.su","date":"2022-09-22 23:07:14.000000000","tz":0},"subject":"fix(tvix/eval): support string identifiers in inherits","message":"fix(tvix/eval): support string identifiers in inherits\n\nThis updates rnix-parser to a version where inherits provide an\niterator over `ast::Attr` instead of `ast::Ident`, which mirrors the\nbehaviour of Nix (inherits can have (statically known) strings as\ntheir identifiers).\n\nThis actually required some fairly significant code reshuffling in the\ncompiler, as there was an implicit assumption in many places that we\nwould have an `ast::Ident` node available when dealing with variable\naccess (which is then explicitly only not true in this case).\n\nChange-Id: I12f1e786c0030c85107b1aa409bd49adb5465546\nReviewed-on: https://cl.tvl.fyi/c/depot/+/6747\nTested-by: BuildkiteCI\nReviewed-by: sterni \u003csternenseemann@systemli.org\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc46025d52011632b9e53bc96cc115c1d74bfbf7a"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc46025d52011632b9e53bc96cc115c1d74bfbf7a"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ee0b89c4029fe027174018c14dcf7fcff342c8bf","is_merged_in_target_branch":true,"change_id":"I9596068f8ab3e51b79602de0bac79af6d558086e","change_number":6723,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}