)]}'
{"tvix/eval/src/compiler/mod.rs":[{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"41a6e29420c5e4619c0f7bb7a8e79ce5fedc5070","unresolved":true,"context_lines":[{"line_number":628,"context_line":"                            }"},{"line_number":629,"context_line":"                        };"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"                        count +\u003d 1;"},{"line_number":632,"context_line":"                        inherit_froms.push((from.expr().unwrap(), name, self.span_for(\u0026attr)));"},{"line_number":633,"context_line":"                    }"},{"line_number":634,"context_line":"                }"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"ed54dfb2_a240c335","line":631,"updated":"2022-09-22 22:44:01.000000000","message":"What about moving the counters for inherit (form) and regular binding both into the bindings loop which is shared by both. Then we only have to count up in two places (for plain inherits and when we compile the other bindings\u0027 values).","commit_id":"cf490adca2071cadd6b5f8884df454dfbf8ac76b"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"f0088f50e19598c106f77f8c7afbe330078e6f4b","unresolved":false,"context_lines":[{"line_number":628,"context_line":"                            }"},{"line_number":629,"context_line":"                        };"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"                        count +\u003d 1;"},{"line_number":632,"context_line":"                        inherit_froms.push((from.expr().unwrap(), name, self.span_for(\u0026attr)));"},{"line_number":633,"context_line":"                    }"},{"line_number":634,"context_line":"                }"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"f681f1ea_b4f1ff43","line":631,"in_reply_to":"b694c3c1_f735b7f0","updated":"2022-09-22 23:23:44.000000000","message":"Ack","commit_id":"cf490adca2071cadd6b5f8884df454dfbf8ac76b"},{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"6e8e201303468317f047a5dcfa355fd11369f0d2","unresolved":true,"context_lines":[{"line_number":628,"context_line":"                            }"},{"line_number":629,"context_line":"                        };"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"                        count +\u003d 1;"},{"line_number":632,"context_line":"                        inherit_froms.push((from.expr().unwrap(), name, self.span_for(\u0026attr)));"},{"line_number":633,"context_line":"                    }"},{"line_number":634,"context_line":"                }"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"b694c3c1_f735b7f0","line":631,"in_reply_to":"bdeb29e4_52af53ba","updated":"2022-09-22 23:16:13.000000000","message":"Hm, okay that also checks out (it wasn\u0027t quite apparent to me on the first look). I think, though, it would be more sensible to pick either the local declaration or the value compilation as the place to count, since we don\u0027t always create a binding for every AST note (i.e. useless inherits).\n\nAll in all this code is probably going to change enough so that there\u0027s no use growing any gray hairs over this.","commit_id":"cf490adca2071cadd6b5f8884df454dfbf8ac76b"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"7447920521938882615277682e849b0a44df7f39","unresolved":true,"context_lines":[{"line_number":628,"context_line":"                            }"},{"line_number":629,"context_line":"                        };"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"                        count +\u003d 1;"},{"line_number":632,"context_line":"                        inherit_froms.push((from.expr().unwrap(), name, self.span_for(\u0026attr)));"},{"line_number":633,"context_line":"                    }"},{"line_number":634,"context_line":"                }"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"bdeb29e4_52af53ba","line":631,"in_reply_to":"ed54dfb2_a240c335","updated":"2022-09-22 23:05:46.000000000","message":"I don\u0027t have a strong view on this. In this case we always count close to the AST node that created the entry, which seems more consistent than doing it in two different \"kinds\" of places. How important is it to you?","commit_id":"cf490adca2071cadd6b5f8884df454dfbf8ac76b"}]}