)]}'
{"id":"depot~6749","triplet_id":"depot~canon~I6f7f7729f3512b297cf29a2e046302ca28477854","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2022-09-22 23:16:13.000000000","reason":"\u003cGERRIT_ACCOUNT_1000034\u003e replied on the change","reason_account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2022-09-22 23:23:44.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2022-09-22 23:23:47.000000000","reason":"Change was submitted"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2022-09-22 23:23:47.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6f7f7729f3512b297cf29a2e046302ca28477854","subject":"fix(tvix/eval): manually count entries in recursive scopes","status":"MERGED","created":"2022-09-22 21:52:18.000000000","updated":"2022-09-22 23:23:47.000000000","submitted":"2022-09-22 23:23:47.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6749","meta_rev_id":"5a506ca52d3752641b5ff90ad3a450cf16264df7","_number":6749,"virtual_id_number":6749,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-22 23:23:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-22 23:23:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-22 21:52:19.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-09-22 21:53:17.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2022-09-22 21:53:17.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2022-09-22 21:53:17.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"state":"REVIEWER"},{"updated":"2022-09-22 21:55:19.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d8aecee2ab78a0540f0a8359affc4d11e4985b00","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-22 21:52:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"08844189bea635c64a90f69e26f2e59d7bc067c9","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-22 21:52:19.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/16686","accounts_in_message":[],"_revision_number":1},{"id":"9ed5e33cabf9a65d90b0d74b0014387fcf669881","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-22 21:53:17.000000000","message":"\u003cGERRIT_ACCOUNT_1000034\u003e, who was added as reviewer owns the following files:\n* tvix/eval/src/compiler/attrs.rs\n* tvix/eval/src/compiler/mod.rs\n* tvix/eval/src/tests/tvix_tests/eval-okay-empty-rec-inherit.exp\n* tvix/eval/src/tests/tvix_tests/eval-okay-empty-rec-inherit.nix\n\n\u003cGERRIT_ACCOUNT_1000010\u003e, who was added as reviewer owns the following files:\n* tvix/eval/src/compiler/attrs.rs\n* tvix/eval/src/compiler/mod.rs\n* tvix/eval/src/tests/tvix_tests/eval-okay-empty-rec-inherit.exp\n* tvix/eval/src/tests/tvix_tests/eval-okay-empty-rec-inherit.nix\n\n\u003cGERRIT_ACCOUNT_1000036\u003e, who was added as reviewer owns the following files:\n* tvix/eval/src/compiler/attrs.rs\n* tvix/eval/src/compiler/mod.rs\n* tvix/eval/src/tests/tvix_tests/eval-okay-empty-rec-inherit.exp\n* tvix/eval/src/tests/tvix_tests/eval-okay-empty-rec-inherit.nix\n","accounts_in_message":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":1},{"id":"f9814fe3184f4d95bbecbe669671ed58b701de9e","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-22 21:55:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/16686","accounts_in_message":[],"_revision_number":1},{"id":"bd222156b0d62d033ba182ce38fd3407c9b53f3a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-22 22:18:43.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"492dab1d743f93dd5543b8d55604b898032d2bf8","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-22 22:18:45.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/16690","accounts_in_message":[],"_revision_number":2},{"id":"e87a6449e90449b74d6b6bdc09892539f7b8faa0","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-22 22:20:34.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/16690","accounts_in_message":[],"_revision_number":2},{"id":"41a6e29420c5e4619c0f7bb7a8e79ce5fedc5070","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-09-22 22:44:01.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)\n\nBy voting Code-Review+2 the following files are now code-owner approved by \u003cGERRIT_ACCOUNT_1000034\u003e:\n* tvix/eval/src/compiler/attrs.rs\n* tvix/eval/src/compiler/mod.rs\n* tvix/eval/src/tests/tvix_tests/eval-okay-empty-rec-inherit.exp\n* tvix/eval/src/tests/tvix_tests/eval-okay-empty-rec-inherit.nix\n","accounts_in_message":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}],"_revision_number":2},{"id":"7447920521938882615277682e849b0a44df7f39","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-22 23:05:46.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"dbdb2ca556f98dd27ce448f3b1cd40ba99fda56f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-22 23:07:18.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"3c7e231ccb50dfedff52230678c2eed8f80f1814","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-22 23:07:19.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/16694","accounts_in_message":[],"_revision_number":3},{"id":"0836453ec776f94ad036205caae943ccf1649775","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-22 23:12:37.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/16694","accounts_in_message":[],"_revision_number":3},{"id":"6e8e201303468317f047a5dcfa355fd11369f0d2","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-09-22 23:16:13.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)\n\nBy voting Code-Review+2 the following files are still code-owner approved by \u003cGERRIT_ACCOUNT_1000034\u003e:\n* tvix/eval/src/compiler/attrs.rs\n* tvix/eval/src/compiler/mod.rs\n* tvix/eval/src/tests/tvix_tests/eval-okay-empty-rec-inherit.exp\n* tvix/eval/src/tests/tvix_tests/eval-okay-empty-rec-inherit.nix\n","accounts_in_message":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}],"_revision_number":3},{"id":"f0088f50e19598c106f77f8c7afbe330078e6f4b","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-22 23:23:44.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"5a506ca52d3752641b5ff90ad3a450cf16264df7","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-22 23:23:47.000000000","message":"Change has been successfully rebased and submitted as 1015f2f8e7c37c5c4b4ebca799579c5f6c0d5100","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"1015f2f8e7c37c5c4b4ebca799579c5f6c0d5100","revisions":{"e9c9919a954837cc88e284f647211f3b2621ad84":{"kind":"REWORK","_number":1,"created":"2022-09-22 21:52:18.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/49/6749/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/49/6749/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/49/6749/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/49/6749/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/49/6749/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/49/6749/1"}}},"commit":{"parents":[{"commit":"c6bebe7739b1f0ce5b0465e7c28f04e0d1b5d388","subject":"test(tvix/eval): add a test for accessing \"strange\" identifiers","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc6bebe7739b1f0ce5b0465e7c28f04e0d1b5d388"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-22 21:51:19.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-22 21:51:19.000000000","tz":180},"subject":"fix(tvix/eval): manually count entries in recursive scopes","message":"fix(tvix/eval): manually count entries in recursive scopes\n\nThe previous version had a bug where we assumed that the number of\nentries in an attribute set AST node would be equivalent to the number\nof entries in the runtime attribute set, but due to inherit nodes\ncontaining a variable number of entries, this did not work out.\n\nFixes b/199\n\nChange-Id: I6f7f7729f3512b297cf29a2e046302ca28477854\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de9c9919a954837cc88e284f647211f3b2621ad84"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de9c9919a954837cc88e284f647211f3b2621ad84"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c6bebe7739b1f0ce5b0465e7c28f04e0d1b5d388","is_merged_in_target_branch":false,"change_id":"Ic868233221befa160538dd2ffaff1cc7f566585a","change_number":6748,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"cf490adca2071cadd6b5f8884df454dfbf8ac76b":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-09-22 22:18:43.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/49/6749/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/49/6749/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/49/6749/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/49/6749/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/49/6749/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/49/6749/2"}}},"commit":{"parents":[{"commit":"756c189b0b7b2f5fb3e8498439efdecc16ede356","subject":"test(tvix/eval): add a test for accessing \"strange\" identifiers","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d756c189b0b7b2f5fb3e8498439efdecc16ede356"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-22 21:51:19.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-22 22:18:40.000000000","tz":180},"subject":"fix(tvix/eval): manually count entries in recursive scopes","message":"fix(tvix/eval): manually count entries in recursive scopes\n\nThe previous version had a bug where we assumed that the number of\nentries in an attribute set AST node would be equivalent to the number\nof entries in the runtime attribute set, but due to inherit nodes\ncontaining a variable number of entries, this did not work out.\n\nFixes b/199\n\nChange-Id: I6f7f7729f3512b297cf29a2e046302ca28477854\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcf490adca2071cadd6b5f8884df454dfbf8ac76b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcf490adca2071cadd6b5f8884df454dfbf8ac76b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"756c189b0b7b2f5fb3e8498439efdecc16ede356","is_merged_in_target_branch":false,"change_id":"Ic868233221befa160538dd2ffaff1cc7f566585a","change_number":6748,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"da15ae9c512366b50f75c901a77d44e7d72c8cc8":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2022-09-22 23:07:18.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/49/6749/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/49/6749/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/49/6749/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/49/6749/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/49/6749/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/49/6749/3"}}},"commit":{"parents":[{"commit":"55459f02fcdca8612673f2df8ba54cb995ae06b6","subject":"test(tvix/eval): add a test for accessing \"strange\" identifiers","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d55459f02fcdca8612673f2df8ba54cb995ae06b6"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-22 21:51:19.000000000","tz":180},"committer":{"name":"tazjin","email":"tazjin@tvl.su","date":"2022-09-22 23:07:18.000000000","tz":0},"subject":"fix(tvix/eval): manually count entries in recursive scopes","message":"fix(tvix/eval): manually count entries in recursive scopes\n\nThe previous version had a bug where we assumed that the number of\nentries in an attribute set AST node would be equivalent to the number\nof entries in the runtime attribute set, but due to inherit nodes\ncontaining a variable number of entries, this did not work out.\n\nFixes b/199\n\nChange-Id: I6f7f7729f3512b297cf29a2e046302ca28477854\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dda15ae9c512366b50f75c901a77d44e7d72c8cc8"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dda15ae9c512366b50f75c901a77d44e7d72c8cc8"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"55459f02fcdca8612673f2df8ba54cb995ae06b6","is_merged_in_target_branch":true,"change_id":"Ic868233221befa160538dd2ffaff1cc7f566585a","change_number":6748,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"},"1015f2f8e7c37c5c4b4ebca799579c5f6c0d5100":{"kind":"REWORK","_number":4,"created":"2022-09-22 23:23:47.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/49/6749/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/49/6749/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/49/6749/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/49/6749/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/49/6749/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/49/6749/4"}}},"commit":{"parents":[{"commit":"bd9cda2af7d9fd8064b719e9135b3a48cf13c36a","subject":"feat(tvix/eval): add builtins.stringLength","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbd9cda2af7d9fd8064b719e9135b3a48cf13c36a"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-22 21:51:19.000000000","tz":180},"committer":{"name":"tazjin","email":"tazjin@tvl.su","date":"2022-09-22 23:23:47.000000000","tz":0},"subject":"fix(tvix/eval): manually count entries in recursive scopes","message":"fix(tvix/eval): manually count entries in recursive scopes\n\nThe previous version had a bug where we assumed that the number of\nentries in an attribute set AST node would be equivalent to the number\nof entries in the runtime attribute set, but due to inherit nodes\ncontaining a variable number of entries, this did not work out.\n\nFixes b/199\n\nChange-Id: I6f7f7729f3512b297cf29a2e046302ca28477854\nReviewed-on: https://cl.tvl.fyi/c/depot/+/6749\nTested-by: BuildkiteCI\nReviewed-by: sterni \u003csternenseemann@systemli.org\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1015f2f8e7c37c5c4b4ebca799579c5f6c0d5100"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1015f2f8e7c37c5c4b4ebca799579c5f6c0d5100"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"bd9cda2af7d9fd8064b719e9135b3a48cf13c36a","is_merged_in_target_branch":true,"change_id":"I03b427e657e402f1f9eb0f795b689bbf5092aba1","change_number":6745,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}