)]}'
{"id":"depot~6781","triplet_id":"depot~canon~Ic2d43dd8fd97d7ccd56d8c6adf2ff97274cd837a","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2022-09-28 12:53:47.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2022-09-29 10:41:29.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2022-09-29 11:47:47.000000000","reason":"Change was submitted"},"1000013":{"account":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"last_update":"2022-09-29 11:47:47.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ic2d43dd8fd97d7ccd56d8c6adf2ff97274cd837a","subject":"feat(tvix/eval): implement dynamic keys in recursive attrs","status":"MERGED","created":"2022-09-24 12:48:14.000000000","updated":"2022-09-29 11:47:47.000000000","submitted":"2022-09-29 11:47:47.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6796","meta_rev_id":"d1c57cd8c210e8ed9c778ccea07bcf87d7f4297c","_number":6781,"virtual_id_number":6781,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-29 11:47:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-29 11:47:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-24 12:48:14.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"state":"REVIEWER"},{"updated":"2022-09-24 12:48:14.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2022-09-24 12:48:14.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"state":"REVIEWER"},{"updated":"2022-09-24 12:48:16.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-09-24 12:50:07.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e9879755569fd1f5b14cc2a154439d5d6b3d04f4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-24 12:48:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1256802db788cf63848576b2a1af8f87c2d113ee","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-24 12:48:14.000000000","message":"\u003cGERRIT_ACCOUNT_1000034\u003e, who was added as reviewer owns the following files:\n* tvix/eval/src/compiler/bindings.rs\n* tvix/eval/src/tests/tvix_tests/eval-okay-rec-dynamic-keys.exp\n* tvix/eval/src/tests/tvix_tests/eval-okay-rec-dynamic-keys.nix\n","accounts_in_message":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}],"_revision_number":1},{"id":"640a7136367ced2fce35a7f9122257c5ee739aaa","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-24 12:48:14.000000000","message":"\u003cGERRIT_ACCOUNT_1000010\u003e, who was added as reviewer owns the following files:\n* tvix/eval/src/compiler/bindings.rs\n* tvix/eval/src/tests/tvix_tests/eval-okay-rec-dynamic-keys.exp\n* tvix/eval/src/tests/tvix_tests/eval-okay-rec-dynamic-keys.nix\n","accounts_in_message":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"_revision_number":1},{"id":"e8473d31100c9c3196224e974a46816cfe69d523","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-24 12:48:16.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/16719","accounts_in_message":[],"_revision_number":1},{"id":"9ee5c2518c737c6b4c2c2f99e1e7db13f6cfb092","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-24 12:50:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/16719","accounts_in_message":[],"_revision_number":1},{"id":"fa95ebdb4c0e46750b5785c500db810b67278adf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-28 00:02:01.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"35a87f54b20981ec7a4bc880f10ff581814f75cd","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-28 00:02:12.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/16777","accounts_in_message":[],"_revision_number":2},{"id":"403f3455a7c43e187acc5ff9a573ffdf2349b63d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-28 00:09:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/16777","accounts_in_message":[],"_revision_number":2},{"id":"b54e603c902a834ecebd697a1e38e7eeb808dc57","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-28 00:10:06.000000000","message":"Uploaded patch set 3: New patch set was added with same tree, parent tree, and commit message as Patch Set 2.","accounts_in_message":[],"_revision_number":3},{"id":"de302861651aa1535feff2d84aae73c963b206ca","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-28 09:48:35.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"3b50ac91e0f5c3466d127cb59f433966aa7f061a","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-28 09:48:41.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/16794","accounts_in_message":[],"_revision_number":4},{"id":"3cd4432005f525acb774b672a3e5b51b9db6f024","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-28 09:51:13.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/16794","accounts_in_message":[],"_revision_number":4},{"id":"1b42ae8f19ed3ff9ad20750dd10e6cc100e33cea","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-09-28 12:53:47.000000000","message":"Patch Set 4: Code-Review+2\n\n(3 comments)\n\nBy voting Code-Review+2 the following files are now code-owner approved by \u003cGERRIT_ACCOUNT_1000034\u003e:\n* tvix/eval/src/compiler/bindings.rs\n* tvix/eval/src/tests/tvix_tests/eval-okay-rec-dynamic-keys.exp\n* tvix/eval/src/tests/tvix_tests/eval-okay-rec-dynamic-keys.nix\n","accounts_in_message":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}],"_revision_number":4},{"id":"ca6e8afb64bc10f38c47a16c2020fb168caa2156","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-09-28 13:00:35.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"ac13416df1827337a425643635113c85b966f1ce","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-29 10:41:29.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"2bbb770b72b3b06b56c3146302f8e2db71255412","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-29 10:53:27.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"ce58b046eb707c4bd1df6a09ed8d140461a6a616","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-29 10:53:28.000000000","message":"Patch Set 5:\n\nStarted build for patchset #5 on: https://buildkite.com/tvl/depot/builds/16813","accounts_in_message":[],"_revision_number":5},{"id":"25004ffc469d0518cbe6a49e42c121051f124966","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-29 10:54:58.000000000","message":"Patch Set 5: Verified+1\n\nBuild of patchset 5 passed: https://buildkite.com/tvl/depot/builds/16813","accounts_in_message":[],"_revision_number":5},{"id":"9e134828d985e988b98bcf14bfe244f96c173340","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-29 11:42:42.000000000","message":"Patch Set 5:\n\n(3 comments)","accounts_in_message":[],"_revision_number":5},{"id":"e7b26b81502f57cbf79dc3c9b5646b396a973262","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-29 11:42:47.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"4dd59a1f1edb92f09e0f2be5416a9122274a6b20","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-29 11:42:48.000000000","message":"Patch Set 6:\n\nStarted build for patchset #6 on: https://buildkite.com/tvl/depot/builds/16825","accounts_in_message":[],"_revision_number":6},{"id":"ccd12ed283644ffefa1643b870b69040e316f2de","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-09-29 11:45:28.000000000","message":"Patch Set 6: Verified+1\n\nBuild of patchset 6 passed: https://buildkite.com/tvl/depot/builds/16825","accounts_in_message":[],"_revision_number":6},{"id":"d1c57cd8c210e8ed9c778ccea07bcf87d7f4297c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-09-29 11:47:47.000000000","message":"Change has been successfully rebased and submitted as 949897651e826598f2011611e0cc03619426fcc2\n\n4 is the latest approved patch-set.\nThe change was submitted with unreviewed changes in the following files:\n\n```\nThe name of the file: tvix/eval/src/compiler/bindings.rs\nInsertions: 2, Deletions: 0.\n\n@@ -257,6 +257,8 @@\n \n                     // Dynamic values are never resolvable (as their names are\n                     // of course only known at runtime).\n+                    //\n+                    // Note: This branch is unreachable in `let`-expressions.\n                     KeySlot::Dynamic { .. } \u003d\u003e self.scope_mut().declare_phantom(key_span, false),\n                 },\n \n```\n","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"949897651e826598f2011611e0cc03619426fcc2","revisions":{"d2c7c5afa5f9fc506084197876df6bd59e4ccd57":{"kind":"REWORK","_number":1,"created":"2022-09-24 12:48:14.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/81/6781/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/81/6781/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/81/6781/1"}}},"commit":{"parents":[{"commit":"f54831a32ce44816f14e026fff71dc9113889a06","subject":"feat(tvix/eval): add KeySlot::Dynamic variant for dynamic keys","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df54831a32ce44816f14e026fff71dc9113889a06"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-24 12:42:32.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-24 12:45:42.000000000","tz":180},"subject":"feat(tvix/eval): implement dynamic keys in recursive attrs","message":"feat(tvix/eval): implement dynamic keys in recursive attrs\n\nThis wires up the new bindings setup logic to be able to thread\nthrough \u0026 compile dynamic attributes in recursive attrs.\n\nIt seems like we don\u0027t actually need to retain the phasing of Nix\nexactly, as we can use the phantom mechanism to declare all locals\nwithout making the dynamic ones accessible.\n\nChange-Id: Ic2d43dd8fd97d7ccd56d8c6adf2ff97274cd837a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd2c7c5afa5f9fc506084197876df6bd59e4ccd57"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd2c7c5afa5f9fc506084197876df6bd59e4ccd57"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"f54831a32ce44816f14e026fff71dc9113889a06","is_merged_in_target_branch":false,"change_id":"I56b4ed323f70754ed1ab27964ee3c99cf3bf3292","change_number":6780,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"cc2debb084e58fbba34c006f746cdf597663cfd9":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-09-28 00:02:01.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/81/6781/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/81/6781/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/81/6781/2"}}},"commit":{"parents":[{"commit":"7273939a4232e786b4d9ca182dbe1e2be844f7fc","subject":"feat(tvix/eval): add KeySlot::Dynamic variant for dynamic keys","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7273939a4232e786b4d9ca182dbe1e2be844f7fc"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-24 12:42:32.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-28 00:01:57.000000000","tz":180},"subject":"feat(tvix/eval): implement dynamic keys in recursive attrs","message":"feat(tvix/eval): implement dynamic keys in recursive attrs\n\nThis wires up the new bindings setup logic to be able to thread\nthrough \u0026 compile dynamic attributes in recursive attrs.\n\nIt seems like we don\u0027t actually need to retain the phasing of Nix\nexactly, as we can use the phantom mechanism to declare all locals\nwithout making the dynamic ones accessible.\n\nChange-Id: Ic2d43dd8fd97d7ccd56d8c6adf2ff97274cd837a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcc2debb084e58fbba34c006f746cdf597663cfd9"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcc2debb084e58fbba34c006f746cdf597663cfd9"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"7273939a4232e786b4d9ca182dbe1e2be844f7fc","is_merged_in_target_branch":false,"change_id":"I56b4ed323f70754ed1ab27964ee3c99cf3bf3292","change_number":6780,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"8725840a65f8387c9bf13b329be2084b2c2c902e":{"kind":"NO_CHANGE","_number":3,"created":"2022-09-28 00:10:06.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/81/6781/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/81/6781/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/81/6781/3"}}},"commit":{"parents":[{"commit":"ef8826a0fe1abe59738bb9c9eaffd322da90c686","subject":"feat(tvix/eval): add KeySlot::Dynamic variant for dynamic keys","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003def8826a0fe1abe59738bb9c9eaffd322da90c686"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-24 12:42:32.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-28 00:09:58.000000000","tz":180},"subject":"feat(tvix/eval): implement dynamic keys in recursive attrs","message":"feat(tvix/eval): implement dynamic keys in recursive attrs\n\nThis wires up the new bindings setup logic to be able to thread\nthrough \u0026 compile dynamic attributes in recursive attrs.\n\nIt seems like we don\u0027t actually need to retain the phasing of Nix\nexactly, as we can use the phantom mechanism to declare all locals\nwithout making the dynamic ones accessible.\n\nChange-Id: Ic2d43dd8fd97d7ccd56d8c6adf2ff97274cd837a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8725840a65f8387c9bf13b329be2084b2c2c902e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8725840a65f8387c9bf13b329be2084b2c2c902e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ef8826a0fe1abe59738bb9c9eaffd322da90c686","is_merged_in_target_branch":false,"change_id":"I56b4ed323f70754ed1ab27964ee3c99cf3bf3292","change_number":6780,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"6d2e4169938f29b948f95b8633bc0f337c98cc38":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2022-09-28 09:48:35.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/81/6781/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/81/6781/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/81/6781/4"}}},"commit":{"parents":[{"commit":"cd0f9694198403cc0b3c297f3f27b434d338d097","subject":"feat(tvix/eval): add KeySlot::Dynamic variant for dynamic keys","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcd0f9694198403cc0b3c297f3f27b434d338d097"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-24 12:42:32.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-28 09:48:31.000000000","tz":180},"subject":"feat(tvix/eval): implement dynamic keys in recursive attrs","message":"feat(tvix/eval): implement dynamic keys in recursive attrs\n\nThis wires up the new bindings setup logic to be able to thread\nthrough \u0026 compile dynamic attributes in recursive attrs.\n\nIt seems like we don\u0027t actually need to retain the phasing of Nix\nexactly, as we can use the phantom mechanism to declare all locals\nwithout making the dynamic ones accessible.\n\nChange-Id: Ic2d43dd8fd97d7ccd56d8c6adf2ff97274cd837a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6d2e4169938f29b948f95b8633bc0f337c98cc38"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6d2e4169938f29b948f95b8633bc0f337c98cc38"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"cd0f9694198403cc0b3c297f3f27b434d338d097","is_merged_in_target_branch":false,"change_id":"I56b4ed323f70754ed1ab27964ee3c99cf3bf3292","change_number":6780,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"c273587b54f178d17490ecf68f75a3fd4056ab40":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2022-09-29 10:53:27.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/81/6781/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/81/6781/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/81/6781/5"}}},"commit":{"parents":[{"commit":"b593f6922c3b31f2456cb8885d80af3789a380b3","subject":"chore(3p/sources): Bump channels \u0026 overlays","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db593f6922c3b31f2456cb8885d80af3789a380b3"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-24 12:42:32.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-29 10:53:20.000000000","tz":180},"subject":"feat(tvix/eval): implement dynamic keys in recursive attrs","message":"feat(tvix/eval): implement dynamic keys in recursive attrs\n\nThis wires up the new bindings setup logic to be able to thread\nthrough \u0026 compile dynamic attributes in recursive attrs.\n\nIt seems like we don\u0027t actually need to retain the phasing of Nix\nexactly, as we can use the phantom mechanism to declare all locals\nwithout making the dynamic ones accessible.\n\nChange-Id: Ic2d43dd8fd97d7ccd56d8c6adf2ff97274cd837a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc273587b54f178d17490ecf68f75a3fd4056ab40"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc273587b54f178d17490ecf68f75a3fd4056ab40"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b593f6922c3b31f2456cb8885d80af3789a380b3","is_merged_in_target_branch":true,"change_id":"I044dc6e2804eacdf8f6136698536fa1b2df79f85","change_number":6797,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"cc14b5f4dc97383ce1ae0eb0085fd8e5880680bc":{"kind":"REWORK","_number":6,"created":"2022-09-29 11:42:47.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/81/6781/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/81/6781/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/81/6781/6"}}},"commit":{"parents":[{"commit":"b593f6922c3b31f2456cb8885d80af3789a380b3","subject":"chore(3p/sources): Bump channels \u0026 overlays","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db593f6922c3b31f2456cb8885d80af3789a380b3"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-24 12:42:32.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-29 11:39:02.000000000","tz":180},"subject":"feat(tvix/eval): implement dynamic keys in recursive attrs","message":"feat(tvix/eval): implement dynamic keys in recursive attrs\n\nThis wires up the new bindings setup logic to be able to thread\nthrough \u0026 compile dynamic attributes in recursive attrs.\n\nIt seems like we don\u0027t actually need to retain the phasing of Nix\nexactly, as we can use the phantom mechanism to declare all locals\nwithout making the dynamic ones accessible.\n\nChange-Id: Ic2d43dd8fd97d7ccd56d8c6adf2ff97274cd837a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcc14b5f4dc97383ce1ae0eb0085fd8e5880680bc"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcc14b5f4dc97383ce1ae0eb0085fd8e5880680bc"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b593f6922c3b31f2456cb8885d80af3789a380b3","is_merged_in_target_branch":true,"change_id":"I044dc6e2804eacdf8f6136698536fa1b2df79f85","change_number":6797,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"949897651e826598f2011611e0cc03619426fcc2":{"kind":"NO_CODE_CHANGE","_number":7,"created":"2022-09-29 11:47:47.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/81/6781/7","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/81/6781/7","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/81/6781/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/81/6781/7"}}},"commit":{"parents":[{"commit":"b593f6922c3b31f2456cb8885d80af3789a380b3","subject":"chore(3p/sources): Bump channels \u0026 overlays","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db593f6922c3b31f2456cb8885d80af3789a380b3"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-09-24 12:42:32.000000000","tz":180},"committer":{"name":"tazjin","email":"tazjin@tvl.su","date":"2022-09-29 11:47:47.000000000","tz":0},"subject":"feat(tvix/eval): implement dynamic keys in recursive attrs","message":"feat(tvix/eval): implement dynamic keys in recursive attrs\n\nThis wires up the new bindings setup logic to be able to thread\nthrough \u0026 compile dynamic attributes in recursive attrs.\n\nIt seems like we don\u0027t actually need to retain the phasing of Nix\nexactly, as we can use the phantom mechanism to declare all locals\nwithout making the dynamic ones accessible.\n\nChange-Id: Ic2d43dd8fd97d7ccd56d8c6adf2ff97274cd837a\nReviewed-on: https://cl.tvl.fyi/c/depot/+/6781\nReviewed-by: sterni \u003csternenseemann@systemli.org\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d949897651e826598f2011611e0cc03619426fcc2"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d949897651e826598f2011611e0cc03619426fcc2"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b593f6922c3b31f2456cb8885d80af3789a380b3","is_merged_in_target_branch":true,"change_id":"I044dc6e2804eacdf8f6136698536fa1b2df79f85","change_number":6797,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}