)]}'
{"id":"depot~6904","triplet_id":"depot~canon~I45adb2f9602762dfc867956323fb3f5ae4c8bd1d","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2022-10-09 13:25:14.000000000","reason":"Change was submitted"},"1000013":{"account":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"last_update":"2022-10-09 13:22:46.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I45adb2f9602762dfc867956323fb3f5ae4c8bd1d","subject":"fix(nix/tag): correct no match check in discr","status":"MERGED","created":"2022-10-09 09:25:52.000000000","updated":"2022-10-09 13:25:14.000000000","submitted":"2022-10-09 13:25:14.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6904","meta_rev_id":"b1e8994d0ffa42ae935a94344fce093dea3808a0","_number":6904,"virtual_id_number":6904,"owner":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-10-09 13:25:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-09 13:25:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-09 13:25:14.000000000","_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-10-09 09:25:53.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-10-09 09:26:05.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"state":"REVIEWER"},{"updated":"2022-10-09 09:27:26.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-10-09 13:25:14.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"41fc3c6b9406034f0fa5bb0885385d8fc92c01d3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-10-09 09:25:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d9122b30da3f438b106026ca5ba83ec40c325bab","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-09 09:25:53.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/17163","accounts_in_message":[],"_revision_number":1},{"id":"1486af457430be5805f5197b8398eeb8eada70e0","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-10-09 09:26:05.000000000","message":"Patch Set 1: Autosubmit+1","accounts_in_message":[],"_revision_number":1},{"id":"a1d3bfafd6dd830b764332926830fe58ae1c50d0","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-10-09 09:26:05.000000000","message":"\u003cGERRIT_ACCOUNT_1000013\u003e, who was added as reviewer owns the following files:\n* nix/tag/default.nix\n* nix/tag/tests.nix\n","accounts_in_message":[{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"_revision_number":1},{"id":"828873a1ddee0611cd7ad3848db67eca8efb63e5","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-09 09:27:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/17163","accounts_in_message":[],"_revision_number":1},{"id":"f03751066bcdf0f263d93b0ee9212f0754bb3add","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2022-10-09 13:22:46.000000000","message":"Patch Set 1: Code-Review+2\n\nBy voting Code-Review+2 the following files are now code-owner approved by \u003cGERRIT_ACCOUNT_1000013\u003e:\n* nix/tag/default.nix\n* nix/tag/tests.nix\n","accounts_in_message":[{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"_revision_number":1},{"id":"55e733f833b9a6aa4717fda15718f5acf445d7d1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2022-10-09 13:23:14.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"464120fa12212abef4f66abb9e9fbae41d6756a0","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-09 13:23:15.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/17164","accounts_in_message":[],"_revision_number":2},{"id":"5303e2b7b2960de9926eb46f513289f71a4d8873","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-09 13:24:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/17164","accounts_in_message":[],"_revision_number":2},{"id":"b1e8994d0ffa42ae935a94344fce093dea3808a0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2022-10-09 13:25:14.000000000","message":"Change has been successfully rebased and submitted as 5174c2163730c683ca5c2a01be537c38173bab33\n\n1 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"5174c2163730c683ca5c2a01be537c38173bab33","revisions":{"22434c669a07e43234fcbab51c7b3235d6b50bc4":{"kind":"REWORK","_number":1,"created":"2022-10-09 09:25:52.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/04/6904/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/6904/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/6904/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/6904/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/6904/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/6904/1"}}},"commit":{"parents":[{"commit":"70427fd93470536c36b2fa8a6c9446f746dcfbec","subject":"refactor(nix/stateMonad): optimize after","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d70427fd93470536c36b2fa8a6c9446f746dcfbec"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-10-09 09:22:00.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-10-09 09:25:18.000000000","tz":120},"subject":"fix(nix/tag): correct no match check in discr","message":"fix(nix/tag): correct no match check in discr\n\nIt uses discrDef internally, but passes `null` as the default tag name,\ncausing Nix to drop the attribute and return an empty attribute set if\nthe default case is hit. Consequently we need to check for the empty\nattribute set, not `null` to figure out if there was no match found.\n\nWe can also test this behavior using `assertThrows` which was introduced\nafter the tag library was originally written.\n\nChange-Id: I45adb2f9602762dfc867956323fb3f5ae4c8bd1d\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d22434c669a07e43234fcbab51c7b3235d6b50bc4"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d22434c669a07e43234fcbab51c7b3235d6b50bc4"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"70427fd93470536c36b2fa8a6c9446f746dcfbec","is_merged_in_target_branch":true,"change_id":"I2bfcd254e55f1bea366b09de294b2bef9f5b5dda","change_number":6834,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"e207538daf16d4e507bf99a672c223341e7ea364":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-10-09 13:23:14.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/04/6904/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/6904/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/6904/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/6904/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/6904/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/6904/2"}}},"commit":{"parents":[{"commit":"1e852098091dcaaaf3b9750c6dff5e465403f8c3","subject":"feat(tvix/eval): Handle invoking binary with a directory","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1e852098091dcaaaf3b9750c6dff5e465403f8c3"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-10-09 09:22:00.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2022-10-09 13:23:14.000000000","tz":0},"subject":"fix(nix/tag): correct no match check in discr","message":"fix(nix/tag): correct no match check in discr\n\nIt uses discrDef internally, but passes `null` as the default tag name,\ncausing Nix to drop the attribute and return an empty attribute set if\nthe default case is hit. Consequently we need to check for the empty\nattribute set, not `null` to figure out if there was no match found.\n\nWe can also test this behavior using `assertThrows` which was introduced\nafter the tag library was originally written.\n\nChange-Id: I45adb2f9602762dfc867956323fb3f5ae4c8bd1d\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de207538daf16d4e507bf99a672c223341e7ea364"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de207538daf16d4e507bf99a672c223341e7ea364"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1e852098091dcaaaf3b9750c6dff5e465403f8c3","is_merged_in_target_branch":true,"change_id":"I281bd44e3c8803b6765c886ae5fd08f549e2e563","change_number":6895,"patch_set_number":8,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"},"5174c2163730c683ca5c2a01be537c38173bab33":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2022-10-09 13:25:14.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/04/6904/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/6904/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/6904/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/6904/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/6904/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/6904/3"}}},"commit":{"parents":[{"commit":"1e852098091dcaaaf3b9750c6dff5e465403f8c3","subject":"feat(tvix/eval): Handle invoking binary with a directory","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1e852098091dcaaaf3b9750c6dff5e465403f8c3"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-10-09 09:22:00.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2022-10-09 13:25:14.000000000","tz":0},"subject":"fix(nix/tag): correct no match check in discr","message":"fix(nix/tag): correct no match check in discr\n\nIt uses discrDef internally, but passes `null` as the default tag name,\ncausing Nix to drop the attribute and return an empty attribute set if\nthe default case is hit. Consequently we need to check for the empty\nattribute set, not `null` to figure out if there was no match found.\n\nWe can also test this behavior using `assertThrows` which was introduced\nafter the tag library was originally written.\n\nChange-Id: I45adb2f9602762dfc867956323fb3f5ae4c8bd1d\nReviewed-on: https://cl.tvl.fyi/c/depot/+/6904\nAutosubmit: sterni \u003csternenseemann@systemli.org\u003e\nReviewed-by: Profpatsch \u003cmail@profpatsch.de\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5174c2163730c683ca5c2a01be537c38173bab33"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5174c2163730c683ca5c2a01be537c38173bab33"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1e852098091dcaaaf3b9750c6dff5e465403f8c3","is_merged_in_target_branch":true,"change_id":"I281bd44e3c8803b6765c886ae5fd08f549e2e563","change_number":6895,"patch_set_number":8,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}