)]}'
{"id":"depot~6932","triplet_id":"depot~canon~I81474810a763046e2eb3a8f07acf7d8ec708824a","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2022-10-10 23:45:03.000000000","reason":"removed on reply"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2022-10-10 23:51:09.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I81474810a763046e2eb3a8f07acf7d8ec708824a","subject":"fix(tvix/eval): Actually trace spans for thunks","status":"MERGED","created":"2022-10-10 20:54:19.000000000","updated":"2022-10-10 23:51:09.000000000","submitted":"2022-10-10 23:51:09.000000000","submitter":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6932","meta_rev_id":"a2e3dedbca08b9e91e18a0145ee894d81a8d8017","_number":6932,"virtual_id_number":6932,"owner":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-10 23:51:09.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-10-10 23:51:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-10 23:51:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-10 23:51:09.000000000","_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-10-10 20:54:23.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-10-10 20:57:09.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-10-10 21:22:32.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2022-10-10 21:35:01.000000000","updated_by":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"reviewer":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"state":"REVIEWER"}],"messages":[{"id":"6f5761bc5c3df27ea106504c4c4608a3a8d00922","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2022-10-10 20:54:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6572d65687ba7a5ddb27f051f73b23e56c245589","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-10 20:54:23.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/17361","accounts_in_message":[],"_revision_number":1},{"id":"bf74c2a334f475620f766ae8176cb82b9c06ac33","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-10 20:57:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/17361","accounts_in_message":[],"_revision_number":1},{"id":"5717f6fb8eb10ccc68516394c4c81cc4dcf43bfc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2022-10-10 20:58:37.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent tree, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"4437d7dc88e44e7754da93e2b207b1abd4279ddb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2022-10-10 21:11:10.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"4a3150bd361e677e70ac62e8e3cf861f8d9ecc36","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-10 21:11:11.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/17368","accounts_in_message":[],"_revision_number":3},{"id":"870fcae68c87b2bf35da414c36e0eaaeee33dd9b","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-10 21:13:14.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/17368","accounts_in_message":[],"_revision_number":3},{"id":"e71ff8b762b015fbeceacefc32b136ee1e9d3edd","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2022-10-10 21:22:32.000000000","message":"Patch Set 3: Autosubmit+1","accounts_in_message":[],"_revision_number":3},{"id":"02f0359200804def9fc8ad41c81447d741e9fc7a","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2022-10-10 21:22:32.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* tvix/eval/src/builtins/impure.rs\n* tvix/eval/src/compiler/mod.rs\n* tvix/eval/src/value/thunk.rs\n* tvix/eval/src/vm.rs\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":3},{"id":"0c767de4121e1769ac06acb6d51728d3a4801420","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-10 21:35:01.000000000","message":"Patch Set 3: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"12c546e01cc18a54bda1dcab5fce4edfae8e2273","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2022-10-10 21:53:35.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"97af1bc548697affd144651df887d7c61ff62d2b","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-10 21:53:38.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/17371","accounts_in_message":[],"_revision_number":4},{"id":"753196feab71805a22115cb4a724c1a5b1f49365","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-10 21:55:54.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/17371","accounts_in_message":[],"_revision_number":4},{"id":"cd33fe0f256b0ec3b4f1f65d31d19f0009467b52","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2022-10-10 21:59:53.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"b46a14610889ea2d9bf119be04e8ec261650aa22","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-10 21:59:56.000000000","message":"Patch Set 5:\n\nStarted build for patchset #5 on: https://buildkite.com/tvl/depot/builds/17374","accounts_in_message":[],"_revision_number":5},{"id":"05a31e5648a6040fb5f70be8bedbb9c4f1921d7b","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-10 22:02:12.000000000","message":"Patch Set 5: Verified+1\n\nBuild of patchset 5 passed: https://buildkite.com/tvl/depot/builds/17374","accounts_in_message":[],"_revision_number":5},{"id":"fdb723c523dd8065a97635f6e2d80016f6cb6a0a","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-10-10 23:45:03.000000000","message":"Patch Set 5: Code-Review+2\n\nBy voting Code-Review+2 the following files are now code-owner approved by \u003cGERRIT_ACCOUNT_1000001\u003e:\n* tvix/eval/src/builtins/impure.rs\n* tvix/eval/src/compiler/mod.rs\n* tvix/eval/src/value/thunk.rs\n* tvix/eval/src/vm.rs\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":5},{"id":"cc3744e31c2d093b76f2ee36431c3bfd3fa9c31b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2022-10-10 23:45:11.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"c5bfebaad405f04ab0f9bb44d4585a7f36ae9839","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-10 23:45:13.000000000","message":"Patch Set 6:\n\nStarted build for patchset #6 on: https://buildkite.com/tvl/depot/builds/17390","accounts_in_message":[],"_revision_number":6},{"id":"face4c97ece85fd700b2294b6f1a06505f9dd5e5","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-10 23:47:35.000000000","message":"Patch Set 6: Verified+1\n\nBuild of patchset 6 passed: https://buildkite.com/tvl/depot/builds/17390","accounts_in_message":[],"_revision_number":6},{"id":"a2e3dedbca08b9e91e18a0145ee894d81a8d8017","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2022-10-10 23:51:09.000000000","message":"Change has been successfully rebased and submitted as 06ec4bebe7e3a9a06a7f300f0a9f7c090d809f08\n\n5 is the latest approved patch-set.\nThe change was submitted with unreviewed changes in the following files:\n\n```\nThe name of the file: tvix/eval/src/value/thunk.rs\nInsertions: 7, Deletions: 7.\n\n@@ -95,13 +95,13 @@\n                         std::mem::replace(\u0026mut *thunk_mut, ThunkRepr::Blackhole)\n                     {\n                         drop(thunk_mut);\n-                        let evaluated \u003d\n-                            ThunkRepr::Evaluated(vm.call(lambda, upvalues, 0).map_err(|e| {\n-                                ErrorKind::ThunkForce(Box::new(Error {\n-                                    span: self.span,\n-                                    ..e\n-                                }))\n-                            })?);\n+                        vm.enter_frame(lambda, upvalues, 0).map_err(|e| {\n+                            ErrorKind::ThunkForce(Box::new(Error {\n+                                span: self.span,\n+                                ..e\n+                            }))\n+                        })?;\n+                        let evaluated \u003d ThunkRepr::Evaluated(vm.pop());\n                         (*self.inner.borrow_mut()) \u003d evaluated;\n                     }\n                 }\n```\n","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"06ec4bebe7e3a9a06a7f300f0a9f7c090d809f08","revisions":{"c87726177d819d637f865c2a0417d031309b20d9":{"kind":"REWORK","_number":1,"created":"2022-10-10 20:54:19.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/32/6932/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/32/6932/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/32/6932/1"}}},"commit":{"parents":[{"commit":"02dfa8a45a564017478bce7861ddd764765ad850","subject":"feat(tvix/eval): Implement builtins.removeAttrs","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d02dfa8a45a564017478bce7861ddd764765ad850"}]}],"author":{"name":"Griffin Smith","email":"root@gws.fyi","date":"2022-10-10 20:50:28.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"root@gws.fyi","date":"2022-10-10 20:54:16.000000000","tz":-240},"subject":"fix(tvix/eval): Actually trace spans for thunks","message":"fix(tvix/eval): Actually trace spans for thunks\n\nCurrently, the span on *all* thunk force errors is the span at which the\nthunk is forced, which for recursive thunk forcing ends up just being\nthe same span over and over again. This changes the span on thunk force\nerrors to be the span at which point the thunk is *created*, which is a\nbit more helpful (though the printing atm is a little... crowded). To\nmake this work, we have to thread through the span at which a thunk is\ncreated into a field on the thunk itself.\n\nChange-Id: I81474810a763046e2eb3a8f07acf7d8ec708824a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc87726177d819d637f865c2a0417d031309b20d9"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc87726177d819d637f865c2a0417d031309b20d9"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"02dfa8a45a564017478bce7861ddd764765ad850","is_merged_in_target_branch":false,"change_id":"I28910991a0108436a42ac7bf3458f9180a44154e","change_number":6928,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"7c0c3a8499c62875cc0d492aa679bb7804d18187":{"kind":"NO_CHANGE","_number":2,"created":"2022-10-10 20:58:37.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/32/6932/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/32/6932/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/32/6932/2"}}},"commit":{"parents":[{"commit":"3c30844f5f004e043f18c9f60b01d95037ab65bc","subject":"feat(tvix/eval): Implement builtins.removeAttrs","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3c30844f5f004e043f18c9f60b01d95037ab65bc"}]}],"author":{"name":"Griffin Smith","email":"root@gws.fyi","date":"2022-10-10 20:50:28.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"root@gws.fyi","date":"2022-10-10 20:58:30.000000000","tz":-240},"subject":"fix(tvix/eval): Actually trace spans for thunks","message":"fix(tvix/eval): Actually trace spans for thunks\n\nCurrently, the span on *all* thunk force errors is the span at which the\nthunk is forced, which for recursive thunk forcing ends up just being\nthe same span over and over again. This changes the span on thunk force\nerrors to be the span at which point the thunk is *created*, which is a\nbit more helpful (though the printing atm is a little... crowded). To\nmake this work, we have to thread through the span at which a thunk is\ncreated into a field on the thunk itself.\n\nChange-Id: I81474810a763046e2eb3a8f07acf7d8ec708824a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7c0c3a8499c62875cc0d492aa679bb7804d18187"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7c0c3a8499c62875cc0d492aa679bb7804d18187"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3c30844f5f004e043f18c9f60b01d95037ab65bc","is_merged_in_target_branch":false,"change_id":"I28910991a0108436a42ac7bf3458f9180a44154e","change_number":6928,"patch_set_number":8,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"cb1968709fbe0e4fd2b5a4f9e409e98400c56adb":{"kind":"REWORK","_number":3,"created":"2022-10-10 21:11:10.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/32/6932/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/32/6932/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/32/6932/3"}}},"commit":{"parents":[{"commit":"3c30844f5f004e043f18c9f60b01d95037ab65bc","subject":"feat(tvix/eval): Implement builtins.removeAttrs","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3c30844f5f004e043f18c9f60b01d95037ab65bc"}]}],"author":{"name":"Griffin Smith","email":"root@gws.fyi","date":"2022-10-10 20:50:28.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"root@gws.fyi","date":"2022-10-10 21:11:07.000000000","tz":-240},"subject":"fix(tvix/eval): Actually trace spans for thunks","message":"fix(tvix/eval): Actually trace spans for thunks\n\nCurrently, the span on *all* thunk force errors is the span at which the\nthunk is forced, which for recursive thunk forcing ends up just being\nthe same span over and over again. This changes the span on thunk force\nerrors to be the span at which point the thunk is *created*, which is a\nbit more helpful (though the printing atm is a little... crowded). To\nmake this work, we have to thread through the span at which a thunk is\ncreated into a field on the thunk itself.\n\nChange-Id: I81474810a763046e2eb3a8f07acf7d8ec708824a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcb1968709fbe0e4fd2b5a4f9e409e98400c56adb"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcb1968709fbe0e4fd2b5a4f9e409e98400c56adb"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3c30844f5f004e043f18c9f60b01d95037ab65bc","is_merged_in_target_branch":false,"change_id":"I28910991a0108436a42ac7bf3458f9180a44154e","change_number":6928,"patch_set_number":8,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"04d10958c6aabd9cdc4e6b4de60eef7aca8f8f43":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2022-10-10 21:53:35.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/32/6932/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/32/6932/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/32/6932/4"}}},"commit":{"parents":[{"commit":"d4095b256f4ba91f27990f989fb7ab9885230206","subject":"feat(tvix/eval): Implement builtins.removeAttrs","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd4095b256f4ba91f27990f989fb7ab9885230206"}]}],"author":{"name":"Griffin Smith","email":"root@gws.fyi","date":"2022-10-10 20:50:28.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"root@gws.fyi","date":"2022-10-10 21:53:09.000000000","tz":-240},"subject":"fix(tvix/eval): Actually trace spans for thunks","message":"fix(tvix/eval): Actually trace spans for thunks\n\nCurrently, the span on *all* thunk force errors is the span at which the\nthunk is forced, which for recursive thunk forcing ends up just being\nthe same span over and over again. This changes the span on thunk force\nerrors to be the span at which point the thunk is *created*, which is a\nbit more helpful (though the printing atm is a little... crowded). To\nmake this work, we have to thread through the span at which a thunk is\ncreated into a field on the thunk itself.\n\nChange-Id: I81474810a763046e2eb3a8f07acf7d8ec708824a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d04d10958c6aabd9cdc4e6b4de60eef7aca8f8f43"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d04d10958c6aabd9cdc4e6b4de60eef7aca8f8f43"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"d4095b256f4ba91f27990f989fb7ab9885230206","is_merged_in_target_branch":false,"change_id":"I28910991a0108436a42ac7bf3458f9180a44154e","change_number":6928,"patch_set_number":9,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"47e02866ef67d2aee8c6cb241557071d4f72b9cc":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2022-10-10 21:59:53.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/32/6932/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/32/6932/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/32/6932/5"}}},"commit":{"parents":[{"commit":"36a519370eb20df770f2deaa8e758165d15a0c90","subject":"feat(tvix/eval): Implement builtins.removeAttrs","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d36a519370eb20df770f2deaa8e758165d15a0c90"}]}],"author":{"name":"Griffin Smith","email":"root@gws.fyi","date":"2022-10-10 20:50:28.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"root@gws.fyi","date":"2022-10-10 21:59:50.000000000","tz":-240},"subject":"fix(tvix/eval): Actually trace spans for thunks","message":"fix(tvix/eval): Actually trace spans for thunks\n\nCurrently, the span on *all* thunk force errors is the span at which the\nthunk is forced, which for recursive thunk forcing ends up just being\nthe same span over and over again. This changes the span on thunk force\nerrors to be the span at which point the thunk is *created*, which is a\nbit more helpful (though the printing atm is a little... crowded). To\nmake this work, we have to thread through the span at which a thunk is\ncreated into a field on the thunk itself.\n\nChange-Id: I81474810a763046e2eb3a8f07acf7d8ec708824a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d47e02866ef67d2aee8c6cb241557071d4f72b9cc"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d47e02866ef67d2aee8c6cb241557071d4f72b9cc"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"36a519370eb20df770f2deaa8e758165d15a0c90","is_merged_in_target_branch":false,"change_id":"I28910991a0108436a42ac7bf3458f9180a44154e","change_number":6928,"patch_set_number":10,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"d0b8b757d8e2127f9c1ecec0e3c75a0afd2108cd":{"kind":"REWORK","_number":6,"created":"2022-10-10 23:45:11.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/32/6932/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/32/6932/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/32/6932/6"}}},"commit":{"parents":[{"commit":"90ec632fd11a8767954f064a9344af8830d9fdc6","subject":"feat(tvix/eval): Implement builtins.getEnv","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d90ec632fd11a8767954f064a9344af8830d9fdc6"}]}],"author":{"name":"Griffin Smith","email":"root@gws.fyi","date":"2022-10-10 20:50:28.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"root@gws.fyi","date":"2022-10-10 23:45:07.000000000","tz":-240},"subject":"fix(tvix/eval): Actually trace spans for thunks","message":"fix(tvix/eval): Actually trace spans for thunks\n\nCurrently, the span on *all* thunk force errors is the span at which the\nthunk is forced, which for recursive thunk forcing ends up just being\nthe same span over and over again. This changes the span on thunk force\nerrors to be the span at which point the thunk is *created*, which is a\nbit more helpful (though the printing atm is a little... crowded). To\nmake this work, we have to thread through the span at which a thunk is\ncreated into a field on the thunk itself.\n\nChange-Id: I81474810a763046e2eb3a8f07acf7d8ec708824a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd0b8b757d8e2127f9c1ecec0e3c75a0afd2108cd"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd0b8b757d8e2127f9c1ecec0e3c75a0afd2108cd"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"90ec632fd11a8767954f064a9344af8830d9fdc6","is_merged_in_target_branch":true,"change_id":"I09f512a60989a37184e73e521d4a3aa23f33a1a8","change_number":6922,"patch_set_number":17,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"06ec4bebe7e3a9a06a7f300f0a9f7c090d809f08":{"kind":"NO_CODE_CHANGE","_number":7,"created":"2022-10-10 23:51:09.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/32/6932/7","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/32/6932/7","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/32/6932/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/32/6932/7"}}},"commit":{"parents":[{"commit":"90ec632fd11a8767954f064a9344af8830d9fdc6","subject":"feat(tvix/eval): Implement builtins.getEnv","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d90ec632fd11a8767954f064a9344af8830d9fdc6"}]}],"author":{"name":"Griffin Smith","email":"root@gws.fyi","date":"2022-10-10 20:50:28.000000000","tz":-240},"committer":{"name":"grfn","email":"grfn@gws.fyi","date":"2022-10-10 23:51:09.000000000","tz":0},"subject":"fix(tvix/eval): Actually trace spans for thunks","message":"fix(tvix/eval): Actually trace spans for thunks\n\nCurrently, the span on *all* thunk force errors is the span at which the\nthunk is forced, which for recursive thunk forcing ends up just being\nthe same span over and over again. This changes the span on thunk force\nerrors to be the span at which point the thunk is *created*, which is a\nbit more helpful (though the printing atm is a little... crowded). To\nmake this work, we have to thread through the span at which a thunk is\ncreated into a field on the thunk itself.\n\nChange-Id: I81474810a763046e2eb3a8f07acf7d8ec708824a\nReviewed-on: https://cl.tvl.fyi/c/depot/+/6932\nAutosubmit: grfn \u003cgrfn@gws.fyi\u003e\nReviewed-by: Adam Joseph \u003cadam@westernsemico.com\u003e\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d06ec4bebe7e3a9a06a7f300f0a9f7c090d809f08"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d06ec4bebe7e3a9a06a7f300f0a9f7c090d809f08"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"90ec632fd11a8767954f064a9344af8830d9fdc6","is_merged_in_target_branch":true,"change_id":"I09f512a60989a37184e73e521d4a3aa23f33a1a8","change_number":6922,"patch_set_number":17,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}