)]}'
{"id":"depot~6947","triplet_id":"depot~canon~I34edf6fc3031fc1485c3e714f2280b4fba8f004b","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2022-10-11 15:53:29.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2022-10-11 15:53:29.000000000","reason":"Change was submitted"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2022-10-11 15:26:12.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I34edf6fc3031fc1485c3e714f2280b4fba8f004b","subject":"fix(tvix/eval/builtins): force acc not list element in foldl\u0027","status":"MERGED","created":"2022-10-11 12:47:00.000000000","updated":"2022-10-11 15:53:29.000000000","submitted":"2022-10-11 15:53:29.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6947","meta_rev_id":"2a34bc9b646ce96722e45ca556242586f6a12694","_number":6947,"virtual_id_number":6947,"owner":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-10-11 15:53:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-11 15:53:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-11 15:53:29.000000000","_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-10-11 12:47:02.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-10-11 12:47:46.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2022-10-11 12:47:46.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2022-10-11 12:49:05.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-10-11 15:53:29.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5d433abd6bc97a62e7254fb57eb2db310a54c2bd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-10-11 12:47:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c08d5c12d3488ecedc050b9751773b44eed79ac0","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-11 12:47:02.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/17424","accounts_in_message":[],"_revision_number":1},{"id":"4cab9806c325b71cecf7678b8993637ea4159ab2","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-10-11 12:47:46.000000000","message":"Patch Set 1: Autosubmit+1","accounts_in_message":[],"_revision_number":1},{"id":"738443e565ad25c08cbd67b9d342199984e0b103","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-10-11 12:47:46.000000000","message":"\u003cGERRIT_ACCOUNT_1000010\u003e, who was added as reviewer owns the following files:\n* tvix/eval/docs/language-issues.md\n* tvix/eval/src/builtins/mod.rs\n* tvix/eval/src/tests/tvix_tests/eval-okay-foldlStrict-lazy-elements.exp\n* tvix/eval/src/tests/tvix_tests/eval-okay-foldlStrict-lazy-elements.nix\n\n\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* tvix/eval/docs/language-issues.md\n* tvix/eval/src/builtins/mod.rs\n* tvix/eval/src/tests/tvix_tests/eval-okay-foldlStrict-lazy-elements.exp\n* tvix/eval/src/tests/tvix_tests/eval-okay-foldlStrict-lazy-elements.nix\n","accounts_in_message":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":1},{"id":"37878032ffb28acdc62047eb23e77ef135cbf1eb","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-11 12:49:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/17424","accounts_in_message":[],"_revision_number":1},{"id":"7fe31413d62a8951c8943355b548d1f2ee1e30c6","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2022-10-11 15:26:12.000000000","message":"Patch Set 1: Code-Review+2\n\nBy voting Code-Review+2 the following files are now code-owner approved by \u003cGERRIT_ACCOUNT_1000010\u003e:\n* tvix/eval/docs/language-issues.md\n* tvix/eval/src/builtins/mod.rs\n* tvix/eval/src/tests/tvix_tests/eval-okay-foldlStrict-lazy-elements.exp\n* tvix/eval/src/tests/tvix_tests/eval-okay-foldlStrict-lazy-elements.nix\n","accounts_in_message":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"_revision_number":1},{"id":"8414efaf9bbb0a938f568e73c3aa9f068329297f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-10-11 15:51:12.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"fbe098ec828cc4f14d83b9b9bf121bac05a6a2ee","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-11 15:51:14.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/17425","accounts_in_message":[],"_revision_number":2},{"id":"541f5fa56505db24e3fa94600bafeee1c0adaa55","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-11 15:53:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/17425","accounts_in_message":[],"_revision_number":2},{"id":"2a34bc9b646ce96722e45ca556242586f6a12694","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2022-10-11 15:53:29.000000000","message":"Change has been successfully rebased and submitted as fcd5e5370320d934f371bb96069a4719e94aafcd\n\n1 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"fcd5e5370320d934f371bb96069a4719e94aafcd","revisions":{"0a69e14ef36d58f371d5e0cb8a6626664ed56478":{"kind":"REWORK","_number":1,"created":"2022-10-11 12:47:00.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/47/6947/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/47/6947/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6947/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6947/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6947/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/47/6947/1"}}},"commit":{"parents":[{"commit":"6a5b443abdf9ad3622b0fc16410161770c2af4a5","subject":"fix(nix/buildGo): fix for Nix \u003e\u003d 2.6 readFile changes","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6a5b443abdf9ad3622b0fc16410161770c2af4a5"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-10-11 12:34:30.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-10-11 12:44:26.000000000","tz":120},"subject":"fix(tvix/eval/builtins): force acc not list element in foldl\u0027","message":"fix(tvix/eval/builtins): force acc not list element in foldl\u0027\n\nWhen investigating discrepancies between foldl\u0027 in tvix and C++ Nix,\nI discovered that C++ Nix\u0027s foldl\u0027 doesn\u0027t seem to be strict at all.\nSince this seemed wrong, I looked into Haskell\u0027s foldl\u0027 implementation\nwhich doesn\u0027t force the list elements (`val` in our code), but the\naccumulation value (`res` in our code). You can look at the code here:\nhttps://hackage.haskell.org/package/base-4.17.0.0/docs/src/GHC.List.html#foldl%27\n\nThis actually makes a lot of sense: If `res` is not forced after each\napplication of `op`, we\u0027ll end up thunks nested as deeply as the list is\nlong, potentially taking up a lot of space. This can be limited by\nforcing the `res` thunk before applying `op` again (and creating a new\nthunk).\n\nI\u0027ve also PR-ed an equivalent change for C++ Nix at\nhttps://github.com/NixOS/nix/pull/7158. Since this is not merged nor\nbackported to our Nix 2.3 fork, I\u0027ve not copied the eval fail test yet,\nsince it wouldn\u0027t when checking our tests against C++ Nix in depot.\n\nChange-Id: I34edf6fc3031fc1485c3e714f2280b4fba8f004b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0a69e14ef36d58f371d5e0cb8a6626664ed56478"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0a69e14ef36d58f371d5e0cb8a6626664ed56478"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6a5b443abdf9ad3622b0fc16410161770c2af4a5","is_merged_in_target_branch":false,"change_id":"I593f1ef513502691119428d26d508a5f4d378543","change_number":6946,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"39145a94b0b1e69fd482b2becab154c25b5f8800":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-10-11 15:51:12.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/47/6947/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/47/6947/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6947/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6947/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6947/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/47/6947/2"}}},"commit":{"parents":[{"commit":"b319e008313d68f2639de0f656d346ed9a823e41","subject":"fix(nix/buildkite): split extra steps based on all known phases","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db319e008313d68f2639de0f656d346ed9a823e41"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-10-11 12:34:30.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-10-11 15:51:12.000000000","tz":0},"subject":"fix(tvix/eval/builtins): force acc not list element in foldl\u0027","message":"fix(tvix/eval/builtins): force acc not list element in foldl\u0027\n\nWhen investigating discrepancies between foldl\u0027 in tvix and C++ Nix,\nI discovered that C++ Nix\u0027s foldl\u0027 doesn\u0027t seem to be strict at all.\nSince this seemed wrong, I looked into Haskell\u0027s foldl\u0027 implementation\nwhich doesn\u0027t force the list elements (`val` in our code), but the\naccumulation value (`res` in our code). You can look at the code here:\nhttps://hackage.haskell.org/package/base-4.17.0.0/docs/src/GHC.List.html#foldl%27\n\nThis actually makes a lot of sense: If `res` is not forced after each\napplication of `op`, we\u0027ll end up thunks nested as deeply as the list is\nlong, potentially taking up a lot of space. This can be limited by\nforcing the `res` thunk before applying `op` again (and creating a new\nthunk).\n\nI\u0027ve also PR-ed an equivalent change for C++ Nix at\nhttps://github.com/NixOS/nix/pull/7158. Since this is not merged nor\nbackported to our Nix 2.3 fork, I\u0027ve not copied the eval fail test yet,\nsince it wouldn\u0027t when checking our tests against C++ Nix in depot.\n\nChange-Id: I34edf6fc3031fc1485c3e714f2280b4fba8f004b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d39145a94b0b1e69fd482b2becab154c25b5f8800"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d39145a94b0b1e69fd482b2becab154c25b5f8800"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b319e008313d68f2639de0f656d346ed9a823e41","is_merged_in_target_branch":true,"change_id":"Iab0f2dc3eadda281e483055e26f00a95442e15b0","change_number":6942,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"},"fcd5e5370320d934f371bb96069a4719e94aafcd":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2022-10-11 15:53:29.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/47/6947/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/47/6947/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6947/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6947/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/47/6947/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/47/6947/3"}}},"commit":{"parents":[{"commit":"b319e008313d68f2639de0f656d346ed9a823e41","subject":"fix(nix/buildkite): split extra steps based on all known phases","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db319e008313d68f2639de0f656d346ed9a823e41"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-10-11 12:34:30.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2022-10-11 15:53:29.000000000","tz":0},"subject":"fix(tvix/eval/builtins): force acc not list element in foldl\u0027","message":"fix(tvix/eval/builtins): force acc not list element in foldl\u0027\n\nWhen investigating discrepancies between foldl\u0027 in tvix and C++ Nix,\nI discovered that C++ Nix\u0027s foldl\u0027 doesn\u0027t seem to be strict at all.\nSince this seemed wrong, I looked into Haskell\u0027s foldl\u0027 implementation\nwhich doesn\u0027t force the list elements (`val` in our code), but the\naccumulation value (`res` in our code). You can look at the code here:\nhttps://hackage.haskell.org/package/base-4.17.0.0/docs/src/GHC.List.html#foldl%27\n\nThis actually makes a lot of sense: If `res` is not forced after each\napplication of `op`, we\u0027ll end up thunks nested as deeply as the list is\nlong, potentially taking up a lot of space. This can be limited by\nforcing the `res` thunk before applying `op` again (and creating a new\nthunk).\n\nI\u0027ve also PR-ed an equivalent change for C++ Nix at\nhttps://github.com/NixOS/nix/pull/7158. Since this is not merged nor\nbackported to our Nix 2.3 fork, I\u0027ve not copied the eval fail test yet,\nsince it wouldn\u0027t when checking our tests against C++ Nix in depot.\n\nChange-Id: I34edf6fc3031fc1485c3e714f2280b4fba8f004b\nReviewed-on: https://cl.tvl.fyi/c/depot/+/6947\nAutosubmit: sterni \u003csternenseemann@systemli.org\u003e\nReviewed-by: grfn \u003cgrfn@gws.fyi\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfcd5e5370320d934f371bb96069a4719e94aafcd"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfcd5e5370320d934f371bb96069a4719e94aafcd"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b319e008313d68f2639de0f656d346ed9a823e41","is_merged_in_target_branch":true,"change_id":"Iab0f2dc3eadda281e483055e26f00a95442e15b0","change_number":6942,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}