)]}'
{"id":"depot~6986","triplet_id":"depot~canon~I947f504b2af5a7fee8cf0cb301421d2fc9174ce1","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000066":{"account":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"last_update":"2022-10-24 12:20:01.000000000","reason":"Change was submitted"},"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2022-10-24 12:20:01.000000000","reason":"Change was submitted"},"1000018":{"account":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"last_update":"2022-10-24 12:20:01.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2022-10-14 08:41:43.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2022-10-24 12:20:01.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I947f504b2af5a7fee8cf0cb301421d2fc9174ce1","subject":"feat(tvix/eval): implement builtins.currentSystem","status":"MERGED","created":"2022-10-12 09:28:03.000000000","updated":"2022-10-24 12:20:01.000000000","submitted":"2022-10-24 12:20:01.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":59,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6986","meta_rev_id":"68a398525514e383d1b06ff856a8e68fb0100296","_number":6986,"virtual_id_number":6986,"owner":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-10-24 12:20:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-24 12:20:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"reviewers":{"CC":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}],"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-10-12 09:28:03.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-10-12 09:30:08.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-10-12 09:50:52.000000000","updated_by":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2022-10-12 09:50:52.000000000","updated_by":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2022-10-12 09:53:49.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"state":"REVIEWER"},{"updated":"2022-10-12 11:31:39.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"state":"CC"}],"messages":[{"id":"65d14a893f9538f3e0e8012d01a5155779a5862a","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-12 09:28:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5d1e7b051cd9c465f440d88b99b1ec50324d9c43","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-12 09:28:03.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/17451","accounts_in_message":[],"_revision_number":1},{"id":"2a77e95345e19a7d2bb18390513c2901db82d7d3","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-12 09:30:08.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/17451","accounts_in_message":[],"_revision_number":1},{"id":"5d2d7f7402d66578ea64d7669d327b3918e422a2","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-12 09:48:28.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"76f57d8aaf50a8920b13b9e5d2f254dbd2c09431","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-12 09:48:29.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/17453","accounts_in_message":[],"_revision_number":2},{"id":"3db0e5aae2cbd86cf0448980076df6c900215fd0","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-12 09:50:32.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/17453","accounts_in_message":[],"_revision_number":2},{"id":"b1dcd596d1c6ed502c0f1baa6e8bbbe1ea240a76","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-12 09:50:52.000000000","message":"Patch Set 2:\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":2},{"id":"4a9073d1576616152bb7c4dab63e852bfa9a6306","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-12 09:50:52.000000000","message":"\u003cGERRIT_ACCOUNT_1000010\u003e, who was added as reviewer owns the following files:\n* tvix/eval/build.rs\n* tvix/eval/src/builtins/mod.rs\n\n\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* tvix/eval/build.rs\n* tvix/eval/src/builtins/mod.rs\n","accounts_in_message":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":2},{"id":"eb7482469a46e653b6d281dba3b372e0b6392261","author":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"date":"2022-10-12 11:16:46.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"b103bcbedaa1c6419a64a2510328371cf61185fd","author":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"date":"2022-10-12 11:28:08.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"79e8672e22597dd6c3d96aa07dffa7910cf129a5","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-10-12 11:31:39.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"8508f17698c4646a02a5ad7e19e0e5b4eaa4a69e","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-10-12 11:32:51.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"846d83a9837c71b01b15b2c349af8993275fa080","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-10-12 11:33:29.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1bfd356c723cd4157ad4fd608bad2e967bc2d6b5","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-12 18:43:46.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8befe1f7578d4c8938559ca51bd47081c12fcefd","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-13 03:33:27.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8bc1221299365d3d3f690f754a3a33f0716a357d","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-13 04:11:18.000000000","message":"Patch Set 2:\n\n(5 comments)","accounts_in_message":[],"_revision_number":2},{"id":"f11f873b90ba3c4ccad6611c5b658211ed74e5a6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-13 04:13:14.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"956ef0d0cbc79e185a4cdc6c2e118751d778ac83","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-13 04:13:15.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/17475","accounts_in_message":[],"_revision_number":3},{"id":"d0f4b66699283b4d1f4ef7ff301fd71818a1e89b","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-13 04:13:21.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b9faf3aac8cdad4143f7053713e33efb9282e140","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-13 04:13:42.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"64e56932e34af98b86ed92955ef207ca0ec5b0e9","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-13 04:15:19.000000000","message":"Patch Set 3: Verified-1\n\nBuild of patchset 3 failed: https://buildkite.com/tvl/depot/builds/17475","accounts_in_message":[],"_revision_number":3},{"id":"d7df313077a0ab852efb8a2024d1e451f8a1e347","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-13 04:16:20.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"b258c809ba43dcf0670b1e9432c13cf13299e776","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-13 04:17:14.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"4438b795e3677beb5f9a33ca5d1111f392e0c517","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-13 04:17:14.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/17476","accounts_in_message":[],"_revision_number":4},{"id":"b8a010e8a4dc9cb846711979777ba7f1ca792b01","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-13 04:19:17.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/17476","accounts_in_message":[],"_revision_number":4},{"id":"68672ce5c895af6a64184a81fdf2e74de6d688d0","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-13 18:23:00.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"dcfa3fb75179804f72071481259249c6f071a527","author":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"date":"2022-10-13 19:17:53.000000000","message":"Patch Set 4:\n\n(9 comments)","accounts_in_message":[],"_revision_number":4},{"id":"2f5ea0b648a05f75b2351da4ec044fafd4246061","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-13 19:32:38.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"879ff5bc325e8a6c46cc15cc33f9dddf358a15d8","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-13 19:32:38.000000000","message":"Patch Set 5:\n\nStarted build for patchset #5 on: https://buildkite.com/tvl/depot/builds/17529","accounts_in_message":[],"_revision_number":5},{"id":"10c2427a2df0a6aa778c9e81fa62eeeee1c92b6b","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-13 19:32:39.000000000","message":"Patch Set 4:\n\n(8 comments)","accounts_in_message":[],"_revision_number":4},{"id":"aef30b3f4eddf46128389ab4f3de5627af582d3f","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-13 19:34:47.000000000","message":"Patch Set 5: Verified+1\n\nBuild of patchset 5 passed: https://buildkite.com/tvl/depot/builds/17529","accounts_in_message":[],"_revision_number":5},{"id":"685be5d01abd33853ebfe702f111c8cc2792baae","author":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"date":"2022-10-13 20:22:08.000000000","message":"Patch Set 5:\n\n(3 comments)","accounts_in_message":[],"_revision_number":5},{"id":"d42363bb652b59021d466b629461aed19ab61be7","author":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"date":"2022-10-13 20:23:15.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"e4516ee93a99c8c6f253e7250ef333d05ac0391f","author":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"date":"2022-10-13 20:25:28.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"9efe5df82aabaeef9075b5a52d703d7ac27afeac","author":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"date":"2022-10-13 20:29:47.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"2224fcc0a8f3c049ad37e3ae4334edb0cbe79d84","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-10-14 08:41:43.000000000","message":"Patch Set 5: Code-Review+2\n\n(1 comment)\n\nBy voting Code-Review+2 the following files are now code-owner approved by \u003cGERRIT_ACCOUNT_1000001\u003e:\n* tvix/eval/build.rs\n* tvix/eval/src/builtins/mod.rs\n* tvix/eval/src/lib.rs\n* tvix/eval/src/systems.rs\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":5},{"id":"f6cf4a85c625d41b702417b2f20063d43e4dec76","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-14 09:22:04.000000000","message":"Patch Set 5: Autosubmit+1","accounts_in_message":[],"_revision_number":5},{"id":"834156b5546bd1160b4b0bc2e444bea6fb8bf2e7","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-10-15 17:25:33.000000000","message":"Patch Set 5:\n\n(4 comments)","accounts_in_message":[],"_revision_number":5},{"id":"6894875e70170a985a61164797d8294cc28f2b6f","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-16 07:16:23.000000000","message":"Patch Set 5: -Autosubmit\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"2c6c9f9efef9f39b3c9a15aa35fcf5c0978a65fc","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-18 10:05:56.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"663423330574075cc6aa89bb9f97646fb8995612","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-10-24 12:14:27.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"20934dc789bb9ee3be51b94a6ff7344f05e6c47c","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-24 12:14:28.000000000","message":"Patch Set 6:\n\nStarted build for patchset #6 on: https://buildkite.com/tvl/depot/builds/17843","accounts_in_message":[],"_revision_number":6},{"id":"7f5ecf5b1cd088ae8e750e8170655ecc58ae5f9d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-24 12:16:33.000000000","message":"Patch Set 6: Verified+1\n\nBuild of patchset 6 passed: https://buildkite.com/tvl/depot/builds/17843","accounts_in_message":[],"_revision_number":6},{"id":"ad9e790dd0006599fa40d1b43d9d39679087a966","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-10-24 12:18:08.000000000","message":"Patch Set 6: Code-Review+2\n\n(7 comments)\n\nBy voting Code-Review+2 the following files are still explicitly code-owner approved by \u003cGERRIT_ACCOUNT_1000001\u003e:\n* tvix/eval/build.rs\n* tvix/eval/src/builtins/mod.rs\n* tvix/eval/src/lib.rs\n* tvix/eval/src/systems.rs\n* tvix/eval/src/tests/nix_tests/eval-okay-builtins.exp\n* tvix/eval/src/tests/nix_tests/eval-okay-builtins.nix\n* tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-builtins.exp\n* tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-builtins.nix\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":6},{"id":"68a398525514e383d1b06ff856a8e68fb0100296","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-10-24 12:20:01.000000000","message":"Change has been successfully rebased and submitted as f7ba502005d6376328e1e2591d70973d4f1d6b15","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"f7ba502005d6376328e1e2591d70973d4f1d6b15","revisions":{"8382ef5f29f73f2d396753776e8b9736ff824a36":{"kind":"REWORK","_number":1,"created":"2022-10-12 09:28:03.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/86/6986/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/86/6986/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/86/6986/1"}}},"commit":{"parents":[{"commit":"32ac7d6c6d06b5191fcc828b762b247b0e27dfda","subject":"refactor(tvix/eval) s/NixPath/NixSearchPath/","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d32ac7d6c6d06b5191fcc828b762b247b0e27dfda"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-10-12 09:26:40.000000000","tz":-420},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-10-12 09:26:40.000000000","tz":-420},"subject":"feat(tvix/eval): implement builtins.currentSystem","message":"feat(tvix/eval): implement builtins.currentSystem\n\nThis commit implements builtins.currentSystem, by capturing the\ncargo environment variable `TARGET` and exposing it to rustc as\n`TVIX_CURRENT_SYSTEM` so it can be inserted into the source code\nusing `env!()`.\n\nThe resulting value needs to be massaged a bit, since it is an \"LLVM\ntriple\".  The current code should work for the four \"supported\"\nnixpkgs platforms: linux/darwin on x86_64/aarch64.\n\nSigned-off-by: Adam Joseph \u003cadam@westernsemico.com\u003e\nChange-Id: I947f504b2af5a7fee8cf0cb301421d2fc9174ce1\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8382ef5f29f73f2d396753776e8b9736ff824a36"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8382ef5f29f73f2d396753776e8b9736ff824a36"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"32ac7d6c6d06b5191fcc828b762b247b0e27dfda","is_merged_in_target_branch":true,"change_id":"Ib2ea155c4b27cb90d6180a04ea7b951d86607373","change_number":6927,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"1811a8b94390e53b195d97fdd849787d577b78b0":{"kind":"REWORK","_number":2,"created":"2022-10-12 09:48:28.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/86/6986/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/86/6986/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/86/6986/2"}}},"commit":{"parents":[{"commit":"32ac7d6c6d06b5191fcc828b762b247b0e27dfda","subject":"refactor(tvix/eval) s/NixPath/NixSearchPath/","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d32ac7d6c6d06b5191fcc828b762b247b0e27dfda"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-10-12 09:26:40.000000000","tz":-420},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-10-12 09:49:17.000000000","tz":-420},"subject":"feat(tvix/eval): implement builtins.currentSystem","message":"feat(tvix/eval): implement builtins.currentSystem\n\nThis commit implements builtins.currentSystem, by capturing the\ncargo environment variable `TARGET` and exposing it to rustc as\n`TVIX_CURRENT_SYSTEM` so it can be inserted into the source code\nusing `env!()`.\n\nThe resulting value needs to be massaged a bit, since it is an \"LLVM\ntriple\".  The current code should work for the four \"supported\"\nnixpkgs platforms: linux/darwin on x86_64/aarch64.\n\nSigned-off-by: Adam Joseph \u003cadam@westernsemico.com\u003e\nChange-Id: I947f504b2af5a7fee8cf0cb301421d2fc9174ce1\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1811a8b94390e53b195d97fdd849787d577b78b0"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1811a8b94390e53b195d97fdd849787d577b78b0"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"32ac7d6c6d06b5191fcc828b762b247b0e27dfda","is_merged_in_target_branch":true,"change_id":"Ib2ea155c4b27cb90d6180a04ea7b951d86607373","change_number":6927,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f678aef53fd21d57e41deb73fda7609adfad0f62":{"kind":"REWORK","_number":3,"created":"2022-10-13 04:13:14.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/86/6986/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/86/6986/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/86/6986/3"}}},"commit":{"parents":[{"commit":"e83609a06195642f472b112ffa95f001fde8ef60","subject":"feat(tvix/eval): allow to disable warnings","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de83609a06195642f472b112ffa95f001fde8ef60"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-10-12 09:26:40.000000000","tz":-420},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-10-13 04:12:28.000000000","tz":-420},"subject":"feat(tvix/eval): implement builtins.currentSystem","message":"feat(tvix/eval): implement builtins.currentSystem\n\nThis commit implements builtins.currentSystem, by capturing the\ncargo environment variable `TARGET` and exposing it to rustc as\n`TVIX_CURRENT_SYSTEM` so it can be inserted into the source code\nusing `env!()`.\n\nThe resulting value needs to be massaged a bit, since it is an \"LLVM\ntriple\".  The current code should work for all the platforms for\nwhich cppnix works (thanks qyliss for generating the list!).  It\ndoes *not* reject all of the triples that cppnix\u0027s configure.ac\nrejects -- it is much more forgiving.  We can tighten this up in a\nfuture commit.\n\nSigned-off-by: Adam Joseph \u003cadam@westernsemico.com\u003e\nChange-Id: I947f504b2af5a7fee8cf0cb301421d2fc9174ce1\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df678aef53fd21d57e41deb73fda7609adfad0f62"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df678aef53fd21d57e41deb73fda7609adfad0f62"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e83609a06195642f472b112ffa95f001fde8ef60","is_merged_in_target_branch":true,"change_id":"I4b065f96fe15838afcca6970491a54e248ae4df7","change_number":6985,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"6ad6a255b953952f350407bea315b6887e10d983":{"kind":"REWORK","_number":4,"created":"2022-10-13 04:17:14.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/86/6986/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/86/6986/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/86/6986/4"}}},"commit":{"parents":[{"commit":"e83609a06195642f472b112ffa95f001fde8ef60","subject":"feat(tvix/eval): allow to disable warnings","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de83609a06195642f472b112ffa95f001fde8ef60"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-10-12 09:26:40.000000000","tz":-420},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-10-13 04:18:05.000000000","tz":-420},"subject":"feat(tvix/eval): implement builtins.currentSystem","message":"feat(tvix/eval): implement builtins.currentSystem\n\nThis commit implements builtins.currentSystem, by capturing the\ncargo environment variable `TARGET` and exposing it to rustc as\n`TVIX_CURRENT_SYSTEM` so it can be inserted into the source code\nusing `env!()`.\n\nThe resulting value needs to be massaged a bit, since it is an \"LLVM\ntriple\".  The current code should work for all the platforms for\nwhich cppnix works (thanks qyliss for generating the list!).  It\ndoes *not* reject all of the triples that cppnix\u0027s configure.ac\nrejects -- it is much more forgiving.  We can tighten this up in a\nfuture commit.\n\nSigned-off-by: Adam Joseph \u003cadam@westernsemico.com\u003e\nChange-Id: I947f504b2af5a7fee8cf0cb301421d2fc9174ce1\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6ad6a255b953952f350407bea315b6887e10d983"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6ad6a255b953952f350407bea315b6887e10d983"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e83609a06195642f472b112ffa95f001fde8ef60","is_merged_in_target_branch":true,"change_id":"I4b065f96fe15838afcca6970491a54e248ae4df7","change_number":6985,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f8d262004e0977ce4481fbc7484dcae6dd51ab41":{"kind":"REWORK","_number":5,"created":"2022-10-13 19:32:38.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/86/6986/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/86/6986/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/86/6986/5"}}},"commit":{"parents":[{"commit":"d4bc58b38d4ff5a58ea92f1ae8ac9c1290e1c741","subject":"docs(tvix/eval): explain where to find the site-specific `mg` tool","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd4bc58b38d4ff5a58ea92f1ae8ac9c1290e1c741"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-10-12 09:26:40.000000000","tz":-420},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-10-13 19:33:27.000000000","tz":-420},"subject":"feat(tvix/eval): implement builtins.currentSystem","message":"feat(tvix/eval): implement builtins.currentSystem\n\nThis commit implements builtins.currentSystem, by capturing the\ncargo environment variable `TARGET` and exposing it to rustc as\n`TVIX_CURRENT_SYSTEM` so it can be inserted into the source code\nusing `env!()`.\n\nThe resulting value needs to be massaged a bit, since it is an \"LLVM\ntriple\".  The current code should work for all the platforms for\nwhich cppnix works (thanks qyliss for generating the list!).  It\ndoes *not* reject all of the triples that cppnix\u0027s configure.ac\nrejects -- it is much more forgiving.  We can tighten this up in a\nfuture commit.\n\nSigned-off-by: Adam Joseph \u003cadam@westernsemico.com\u003e\nChange-Id: I947f504b2af5a7fee8cf0cb301421d2fc9174ce1\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df8d262004e0977ce4481fbc7484dcae6dd51ab41"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df8d262004e0977ce4481fbc7484dcae6dd51ab41"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"d4bc58b38d4ff5a58ea92f1ae8ac9c1290e1c741","is_merged_in_target_branch":true,"change_id":"Icb8c51087fd41b696794516abcfee24a4b3b4a14","change_number":6948,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"66aaa5670950c85cc3b180ed98ff2f8f66e93a8d":{"kind":"REWORK","_number":6,"created":"2022-10-24 12:14:27.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/86/6986/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/86/6986/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/86/6986/6"}}},"commit":{"parents":[{"commit":"e2f0967d3fd44cac78ac50425bc2dbe65fd4a8c4","subject":"feat(nix/eval): Implement builtins.groupBy","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de2f0967d3fd44cac78ac50425bc2dbe65fd4a8c4"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-10-12 09:26:40.000000000","tz":-420},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-10-24 12:13:11.000000000","tz":180},"subject":"feat(tvix/eval): implement builtins.currentSystem","message":"feat(tvix/eval): implement builtins.currentSystem\n\nThis commit implements builtins.currentSystem, by capturing the\ncargo environment variable `TARGET` and exposing it to rustc as\n`TVIX_CURRENT_SYSTEM` so it can be inserted into the source code\nusing `env!()`.\n\nThe resulting value needs to be massaged a bit, since it is an \"LLVM\ntriple\".  The current code should work for all the platforms for\nwhich cppnix works (thanks qyliss for generating the list!).  It\ndoes *not* reject all of the triples that cppnix\u0027s configure.ac\nrejects -- it is much more forgiving.  We can tighten this up in a\nfuture commit.\n\nSigned-off-by: Adam Joseph \u003cadam@westernsemico.com\u003e\nChange-Id: I947f504b2af5a7fee8cf0cb301421d2fc9174ce1\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d66aaa5670950c85cc3b180ed98ff2f8f66e93a8d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d66aaa5670950c85cc3b180ed98ff2f8f66e93a8d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e2f0967d3fd44cac78ac50425bc2dbe65fd4a8c4","is_merged_in_target_branch":true,"change_id":"I3e0aa017a7100cbeb86d2e5747471b36affcc102","change_number":7038,"patch_set_number":9,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f7ba502005d6376328e1e2591d70973d4f1d6b15":{"kind":"NO_CODE_CHANGE","_number":7,"created":"2022-10-24 12:20:01.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/86/6986/7","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/86/6986/7","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/86/6986/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/86/6986/7"}}},"commit":{"parents":[{"commit":"e2f0967d3fd44cac78ac50425bc2dbe65fd4a8c4","subject":"feat(nix/eval): Implement builtins.groupBy","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de2f0967d3fd44cac78ac50425bc2dbe65fd4a8c4"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-10-12 09:26:40.000000000","tz":-420},"committer":{"name":"tazjin","email":"tazjin@tvl.su","date":"2022-10-24 12:20:01.000000000","tz":0},"subject":"feat(tvix/eval): implement builtins.currentSystem","message":"feat(tvix/eval): implement builtins.currentSystem\n\nThis commit implements builtins.currentSystem, by capturing the\ncargo environment variable `TARGET` and exposing it to rustc as\n`TVIX_CURRENT_SYSTEM` so it can be inserted into the source code\nusing `env!()`.\n\nThe resulting value needs to be massaged a bit, since it is an \"LLVM\ntriple\".  The current code should work for all the platforms for\nwhich cppnix works (thanks qyliss for generating the list!).  It\ndoes *not* reject all of the triples that cppnix\u0027s configure.ac\nrejects -- it is much more forgiving.  We can tighten this up in a\nfuture commit.\n\nSigned-off-by: Adam Joseph \u003cadam@westernsemico.com\u003e\nChange-Id: I947f504b2af5a7fee8cf0cb301421d2fc9174ce1\nReviewed-on: https://cl.tvl.fyi/c/depot/+/6986\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df7ba502005d6376328e1e2591d70973d4f1d6b15"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df7ba502005d6376328e1e2591d70973d4f1d6b15"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e2f0967d3fd44cac78ac50425bc2dbe65fd4a8c4","is_merged_in_target_branch":true,"change_id":"I3e0aa017a7100cbeb86d2e5747471b36affcc102","change_number":7038,"patch_set_number":9,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}