)]}'
{"id":"depot~7024","triplet_id":"depot~canon~I30bd69b575667c49170a9fdea23a020565d0f9ec","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2022-10-16 19:11:23.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2022-10-16 19:11:23.000000000","reason":"Change was submitted"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2022-10-16 19:11:23.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I30bd69b575667c49170a9fdea23a020565d0f9ec","subject":"fix(tvix/eval): resolve home relative paths at runtime","status":"MERGED","created":"2022-10-15 15:22:46.000000000","updated":"2022-10-16 19:11:23.000000000","submitted":"2022-10-16 19:11:23.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7024","meta_rev_id":"4483473610a220229013c23f98bff60e0b4203eb","_number":7024,"virtual_id_number":7024,"owner":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-10-16 19:11:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-16 19:11:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-16 19:11:23.000000000","_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-10-15 15:22:48.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-10-15 15:23:58.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2022-10-15 15:23:58.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2022-10-15 15:24:55.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-10-16 07:04:06.000000000","updated_by":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"reviewer":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"state":"REVIEWER"},{"updated":"2022-10-16 19:11:23.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a8793bbf134271f12c820503233dd13112822765","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-10-15 15:22:46.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"e0d2d9610f9bc0c8b8f5ad4754de887d416a9cbf","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-15 15:22:48.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/17573","accounts_in_message":[],"_revision_number":1},{"id":"7288b21052846c2bd683aaf26ed1516882f2667c","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-10-15 15:23:58.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* tvix/eval/src/compiler/mod.rs\n* tvix/eval/src/opcode.rs\n* tvix/eval/src/vm.rs\n\n\u003cGERRIT_ACCOUNT_1000010\u003e, who was added as reviewer owns the following files:\n* tvix/eval/src/compiler/mod.rs\n* tvix/eval/src/opcode.rs\n* tvix/eval/src/vm.rs\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"_revision_number":1},{"id":"f853a88aa2c0bace1d93435eb925f5a98a9b970c","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-15 15:24:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/17573","accounts_in_message":[],"_revision_number":1},{"id":"55d0a3a48666521a29d0e2eb347350480376474b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-10-15 18:22:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"67e30383275f88722af2cb64a217c47f07559d27","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-15 18:22:40.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/17576","accounts_in_message":[],"_revision_number":2},{"id":"e5282d5dee1c50acce4773a9f722fc82bdd8e223","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-15 18:24:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/17576","accounts_in_message":[],"_revision_number":2},{"id":"c26758cfe86fc0776533481264dd675c7ed4ba8f","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-10-16 07:04:06.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b9e51be3d9e9c80317515f136d3c3d45d72bd814","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-10-16 12:37:52.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"fb2c14347034a1cf4f111875077f9c39eeb17f56","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-16 12:37:53.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/17611","accounts_in_message":[],"_revision_number":3},{"id":"64c79e627fa8aec2db0bdd8f46e020e9ff729f5d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-16 12:40:08.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/17611","accounts_in_message":[],"_revision_number":3},{"id":"4483473610a220229013c23f98bff60e0b4203eb","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2022-10-16 19:11:23.000000000","message":"Change has been successfully rebased and submitted as 4dcb8f38c2e442b6433b21b8a7de303736a04568\n\n2 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"4dcb8f38c2e442b6433b21b8a7de303736a04568","revisions":{"e4b22864a3b160b1f50371fa6ef32a11463fd278":{"kind":"REWORK","_number":1,"created":"2022-10-15 15:22:46.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/24/7024/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/24/7024/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/24/7024/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/24/7024/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/24/7024/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/24/7024/1"}}},"commit":{"parents":[{"commit":"795f2445bd563b1cd3d0e39cdc16d4aa29c735b9","subject":"refactor(tvix/eval): make OpFindFile use internal UnresolvedPath","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d795f2445bd563b1cd3d0e39cdc16d4aa29c735b9"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-10-15 14:42:27.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-10-15 15:22:44.000000000","tz":120},"subject":"fix(tvix/eval): resolve home relative paths at runtime","message":"fix(tvix/eval): resolve home relative paths at runtime\n\nHome relative paths depend on the environment to be resolved. We have\nelected to do everything that depends on the environment, e.g. resolving\nSPATH expressions using NIX_PATH, at runtime, so tvix evaluation would\ncontinue to behave correctly even if we separated the compilation and\nexecution phases more, e.g. via serializing bytecode. Then the value of\nHOME, NIX_PATH etc. could reasonably change in the time until execution,\nyielding wrong results if the resolution results were cached in the\nbytecode.\n\nWe also take the opportunity to fix the broken path concatenation\npreviously found in the compiler, fixing b/205.\n\nAnother thing we could consider is emitting a warning for home relative\npath literals, as they are by nature relatively fragile.\n\nOne sideeffect of this change is that home path resolution errors\nbecome catchable which is not the case in C++ Nix. This will need to be\nfixed up in a subsequent change.\n\nChange-Id: I30bd69b575667c49170a9fdea23a020565d0f9ec\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de4b22864a3b160b1f50371fa6ef32a11463fd278"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de4b22864a3b160b1f50371fa6ef32a11463fd278"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"795f2445bd563b1cd3d0e39cdc16d4aa29c735b9","is_merged_in_target_branch":false,"change_id":"I6acf287f35197cd9e13377079f972b9d36e5b22e","change_number":7023,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"c1957ce3d118a84c2f09cc6d6693806ed1e884c4":{"kind":"REWORK","_number":2,"created":"2022-10-15 18:22:39.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/24/7024/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/24/7024/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/24/7024/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/24/7024/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/24/7024/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/24/7024/2"}}},"commit":{"parents":[{"commit":"795f2445bd563b1cd3d0e39cdc16d4aa29c735b9","subject":"refactor(tvix/eval): make OpFindFile use internal UnresolvedPath","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d795f2445bd563b1cd3d0e39cdc16d4aa29c735b9"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-10-15 14:42:27.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-10-15 18:21:06.000000000","tz":120},"subject":"fix(tvix/eval): resolve home relative paths at runtime","message":"fix(tvix/eval): resolve home relative paths at runtime\n\nHome relative paths depend on the environment to be resolved. We have\nelected to do everything that depends on the environment, e.g. resolving\nSPATH expressions using NIX_PATH, at runtime, so tvix evaluation would\ncontinue to behave correctly even if we separated the compilation and\nexecution phases more, e.g. via serializing bytecode. Then the value of\nHOME, NIX_PATH etc. could reasonably change in the time until execution,\nyielding wrong results if the resolution results were cached in the\nbytecode.\n\nWe also take the opportunity to fix the broken path concatenation\npreviously found in the compiler, fixing b/205.\n\nAnother thing we could consider is emitting a warning for home relative\npath literals, as they are by nature relatively fragile.\n\nOne sideeffect of this change is that home path resolution errors\nbecome catchable which is not the case in C++ Nix. This will need to be\nfixed up in a subsequent change.\n\nChange-Id: I30bd69b575667c49170a9fdea23a020565d0f9ec\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc1957ce3d118a84c2f09cc6d6693806ed1e884c4"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc1957ce3d118a84c2f09cc6d6693806ed1e884c4"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"795f2445bd563b1cd3d0e39cdc16d4aa29c735b9","is_merged_in_target_branch":false,"change_id":"I6acf287f35197cd9e13377079f972b9d36e5b22e","change_number":7023,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"450179b7287401f0e3ab34f098e8b7d9fc93080e":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2022-10-16 12:37:52.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/24/7024/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/24/7024/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/24/7024/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/24/7024/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/24/7024/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/24/7024/3"}}},"commit":{"parents":[{"commit":"97018a6f0a5205f375545f4fad62ddc2ab05bca1","subject":"refactor(tvix/eval): make OpFindFile use internal UnresolvedPath","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d97018a6f0a5205f375545f4fad62ddc2ab05bca1"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-10-15 14:42:27.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-10-16 12:37:46.000000000","tz":120},"subject":"fix(tvix/eval): resolve home relative paths at runtime","message":"fix(tvix/eval): resolve home relative paths at runtime\n\nHome relative paths depend on the environment to be resolved. We have\nelected to do everything that depends on the environment, e.g. resolving\nSPATH expressions using NIX_PATH, at runtime, so tvix evaluation would\ncontinue to behave correctly even if we separated the compilation and\nexecution phases more, e.g. via serializing bytecode. Then the value of\nHOME, NIX_PATH etc. could reasonably change in the time until execution,\nyielding wrong results if the resolution results were cached in the\nbytecode.\n\nWe also take the opportunity to fix the broken path concatenation\npreviously found in the compiler, fixing b/205.\n\nAnother thing we could consider is emitting a warning for home relative\npath literals, as they are by nature relatively fragile.\n\nOne sideeffect of this change is that home path resolution errors\nbecome catchable which is not the case in C++ Nix. This will need to be\nfixed up in a subsequent change.\n\nChange-Id: I30bd69b575667c49170a9fdea23a020565d0f9ec\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d450179b7287401f0e3ab34f098e8b7d9fc93080e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d450179b7287401f0e3ab34f098e8b7d9fc93080e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"97018a6f0a5205f375545f4fad62ddc2ab05bca1","is_merged_in_target_branch":false,"change_id":"I6acf287f35197cd9e13377079f972b9d36e5b22e","change_number":7023,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"4dcb8f38c2e442b6433b21b8a7de303736a04568":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2022-10-16 19:11:23.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/24/7024/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/24/7024/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/24/7024/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/24/7024/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/24/7024/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/24/7024/4"}}},"commit":{"parents":[{"commit":"0624d78af0839cd8b290eb9cb6e5737f01162b96","subject":"refactor(tvix/eval): make OpFindFile use internal UnresolvedPath","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0624d78af0839cd8b290eb9cb6e5737f01162b96"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2022-10-15 14:42:27.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2022-10-16 19:11:23.000000000","tz":0},"subject":"fix(tvix/eval): resolve home relative paths at runtime","message":"fix(tvix/eval): resolve home relative paths at runtime\n\nHome relative paths depend on the environment to be resolved. We have\nelected to do everything that depends on the environment, e.g. resolving\nSPATH expressions using NIX_PATH, at runtime, so tvix evaluation would\ncontinue to behave correctly even if we separated the compilation and\nexecution phases more, e.g. via serializing bytecode. Then the value of\nHOME, NIX_PATH etc. could reasonably change in the time until execution,\nyielding wrong results if the resolution results were cached in the\nbytecode.\n\nWe also take the opportunity to fix the broken path concatenation\npreviously found in the compiler, fixing b/205.\n\nAnother thing we could consider is emitting a warning for home relative\npath literals, as they are by nature relatively fragile.\n\nOne sideeffect of this change is that home path resolution errors\nbecome catchable which is not the case in C++ Nix. This will need to be\nfixed up in a subsequent change.\n\nChange-Id: I30bd69b575667c49170a9fdea23a020565d0f9ec\nReviewed-on: https://cl.tvl.fyi/c/depot/+/7024\nAutosubmit: sterni \u003csternenseemann@systemli.org\u003e\nReviewed-by: Adam Joseph \u003cadam@westernsemico.com\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4dcb8f38c2e442b6433b21b8a7de303736a04568"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4dcb8f38c2e442b6433b21b8a7de303736a04568"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"0624d78af0839cd8b290eb9cb6e5737f01162b96","is_merged_in_target_branch":true,"change_id":"I6acf287f35197cd9e13377079f972b9d36e5b22e","change_number":7023,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}