)]}'
{"id":"depot~7078","triplet_id":"depot~canon~Iee2e1ed666f2ccb5e56cc50054ca85b8ba513f3b","project":"depot","branch":"canon","hashtags":[],"change_id":"Iee2e1ed666f2ccb5e56cc50054ca85b8ba513f3b","subject":"refactor(wpcarro/compiler): Modularize debug fns","status":"MERGED","created":"2022-10-25 03:54:38.000000000","updated":"2022-10-25 03:59:02.000000000","submitted":"2022-10-25 03:59:02.000000000","submitter":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7078","meta_rev_id":"547395472f42297760e5da6d02828624e69f7a5a","_number":7078,"virtual_id_number":7078,"owner":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-10-25 03:59:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-25 03:59:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-10-25 03:54:39.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-10-25 03:56:21.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e72f4072c66c77b62e9d42306ae898c9903c1830","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"date":"2022-10-25 03:54:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3b69ba1a0d39abe0305e49953ff25fa96e4ebb5e","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-25 03:54:39.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/17861","accounts_in_message":[],"_revision_number":1},{"id":"c2dc6063a57308db8cfd7de3c15f3783f71860e6","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-25 03:56:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/17861","accounts_in_message":[],"_revision_number":1},{"id":"80debc8138866ea954ff8a8c6826167c92b7a335","author":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"date":"2022-10-25 03:58:53.000000000","message":"Patch Set 1: Code-Review+2\n\nBy voting Code-Review+2 the following files are now explicitly code-owner approved by \u003cGERRIT_ACCOUNT_1000045\u003e:\n* users/wpcarro/scratch/compiler/debug.ml\n* users/wpcarro/scratch/compiler/expr_parser.ml\n* users/wpcarro/scratch/compiler/inference.ml\n* users/wpcarro/scratch/compiler/prettify.ml\n* users/wpcarro/scratch/compiler/register_vm.ml\n* users/wpcarro/scratch/compiler/type_parser.ml\n* users/wpcarro/scratch/compiler/types.ml\n","accounts_in_message":[{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}],"_revision_number":1},{"id":"547395472f42297760e5da6d02828624e69f7a5a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"date":"2022-10-25 03:59:02.000000000","message":"Change has been successfully rebased and submitted as 1e9c3955bf2c17206c6dd536ebaf96a7e6f4f22d","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1e9c3955bf2c17206c6dd536ebaf96a7e6f4f22d","revisions":{"f9ac1a5bfe4613d2fba0a013af5e569a69dd6787":{"kind":"REWORK","_number":1,"created":"2022-10-25 03:54:38.000000000","uploader":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"ref":"refs/changes/78/7078/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/78/7078/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/78/7078/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/78/7078/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/78/7078/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/78/7078/1"}}},"commit":{"parents":[{"commit":"a8876a4cdaaf0a1f051fefad436e08d983b402e2","subject":"feat(wpcarro/scratch): Implement \"Algorithm W\"","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da8876a4cdaaf0a1f051fefad436e08d983b402e2"}]}],"author":{"name":"William Carroll","email":"wpcarro@gmail.com","date":"2022-10-24 21:51:48.000000000","tz":-240},"committer":{"name":"William Carroll","email":"wpcarro@gmail.com","date":"2022-10-24 21:51:48.000000000","tz":-240},"subject":"refactor(wpcarro/compiler): Modularize debug fns","message":"refactor(wpcarro/compiler): Modularize debug fns\n\nDefine `debug.ml` and `prettify.ml` to clean-up some code.\n\nChange-Id: Iee2e1ed666f2ccb5e56cc50054ca85b8ba513f3b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df9ac1a5bfe4613d2fba0a013af5e569a69dd6787"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df9ac1a5bfe4613d2fba0a013af5e569a69dd6787"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a8876a4cdaaf0a1f051fefad436e08d983b402e2","is_merged_in_target_branch":true,"change_id":"I69261202a3d74d55c6e38763d7ddfec73c392465","change_number":6988,"patch_set_number":11,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"1e9c3955bf2c17206c6dd536ebaf96a7e6f4f22d":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-10-25 03:59:02.000000000","uploader":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"ref":"refs/changes/78/7078/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/78/7078/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/78/7078/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/78/7078/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/78/7078/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/78/7078/2"}}},"commit":{"parents":[{"commit":"a8876a4cdaaf0a1f051fefad436e08d983b402e2","subject":"feat(wpcarro/scratch): Implement \"Algorithm W\"","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da8876a4cdaaf0a1f051fefad436e08d983b402e2"}]}],"author":{"name":"William Carroll","email":"wpcarro@gmail.com","date":"2022-10-24 21:51:48.000000000","tz":-240},"committer":{"name":"wpcarro","email":"wpcarro@gmail.com","date":"2022-10-25 03:59:02.000000000","tz":0},"subject":"refactor(wpcarro/compiler): Modularize debug fns","message":"refactor(wpcarro/compiler): Modularize debug fns\n\nDefine `debug.ml` and `prettify.ml` to clean-up some code.\n\nChange-Id: Iee2e1ed666f2ccb5e56cc50054ca85b8ba513f3b\nReviewed-on: https://cl.tvl.fyi/c/depot/+/7078\nTested-by: BuildkiteCI\nReviewed-by: wpcarro \u003cwpcarro@gmail.com\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1e9c3955bf2c17206c6dd536ebaf96a7e6f4f22d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1e9c3955bf2c17206c6dd536ebaf96a7e6f4f22d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a8876a4cdaaf0a1f051fefad436e08d983b402e2","is_merged_in_target_branch":true,"change_id":"I69261202a3d74d55c6e38763d7ddfec73c392465","change_number":6988,"patch_set_number":11,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}