)]}'
{"id":"depot~7080","triplet_id":"depot~canon~I910b140b7c1bdddae40e08f8191986dccbc6fddf","project":"depot","branch":"canon","hashtags":[],"change_id":"I910b140b7c1bdddae40e08f8191986dccbc6fddf","subject":"feat(wpcarro/compiler): Support Vector type","status":"MERGED","created":"2022-10-25 03:54:38.000000000","updated":"2022-10-25 04:32:59.000000000","submitted":"2022-10-25 04:32:59.000000000","submitter":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7080","meta_rev_id":"79885db13e525b8a61d9722a10916d27ff918c36","_number":7080,"virtual_id_number":7080,"owner":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-10-25 04:32:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-25 04:32:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"all":[{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-10-25 03:54:40.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-10-25 03:56:21.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1c2f88ae552b0bf6776d59c6622c517af6620225","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"date":"2022-10-25 03:54:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"92b1c00b0b18d0cc3c749c8cd493ebc5677c2e9c","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-25 03:54:40.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/17863","accounts_in_message":[],"_revision_number":1},{"id":"5239e198df495a75d340aee5e49ee9bb6cc7e3c1","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-10-25 03:56:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/17863","accounts_in_message":[],"_revision_number":1},{"id":"e237fab3b4b25f8644a05ca0ff3a5bc39fcd42d8","author":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"date":"2022-10-25 03:58:47.000000000","message":"Patch Set 1: Code-Review+2\n\nBy voting Code-Review+2 the following files are now explicitly code-owner approved by \u003cGERRIT_ACCOUNT_1000045\u003e:\n* users/wpcarro/scratch/compiler/expr_parser.ml\n* users/wpcarro/scratch/compiler/parser.ml\n* users/wpcarro/scratch/compiler/register_vm.ml\n* users/wpcarro/scratch/compiler/type_parser.ml\n* users/wpcarro/scratch/compiler/vec.ml\n","accounts_in_message":[{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}],"_revision_number":1},{"id":"57457ef6268272275053a9f3ffc8fc587a597f28","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"date":"2022-10-25 04:01:16.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"36a31e6771c27fea181d3e2b5895e957e4f623fb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"date":"2022-10-25 04:30:33.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"79885db13e525b8a61d9722a10916d27ff918c36","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"date":"2022-10-25 04:32:59.000000000","message":"Change has been successfully rebased and submitted as bd0bf6ea7d64d2b3b453db4adb94c98c0b459a24\n\n1 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"bd0bf6ea7d64d2b3b453db4adb94c98c0b459a24","revisions":{"e2fc07171f874d659db885a28c12032913c71062":{"kind":"REWORK","_number":1,"created":"2022-10-25 03:54:38.000000000","uploader":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"ref":"refs/changes/80/7080/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/80/7080/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/80/7080/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/80/7080/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/80/7080/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/80/7080/1"}}},"commit":{"parents":[{"commit":"47c9bce7f34febd7b94d5145151bd3c4b1b1a512","subject":"feat(wpcarro/compiler): Support string literal type","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d47c9bce7f34febd7b94d5145151bd3c4b1b1a512"}]}],"author":{"name":"William Carroll","email":"wpcarro@gmail.com","date":"2022-10-25 01:06:01.000000000","tz":-240},"committer":{"name":"William Carroll","email":"wpcarro@gmail.com","date":"2022-10-25 01:06:01.000000000","tz":-240},"subject":"wip(wpcarro/compiler): Support Vector type","message":"wip(wpcarro/compiler): Support Vector type\n\nSupport an array that dynamically resizes itself, and replace usages of `List`,\n`Array`, and `Queue` with `Vec`.\n\nChange-Id: I910b140b7c1bdddae40e08f8191986dccbc6fddf\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de2fc07171f874d659db885a28c12032913c71062"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de2fc07171f874d659db885a28c12032913c71062"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"47c9bce7f34febd7b94d5145151bd3c4b1b1a512","is_merged_in_target_branch":false,"change_id":"Ia76299a56aa4d2032c9a21277e2fddfb2e055831","change_number":7079,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"b11456d946c5c4f32110b6d661e61e0d804a0cf6":{"kind":"NO_CHANGE","_number":2,"created":"2022-10-25 04:01:16.000000000","uploader":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"ref":"refs/changes/80/7080/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/80/7080/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/80/7080/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/80/7080/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/80/7080/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/80/7080/2"}}},"commit":{"parents":[{"commit":"ee235235b98d01b00de5a446b48d6dec574b1458","subject":"feat(wpcarro/compiler): Support string literal type","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dee235235b98d01b00de5a446b48d6dec574b1458"}]}],"author":{"name":"William Carroll","email":"wpcarro@gmail.com","date":"2022-10-25 01:06:01.000000000","tz":-240},"committer":{"name":"wpcarro","email":"wpcarro@gmail.com","date":"2022-10-25 04:01:16.000000000","tz":0},"subject":"wip(wpcarro/compiler): Support Vector type","message":"wip(wpcarro/compiler): Support Vector type\n\nSupport an array that dynamically resizes itself, and replace usages of `List`,\n`Array`, and `Queue` with `Vec`.\n\nChange-Id: I910b140b7c1bdddae40e08f8191986dccbc6fddf\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db11456d946c5c4f32110b6d661e61e0d804a0cf6"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db11456d946c5c4f32110b6d661e61e0d804a0cf6"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ee235235b98d01b00de5a446b48d6dec574b1458","is_merged_in_target_branch":true,"change_id":"Ia76299a56aa4d2032c9a21277e2fddfb2e055831","change_number":7079,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"},"dcc9dd441b1cb35cfb44b53026f76e62aac450f6":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2022-10-25 04:30:33.000000000","uploader":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"ref":"refs/changes/80/7080/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/80/7080/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/80/7080/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/80/7080/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/80/7080/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/80/7080/3"}}},"commit":{"parents":[{"commit":"ee235235b98d01b00de5a446b48d6dec574b1458","subject":"feat(wpcarro/compiler): Support string literal type","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dee235235b98d01b00de5a446b48d6dec574b1458"}]}],"author":{"name":"William Carroll","email":"wpcarro@gmail.com","date":"2022-10-25 01:06:01.000000000","tz":-240},"committer":{"name":"William Carroll","email":"wpcarro@gmail.com","date":"2022-10-25 04:30:23.000000000","tz":-420},"subject":"feat(wpcarro/compiler): Support Vector type","message":"feat(wpcarro/compiler): Support Vector type\n\nSupport an array that dynamically resizes itself, and replace usages of `List`,\n`Array`, and `Queue` with `Vec`.\n\nChange-Id: I910b140b7c1bdddae40e08f8191986dccbc6fddf\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddcc9dd441b1cb35cfb44b53026f76e62aac450f6"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddcc9dd441b1cb35cfb44b53026f76e62aac450f6"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ee235235b98d01b00de5a446b48d6dec574b1458","is_merged_in_target_branch":true,"change_id":"Ia76299a56aa4d2032c9a21277e2fddfb2e055831","change_number":7079,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"bd0bf6ea7d64d2b3b453db4adb94c98c0b459a24":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2022-10-25 04:32:59.000000000","uploader":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"},"ref":"refs/changes/80/7080/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/80/7080/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/80/7080/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/80/7080/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/80/7080/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/80/7080/4"}}},"commit":{"parents":[{"commit":"ee235235b98d01b00de5a446b48d6dec574b1458","subject":"feat(wpcarro/compiler): Support string literal type","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dee235235b98d01b00de5a446b48d6dec574b1458"}]}],"author":{"name":"William Carroll","email":"wpcarro@gmail.com","date":"2022-10-25 01:06:01.000000000","tz":-240},"committer":{"name":"wpcarro","email":"wpcarro@gmail.com","date":"2022-10-25 04:32:59.000000000","tz":0},"subject":"feat(wpcarro/compiler): Support Vector type","message":"feat(wpcarro/compiler): Support Vector type\n\nSupport an array that dynamically resizes itself, and replace usages of `List`,\n`Array`, and `Queue` with `Vec`.\n\nChange-Id: I910b140b7c1bdddae40e08f8191986dccbc6fddf\nReviewed-on: https://cl.tvl.fyi/c/depot/+/7080\nTested-by: BuildkiteCI\nReviewed-by: wpcarro \u003cwpcarro@gmail.com\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbd0bf6ea7d64d2b3b453db4adb94c98c0b459a24"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbd0bf6ea7d64d2b3b453db4adb94c98c0b459a24"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ee235235b98d01b00de5a446b48d6dec574b1458","is_merged_in_target_branch":true,"change_id":"Ia76299a56aa4d2032c9a21277e2fddfb2e055831","change_number":7079,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000045,"name":"wpcarro","email":"wpcarro@gmail.com","username":"wpcarro"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}
