)]}'
{"id":"depot~7197","triplet_id":"depot~canon~I16d50440e6f018160dcc8a61883f8b3f38b77424","project":"depot","branch":"canon","hashtags":[],"change_id":"I16d50440e6f018160dcc8a61883f8b3f38b77424","subject":"refactor(tvix/eval): [FOUNDLING]: drop explicit `\u0026mut vm` parameter","status":"ABANDONED","created":"2022-11-05 21:48:14.000000000","updated":"2022-11-05 22:16:54.000000000","total_comment_count":0,"unresolved_comment_count":0,"work_in_progress":true,"has_review_started":false,"meta_rev_id":"715e5847c0d0ae24481ba650886b6a90403e90c9","_number":7197,"virtual_id_number":7197,"owner":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:buildkite~result","value":1,"date":"2022-11-05 22:16:23.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}},"Conformant-Commit-Message":{"approved":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"reviewer_updates":[{"updated":"2022-11-05 21:48:25.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-11-05 22:10:13.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ba6b7b0f96e3a4f2b0347f45d228278a4e0d5846","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-11-05 21:48:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ea83dbbd744925686fb39dc3e29bb3f4dc40c7c9","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-11-05 21:48:25.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/18131","accounts_in_message":[],"_revision_number":1},{"id":"316fb4b9814f104e719ae3c71fd08de32d4aa2e8","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-11-05 21:50:40.000000000","message":"Abandoned\n\nfoundling","accounts_in_message":[],"_revision_number":1},{"id":"5fa5d3a1533b650db313d6f24c2ca9950459fe3c","tag":"autogenerated:gerrit:restore","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-11-05 22:06:54.000000000","message":"Restored","accounts_in_message":[],"_revision_number":1},{"id":"215f57e5a0ca5cf86dac7eca710c1e985e256ae9","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-11-05 22:07:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c032674ed7868be102e749853306972db307ff8c","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-11-05 22:07:35.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/18143","accounts_in_message":[],"_revision_number":2},{"id":"e711fa8705ed858193d91c962904eee66836b4ed","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-11-05 22:10:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/18143","accounts_in_message":[],"_revision_number":2},{"id":"60dadceb29c95271b5a1b2506adde083bce269dd","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-11-05 22:10:17.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"3bfd9cd7d25e22f233fc0050c215a7606c747e42","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-11-05 22:10:22.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/18149","accounts_in_message":[],"_revision_number":3},{"id":"478e51169a049a18ac747d9a983f1eabd55af652","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-11-05 22:13:34.000000000","message":"Patch Set 3: Verified-1\n\nBuild of patchset 3 failed: https://buildkite.com/tvl/depot/builds/18149","accounts_in_message":[],"_revision_number":3},{"id":"64cf803e5d2717d17e7c7534ef77e1447184c9e8","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-11-05 22:13:56.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"a61ddaaf02a785b7123c39ec7d263e581b2a4e4f","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-11-05 22:13:57.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/18150","accounts_in_message":[],"_revision_number":4},{"id":"ceee139ceeb44f7a9160d648d3698fa20c8c7d34","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-11-05 22:16:23.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/18150","accounts_in_message":[],"_revision_number":4},{"id":"715e5847c0d0ae24481ba650886b6a90403e90c9","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2022-11-05 22:16:54.000000000","message":"Abandoned\n\nfoundling","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"0473fb3c1cc95dcc67b9ecaaf92f6a244cb371ba","revisions":{"a70b4ffa2e0d6caa3e4d9d3a7725b91b66638b4e":{"kind":"REWORK","_number":1,"created":"2022-11-05 21:48:14.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/97/7197/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/97/7197/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/97/7197/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/97/7197/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/97/7197/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/97/7197/1"}}},"commit":{"parents":[{"commit":"5dace91f8c693094651dc622f705fbdb3274f2d2","subject":"feat(tvix/eval): [FOUNDLING] VM::vm_xxx convenience methods","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5dace91f8c693094651dc622f705fbdb3274f2d2"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-11-05 21:25:02.000000000","tz":-420},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-11-05 21:42:15.000000000","tz":-420},"subject":"refactor(tvix/eval): [FOUNDLING]: drop explicit `\u0026mut vm` parameter","message":"refactor(tvix/eval): [FOUNDLING]: drop explicit `\u0026mut vm` parameter\n\nThis foundling commit deletes all of the `\u0026mut vm` parameters\nthreaded throughout the code, since they are no longer necessary now\nthat the VM is accessible in thread-local storage via `VM::with()`.\n\nThis commit is 100% refactoring noise.\n\nChange-Id: I16d50440e6f018160dcc8a61883f8b3f38b77424\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da70b4ffa2e0d6caa3e4d9d3a7725b91b66638b4e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da70b4ffa2e0d6caa3e4d9d3a7725b91b66638b4e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"5dace91f8c693094651dc622f705fbdb3274f2d2","is_merged_in_target_branch":false,"change_id":"I6393a167ffe9422b1561d73240ee330fa2d32d8f","change_number":7196,"patch_set_number":1,"change_status":"ABANDONED"}],"branch":"refs/heads/canon"},"ebaed2c08842448a8d7ee1ffbd3a80e7b4dcd993":{"kind":"REWORK","_number":2,"created":"2022-11-05 22:07:34.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/97/7197/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/97/7197/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/97/7197/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/97/7197/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/97/7197/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/97/7197/2"}}},"commit":{"parents":[{"commit":"5be212902cd1b8d902cf0e98278dc4ea21a8a854","subject":"feat(tvix/eval): [FOUNDLING] VM::vm_xxx convenience methods","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5be212902cd1b8d902cf0e98278dc4ea21a8a854"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-11-05 21:25:02.000000000","tz":-420},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-11-05 22:01:32.000000000","tz":-420},"subject":"refactor(tvix/eval): [FOUNDLING]: drop explicit `\u0026mut vm` parameter","message":"refactor(tvix/eval): [FOUNDLING]: drop explicit `\u0026mut vm` parameter\n\nThis foundling commit deletes all of the `\u0026mut vm` parameters\nthreaded throughout the code, since they are no longer necessary now\nthat the VM is accessible in thread-local storage via `VM::with()`.\n\nThis commit is 100% refactoring noise.\n\nChange-Id: I16d50440e6f018160dcc8a61883f8b3f38b77424\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003debaed2c08842448a8d7ee1ffbd3a80e7b4dcd993"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003debaed2c08842448a8d7ee1ffbd3a80e7b4dcd993"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"5be212902cd1b8d902cf0e98278dc4ea21a8a854","is_merged_in_target_branch":false,"change_id":"I6393a167ffe9422b1561d73240ee330fa2d32d8f","change_number":7196,"patch_set_number":2,"change_status":"ABANDONED"}],"branch":"refs/heads/canon"},"9410bd515b1992535ef8b491880f50714848708f":{"kind":"REWORK","_number":3,"created":"2022-11-05 22:10:17.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/97/7197/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/97/7197/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/97/7197/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/97/7197/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/97/7197/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/97/7197/3"}}},"commit":{"parents":[{"commit":"48646b9b606177ef9f342a3f68d3674a2fec0fe1","subject":"feat(tvix/eval): [FOUNDLING] VM::vm_xxx convenience methods","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d48646b9b606177ef9f342a3f68d3674a2fec0fe1"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-11-05 21:25:02.000000000","tz":-420},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-11-05 22:03:31.000000000","tz":-420},"subject":"refactor(tvix/eval): [FOUNDLING]: drop explicit `\u0026mut vm` parameter","message":"refactor(tvix/eval): [FOUNDLING]: drop explicit `\u0026mut vm` parameter\n\nThis foundling commit deletes all of the `\u0026mut vm` parameters\nthreaded throughout the code, since they are no longer necessary now\nthat the VM is accessible in thread-local storage via `VM::with()`.\n\nThis commit is 100% refactoring noise.\n\nChange-Id: I16d50440e6f018160dcc8a61883f8b3f38b77424\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9410bd515b1992535ef8b491880f50714848708f"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9410bd515b1992535ef8b491880f50714848708f"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"48646b9b606177ef9f342a3f68d3674a2fec0fe1","is_merged_in_target_branch":false,"change_id":"I6393a167ffe9422b1561d73240ee330fa2d32d8f","change_number":7196,"patch_set_number":3,"change_status":"ABANDONED"}],"branch":"refs/heads/canon"},"0473fb3c1cc95dcc67b9ecaaf92f6a244cb371ba":{"kind":"REWORK","_number":4,"created":"2022-11-05 22:13:56.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/97/7197/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/97/7197/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/97/7197/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/97/7197/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/97/7197/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/97/7197/4"}}},"commit":{"parents":[{"commit":"48646b9b606177ef9f342a3f68d3674a2fec0fe1","subject":"feat(tvix/eval): [FOUNDLING] VM::vm_xxx convenience methods","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d48646b9b606177ef9f342a3f68d3674a2fec0fe1"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-11-05 21:25:02.000000000","tz":-420},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2022-11-05 22:07:58.000000000","tz":-420},"subject":"refactor(tvix/eval): [FOUNDLING]: drop explicit `\u0026mut vm` parameter","message":"refactor(tvix/eval): [FOUNDLING]: drop explicit `\u0026mut vm` parameter\n\nThis foundling commit deletes all of the `\u0026mut vm` parameters\nthreaded throughout the code, since they are no longer necessary now\nthat the VM is accessible in thread-local storage via `VM::with()`.\n\nThis commit is 100% refactoring noise.\n\nChange-Id: I16d50440e6f018160dcc8a61883f8b3f38b77424\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0473fb3c1cc95dcc67b9ecaaf92f6a244cb371ba"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0473fb3c1cc95dcc67b9ecaaf92f6a244cb371ba"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"48646b9b606177ef9f342a3f68d3674a2fec0fe1","is_merged_in_target_branch":false,"change_id":"I6393a167ffe9422b1561d73240ee330fa2d32d8f","change_number":7196,"patch_set_number":3,"change_status":"ABANDONED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[],"submit_requirements":[]}