)]}'
{"id":"depot~7258","triplet_id":"depot~canon~I50203d14a71482bc757832a2c8dee08eb7d35c49","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000067":{"account":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"last_update":"2022-11-10 13:12:05.000000000","reason":"Change was submitted"},"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2022-11-10 13:12:05.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2022-11-10 12:57:05.000000000","reason":"\u003cGERRIT_ACCOUNT_1000036\u003e replied on the change","reason_account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2022-11-10 13:12:05.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I50203d14a71482bc757832a2c8dee08eb7d35c49","subject":"feat(tvix/eval): detect division by zero","status":"MERGED","created":"2022-11-09 23:47:46.000000000","updated":"2022-11-10 13:12:05.000000000","submitted":"2022-11-10 13:12:05.000000000","submitter":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7258","meta_rev_id":"c1fc0f62897ca34c95413f4f23c8e93e0e8a9df1","_number":7258,"virtual_id_number":7258,"owner":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-11-10 13:12:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-11-10 13:12:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"all":[{"value":0,"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"all":[{"value":0,"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"reviewers":{"REVIEWER":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-11-09 23:47:47.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-11-09 23:48:33.000000000","updated_by":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2022-11-09 23:48:33.000000000","updated_by":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"reviewer":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"state":"REVIEWER"},{"updated":"2022-11-09 23:50:39.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-11-10 00:00:16.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"}],"messages":[{"id":"a91ff1982fe2cee5de41debebb789b76008ddd5e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"date":"2022-11-09 23:47:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a210c325dafa5daaa2294713000315272a3fac49","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-11-09 23:47:47.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/18265","accounts_in_message":[],"_revision_number":1},{"id":"090ee550a35f9a592b19fc1cd740ead9e8a699e8","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"date":"2022-11-09 23:48:33.000000000","message":"\u003cGERRIT_ACCOUNT_1000034\u003e, who was added as reviewer owns the following files:\n* tvix/eval/src/errors.rs\n* tvix/eval/src/vm.rs\n\n\u003cGERRIT_ACCOUNT_1000010\u003e, who was added as reviewer owns the following files:\n* tvix/eval/src/errors.rs\n* tvix/eval/src/vm.rs\n","accounts_in_message":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"_revision_number":1},{"id":"5e80beeb3dab0c2d4a3fcd15db382173da5e47fb","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-11-09 23:50:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/18265","accounts_in_message":[],"_revision_number":1},{"id":"13a0361c9b9334d48d3479670b32eb0ca0fbc62f","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2022-11-10 00:00:16.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"dc69bfe1251fbc6aed7c02bff1ae3a42ba2303b8","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2022-11-10 00:17:05.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"f814d035489dc155f356c66e6aa54c2e97da356a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"date":"2022-11-10 12:22:08.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Code-Review+1, Code-Review-1 (copy condition: \"((is:ANY AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"309a862dd338e915c48a4b4e408e319f824df9ee","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-11-10 12:22:16.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/18267","accounts_in_message":[],"_revision_number":2},{"id":"70fc68af628a3392bb834de6b8f0c77e7d4e6b32","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-11-10 12:24:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/18267","accounts_in_message":[],"_revision_number":2},{"id":"7c233a20fae560c16ed97f4eab0b71eed892747e","author":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"date":"2022-11-10 12:28:24.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e7a86bfc13349bddb4ee524f3a63396ba0706ec4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"date":"2022-11-10 12:48:18.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review+1, Code-Review-1 (copy condition: \"((is:ANY AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"03b9978aa494d2942a8f09077f3d7a7e76f11e05","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-11-10 12:48:19.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/18268","accounts_in_message":[],"_revision_number":3},{"id":"7ab0679a2cc7fe02f0f9824c80c6d2f9df25063d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-11-10 12:50:52.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/18268","accounts_in_message":[],"_revision_number":3},{"id":"9679c80f29e947566b24f034e4625641748d6408","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"date":"2022-11-10 12:53:31.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"58f345390c304ff3c3d9b07c9843da4975d02963","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-11-10 12:53:32.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/18269","accounts_in_message":[],"_revision_number":4},{"id":"58d8279414b1ecc0dffa658bb7c3643793f633c7","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-11-10 12:56:07.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/18269","accounts_in_message":[],"_revision_number":4},{"id":"3b012513420d3778f5d57e98b725f3ef53fef5d7","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2022-11-10 12:57:05.000000000","message":"Patch Set 4: Code-Review+2\n\nBy voting Code-Review+2 the following files are now code-owner approved by \u003cGERRIT_ACCOUNT_1000036\u003e:\n* tvix/eval/src/errors.rs\n* tvix/eval/src/tests/nix_tests/eval-fail-division-by-zero-float.nix\n* tvix/eval/src/tests/nix_tests/eval-fail-division-by-zero-int.nix\n* tvix/eval/src/vm.rs\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":4},{"id":"c1fc0f62897ca34c95413f4f23c8e93e0e8a9df1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"date":"2022-11-10 13:12:05.000000000","message":"Change has been successfully rebased and submitted as d00030128e465c8351412b1aefb4260681d8b497","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"d00030128e465c8351412b1aefb4260681d8b497","revisions":{"0fa30b61bcea7f6006943daa09b34bc27142db69":{"kind":"REWORK","_number":1,"created":"2022-11-09 23:47:46.000000000","uploader":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"ref":"refs/changes/58/7258/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/58/7258/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/58/7258/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/58/7258/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/58/7258/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/58/7258/1"}}},"commit":{"parents":[{"commit":"40826e664de6c5d243ced77fd6662b004b8fef49","subject":"feat(ops/users): Add jrhahn to users","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d40826e664de6c5d243ced77fd6662b004b8fef49"}]}],"author":{"name":"jhahn","email":"mail.jhahn@gmail.com","date":"2022-11-09 23:47:07.000000000","tz":0},"committer":{"name":"jhahn","email":"mail.jhahn@gmail.com","date":"2022-11-09 23:47:07.000000000","tz":0},"subject":"feat(tvix/eval): detect division by zero","message":"feat(tvix/eval): detect division by zero\n\nThis detects if the second argument of a division is a zero (either as integer\nor as float). If so, an error message is displayed.\n\nThis fixes b/219.\n\nChange-Id: I50203d14a71482bc757832a2c8dee08eb7d35c49\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0fa30b61bcea7f6006943daa09b34bc27142db69"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0fa30b61bcea7f6006943daa09b34bc27142db69"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"40826e664de6c5d243ced77fd6662b004b8fef49","is_merged_in_target_branch":true,"change_id":"I00913a302ecc23fec2e60875dc164b24d73ba4ad","change_number":7257,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"8c96df28d96ed54b7b5f0897d7aad6658e6ff1bd":{"kind":"REWORK","_number":2,"created":"2022-11-10 12:22:08.000000000","uploader":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"ref":"refs/changes/58/7258/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/58/7258/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/58/7258/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/58/7258/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/58/7258/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/58/7258/2"}}},"commit":{"parents":[{"commit":"40826e664de6c5d243ced77fd6662b004b8fef49","subject":"feat(ops/users): Add jrhahn to users","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d40826e664de6c5d243ced77fd6662b004b8fef49"}]}],"author":{"name":"jhahn","email":"mail.jhahn@gmail.com","date":"2022-11-09 23:47:07.000000000","tz":0},"committer":{"name":"jhahn","email":"mail.jhahn@gmail.com","date":"2022-11-10 12:21:09.000000000","tz":0},"subject":"feat(tvix/eval): detect division by zero","message":"feat(tvix/eval): detect division by zero\n\nThis detects if the second argument of a division is a zero (either as integer\nor as float). If so, an error message is displayed.\n\nThis fixes b/219.\n\nChange-Id: I50203d14a71482bc757832a2c8dee08eb7d35c49\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8c96df28d96ed54b7b5f0897d7aad6658e6ff1bd"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8c96df28d96ed54b7b5f0897d7aad6658e6ff1bd"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"40826e664de6c5d243ced77fd6662b004b8fef49","is_merged_in_target_branch":true,"change_id":"I00913a302ecc23fec2e60875dc164b24d73ba4ad","change_number":7257,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"3ce802691aaf2ebf703ef66f3d10994c6be387dd":{"kind":"REWORK","_number":3,"created":"2022-11-10 12:48:18.000000000","uploader":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"ref":"refs/changes/58/7258/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/58/7258/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/58/7258/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/58/7258/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/58/7258/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/58/7258/3"}}},"commit":{"parents":[{"commit":"40826e664de6c5d243ced77fd6662b004b8fef49","subject":"feat(ops/users): Add jrhahn to users","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d40826e664de6c5d243ced77fd6662b004b8fef49"}]}],"author":{"name":"jhahn","email":"mail.jhahn@gmail.com","date":"2022-11-09 23:47:07.000000000","tz":0},"committer":{"name":"jhahn","email":"mail.jhahn@gmail.com","date":"2022-11-10 12:48:05.000000000","tz":0},"subject":"feat(tvix/eval): detect division by zero","message":"feat(tvix/eval): detect division by zero\n\nThis detects if the second argument of a division is a zero (either as integer\nor as float). If so, an error message is displayed.\n\nThis fixes b/219.\n\nChange-Id: I50203d14a71482bc757832a2c8dee08eb7d35c49\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3ce802691aaf2ebf703ef66f3d10994c6be387dd"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3ce802691aaf2ebf703ef66f3d10994c6be387dd"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"40826e664de6c5d243ced77fd6662b004b8fef49","is_merged_in_target_branch":true,"change_id":"I00913a302ecc23fec2e60875dc164b24d73ba4ad","change_number":7257,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"3d7a54ff818d7b425b2f05e88e80c5204e45cce3":{"kind":"REWORK","_number":4,"created":"2022-11-10 12:53:31.000000000","uploader":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"ref":"refs/changes/58/7258/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/58/7258/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/58/7258/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/58/7258/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/58/7258/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/58/7258/4"}}},"commit":{"parents":[{"commit":"40826e664de6c5d243ced77fd6662b004b8fef49","subject":"feat(ops/users): Add jrhahn to users","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d40826e664de6c5d243ced77fd6662b004b8fef49"}]}],"author":{"name":"jhahn","email":"mail.jhahn@gmail.com","date":"2022-11-09 23:47:07.000000000","tz":0},"committer":{"name":"jhahn","email":"mail.jhahn@gmail.com","date":"2022-11-10 12:53:06.000000000","tz":0},"subject":"feat(tvix/eval): detect division by zero","message":"feat(tvix/eval): detect division by zero\n\nThis detects if the second argument of a division is a zero (either as integer\nor as float). If so, an error message is displayed.\n\nThis fixes b/219.\n\nChange-Id: I50203d14a71482bc757832a2c8dee08eb7d35c49\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3d7a54ff818d7b425b2f05e88e80c5204e45cce3"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3d7a54ff818d7b425b2f05e88e80c5204e45cce3"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"40826e664de6c5d243ced77fd6662b004b8fef49","is_merged_in_target_branch":true,"change_id":"I00913a302ecc23fec2e60875dc164b24d73ba4ad","change_number":7257,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"d00030128e465c8351412b1aefb4260681d8b497":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2022-11-10 13:12:05.000000000","uploader":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"},"ref":"refs/changes/58/7258/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/58/7258/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/58/7258/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/58/7258/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/58/7258/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/58/7258/5"}}},"commit":{"parents":[{"commit":"40826e664de6c5d243ced77fd6662b004b8fef49","subject":"feat(ops/users): Add jrhahn to users","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d40826e664de6c5d243ced77fd6662b004b8fef49"}]}],"author":{"name":"jhahn","email":"mail.jhahn@gmail.com","date":"2022-11-09 23:47:07.000000000","tz":0},"committer":{"name":"jrhahn","email":"mail.jhahn@gmail.com","date":"2022-11-10 13:12:05.000000000","tz":0},"subject":"feat(tvix/eval): detect division by zero","message":"feat(tvix/eval): detect division by zero\n\nThis detects if the second argument of a division is a zero (either as integer\nor as float). If so, an error message is displayed.\n\nThis fixes b/219.\n\nChange-Id: I50203d14a71482bc757832a2c8dee08eb7d35c49\nReviewed-on: https://cl.tvl.fyi/c/depot/+/7258\nTested-by: BuildkiteCI\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd00030128e465c8351412b1aefb4260681d8b497"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd00030128e465c8351412b1aefb4260681d8b497"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"40826e664de6c5d243ced77fd6662b004b8fef49","is_merged_in_target_branch":true,"change_id":"I00913a302ecc23fec2e60875dc164b24d73ba4ad","change_number":7257,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000067,"name":"jrhahn","email":"mail.jhahn@gmail.com","username":"jrhahn"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}