)]}'
{"nix/bufCheck/default.nix":[{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"968930cbca562f9d74e70b1c02c4d62688b3e15d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  buf lint ."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  # Run buf generate, and bail out if generated files are changed."},{"line_number":10,"context_line":"  buf generate --path tvix/store/protos"},{"line_number":11,"context_line":"  # Check if any files have changed"},{"line_number":12,"context_line":"  if [[ -n \"$(git status --porcelain -unormal)\" ]]; then"},{"line_number":13,"context_line":"      echo \"-----------------------------\""}],"source_content_type":"text/x-nix","patch_set":9,"id":"c776041d_23a7c26a","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":39},"updated":"2022-12-02 11:18:37.000000000","message":"this isn\u0027t the right place for this, it should be an extra build target inside of the store folder or something like that","commit_id":"be87ec1c6d724fd9d6f77bd9354373cff0a36e21"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"9599fdd9c4917fbb854850a3ed427b59fbf1ce2c","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  buf lint ."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  # Run buf generate, and bail out if generated files are changed."},{"line_number":10,"context_line":"  buf generate --path tvix/store/protos"},{"line_number":11,"context_line":"  # Check if any files have changed"},{"line_number":12,"context_line":"  if [[ -n \"$(git status --porcelain -unormal)\" ]]; then"},{"line_number":13,"context_line":"      echo \"-----------------------------\""}],"source_content_type":"text/x-nix","patch_set":9,"id":"4960cde7_d72939a5","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":39},"in_reply_to":"17ca85b6_c75d8cf3","updated":"2022-12-26 09:53:17.000000000","message":"See cl/7639","commit_id":"be87ec1c6d724fd9d6f77bd9354373cff0a36e21"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"d8d6e546e46a0960a6b50ec4e237f644b12bd304","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  buf lint ."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  # Run buf generate, and bail out if generated files are changed."},{"line_number":10,"context_line":"  buf generate --path tvix/store/protos"},{"line_number":11,"context_line":"  # Check if any files have changed"},{"line_number":12,"context_line":"  if [[ -n \"$(git status --porcelain -unormal)\" ]]; then"},{"line_number":13,"context_line":"      echo \"-----------------------------\""}],"source_content_type":"text/x-nix","patch_set":9,"id":"2e81f256_4dd2ca37","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":39},"in_reply_to":"4960cde7_d72939a5","updated":"2022-12-26 11:35:23.000000000","message":"I cleaned up `nix/buildGo/example/thing.proto` in cl/7641.\n\nThe evaluator.proto file also causes this check to fail. I kept restricting this to `tvix/store/protos` for now, but left a comment in this CL.","commit_id":"be87ec1c6d724fd9d6f77bd9354373cff0a36e21"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"db13720ae57bf6984b04c48f50cb3bbc4005f7e5","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  buf lint ."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  # Run buf generate, and bail out if generated files are changed."},{"line_number":10,"context_line":"  buf generate --path tvix/store/protos"},{"line_number":11,"context_line":"  # Check if any files have changed"},{"line_number":12,"context_line":"  if [[ -n \"$(git status --porcelain -unormal)\" ]]; then"},{"line_number":13,"context_line":"      echo \"-----------------------------\""}],"source_content_type":"text/x-nix","patch_set":9,"id":"17ca85b6_c75d8cf3","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":39},"in_reply_to":"c776041d_23a7c26a","updated":"2022-12-21 15:28:49.000000000","message":"`buf generate` is a global thing, like `buf lint` is.\n\nIt\u0027ll emit .pb.go files alongside .proto files repo-wide, or in a subpath specified.\n\nThe only problem is that `buf generate` will fail if we load the go and go-grpc plugins, but there\u0027s no `go_package` option in a `.proto` file, which is why I opt in to the ones I want this code to be generated for.\n\nThe only two other .proto files are `tools/depot-scanner/depot_scanner.proto` and `nix/buildGo/example/thing.proto`. The former seems semi-unused (see comments on cl/7536), and the latter is removed by the same CL.\n\nOnce both of them are gone, we can drop the `--path` argument and make this a depot-wide thing, but explicitly allow-listing a certain path here unblocks this.","commit_id":"be87ec1c6d724fd9d6f77bd9354373cff0a36e21"}]}