)]}'
{"id":"depot~7560","triplet_id":"depot~canon~I29ce5eb9452b02d3b358c673e1f5cf8082e2fef9","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000066":{"account":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"last_update":"2022-12-21 21:48:08.000000000","reason":"Change was submitted"},"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2022-12-21 21:48:08.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2022-12-21 21:48:08.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2022-12-21 21:48:08.000000000","reason":"Change was submitted"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2022-12-21 13:39:16.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I29ce5eb9452b02d3b358c673e1f5cf8082e2fef9","subject":"refactor(tvix/eval): add name-based index over compiler\u0027s locals","status":"MERGED","created":"2022-12-12 00:02:55.000000000","updated":"2022-12-21 21:48:08.000000000","submitted":"2022-12-21 21:48:08.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7580","meta_rev_id":"14615ccf8e5eda32b12ab99deeb6b3bcc9991bb9","_number":7560,"virtual_id_number":7560,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-12-21 21:48:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-12-21 21:48:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-12-12 00:02:56.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-12-12 00:05:56.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-12-16 15:34:26.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"state":"REVIEWER"},{"updated":"2022-12-16 15:34:26.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2022-12-16 15:34:26.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2022-12-16 15:34:26.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"state":"REVIEWER"}],"messages":[{"id":"9689f2283267c78b05b0b84f184a31362fe842d9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-12 00:02:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c4e999a6b86e051a981d0e6ccb3249e43962f84b","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-12 00:02:56.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/19314","accounts_in_message":[],"_revision_number":1},{"id":"3e8e83c8054095b8396316f03a422b0f2efb003c","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-12 00:05:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/19314","accounts_in_message":[],"_revision_number":1},{"id":"513f9370ceb385e2308cd0fb44b548233dd9f716","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-12 09:14:35.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"7909e956f9c26be86d45a5455196c1584c211f37","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-12 09:14:52.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/19332","accounts_in_message":[],"_revision_number":2},{"id":"3d87634f3a953dd080dffe78c0b6ba8ab87636c5","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-12 09:21:19.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/19332","accounts_in_message":[],"_revision_number":2},{"id":"501d2554c2d7042901e3da9583fa2a0e8f95cdf7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-12 11:09:16.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"6c8dc5dab6a9a2c6dfa97242abda54c01ccf745f","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-12 11:09:31.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/19355","accounts_in_message":[],"_revision_number":3},{"id":"4b93b828df60cd4e89edfbc4eea51b1acad071d4","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-12 11:16:10.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/19355","accounts_in_message":[],"_revision_number":3},{"id":"ae65c2708fe82b03379cd673b4c77e59f42a9625","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-12 21:14:47.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"da046d6d7c07348b7d4023d17828780d924f5a0f","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-12 21:15:12.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/19411","accounts_in_message":[],"_revision_number":4},{"id":"05e5aff087afacedda53f3d2846aafea066df688","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-12 21:22:35.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/19411","accounts_in_message":[],"_revision_number":4},{"id":"07f36307bb98ec0e2430eab217c6eb58b73be6a3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-15 17:39:08.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"16e3b6b541d5269c6eec59f8a862d417ad76cc88","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-15 17:39:36.000000000","message":"Patch Set 5:\n\nStarted build for patchset #5 on: https://buildkite.com/tvl/depot/builds/19452","accounts_in_message":[],"_revision_number":5},{"id":"ed59457c7007334d6f5bdafcbe60aa59cbb26edc","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-15 17:47:16.000000000","message":"Patch Set 5: Verified+1\n\nBuild of patchset 5 passed: https://buildkite.com/tvl/depot/builds/19452","accounts_in_message":[],"_revision_number":5},{"id":"7cdcb967ac369c50de13727a4e586a9140e3c9ad","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-16 12:03:49.000000000","message":"Uploaded patch set 6: Patch Set 5 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":6},{"id":"d92c9966b683d1af49edf1822322c14393e00c46","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-16 12:04:05.000000000","message":"Patch Set 6:\n\nStarted build for patchset #6 on: https://buildkite.com/tvl/depot/builds/19541","accounts_in_message":[],"_revision_number":6},{"id":"e49a15fefb22e3ab4d735c0af20dc45d77fcece2","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-16 12:11:08.000000000","message":"Patch Set 6: Verified-1\n\nBuild of patchset 6 failed: https://buildkite.com/tvl/depot/builds/19541","accounts_in_message":[],"_revision_number":6},{"id":"af7924533a77fdb58d99d5cf7d9018029d731e98","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-16 12:14:54.000000000","message":"Uploaded patch set 7: Patch Set 6 was rebased.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":7},{"id":"e7681c0bc1665a1401ff5b34d06150675dc417b8","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-16 12:15:07.000000000","message":"Patch Set 7:\n\nStarted build for patchset #7 on: https://buildkite.com/tvl/depot/builds/19568","accounts_in_message":[],"_revision_number":7},{"id":"a902254d72a8e1ca89032c43c120467386fe0f08","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-16 12:20:21.000000000","message":"Patch Set 7: Verified-1\n\nBuild of patchset 7 failed: https://buildkite.com/tvl/depot/builds/19568","accounts_in_message":[],"_revision_number":7},{"id":"436b0971d70f1d9a8ca6b089d58735eb8eaf9da1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-16 13:18:03.000000000","message":"Uploaded patch set 8: Patch Set 7 was rebased.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":8},{"id":"61b62081e4026a13b11f67960c4b777e760ae1c2","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-16 13:18:19.000000000","message":"Patch Set 8:\n\nStarted build for patchset #8 on: https://buildkite.com/tvl/depot/builds/19597","accounts_in_message":[],"_revision_number":8},{"id":"1cade72170a101357f2d4563bf0d5d756ef7f57d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-16 13:27:25.000000000","message":"Patch Set 8: Verified+1\n\nBuild of patchset 8 passed: https://buildkite.com/tvl/depot/builds/19597","accounts_in_message":[],"_revision_number":8},{"id":"ff2a40f40aab8669b7c7929a1af0832e040bd70b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-16 15:34:26.000000000","message":"Uploaded patch set 9: New patch set was added with same tree, parent tree, and commit message as Patch Set 8.\n\nCopied Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":9},{"id":"af1228cbfea1e099523ee5200264023aaccdde64","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-16 15:34:26.000000000","message":"\u003cGERRIT_ACCOUNT_1000034\u003e, who was added as reviewer owns the following files:\n* tvix/eval/src/compiler/mod.rs\n* tvix/eval/src/compiler/scope.rs\n","accounts_in_message":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}],"_revision_number":9},{"id":"13775a11347724d2b66d1d984e4979b0e4fe4a64","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-16 15:34:26.000000000","message":"\u003cGERRIT_ACCOUNT_1000010\u003e, who was added as reviewer owns the following files:\n* tvix/eval/src/compiler/mod.rs\n* tvix/eval/src/compiler/scope.rs\n","accounts_in_message":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"_revision_number":9},{"id":"7cd21e0d6340cdbff97c325a6fb9d57646fb65cc","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-16 15:34:26.000000000","message":"\u003cGERRIT_ACCOUNT_1000036\u003e, who was added as reviewer owns the following files:\n* tvix/eval/src/compiler/mod.rs\n* tvix/eval/src/compiler/scope.rs\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":9},{"id":"7a5a1669fe6e9d632daa090825111ed991e0c858","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-18 15:50:33.000000000","message":"Uploaded patch set 10: Patch Set 9 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":10},{"id":"6263d20e3a744aac13b920b4be34e4fdb2fa1e14","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-18 15:50:52.000000000","message":"Patch Set 10:\n\nStarted build for patchset #10 on: https://buildkite.com/tvl/depot/builds/19626","accounts_in_message":[],"_revision_number":10},{"id":"5d690e1a14835506a84ce19b2aa4b0029edfa6b6","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-18 15:58:04.000000000","message":"Patch Set 10: Verified+1\n\nBuild of patchset 10 passed: https://buildkite.com/tvl/depot/builds/19626","accounts_in_message":[],"_revision_number":10},{"id":"cf531ec42dd4754ae5e6534921a58034a9bdfae6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-20 15:44:41.000000000","message":"Uploaded patch set 11: Patch Set 10 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":11},{"id":"392f39166b962820d3128fcf517931ef198b74b4","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-20 15:44:59.000000000","message":"Patch Set 11:\n\nStarted build for patchset #11 on: https://buildkite.com/tvl/depot/builds/19670","accounts_in_message":[],"_revision_number":11},{"id":"0914b780e31901ba2e42751ffe2b02b317fd1571","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-20 15:53:44.000000000","message":"Patch Set 11: Verified+1\n\nBuild of patchset 11 passed: https://buildkite.com/tvl/depot/builds/19670","accounts_in_message":[],"_revision_number":11},{"id":"c0de5c9b393e469a1f584a12a35add92d49efab4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-21 13:10:03.000000000","message":"Uploaded patch set 12: Patch Set 11 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":12},{"id":"013c100df1a75d034f895cfcc33c8272eb2ed35e","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-21 13:10:20.000000000","message":"Patch Set 12:\n\nStarted build for patchset #12 on: https://buildkite.com/tvl/depot/builds/19737","accounts_in_message":[],"_revision_number":12},{"id":"3a96db06d894a3d141c44ea8d8a592a34f17788c","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-21 13:19:12.000000000","message":"Patch Set 12: Verified+1\n\nBuild of patchset 12 passed: https://buildkite.com/tvl/depot/builds/19737","accounts_in_message":[],"_revision_number":12},{"id":"f6b124c06d109147bbc6f7bf6379167690e5d359","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2022-12-21 13:39:16.000000000","message":"Patch Set 12: Code-Review+2\n\nBy voting Code-Review+2 the following files are now code-owner approved by \u003cGERRIT_ACCOUNT_1000010\u003e:\n* tvix/eval/src/compiler/mod.rs\n* tvix/eval/src/compiler/scope.rs\n","accounts_in_message":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"_revision_number":12},{"id":"515411d40b1d372a9213108a47f5fb4c2567a82d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-21 14:31:06.000000000","message":"Uploaded patch set 13: Patch Set 12 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"((is:ANY AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":13},{"id":"d9655b62c49d2eca18e901d64ef328825599a7e2","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-21 14:31:13.000000000","message":"Patch Set 13:\n\nStarted build for patchset #13 on: https://buildkite.com/tvl/depot/builds/19851","accounts_in_message":[],"_revision_number":13},{"id":"aae07460b23be23d084e84f62844c8b50cf1fdf0","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-21 14:36:11.000000000","message":"Patch Set 13: Verified-1\n\nBuild of patchset 13 failed: https://buildkite.com/tvl/depot/builds/19851","accounts_in_message":[],"_revision_number":13},{"id":"bbfc37d86496e238538a42df9ffbe5e707557ed5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-21 14:39:11.000000000","message":"Uploaded patch set 14: Patch Set 13 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"((is:ANY AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":14},{"id":"9961033c65bdaa90972483d0d86dbdfa3e4b2c91","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-21 14:39:19.000000000","message":"Patch Set 14:\n\nStarted build for patchset #14 on: https://buildkite.com/tvl/depot/builds/19876","accounts_in_message":[],"_revision_number":14},{"id":"aa769ab99899e15efb2d6ce3f4a8ea200c248500","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-21 14:46:19.000000000","message":"Patch Set 14: Verified+1\n\nBuild of patchset 14 passed: https://buildkite.com/tvl/depot/builds/19876","accounts_in_message":[],"_revision_number":14},{"id":"272ebc331a84179b6f7b6ecf355ed8ddeb56ebed","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-21 21:37:28.000000000","message":"Uploaded patch set 15: Patch Set 14 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"((is:ANY AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":15},{"id":"6d9029e213e7a02934254bfff923958e2f8ef299","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-21 21:37:31.000000000","message":"Patch Set 15:\n\nStarted build for patchset #15 on: https://buildkite.com/tvl/depot/builds/19964","accounts_in_message":[],"_revision_number":15},{"id":"97d093d9af7d5b2566166e73d484b5a27aa09176","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2022-12-21 21:40:34.000000000","message":"Patch Set 15: Verified+1\n\nBuild of patchset 15 passed: https://buildkite.com/tvl/depot/builds/19964","accounts_in_message":[],"_revision_number":15},{"id":"14615ccf8e5eda32b12ab99deeb6b3bcc9991bb9","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2022-12-21 21:48:08.000000000","message":"Change has been successfully rebased and submitted as 87995ed35575e31ee881c796a901fdf4005a6ccb\n\n12 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":16}],"current_revision_number":16,"current_revision":"87995ed35575e31ee881c796a901fdf4005a6ccb","revisions":{"0665288876ccded88e87bb5fbd81799fcbf2be1e":{"kind":"REWORK","_number":1,"created":"2022-12-12 00:02:55.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/60/7560/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/7560/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/7560/1"}}},"commit":{"parents":[{"commit":"1b14d1768152b32dcfdb4b14083eef783142e07d","subject":"refactor(tvix/eval): add a LightSpan type for lighter span tracking","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1b14d1768152b32dcfdb4b14083eef783142e07d"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 00:00:12.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 00:00:12.000000000","tz":180},"subject":"refactor(tvix/eval): add name-based index over compiler\u0027s locals","message":"refactor(tvix/eval): add name-based index over compiler\u0027s locals\n\nInstead of finding locals by doing 2x O(n) walks over the compiler\u0027s\nlocals list, use a secondary name-based index for resolving locals by\nname.\n\nPreviously, almost 60% (!!) of eval time on some expressions over\nnixpkgs was spent in `Local::has_name`. This function doesn\u0027t even\nexist anymore now, and eval speed about doubles as a result.\n\nNote that this doesn\u0027t exactly make the locals code easier to read,\nbut I\u0027m also not sure what we can simplify in there in general.\n\nThis fixes b/227.\n\nChange-Id: I29ce5eb9452b02d3b358c673e1f5cf8082e2fef9\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0665288876ccded88e87bb5fbd81799fcbf2be1e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0665288876ccded88e87bb5fbd81799fcbf2be1e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1b14d1768152b32dcfdb4b14083eef783142e07d","is_merged_in_target_branch":false,"change_id":"I27d4c4b5c5f9be90ac47f2db61941e123a78a77b","change_number":7558,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"c2796ddcd207c6cd25d6f7395230862cd0f1d1aa":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-12-12 09:14:35.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/60/7560/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/7560/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/7560/2"}}},"commit":{"parents":[{"commit":"1de50db39d10d8356f8816ccf14f07982a5e6095","subject":"refactor(tvix/eval): add a LightSpan type for lighter span tracking","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1de50db39d10d8356f8816ccf14f07982a5e6095"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 00:00:12.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 09:14:17.000000000","tz":180},"subject":"refactor(tvix/eval): add name-based index over compiler\u0027s locals","message":"refactor(tvix/eval): add name-based index over compiler\u0027s locals\n\nInstead of finding locals by doing 2x O(n) walks over the compiler\u0027s\nlocals list, use a secondary name-based index for resolving locals by\nname.\n\nPreviously, almost 60% (!!) of eval time on some expressions over\nnixpkgs was spent in `Local::has_name`. This function doesn\u0027t even\nexist anymore now, and eval speed about doubles as a result.\n\nNote that this doesn\u0027t exactly make the locals code easier to read,\nbut I\u0027m also not sure what we can simplify in there in general.\n\nThis fixes b/227.\n\nChange-Id: I29ce5eb9452b02d3b358c673e1f5cf8082e2fef9\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc2796ddcd207c6cd25d6f7395230862cd0f1d1aa"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc2796ddcd207c6cd25d6f7395230862cd0f1d1aa"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1de50db39d10d8356f8816ccf14f07982a5e6095","is_merged_in_target_branch":false,"change_id":"I27d4c4b5c5f9be90ac47f2db61941e123a78a77b","change_number":7558,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"a3c6ab68bec2612eb3f743227a77a2b74c943b87":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2022-12-12 11:09:16.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/60/7560/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/7560/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/7560/3"}}},"commit":{"parents":[{"commit":"4fd649583df4f583204e056a472be259ad0d272d","subject":"refactor(tvix/eval): add a LightSpan type for lighter span tracking","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4fd649583df4f583204e056a472be259ad0d272d"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 00:00:12.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 11:09:12.000000000","tz":180},"subject":"refactor(tvix/eval): add name-based index over compiler\u0027s locals","message":"refactor(tvix/eval): add name-based index over compiler\u0027s locals\n\nInstead of finding locals by doing 2x O(n) walks over the compiler\u0027s\nlocals list, use a secondary name-based index for resolving locals by\nname.\n\nPreviously, almost 60% (!!) of eval time on some expressions over\nnixpkgs was spent in `Local::has_name`. This function doesn\u0027t even\nexist anymore now, and eval speed about doubles as a result.\n\nNote that this doesn\u0027t exactly make the locals code easier to read,\nbut I\u0027m also not sure what we can simplify in there in general.\n\nThis fixes b/227.\n\nChange-Id: I29ce5eb9452b02d3b358c673e1f5cf8082e2fef9\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da3c6ab68bec2612eb3f743227a77a2b74c943b87"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da3c6ab68bec2612eb3f743227a77a2b74c943b87"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"4fd649583df4f583204e056a472be259ad0d272d","is_merged_in_target_branch":false,"change_id":"I27d4c4b5c5f9be90ac47f2db61941e123a78a77b","change_number":7558,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"7e537cd7cf741db0a12fca6ed5a3780b468b4bfd":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2022-12-12 21:14:47.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/60/7560/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/7560/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/7560/4"}}},"commit":{"parents":[{"commit":"a384a4d0c222d49e80cb6b85392266a66260657c","subject":"refactor(tvix/eval): add a LightSpan type for lighter span tracking","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da384a4d0c222d49e80cb6b85392266a66260657c"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 00:00:12.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 21:14:44.000000000","tz":180},"subject":"refactor(tvix/eval): add name-based index over compiler\u0027s locals","message":"refactor(tvix/eval): add name-based index over compiler\u0027s locals\n\nInstead of finding locals by doing 2x O(n) walks over the compiler\u0027s\nlocals list, use a secondary name-based index for resolving locals by\nname.\n\nPreviously, almost 60% (!!) of eval time on some expressions over\nnixpkgs was spent in `Local::has_name`. This function doesn\u0027t even\nexist anymore now, and eval speed about doubles as a result.\n\nNote that this doesn\u0027t exactly make the locals code easier to read,\nbut I\u0027m also not sure what we can simplify in there in general.\n\nThis fixes b/227.\n\nChange-Id: I29ce5eb9452b02d3b358c673e1f5cf8082e2fef9\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7e537cd7cf741db0a12fca6ed5a3780b468b4bfd"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7e537cd7cf741db0a12fca6ed5a3780b468b4bfd"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a384a4d0c222d49e80cb6b85392266a66260657c","is_merged_in_target_branch":false,"change_id":"I27d4c4b5c5f9be90ac47f2db61941e123a78a77b","change_number":7558,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"0963f7f9a44c1c8a5dc0f387b2455d19dc09eacb":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2022-12-15 17:39:08.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/60/7560/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/7560/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/7560/5"}}},"commit":{"parents":[{"commit":"9286901c54d59a32d7e3c4bc408747e5e6db9bc8","subject":"refactor(tvix/eval): add a LightSpan type for lighter span tracking","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9286901c54d59a32d7e3c4bc408747e5e6db9bc8"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 00:00:12.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-15 17:39:05.000000000","tz":180},"subject":"refactor(tvix/eval): add name-based index over compiler\u0027s locals","message":"refactor(tvix/eval): add name-based index over compiler\u0027s locals\n\nInstead of finding locals by doing 2x O(n) walks over the compiler\u0027s\nlocals list, use a secondary name-based index for resolving locals by\nname.\n\nPreviously, almost 60% (!!) of eval time on some expressions over\nnixpkgs was spent in `Local::has_name`. This function doesn\u0027t even\nexist anymore now, and eval speed about doubles as a result.\n\nNote that this doesn\u0027t exactly make the locals code easier to read,\nbut I\u0027m also not sure what we can simplify in there in general.\n\nThis fixes b/227.\n\nChange-Id: I29ce5eb9452b02d3b358c673e1f5cf8082e2fef9\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0963f7f9a44c1c8a5dc0f387b2455d19dc09eacb"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0963f7f9a44c1c8a5dc0f387b2455d19dc09eacb"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"9286901c54d59a32d7e3c4bc408747e5e6db9bc8","is_merged_in_target_branch":false,"change_id":"I27d4c4b5c5f9be90ac47f2db61941e123a78a77b","change_number":7558,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"2d54a20c465fdcd73c05660ade2d181ba9dc8ccc":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2022-12-16 12:03:49.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/60/7560/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/7560/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/7560/6"}}},"commit":{"parents":[{"commit":"b86b6ab90d066b26c77bf3a7c13221069146b3dc","subject":"refactor(tvix/eval): add a LightSpan type for lighter span tracking","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db86b6ab90d066b26c77bf3a7c13221069146b3dc"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 00:00:12.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-16 12:02:18.000000000","tz":180},"subject":"refactor(tvix/eval): add name-based index over compiler\u0027s locals","message":"refactor(tvix/eval): add name-based index over compiler\u0027s locals\n\nInstead of finding locals by doing 2x O(n) walks over the compiler\u0027s\nlocals list, use a secondary name-based index for resolving locals by\nname.\n\nPreviously, almost 60% (!!) of eval time on some expressions over\nnixpkgs was spent in `Local::has_name`. This function doesn\u0027t even\nexist anymore now, and eval speed about doubles as a result.\n\nNote that this doesn\u0027t exactly make the locals code easier to read,\nbut I\u0027m also not sure what we can simplify in there in general.\n\nThis fixes b/227.\n\nChange-Id: I29ce5eb9452b02d3b358c673e1f5cf8082e2fef9\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2d54a20c465fdcd73c05660ade2d181ba9dc8ccc"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2d54a20c465fdcd73c05660ade2d181ba9dc8ccc"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b86b6ab90d066b26c77bf3a7c13221069146b3dc","is_merged_in_target_branch":false,"change_id":"I27d4c4b5c5f9be90ac47f2db61941e123a78a77b","change_number":7558,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"5d0701538694aad6544fbb6b543c3376fc1550db":{"kind":"TRIVIAL_REBASE","_number":7,"created":"2022-12-16 12:14:54.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/60/7560/7","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/7560/7","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/7560/7"}}},"commit":{"parents":[{"commit":"b79c383d4cb27b1ac90b8c0bd443ab42b9e15785","subject":"refactor(tvix/eval): add a LightSpan type for lighter span tracking","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db79c383d4cb27b1ac90b8c0bd443ab42b9e15785"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 00:00:12.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-16 12:14:48.000000000","tz":180},"subject":"refactor(tvix/eval): add name-based index over compiler\u0027s locals","message":"refactor(tvix/eval): add name-based index over compiler\u0027s locals\n\nInstead of finding locals by doing 2x O(n) walks over the compiler\u0027s\nlocals list, use a secondary name-based index for resolving locals by\nname.\n\nPreviously, almost 60% (!!) of eval time on some expressions over\nnixpkgs was spent in `Local::has_name`. This function doesn\u0027t even\nexist anymore now, and eval speed about doubles as a result.\n\nNote that this doesn\u0027t exactly make the locals code easier to read,\nbut I\u0027m also not sure what we can simplify in there in general.\n\nThis fixes b/227.\n\nChange-Id: I29ce5eb9452b02d3b358c673e1f5cf8082e2fef9\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5d0701538694aad6544fbb6b543c3376fc1550db"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5d0701538694aad6544fbb6b543c3376fc1550db"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b79c383d4cb27b1ac90b8c0bd443ab42b9e15785","is_merged_in_target_branch":false,"change_id":"I27d4c4b5c5f9be90ac47f2db61941e123a78a77b","change_number":7558,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"e4996915bcecb14f0f4c3e3ae4404c9c862e425f":{"kind":"TRIVIAL_REBASE","_number":8,"created":"2022-12-16 13:18:03.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/60/7560/8","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/7560/8","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/7560/8"}}},"commit":{"parents":[{"commit":"973e510b316a5f63e1cae1d105f45c62b7f3739d","subject":"refactor(tvix/eval): add a LightSpan type for lighter span tracking","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d973e510b316a5f63e1cae1d105f45c62b7f3739d"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 00:00:12.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-16 13:17:11.000000000","tz":180},"subject":"refactor(tvix/eval): add name-based index over compiler\u0027s locals","message":"refactor(tvix/eval): add name-based index over compiler\u0027s locals\n\nInstead of finding locals by doing 2x O(n) walks over the compiler\u0027s\nlocals list, use a secondary name-based index for resolving locals by\nname.\n\nPreviously, almost 60% (!!) of eval time on some expressions over\nnixpkgs was spent in `Local::has_name`. This function doesn\u0027t even\nexist anymore now, and eval speed about doubles as a result.\n\nNote that this doesn\u0027t exactly make the locals code easier to read,\nbut I\u0027m also not sure what we can simplify in there in general.\n\nThis fixes b/227.\n\nChange-Id: I29ce5eb9452b02d3b358c673e1f5cf8082e2fef9\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de4996915bcecb14f0f4c3e3ae4404c9c862e425f"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de4996915bcecb14f0f4c3e3ae4404c9c862e425f"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"973e510b316a5f63e1cae1d105f45c62b7f3739d","is_merged_in_target_branch":false,"change_id":"I27d4c4b5c5f9be90ac47f2db61941e123a78a77b","change_number":7558,"patch_set_number":8,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"3bd5cc2667b579b2363f21291f7dd18772d4ff1b":{"kind":"NO_CHANGE","_number":9,"created":"2022-12-16 15:34:26.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/60/7560/9","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/7560/9","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/7560/9"}}},"commit":{"parents":[{"commit":"b4bc84b50a52bf92e91f38cbdef828d4fe2fe419","subject":"refactor(tvix/eval): add a LightSpan type for lighter span tracking","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db4bc84b50a52bf92e91f38cbdef828d4fe2fe419"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 00:00:12.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-16 15:31:27.000000000","tz":180},"subject":"refactor(tvix/eval): add name-based index over compiler\u0027s locals","message":"refactor(tvix/eval): add name-based index over compiler\u0027s locals\n\nInstead of finding locals by doing 2x O(n) walks over the compiler\u0027s\nlocals list, use a secondary name-based index for resolving locals by\nname.\n\nPreviously, almost 60% (!!) of eval time on some expressions over\nnixpkgs was spent in `Local::has_name`. This function doesn\u0027t even\nexist anymore now, and eval speed about doubles as a result.\n\nNote that this doesn\u0027t exactly make the locals code easier to read,\nbut I\u0027m also not sure what we can simplify in there in general.\n\nThis fixes b/227.\n\nChange-Id: I29ce5eb9452b02d3b358c673e1f5cf8082e2fef9\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3bd5cc2667b579b2363f21291f7dd18772d4ff1b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3bd5cc2667b579b2363f21291f7dd18772d4ff1b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b4bc84b50a52bf92e91f38cbdef828d4fe2fe419","is_merged_in_target_branch":false,"change_id":"I27d4c4b5c5f9be90ac47f2db61941e123a78a77b","change_number":7558,"patch_set_number":9,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"37bd8a2bb2ca9a389d3a1ffa31fe61f201c50312":{"kind":"TRIVIAL_REBASE","_number":10,"created":"2022-12-18 15:50:33.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/60/7560/10","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/7560/10","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/7560/10"}}},"commit":{"parents":[{"commit":"88b4fc8e79e426384c4eb6c07407696645bc013c","subject":"refactor(tvix/eval): add a LightSpan type for lighter span tracking","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d88b4fc8e79e426384c4eb6c07407696645bc013c"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 00:00:12.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-18 15:24:08.000000000","tz":180},"subject":"refactor(tvix/eval): add name-based index over compiler\u0027s locals","message":"refactor(tvix/eval): add name-based index over compiler\u0027s locals\n\nInstead of finding locals by doing 2x O(n) walks over the compiler\u0027s\nlocals list, use a secondary name-based index for resolving locals by\nname.\n\nPreviously, almost 60% (!!) of eval time on some expressions over\nnixpkgs was spent in `Local::has_name`. This function doesn\u0027t even\nexist anymore now, and eval speed about doubles as a result.\n\nNote that this doesn\u0027t exactly make the locals code easier to read,\nbut I\u0027m also not sure what we can simplify in there in general.\n\nThis fixes b/227.\n\nChange-Id: I29ce5eb9452b02d3b358c673e1f5cf8082e2fef9\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d37bd8a2bb2ca9a389d3a1ffa31fe61f201c50312"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d37bd8a2bb2ca9a389d3a1ffa31fe61f201c50312"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"88b4fc8e79e426384c4eb6c07407696645bc013c","is_merged_in_target_branch":false,"change_id":"I27d4c4b5c5f9be90ac47f2db61941e123a78a77b","change_number":7558,"patch_set_number":10,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"5d44d72a121d8f5c48d019c46f49d9dae0b0a38f":{"kind":"TRIVIAL_REBASE","_number":11,"created":"2022-12-20 15:44:41.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/60/7560/11","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/7560/11","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/7560/11"}}},"commit":{"parents":[{"commit":"2896aabee4a9029250cf871ee27fe478aea6c969","subject":"refactor(tvix/eval): add a LightSpan type for lighter span tracking","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2896aabee4a9029250cf871ee27fe478aea6c969"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 00:00:12.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-20 15:44:39.000000000","tz":180},"subject":"refactor(tvix/eval): add name-based index over compiler\u0027s locals","message":"refactor(tvix/eval): add name-based index over compiler\u0027s locals\n\nInstead of finding locals by doing 2x O(n) walks over the compiler\u0027s\nlocals list, use a secondary name-based index for resolving locals by\nname.\n\nPreviously, almost 60% (!!) of eval time on some expressions over\nnixpkgs was spent in `Local::has_name`. This function doesn\u0027t even\nexist anymore now, and eval speed about doubles as a result.\n\nNote that this doesn\u0027t exactly make the locals code easier to read,\nbut I\u0027m also not sure what we can simplify in there in general.\n\nThis fixes b/227.\n\nChange-Id: I29ce5eb9452b02d3b358c673e1f5cf8082e2fef9\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5d44d72a121d8f5c48d019c46f49d9dae0b0a38f"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5d44d72a121d8f5c48d019c46f49d9dae0b0a38f"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2896aabee4a9029250cf871ee27fe478aea6c969","is_merged_in_target_branch":false,"change_id":"I27d4c4b5c5f9be90ac47f2db61941e123a78a77b","change_number":7558,"patch_set_number":11,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"72a45add468f2183f984002ab5ebf16ae970084d":{"kind":"TRIVIAL_REBASE","_number":12,"created":"2022-12-21 13:10:03.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/60/7560/12","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/7560/12","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/7560/12"}}},"commit":{"parents":[{"commit":"6d85c5eefe0cdea877269692b00c63312d803b4d","subject":"refactor(tvix/eval): add a LightSpan type for lighter span tracking","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6d85c5eefe0cdea877269692b00c63312d803b4d"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 00:00:12.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-21 13:10:00.000000000","tz":180},"subject":"refactor(tvix/eval): add name-based index over compiler\u0027s locals","message":"refactor(tvix/eval): add name-based index over compiler\u0027s locals\n\nInstead of finding locals by doing 2x O(n) walks over the compiler\u0027s\nlocals list, use a secondary name-based index for resolving locals by\nname.\n\nPreviously, almost 60% (!!) of eval time on some expressions over\nnixpkgs was spent in `Local::has_name`. This function doesn\u0027t even\nexist anymore now, and eval speed about doubles as a result.\n\nNote that this doesn\u0027t exactly make the locals code easier to read,\nbut I\u0027m also not sure what we can simplify in there in general.\n\nThis fixes b/227.\n\nChange-Id: I29ce5eb9452b02d3b358c673e1f5cf8082e2fef9\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d72a45add468f2183f984002ab5ebf16ae970084d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d72a45add468f2183f984002ab5ebf16ae970084d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6d85c5eefe0cdea877269692b00c63312d803b4d","is_merged_in_target_branch":false,"change_id":"I27d4c4b5c5f9be90ac47f2db61941e123a78a77b","change_number":7558,"patch_set_number":12,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"6979bf7d017039f167bd8d56192a58167f8b86de":{"kind":"TRIVIAL_REBASE","_number":13,"created":"2022-12-21 14:31:06.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/60/7560/13","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/7560/13","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/13 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/13 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/13 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/7560/13"}}},"commit":{"parents":[{"commit":"1851ef119b50fbfb09176e83474e9f750f83581b","subject":"refactor(tvix/eval): add a LightSpan type for lighter span tracking","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1851ef119b50fbfb09176e83474e9f750f83581b"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 00:00:12.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-21 14:30:07.000000000","tz":180},"subject":"refactor(tvix/eval): add name-based index over compiler\u0027s locals","message":"refactor(tvix/eval): add name-based index over compiler\u0027s locals\n\nInstead of finding locals by doing 2x O(n) walks over the compiler\u0027s\nlocals list, use a secondary name-based index for resolving locals by\nname.\n\nPreviously, almost 60% (!!) of eval time on some expressions over\nnixpkgs was spent in `Local::has_name`. This function doesn\u0027t even\nexist anymore now, and eval speed about doubles as a result.\n\nNote that this doesn\u0027t exactly make the locals code easier to read,\nbut I\u0027m also not sure what we can simplify in there in general.\n\nThis fixes b/227.\n\nChange-Id: I29ce5eb9452b02d3b358c673e1f5cf8082e2fef9\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6979bf7d017039f167bd8d56192a58167f8b86de"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6979bf7d017039f167bd8d56192a58167f8b86de"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1851ef119b50fbfb09176e83474e9f750f83581b","is_merged_in_target_branch":false,"change_id":"I27d4c4b5c5f9be90ac47f2db61941e123a78a77b","change_number":7558,"patch_set_number":13,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"4991f45b5cea5f97b118470de8fbbb4ba6a4609c":{"kind":"TRIVIAL_REBASE","_number":14,"created":"2022-12-21 14:39:11.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/60/7560/14","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/7560/14","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/14 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/14 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/14 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/7560/14"}}},"commit":{"parents":[{"commit":"2d05621ed774a0ad4bb378eaf7857bfd20ae75e8","subject":"refactor(tvix/eval): add a LightSpan type for lighter span tracking","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2d05621ed774a0ad4bb378eaf7857bfd20ae75e8"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 00:00:12.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-21 14:39:05.000000000","tz":180},"subject":"refactor(tvix/eval): add name-based index over compiler\u0027s locals","message":"refactor(tvix/eval): add name-based index over compiler\u0027s locals\n\nInstead of finding locals by doing 2x O(n) walks over the compiler\u0027s\nlocals list, use a secondary name-based index for resolving locals by\nname.\n\nPreviously, almost 60% (!!) of eval time on some expressions over\nnixpkgs was spent in `Local::has_name`. This function doesn\u0027t even\nexist anymore now, and eval speed about doubles as a result.\n\nNote that this doesn\u0027t exactly make the locals code easier to read,\nbut I\u0027m also not sure what we can simplify in there in general.\n\nThis fixes b/227.\n\nChange-Id: I29ce5eb9452b02d3b358c673e1f5cf8082e2fef9\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4991f45b5cea5f97b118470de8fbbb4ba6a4609c"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4991f45b5cea5f97b118470de8fbbb4ba6a4609c"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2d05621ed774a0ad4bb378eaf7857bfd20ae75e8","is_merged_in_target_branch":false,"change_id":"I27d4c4b5c5f9be90ac47f2db61941e123a78a77b","change_number":7558,"patch_set_number":14,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"d7e581d1ea5b1b06244ec2275d48cdd472932ff3":{"kind":"TRIVIAL_REBASE","_number":15,"created":"2022-12-21 21:37:28.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/60/7560/15","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/7560/15","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/15 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/15 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/15 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/7560/15"}}},"commit":{"parents":[{"commit":"922bf7aca9f4d4f4834ba5de7841ff58015c8791","subject":"feat(tvix/eval): remove `derive(Copy)` from Upvalues","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d922bf7aca9f4d4f4834ba5de7841ff58015c8791"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 00:00:12.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-21 21:28:21.000000000","tz":180},"subject":"refactor(tvix/eval): add name-based index over compiler\u0027s locals","message":"refactor(tvix/eval): add name-based index over compiler\u0027s locals\n\nInstead of finding locals by doing 2x O(n) walks over the compiler\u0027s\nlocals list, use a secondary name-based index for resolving locals by\nname.\n\nPreviously, almost 60% (!!) of eval time on some expressions over\nnixpkgs was spent in `Local::has_name`. This function doesn\u0027t even\nexist anymore now, and eval speed about doubles as a result.\n\nNote that this doesn\u0027t exactly make the locals code easier to read,\nbut I\u0027m also not sure what we can simplify in there in general.\n\nThis fixes b/227.\n\nChange-Id: I29ce5eb9452b02d3b358c673e1f5cf8082e2fef9\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd7e581d1ea5b1b06244ec2275d48cdd472932ff3"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd7e581d1ea5b1b06244ec2275d48cdd472932ff3"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"922bf7aca9f4d4f4834ba5de7841ff58015c8791","is_merged_in_target_branch":true,"change_id":"I0fa069fbeff6718a765ece948c2c1bce285496f7","change_number":7449,"patch_set_number":21,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"87995ed35575e31ee881c796a901fdf4005a6ccb":{"kind":"NO_CODE_CHANGE","_number":16,"created":"2022-12-21 21:48:08.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/60/7560/16","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/60/7560/16","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/16 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/16 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/60/7560/16 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/60/7560/16"}}},"commit":{"parents":[{"commit":"922bf7aca9f4d4f4834ba5de7841ff58015c8791","subject":"feat(tvix/eval): remove `derive(Copy)` from Upvalues","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d922bf7aca9f4d4f4834ba5de7841ff58015c8791"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2022-12-12 00:00:12.000000000","tz":180},"committer":{"name":"tazjin","email":"tazjin@tvl.su","date":"2022-12-21 21:48:08.000000000","tz":0},"subject":"refactor(tvix/eval): add name-based index over compiler\u0027s locals","message":"refactor(tvix/eval): add name-based index over compiler\u0027s locals\n\nInstead of finding locals by doing 2x O(n) walks over the compiler\u0027s\nlocals list, use a secondary name-based index for resolving locals by\nname.\n\nPreviously, almost 60% (!!) of eval time on some expressions over\nnixpkgs was spent in `Local::has_name`. This function doesn\u0027t even\nexist anymore now, and eval speed about doubles as a result.\n\nNote that this doesn\u0027t exactly make the locals code easier to read,\nbut I\u0027m also not sure what we can simplify in there in general.\n\nThis fixes b/227.\n\nChange-Id: I29ce5eb9452b02d3b358c673e1f5cf8082e2fef9\nReviewed-on: https://cl.tvl.fyi/c/depot/+/7560\nReviewed-by: grfn \u003cgrfn@gws.fyi\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d87995ed35575e31ee881c796a901fdf4005a6ccb"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d87995ed35575e31ee881c796a901fdf4005a6ccb"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"922bf7aca9f4d4f4834ba5de7841ff58015c8791","is_merged_in_target_branch":true,"change_id":"I0fa069fbeff6718a765ece948c2c1bce285496f7","change_number":7449,"patch_set_number":21,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}