)]}'
{"id":"depot~7752","triplet_id":"depot~canon~Iad5d0e6f595763d86cf308c50e85a03cbf12ea6a","project":"depot","branch":"canon","hashtags":[],"change_id":"Iad5d0e6f595763d86cf308c50e85a03cbf12ea6a","subject":"feat(tvix/eval): warn about unnecessarily nested builtins","status":"NEW","created":"2023-01-04 15:23:35.000000000","updated":"2023-01-04 16:44:44.000000000","submit_type":"REBASE_ALWAYS","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"work_in_progress":true,"has_review_started":false,"meta_rev_id":"6c0d8dcd64df93836162586836538aeea644d403","_number":7752,"virtual_id_number":7752,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:buildkite~result","value":1,"date":"2023-01-04 16:44:44.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"reviewer_updates":[{"updated":"2023-01-04 15:23:35.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-01-04 15:27:27.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3051558e4d9858dfaa79b97e8b057d9097fae19a","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-01-04 15:23:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5a6d7ec48fe01e3451168aa01cc7786fe0f108d3","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-01-04 15:23:35.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/20917","accounts_in_message":[],"_revision_number":1},{"id":"c0244d5a10219a30ebcafd15bda746e32732cbc9","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-01-04 15:27:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/20917","accounts_in_message":[],"_revision_number":1},{"id":"04d39cafd733ff5d65224ad509234adae8e9c04e","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-01-04 15:57:19.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"c020d8a5828ed0e8fb0a28be97a9b496d9aac5e7","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-01-04 15:57:20.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/20925","accounts_in_message":[],"_revision_number":2},{"id":"d8dcc52b40cd4cadc17c3e26bc64bde2a539cdab","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-01-04 16:00:08.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/20925","accounts_in_message":[],"_revision_number":2},{"id":"100ae53a08d2cb59182377cd878d8731388ab0c4","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-01-04 16:00:16.000000000","message":"Uploaded patch set 3: Commit message was updated.\n\nCopied Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"6c0d8dcd64df93836162586836538aeea644d403","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-01-04 16:44:44.000000000","message":"Uploaded patch set 4: New patch set was added with same tree, parent tree, and commit message as Patch Set 3.\n\nCopied Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"144262be7173319c95d5cc222c14ff697b03e3e6","revisions":{"11b2bb6857dd63db8f9a214fafd0241756f02c83":{"kind":"REWORK","_number":1,"created":"2023-01-04 15:23:35.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/52/7752/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/52/7752/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/52/7752/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/52/7752/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/52/7752/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/52/7752/1"}}},"commit":{"parents":[{"commit":"f5702d8227a80b7b534b94a4577f9ac2a210135f","subject":"refactor(tvix/eval): non-hacky suspended native thunks","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df5702d8227a80b7b534b94a4577f9ac2a210135f"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-01-04 15:23:23.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-01-04 15:23:23.000000000","tz":180},"subject":"feat(tvix/eval): warn about unnecessarily nested builtins","message":"feat(tvix/eval): warn about unnecessarily nested builtins\n\nChange-Id: Iad5d0e6f595763d86cf308c50e85a03cbf12ea6a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d11b2bb6857dd63db8f9a214fafd0241756f02c83"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d11b2bb6857dd63db8f9a214fafd0241756f02c83"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"f5702d8227a80b7b534b94a4577f9ac2a210135f","is_merged_in_target_branch":false,"change_id":"I771d03864084d63953bdbb518fec94487481f839","change_number":7750,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"62cb97cf56fc698c020046e57a003a51e0f0fe3c":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-01-04 15:57:19.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/52/7752/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/52/7752/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/52/7752/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/52/7752/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/52/7752/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/52/7752/2"}}},"commit":{"parents":[{"commit":"147644f6e243764008c8e0a3e675d894495b4b34","subject":"refactor(tvix/eval): avoid unnecessary pop/push in OpForce","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d147644f6e243764008c8e0a3e675d894495b4b34"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-01-04 15:23:23.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-01-04 15:57:13.000000000","tz":180},"subject":"feat(tvix/eval): warn about unnecessarily nested builtins","message":"feat(tvix/eval): warn about unnecessarily nested builtins\n\nChange-Id: Iad5d0e6f595763d86cf308c50e85a03cbf12ea6a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d62cb97cf56fc698c020046e57a003a51e0f0fe3c"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d62cb97cf56fc698c020046e57a003a51e0f0fe3c"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"147644f6e243764008c8e0a3e675d894495b4b34","is_merged_in_target_branch":false,"change_id":"Ic7559eaa43aa0dcc97babb7669770c0f7f959f1b","change_number":7754,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"7e2f821fa2bb00198a5f0f3be40e453a44d77feb":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2023-01-04 16:00:16.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/52/7752/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/52/7752/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/52/7752/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/52/7752/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/52/7752/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/52/7752/3"}}},"commit":{"parents":[{"commit":"5afc3e1f4622ec225211cabcfc09c1d5e9051473","subject":"refactor(tvix/eval): avoid unnecessary pop/push in OpForce","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5afc3e1f4622ec225211cabcfc09c1d5e9051473"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-01-04 15:23:23.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-01-04 16:00:03.000000000","tz":180},"subject":"feat(tvix/eval): warn about unnecessarily nested builtins","message":"feat(tvix/eval): warn about unnecessarily nested builtins\n\nMarked WIP for now as `builtins.builtins` crashes with this commit.\n\nThis makes it possible to reproduce b/238.\n\nChange-Id: Iad5d0e6f595763d86cf308c50e85a03cbf12ea6a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7e2f821fa2bb00198a5f0f3be40e453a44d77feb"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7e2f821fa2bb00198a5f0f3be40e453a44d77feb"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"5afc3e1f4622ec225211cabcfc09c1d5e9051473","is_merged_in_target_branch":false,"change_id":"Ic7559eaa43aa0dcc97babb7669770c0f7f959f1b","change_number":7754,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"144262be7173319c95d5cc222c14ff697b03e3e6":{"kind":"NO_CHANGE","_number":4,"created":"2023-01-04 16:44:44.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/52/7752/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/52/7752/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/52/7752/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/52/7752/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/52/7752/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/52/7752/4"}}},"commit":{"parents":[{"commit":"40983efd6807e9d91a6ccb5885ad75c1583cd2b1","subject":"refactor(tvix/eval): non-hacky suspended native thunks","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d40983efd6807e9d91a6ccb5885ad75c1583cd2b1"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-01-04 15:23:23.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-01-04 16:44:41.000000000","tz":180},"subject":"feat(tvix/eval): warn about unnecessarily nested builtins","message":"feat(tvix/eval): warn about unnecessarily nested builtins\n\nMarked WIP for now as `builtins.builtins` crashes with this commit.\n\nThis makes it possible to reproduce b/238.\n\nChange-Id: Iad5d0e6f595763d86cf308c50e85a03cbf12ea6a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d144262be7173319c95d5cc222c14ff697b03e3e6"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d144262be7173319c95d5cc222c14ff697b03e3e6"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"40983efd6807e9d91a6ccb5885ad75c1583cd2b1","is_merged_in_target_branch":false,"change_id":"I771d03864084d63953bdbb518fec94487481f839","change_number":7750,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[{"status":"OK","fallback_text":"Code-Owners","type":"code-owners"}],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"NOT_READY","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]},{"rule_name":"Code-Owners","status":"OK","requirements":[{"status":"OK","fallback_text":"Code-Owners","type":"code-owners"}]}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dgerrit~PrologRule"]}}]}