)]}'
{"tvix/cli/src/errors.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"b46ca7464a94d1f42784c95c2c8e76f0044b425c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"use std::{error, fmt::Display, rc::Rc};"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#[derive(Debug)]"},{"line_number":4,"context_line":"pub enum Error {"},{"line_number":5,"context_line":"    // Errors related to derivation construction"},{"line_number":6,"context_line":"    InvalidOutputName(String),"},{"line_number":7,"context_line":"    DuplicateOutput(String),"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"7fe42f12_b34033bf","line":4,"updated":"2023-01-16 12:28:35.000000000","message":"Shouldn\u0027t this be part of tvix/derivation, and be returned by the validate() function in there?","commit_id":"432b1de3182a0757b44637085826cd68576d169a"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"5178aae998491d08a1747f7ebf50becdbc564693","unresolved":false,"context_lines":[{"line_number":1,"context_line":"use std::{error, fmt::Display, rc::Rc};"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#[derive(Debug)]"},{"line_number":4,"context_line":"pub enum Error {"},{"line_number":5,"context_line":"    // Errors related to derivation construction"},{"line_number":6,"context_line":"    InvalidOutputName(String),"},{"line_number":7,"context_line":"    DuplicateOutput(String),"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"fb488198_409e6574","line":4,"in_reply_to":"2ac30a99_fe88e7f4","updated":"2023-01-20 08:37:02.000000000","message":"Done","commit_id":"432b1de3182a0757b44637085826cd68576d169a"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"151b1f07f1eace610cb9a2bfbb016251e97baafe","unresolved":true,"context_lines":[{"line_number":1,"context_line":"use std::{error, fmt::Display, rc::Rc};"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#[derive(Debug)]"},{"line_number":4,"context_line":"pub enum Error {"},{"line_number":5,"context_line":"    // Errors related to derivation construction"},{"line_number":6,"context_line":"    InvalidOutputName(String),"},{"line_number":7,"context_line":"    DuplicateOutput(String),"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"2ac30a99_fe88e7f4","line":4,"in_reply_to":"6c1fc4a9_212a3f30","updated":"2023-01-20 08:36:35.000000000","message":"Rebased on those new errors and added them to the variant here.","commit_id":"432b1de3182a0757b44637085826cd68576d169a"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"0e0158598de375cba86676873164623e9a0b6818","unresolved":true,"context_lines":[{"line_number":1,"context_line":"use std::{error, fmt::Display, rc::Rc};"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#[derive(Debug)]"},{"line_number":4,"context_line":"pub enum Error {"},{"line_number":5,"context_line":"    // Errors related to derivation construction"},{"line_number":6,"context_line":"    InvalidOutputName(String),"},{"line_number":7,"context_line":"    DuplicateOutput(String),"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"6c1fc4a9_212a3f30","line":4,"in_reply_to":"72d3e53a_bdc4424e","updated":"2023-01-16 15:12:33.000000000","message":"Done in cl/7847.","commit_id":"432b1de3182a0757b44637085826cd68576d169a"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"55f63f50cb6efb4d0901813acc1d06b2e720f11c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"use std::{error, fmt::Display, rc::Rc};"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#[derive(Debug)]"},{"line_number":4,"context_line":"pub enum Error {"},{"line_number":5,"context_line":"    // Errors related to derivation construction"},{"line_number":6,"context_line":"    InvalidOutputName(String),"},{"line_number":7,"context_line":"    DuplicateOutput(String),"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"f1aadb5f_e249efde","line":4,"in_reply_to":"7fe42f12_b34033bf","updated":"2023-01-16 13:12:20.000000000","message":"Well, some of these come from eval data structures, so not directly. However, tvix/derivation *should* use typed errors instead of anyhow::Result (that\u0027s a code smell in library code).\n\nFor now these need to live somewhere, and as you can see in the WIP commit many of these errors are no longer possible to construct correctly after the Derivation structure is populated, so the obvious place is here.","commit_id":"432b1de3182a0757b44637085826cd68576d169a"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"5074d7ad53cc2cd244dab7fb550897df5bd70729","unresolved":true,"context_lines":[{"line_number":1,"context_line":"use std::{error, fmt::Display, rc::Rc};"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#[derive(Debug)]"},{"line_number":4,"context_line":"pub enum Error {"},{"line_number":5,"context_line":"    // Errors related to derivation construction"},{"line_number":6,"context_line":"    InvalidOutputName(String),"},{"line_number":7,"context_line":"    DuplicateOutput(String),"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"72d3e53a_bdc4424e","line":4,"in_reply_to":"f1aadb5f_e249efde","updated":"2023-01-16 13:23:22.000000000","message":"Only for the shadowing parts, the rest is pretty much errors that could also be emitted (in similar form) by Derivation::validate().\n\nI\u0027m up to improving the error situation in the tvix/derivation side of things if you don\u0027t want to touch it, but I don\u0027t think we should add more smell here because the errors are not (yet) properly exposed.","commit_id":"432b1de3182a0757b44637085826cd68576d169a"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"91eaaf5066f96372ed61377b9ac398c2802580ee","unresolved":true,"context_lines":[{"line_number":15,"context_line":"impl Display for Error {"},{"line_number":16,"context_line":"    fn fmt(\u0026self, f: \u0026mut std::fmt::Formatter\u003c\u0027_\u003e) -\u003e std::fmt::Result {"},{"line_number":17,"context_line":"        match self {"},{"line_number":18,"context_line":"            Error::InvalidOutputName(name) \u003d\u003e write!(f, \"invalid derivation output name: {name}\"),"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"            Error::DuplicateOutput(name) \u003d\u003e {"},{"line_number":21,"context_line":"                write!(f, \"an output with the name \u0027{name}\u0027 is already defined\")"}],"source_content_type":"text/x-rustsrc","patch_set":10,"id":"df61573b_3c44cb03","line":18,"updated":"2023-01-20 10:39:41.000000000","message":"Covered and emitted by Derivation::validate(), see comments in cl/7756.","commit_id":"c22d214bedb753404551c9b61025c8681f3dc0ce"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"980f47d034298dd145ad3148d49030b455ea813a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"impl Display for Error {"},{"line_number":16,"context_line":"    fn fmt(\u0026self, f: \u0026mut std::fmt::Formatter\u003c\u0027_\u003e) -\u003e std::fmt::Result {"},{"line_number":17,"context_line":"        match self {"},{"line_number":18,"context_line":"            Error::InvalidOutputName(name) \u003d\u003e write!(f, \"invalid derivation output name: {name}\"),"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"            Error::DuplicateOutput(name) \u003d\u003e {"},{"line_number":21,"context_line":"                write!(f, \"an output with the name \u0027{name}\u0027 is already defined\")"}],"source_content_type":"text/x-rustsrc","patch_set":10,"id":"87fdf278_5976b88a","line":18,"in_reply_to":"df61573b_3c44cb03","updated":"2023-01-20 12:24:31.000000000","message":"Done","commit_id":"c22d214bedb753404551c9b61025c8681f3dc0ce"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"91eaaf5066f96372ed61377b9ac398c2802580ee","unresolved":true,"context_lines":[{"line_number":21,"context_line":"                write!(f, \"an output with the name \u0027{name}\u0027 is already defined\")"},{"line_number":22,"context_line":"            }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"            Error::ConflictingOutputTypes \u003d\u003e write!("},{"line_number":25,"context_line":"                f,"},{"line_number":26,"context_line":"                \"fixed-output derivations can only have the default `out`-output\""},{"line_number":27,"context_line":"            ),"}],"source_content_type":"text/x-rustsrc","patch_set":10,"id":"aa3da3e1_10a1171d","line":24,"updated":"2023-01-20 10:39:41.000000000","message":"Covered and emitted by Derivation::validate(), see comments in cl/7756.","commit_id":"c22d214bedb753404551c9b61025c8681f3dc0ce"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"980f47d034298dd145ad3148d49030b455ea813a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                write!(f, \"an output with the name \u0027{name}\u0027 is already defined\")"},{"line_number":22,"context_line":"            }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"            Error::ConflictingOutputTypes \u003d\u003e write!("},{"line_number":25,"context_line":"                f,"},{"line_number":26,"context_line":"                \"fixed-output derivations can only have the default `out`-output\""},{"line_number":27,"context_line":"            ),"}],"source_content_type":"text/x-rustsrc","patch_set":10,"id":"625d891d_206654c1","line":24,"in_reply_to":"aa3da3e1_10a1171d","updated":"2023-01-20 12:24:31.000000000","message":"This one will be cleaned up later, as discussed.","commit_id":"c22d214bedb753404551c9b61025c8681f3dc0ce"}]}