)]}'
{"tvix/cli/src/derivation.nix":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"731ca10c4c51ae0c86b80a6e45747846aa690c69","unresolved":true,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# taken from: https://github.com/NixOS/nix/blob/master/src/libexpr/primops/derivation.nix"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# TODO: rewrite in native Rust code"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"/* This is the implementation of the ‘derivation’ builtin function."},{"line_number":8,"context_line":"   It\u0027s actually a wrapper around the ‘derivationStrict’ primop. */"}],"source_content_type":"text/x-nix","patch_set":13,"id":"10cdd08b_57e0c387","line":5,"updated":"2023-01-26 23:26:05.000000000","message":"I\u0027d probably put this in \"known optimization potential\" (even though I hope Tvix will become a better codegen from Nix to native than us doing it manual.\n\nIn the case of fetchurl.nix, we probably don\u0027t have a choice.","commit_id":"24cde76628c10778d6ee8ab5425c95e96eb606f8"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"b95aa9e11c5edce35f71113d2895b8e324be6ea0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# taken from: https://github.com/NixOS/nix/blob/master/src/libexpr/primops/derivation.nix"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# TODO: rewrite in native Rust code"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"/* This is the implementation of the ‘derivation’ builtin function."},{"line_number":8,"context_line":"   It\u0027s actually a wrapper around the ‘derivationStrict’ primop. */"}],"source_content_type":"text/x-nix","patch_set":13,"id":"1e5592b8_ae800afc","line":5,"in_reply_to":"10cdd08b_57e0c387","updated":"2023-01-27 00:26:38.000000000","message":"I don\u0027t know if this is a known optimisation, due to the complexity of the thunking in the mutually recursive structure we\u0027re already not going to do much better than the compiler. This is something we can think about much later, imo.","commit_id":"24cde76628c10778d6ee8ab5425c95e96eb606f8"}],"tvix/cli/src/main.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"731ca10c4c51ae0c86b80a6e45747846aa690c69","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    // Add the actual `builtins.derivation` from compiled Nix code"},{"line_number":64,"context_line":"    eval.src_builtins"},{"line_number":65,"context_line":"        .push((\"derivation\", include_str!(\"derivation.nix\")));"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    let source_map \u003d eval.source_map();"},{"line_number":68,"context_line":"    let result \u003d {"}],"source_content_type":"text/x-rustsrc","patch_set":13,"id":"93288c8b_a7240992","line":65,"updated":"2023-01-26 23:26:05.000000000","message":"Should we also vendor in `fetchurl.nix` in Tvix directly? Setting `NIX_PATH\u003dnix\u003d… manually is a bit clunky, and Nix also defaults to something usable. I\u0027m not even sure if overriding it should be possible, or is desirable…","commit_id":"24cde76628c10778d6ee8ab5425c95e96eb606f8"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"b95aa9e11c5edce35f71113d2895b8e324be6ea0","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    // Add the actual `builtins.derivation` from compiled Nix code"},{"line_number":64,"context_line":"    eval.src_builtins"},{"line_number":65,"context_line":"        .push((\"derivation\", include_str!(\"derivation.nix\")));"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    let source_map \u003d eval.source_map();"},{"line_number":68,"context_line":"    let result \u003d {"}],"source_content_type":"text/x-rustsrc","patch_set":13,"id":"035b0a77_88a232d4","line":65,"in_reply_to":"93288c8b_a7240992","updated":"2023-01-27 00:26:38.000000000","message":"Yes, but not in this commit. It needs some other spooky machinery ...","commit_id":"24cde76628c10778d6ee8ab5425c95e96eb606f8"}]}