)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"7bca19576a455c404110d5e005db60fe5be1686f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c41b0f89_685b9c57","updated":"2023-01-27 12:31:50.000000000","message":"I like that, and would be happy to rebase cl/7933 past that. Can you get this to build?","commit_id":"4328995afdf52e4a133995f8a6a887b63b6494c7"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"b77db4f4699291055570c67e57d6c5a481f922de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7aafadcd_4916b118","in_reply_to":"084e6959_9cd0fd2e","updated":"2023-01-29 12:54:49.000000000","message":"Ack","commit_id":"4328995afdf52e4a133995f8a6a887b63b6494c7"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"b0546268f8ada3e91b8e9e918c2a06ed7be91c3c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"084e6959_9cd0fd2e","in_reply_to":"c41b0f89_685b9c57","updated":"2023-01-27 12:32:12.000000000","message":"unresolved.","commit_id":"4328995afdf52e4a133995f8a6a887b63b6494c7"}],"tvix/cli/src/derivation.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"1f0a716fd39a2c15431b75b08bc8a642a0e3d9ad","unresolved":true,"context_lines":[{"line_number":173,"context_line":"        (Some(hash), Some(algo), hash_mode) \u003d\u003e match drv.outputs.get_mut(\"out\") {"},{"line_number":174,"context_line":"            None \u003d\u003e return Err(Error::ConflictingOutputTypes.into()),"},{"line_number":175,"context_line":"            Some(out) \u003d\u003e {"},{"line_number":176,"context_line":"                let algo \u003d strong_coerce_to_string("},{"line_number":177,"context_line":"                    vm,"},{"line_number":178,"context_line":"                    \u0026algo,"},{"line_number":179,"context_line":"                    \"evaluating outputHashAlgo of a derivation\","}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"5c133a0b_3c02822b","side":"PARENT","line":176,"updated":"2023-01-29 13:12:29.000000000","message":"With all of this out of the way, we can probably inline construct_output_hash again.\n\nThe only reason I put it in a separate function was because it was hard to mock the input parameters of this function.","commit_id":"81b1fc6f003f34178defef7f0c2f1746d93b1c61"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"bd745c5e3edd6b2a61c237a7882b8814e3e484a7","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        (Some(hash), Some(algo), hash_mode) \u003d\u003e match drv.outputs.get_mut(\"out\") {"},{"line_number":174,"context_line":"            None \u003d\u003e return Err(Error::ConflictingOutputTypes.into()),"},{"line_number":175,"context_line":"            Some(out) \u003d\u003e {"},{"line_number":176,"context_line":"                let algo \u003d strong_coerce_to_string("},{"line_number":177,"context_line":"                    vm,"},{"line_number":178,"context_line":"                    \u0026algo,"},{"line_number":179,"context_line":"                    \"evaluating outputHashAlgo of a derivation\","}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"723b48c3_f23fd6f0","side":"PARENT","line":176,"in_reply_to":"179865ea_f2c16b59","updated":"2023-01-30 21:46:57.000000000","message":"Well, that helper isn\u0027t only doing SRI stuff anymore, but also mutating the algo string, depending on the hashMode. This function now only has a single match unpacking.\n\nI sent cl/7961 pulling it back in, and think it\u0027s more readable - especially considering it\u0027s completing the testcases. PTAL.","commit_id":"81b1fc6f003f34178defef7f0c2f1746d93b1c61"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"301d94ae186da7bafd5c33780d42bf1a14b19eb5","unresolved":true,"context_lines":[{"line_number":173,"context_line":"        (Some(hash), Some(algo), hash_mode) \u003d\u003e match drv.outputs.get_mut(\"out\") {"},{"line_number":174,"context_line":"            None \u003d\u003e return Err(Error::ConflictingOutputTypes.into()),"},{"line_number":175,"context_line":"            Some(out) \u003d\u003e {"},{"line_number":176,"context_line":"                let algo \u003d strong_coerce_to_string("},{"line_number":177,"context_line":"                    vm,"},{"line_number":178,"context_line":"                    \u0026algo,"},{"line_number":179,"context_line":"                    \"evaluating outputHashAlgo of a derivation\","}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"179865ea_f2c16b59","side":"PARENT","line":176,"in_reply_to":"5c133a0b_3c02822b","updated":"2023-01-29 17:37:58.000000000","message":"I think it\u0027s fine to keep that separately, originally this function wasn\u0027t dealing with SRI hashes and that seems like it\u0027s own field of complexity (unrelated to figuring out which/any fields should be set in general). It\u0027s also quite a lot of code","commit_id":"81b1fc6f003f34178defef7f0c2f1746d93b1c61"}]}