)]}'
{"id":"depot~7973","triplet_id":"depot~canon~Ic745a5e5cf68417e79538946fbf06e2945db04a4","project":"depot","branch":"canon","hashtags":[],"change_id":"Ic745a5e5cf68417e79538946fbf06e2945db04a4","subject":"refactor(tvix/eval): use a union representation of ops in Chunk","status":"ABANDONED","created":"2023-01-31 22:10:37.000000000","updated":"2023-11-05 17:00:37.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"aac99d26801553b722fb4f170f5685ac5293f9e3","_number":7973,"virtual_id_number":7973,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:buildkite~result","value":1,"date":"2023-02-02 21:05:47.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-01-31 22:10:39.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-01-31 22:14:37.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"430a2ba4be4cdf031e95e7d317b7678c4ab441f3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-01-31 22:10:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bb37fb62f4f0fa0bdae9f388540bd5eddfac8150","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-01-31 22:10:39.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/21996","accounts_in_message":[],"_revision_number":1},{"id":"ef6fffd215b5e1dcbe3d06d42d2652576c1ee47f","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-01-31 22:14:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/21996","accounts_in_message":[],"_revision_number":1},{"id":"0d13d0edb3e25454e43ab849d15c1abd8b743de6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-02-01 13:40:41.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"ae362916f42910c4907ac006dbdd1a670be0bee0","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-02-01 13:40:45.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/22042","accounts_in_message":[],"_revision_number":2},{"id":"63cba829c5112e69289cb07bbfa5bebafa8c660d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-02-01 13:45:17.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/22042","accounts_in_message":[],"_revision_number":2},{"id":"0326539c99681faf29d14064997ea3b498af4dd5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-02-02 21:01:59.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"0e61572b6e90a29198b9e3dd1e678d1b8d48ea22","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-02-02 21:02:05.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/22180","accounts_in_message":[],"_revision_number":3},{"id":"7b31a84507f7d52ae44e7d81d1b82369edef0b50","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-02-02 21:05:47.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/22180","accounts_in_message":[],"_revision_number":3},{"id":"aac99d26801553b722fb4f170f5685ac5293f9e3","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-11-05 17:00:37.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"4e1aa137e61e09256b498aeda9a6712a91badd69","revisions":{"76a992c2a8596c7bd559158fe495f6b62ae7baa2":{"kind":"REWORK","_number":1,"created":"2023-01-31 22:10:37.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/73/7973/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/73/7973/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/73/7973/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/73/7973/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/73/7973/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/73/7973/1"}}},"commit":{"parents":[{"commit":"5f62cd1ad5a1217ea6b47ec826908d0b298925a9","subject":"refactor(tvix/serde): allow dead_code in struct","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5f62cd1ad5a1217ea6b47ec826908d0b298925a9"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-01-31 18:26:17.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-01-31 18:26:17.000000000","tz":180},"subject":"refactor(tvix/eval): use a union representation of ops in Chunk","message":"refactor(tvix/eval): use a union representation of ops in Chunk\n\nThis will allow us to add a `data` field to the union representation\nto significantly reduce the size of an `Op` in the code\nchunks (eventually, from the current 16 to 1 (one!) byte).\n\nHowever, this is a delicate undertaking as we can not easily verify\nthe validity of an OpCode and accessing these operations requires\n`unsafe`, which means we\u0027re on our own. A compiler bug could lead to\nsegfaults as soon as data operands are used.\n\nI believe that the cache efficiency gained by this is worth it, but it\nwill take several CLs to get there and prove this. It will likely take\nsome future pain for us to be fully confident in this, as I\u0027m already\naware of (and have annotated) at least one possible bug this can\nintroduce.\n\nI want to get this to work, and then tackle the known possible bugs\nfound along the way, and then make a decision on whether it is worth\nit.\n\nChange-Id: Ic745a5e5cf68417e79538946fbf06e2945db04a4\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d76a992c2a8596c7bd559158fe495f6b62ae7baa2"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d76a992c2a8596c7bd559158fe495f6b62ae7baa2"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"5f62cd1ad5a1217ea6b47ec826908d0b298925a9","is_merged_in_target_branch":true,"change_id":"I5f1216c77819003302e83ba1af1ff13c924f3b38","change_number":7971,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"9010c98f8ae5f52e8759ca22a223126c2c5cea47":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-02-01 13:40:41.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/73/7973/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/73/7973/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/73/7973/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/73/7973/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/73/7973/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/73/7973/2"}}},"commit":{"parents":[{"commit":"361ffd7903ab129657a7dcc37654f3c077321027","subject":"refactor(tvix/derivation): don\u0027t create deref\u0027d immediately ref","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d361ffd7903ab129657a7dcc37654f3c077321027"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-01-31 18:26:17.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-02-01 13:40:38.000000000","tz":180},"subject":"refactor(tvix/eval): use a union representation of ops in Chunk","message":"refactor(tvix/eval): use a union representation of ops in Chunk\n\nThis will allow us to add a `data` field to the union representation\nto significantly reduce the size of an `Op` in the code\nchunks (eventually, from the current 16 to 1 (one!) byte).\n\nHowever, this is a delicate undertaking as we can not easily verify\nthe validity of an OpCode and accessing these operations requires\n`unsafe`, which means we\u0027re on our own. A compiler bug could lead to\nsegfaults as soon as data operands are used.\n\nI believe that the cache efficiency gained by this is worth it, but it\nwill take several CLs to get there and prove this. It will likely take\nsome future pain for us to be fully confident in this, as I\u0027m already\naware of (and have annotated) at least one possible bug this can\nintroduce.\n\nI want to get this to work, and then tackle the known possible bugs\nfound along the way, and then make a decision on whether it is worth\nit.\n\nChange-Id: Ic745a5e5cf68417e79538946fbf06e2945db04a4\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9010c98f8ae5f52e8759ca22a223126c2c5cea47"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9010c98f8ae5f52e8759ca22a223126c2c5cea47"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"361ffd7903ab129657a7dcc37654f3c077321027","is_merged_in_target_branch":true,"change_id":"Ic2c093b043ebee9ae80912075083107e4d216cf1","change_number":7995,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"4e1aa137e61e09256b498aeda9a6712a91badd69":{"kind":"REWORK","_number":3,"created":"2023-02-02 21:01:59.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/73/7973/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/73/7973/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/73/7973/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/73/7973/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/73/7973/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/73/7973/3"}}},"commit":{"parents":[{"commit":"4b116dee3ef736345f57ba1e9fd44c344ef5bac1","subject":"refactor(tvix/eval): statically resolve select from constant attrs","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4b116dee3ef736345f57ba1e9fd44c344ef5bac1"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-01-31 18:26:17.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-02-02 18:12:31.000000000","tz":180},"subject":"refactor(tvix/eval): use a union representation of ops in Chunk","message":"refactor(tvix/eval): use a union representation of ops in Chunk\n\nThis will allow us to add a `data` field to the union representation\nto significantly reduce the size of an `Op` in the code\nchunks (eventually, from the current 16 to 1 (one!) byte).\n\nHowever, this is a delicate undertaking as we can not easily verify\nthe validity of an OpCode and accessing these operations requires\n`unsafe`, which means we\u0027re on our own. A compiler bug could lead to\nsegfaults as soon as data operands are used.\n\nI believe that the cache efficiency gained by this is worth it, but it\nwill take several CLs to get there and prove this. It will likely take\nsome future pain for us to be fully confident in this.\n\nI want to get this to work, and then tackle the known possible bugs\nfound along the way, and then make a decision on whether it is worth\nit.\n\nChange-Id: Ic745a5e5cf68417e79538946fbf06e2945db04a4\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4e1aa137e61e09256b498aeda9a6712a91badd69"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4e1aa137e61e09256b498aeda9a6712a91badd69"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"4b116dee3ef736345f57ba1e9fd44c344ef5bac1","is_merged_in_target_branch":false,"change_id":"I639654e065a06e8cfcbcacb528c6da7ec9e513ee","change_number":7957,"patch_set_number":9,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[],"submit_requirements":[]}