)]}'
{"id":"depot~8037","triplet_id":"depot~canon~I9ffc2b417501b426ced1894a9cbf95ff5f0e5159","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000018":{"account":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"last_update":"2023-02-08 10:11:44.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2023-02-08 10:39:26.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2023-02-08 10:39:26.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I9ffc2b417501b426ced1894a9cbf95ff5f0e5159","subject":"feat(tvix/nix-compat/nixhash): support BASE64_NOPAD SRI","status":"MERGED","created":"2023-02-08 09:45:20.000000000","updated":"2023-02-08 10:39:26.000000000","submitted":"2023-02-08 10:39:26.000000000","submitter":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8037","meta_rev_id":"1c606f208c3f622ba07931c3e9f7b6b215e3e5dc","_number":8037,"virtual_id_number":8037,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-02-08 10:39:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-02-08 10:39:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-02-08 09:45:20.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"state":"REVIEWER"},{"updated":"2023-02-08 09:45:20.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2023-02-08 09:45:23.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-02-08 09:48:04.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4ed3e6204d72b968dacc92f0a357f6ef73de54e5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-02-08 09:45:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9f6587dc1d94fcce0f9cdba8c3ae6c173f17b774","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-02-08 09:45:20.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* tvix/nix-compat/src/nixhash.rs\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":1},{"id":"e7eee3c66035de065d993a2e3f84c8fd3625b5fb","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-02-08 09:45:23.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/22244","accounts_in_message":[],"_revision_number":1},{"id":"11c5918a9aa691eca7fc7aee52b31966c6d54348","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-02-08 09:48:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/22244","accounts_in_message":[],"_revision_number":1},{"id":"a2ce8124c0465b3d3d39099a5f2aa1b7293aeb55","author":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"date":"2023-02-08 10:11:44.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1c606f208c3f622ba07931c3e9f7b6b215e3e5dc","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-02-08 10:39:26.000000000","message":"Change has been successfully rebased and submitted as d4cbdc2beb0460918d9c358e1bc39a5dbaa67b09","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d4cbdc2beb0460918d9c358e1bc39a5dbaa67b09","revisions":{"186200bc1b191b77beda379c67c09cf7aedd8cdc":{"kind":"REWORK","_number":1,"created":"2023-02-08 09:45:20.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/37/8037/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/37/8037/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/37/8037/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/37/8037/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/37/8037/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/37/8037/1"}}},"commit":{"parents":[{"commit":"02808d74a6ada0bb30f4150f580be57874bc3b5f","subject":"refactor(tvix/nix-compat/nixhash): fix test function name","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d02808d74a6ada0bb30f4150f580be57874bc3b5f"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-02-08 09:37:04.000000000","tz":60},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-02-08 09:44:37.000000000","tz":60},"subject":"feat(tvix/nix-compat/nixhash): support BASE64_NOPAD SRI","message":"feat(tvix/nix-compat/nixhash): support BASE64_NOPAD SRI\n\nNix accepts SRI hashes that are missing their padding characters\nin base64, as seen in\nhttps://github.com/NixOS/nixpkgs/blob/7e49471316373c471a3bf4b78c130ebc907ae2d2/pkgs/development/libraries/kerberos/krb5.nix .\n\nIt only seems to work in the SRI case, not with `sha256` being set to a\n(nopad) base64 string.\n\nAdd regression tests for this, and document why we don\u0027t want to support\n*additional* characters afterwards.\n\nReported in https://b.tvl.fyi/issues/252\n\nChange-Id: I9ffc2b417501b426ced1894a9cbf95ff5f0e5159\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d186200bc1b191b77beda379c67c09cf7aedd8cdc"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d186200bc1b191b77beda379c67c09cf7aedd8cdc"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"02808d74a6ada0bb30f4150f580be57874bc3b5f","is_merged_in_target_branch":false,"change_id":"I3b089758ce8c01df544064422e56a97a8402513d","change_number":8036,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"d4cbdc2beb0460918d9c358e1bc39a5dbaa67b09":{"kind":"REWORK","_number":2,"created":"2023-02-08 10:39:26.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/37/8037/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/37/8037/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/37/8037/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/37/8037/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/37/8037/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/37/8037/2"}}},"commit":{"parents":[{"commit":"5fa35d9d49572a8276cb044a6aa7d9a83308d9be","subject":"refactor(tvix/nix-compat/nixhash): fix test function name","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5fa35d9d49572a8276cb044a6aa7d9a83308d9be"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-02-08 09:37:04.000000000","tz":60},"committer":{"name":"flokli","email":"flokli@flokli.de","date":"2023-02-08 10:39:26.000000000","tz":0},"subject":"feat(tvix/nix-compat/nixhash): support BASE64_NOPAD SRI","message":"feat(tvix/nix-compat/nixhash): support BASE64_NOPAD SRI\n\nNix accepts SRI hashes that are missing their padding characters\nin base64, as seen in\nhttps://github.com/NixOS/nixpkgs/blob/7e49471316373c471a3bf4b78c130ebc907ae2d2/pkgs/development/libraries/kerberos/krb5.nix .\n\nIt only seems to work in the SRI case, not with `sha256` being set to a\n(nopad) base64 string.\n\nAdd regression tests for this, and document why we don\u0027t want to support\n*additional* characters afterwards.\n\nReported in https://b.tvl.fyi/issues/252\n\nChange-Id: I9ffc2b417501b426ced1894a9cbf95ff5f0e5159\nReviewed-on: https://cl.tvl.fyi/c/depot/+/8037\nReviewed-by: Alyssa Ross \u003chi@alyssa.is\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd4cbdc2beb0460918d9c358e1bc39a5dbaa67b09"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd4cbdc2beb0460918d9c358e1bc39a5dbaa67b09"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"5fa35d9d49572a8276cb044a6aa7d9a83308d9be","is_merged_in_target_branch":true,"change_id":"I3b089758ce8c01df544064422e56a97a8402513d","change_number":8036,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}