)]}'
{"id":"depot~8226","triplet_id":"depot~canon~I8224bf039f739c401900b5a2ddc839810c87cf6e","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000066":{"account":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"last_update":"2023-03-14 09:22:32.000000000","reason":"Change was submitted"},"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2023-03-14 09:22:32.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2023-03-13 21:49:42.000000000","reason":"removed on reply"},"1000038":{"account":{"_account_id":1000038,"name":"ezemtsov","email":"eugene.zemtsov@gmail.com","username":"ezemtsov"},"last_update":"2023-03-14 09:22:32.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2023-03-14 09:22:32.000000000","reason":"Change was submitted"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2023-03-14 09:22:32.000000000","reason":"Change was submitted"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2023-03-14 09:22:32.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I8224bf039f739c401900b5a2ddc839810c87cf6e","subject":"docs(tvix/eval): document inner workings of the new VM loop","status":"MERGED","created":"2023-03-07 16:55:14.000000000","updated":"2023-03-14 09:22:32.000000000","submitted":"2023-03-14 09:22:32.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":53,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8226","meta_rev_id":"59d140bfcf755a3d4f3895d2bc52358ad74d8a21","_number":8226,"virtual_id_number":8226,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-03-14 09:22:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-14 09:22:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000038,"name":"ezemtsov","email":"eugene.zemtsov@gmail.com","username":"ezemtsov"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000038,"name":"ezemtsov","email":"eugene.zemtsov@gmail.com","username":"ezemtsov"},{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-07 16:55:14.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-03-07 16:58:17.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-07 18:48:09.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2023-03-07 18:48:09.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"state":"REVIEWER"},{"updated":"2023-03-07 18:48:09.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2023-03-07 18:48:09.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2023-03-07 18:48:09.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"state":"REVIEWER"},{"updated":"2023-03-07 18:49:17.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000038,"name":"ezemtsov","email":"eugene.zemtsov@gmail.com","username":"ezemtsov"},"state":"REVIEWER"}],"messages":[{"id":"d66a57afd42c36c9291d73bd1fc541cfc9e8f0cb","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-07 16:55:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"863e9bdae65c6be340b7efbd379c2441294aabca","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-07 16:55:14.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/23188","accounts_in_message":[],"_revision_number":1},{"id":"95340afb98ca1340c7f70d8f669ef6a9e5ab6497","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-07 16:58:17.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/23188","accounts_in_message":[],"_revision_number":1},{"id":"f3d1c014cec3958361f85d5d4b9de25e8b3d1e43","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-07 17:48:43.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"e05dbbaecc71790aa1be1e8e0247b26dc30024f3","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-07 17:48:44.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/23189","accounts_in_message":[],"_revision_number":2},{"id":"517b4d4a980a9b821686f2a9fac44de32ff0419b","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-07 17:51:50.000000000","message":"Patch Set 2: Verified-1\n\nBuild of patchset 2 failed: https://buildkite.com/tvl/depot/builds/23189","accounts_in_message":[],"_revision_number":2},{"id":"520424649f57309eb78889dec589e2a122124a6d","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-07 18:16:51.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"f8225dda55fbc3d43f82dca6938e6e9bbe9ebbda","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-07 18:16:52.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/23190","accounts_in_message":[],"_revision_number":3},{"id":"9bf5998abc40f16b59ee2b8fcbe565519c666c73","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-07 18:19:59.000000000","message":"Patch Set 3: Verified-1\n\nBuild of patchset 3 failed: https://buildkite.com/tvl/depot/builds/23190","accounts_in_message":[],"_revision_number":3},{"id":"c33e221ca6d64166e78664bc6c85e6d33ba2ccf3","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-07 18:37:33.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"73129df2a403b441592b23bc7065684caa466658","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-07 18:37:35.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/23191","accounts_in_message":[],"_revision_number":4},{"id":"3d0212171e362e5d03108d8fa52c64b34c4b4940","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-07 18:41:07.000000000","message":"Patch Set 4: Verified-1\n\nBuild of patchset 4 failed: https://buildkite.com/tvl/depot/builds/23191","accounts_in_message":[],"_revision_number":4},{"id":"2836a21093177d044eb3cc1b82e91544ce667fc7","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-07 18:47:45.000000000","message":"Uploaded patch set 5.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"79dc0b90525978b7edc6dc144ff41c8d57cddc24","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-07 18:47:47.000000000","message":"Patch Set 5:\n\nStarted build for patchset #5 on: https://buildkite.com/tvl/depot/builds/23192","accounts_in_message":[],"_revision_number":5},{"id":"49acbbc5e43cef22a24712a33f33e8c71db8630f","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-07 18:48:09.000000000","message":"Patch Set 5:\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":5},{"id":"4e951dc71be5c1060698c0b8b5c3daf03738f804","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-07 18:48:09.000000000","message":"\u003cGERRIT_ACCOUNT_1000036\u003e, who was added as reviewer owns the following files:\n* tvix/eval/docs/vm-loop.md\n\n\u003cGERRIT_ACCOUNT_1000010\u003e, who was added as reviewer owns the following files:\n* tvix/eval/docs/vm-loop.md\n\n\u003cGERRIT_ACCOUNT_1000034\u003e, who was added as reviewer owns the following files:\n* tvix/eval/docs/vm-loop.md\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}],"_revision_number":5},{"id":"c2b402638f8b5d13b6a5f860718377f918ee4249","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-07 18:48:13.000000000","message":"Patch Set 6: Commit message was updated.","accounts_in_message":[],"_revision_number":6},{"id":"6986c625d497c7b1d3b3e92682b7155ec4d02a32","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-07 18:50:56.000000000","message":"Patch Set 5: Verified+1\n\nBuild of patchset 5 passed: https://buildkite.com/tvl/depot/builds/23192","accounts_in_message":[],"_revision_number":5},{"id":"b0faefbe75120913f4e2317e10cb4ef302f8d8df","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-07 19:11:04.000000000","message":"Uploaded patch set 7.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":7},{"id":"36377d246080edc450fe665cda24800e5d776ce8","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-07 19:11:05.000000000","message":"Patch Set 7:\n\nStarted build for patchset #7 on: https://buildkite.com/tvl/depot/builds/23193","accounts_in_message":[],"_revision_number":7},{"id":"a2f821d6bf1c899b207d0d7a26a4409d0f05baa0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-07 19:11:47.000000000","message":"Uploaded patch set 8: Commit message was updated.","accounts_in_message":[],"_revision_number":8},{"id":"2cfea2961ee47fe3b84e0caa29ccd68709632d5b","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-07 19:14:13.000000000","message":"Patch Set 7: Verified+1\n\nBuild of patchset 7 passed: https://buildkite.com/tvl/depot/builds/23193","accounts_in_message":[],"_revision_number":7},{"id":"f3cf3fac9bb4ac64971743eefebea311629f8dc1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-07 22:07:04.000000000","message":"Uploaded patch set 9.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":9},{"id":"340c1c5c6bebbf0ea5a8c1c2208d72c539281cc9","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-07 22:07:06.000000000","message":"Patch Set 9:\n\nStarted build for patchset #9 on: https://buildkite.com/tvl/depot/builds/23200","accounts_in_message":[],"_revision_number":9},{"id":"9d8b88d5462dc11f73c818496ab2fb388298c57f","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-07 22:12:38.000000000","message":"Patch Set 9: Verified+1\n\nBuild of patchset 9 passed: https://buildkite.com/tvl/depot/builds/23200","accounts_in_message":[],"_revision_number":9},{"id":"b74e61736b9934dd0a3605daf04c2bb97a630a9f","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-03-08 11:58:34.000000000","message":"Patch Set 9: Code-Review+1\n\n(16 comments)","accounts_in_message":[],"_revision_number":9},{"id":"d0c3f0852839e01a714832aba9f6bd7b8416f4c4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-08 12:44:36.000000000","message":"Uploaded patch set 10.\n\nCopied Votes:\n* Code-Review+1 (copy condition: \"((is:ANY AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":10},{"id":"46c62dd5b97259d624d775d71de7976fc2548064","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-08 12:44:36.000000000","message":"Patch Set 10:\n\n(13 comments)","accounts_in_message":[],"_revision_number":10},{"id":"f96c1481a2329588c1d18a97d1167d1ac909e409","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-08 12:44:38.000000000","message":"Patch Set 10:\n\nStarted build for patchset #10 on: https://buildkite.com/tvl/depot/builds/23231","accounts_in_message":[],"_revision_number":10},{"id":"f1cacf1c0a3fabd214c009cc372b14e77ad5ed2f","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-08 12:47:36.000000000","message":"Patch Set 10: Verified+1\n\nBuild of patchset 10 passed: https://buildkite.com/tvl/depot/builds/23231","accounts_in_message":[],"_revision_number":10},{"id":"b5aa37f9837fe572164b184f28bfffa973cfdd61","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-08 12:52:08.000000000","message":"Patch Set 10:\n\n(1 comment)","accounts_in_message":[],"_revision_number":10},{"id":"f1acaad3f378baad102de1df1648a73449e64a20","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-03-11 11:06:26.000000000","message":"Uploaded patch set 11: Patch Set 10 was rebased.\n\nCopied Votes:\n* Code-Review+1 (copy condition: \"((is:ANY AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":11},{"id":"bc17ec3571bd9da0ba74c77a367f1044f69890ba","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-11 11:06:28.000000000","message":"Patch Set 11:\n\nStarted build for patchset #11 on: https://buildkite.com/tvl/depot/builds/23535","accounts_in_message":[],"_revision_number":11},{"id":"ce949d80d23368ad8ecc5651a287e330d43c9421","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-03-11 11:09:11.000000000","message":"Patch Set 10: Code-Review+1\n\n(8 comments)","accounts_in_message":[],"_revision_number":10},{"id":"46bc9ed050695242901652840a4f727d7a08b007","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-11 11:09:57.000000000","message":"Patch Set 11: Verified+1\n\nBuild of patchset 11 passed: https://buildkite.com/tvl/depot/builds/23535","accounts_in_message":[],"_revision_number":11},{"id":"8a789469a722f1664f74061bf90a38f8219503ba","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-11 13:24:12.000000000","message":"Patch Set 11:\n\n(6 comments)","accounts_in_message":[],"_revision_number":11},{"id":"96281657442ae36d259721122180249203c0a4f2","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-11 20:23:16.000000000","message":"Patch Set 11:\n\n(1 comment)","accounts_in_message":[],"_revision_number":11},{"id":"e6396d9a300c62c6acd32ed7e6d27bf3ac434e4d","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-03-13 14:48:12.000000000","message":"Patch Set 11: Code-Review+2\n\n(4 comments)","accounts_in_message":[],"_revision_number":11},{"id":"566a30809911138e39150c37eca506b3a4adcf72","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-13 21:49:42.000000000","message":"Uploaded patch set 12.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"((is:ANY AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":12},{"id":"df07658b4b79214ea6541cd86bc0f0830b4773b3","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-13 21:49:42.000000000","message":"Patch Set 12:\n\n(2 comments)","accounts_in_message":[],"_revision_number":12},{"id":"fb29aad631fe204cb26327a496325344ebe258c9","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-13 21:49:43.000000000","message":"Patch Set 12:\n\nStarted build for patchset #12 on: https://buildkite.com/tvl/depot/builds/23737","accounts_in_message":[],"_revision_number":12},{"id":"f96697bfa09af80f4a44e3a2df70c44b57a24f6d","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-13 21:50:04.000000000","message":"Patch Set 11:\n\n(1 comment)","accounts_in_message":[],"_revision_number":11},{"id":"8087248bc52b68083f4f1f596482f1c2f9627cb6","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-13 21:52:45.000000000","message":"Patch Set 12: Verified+1\n\nBuild of patchset 12 passed: https://buildkite.com/tvl/depot/builds/23737","accounts_in_message":[],"_revision_number":12},{"id":"47313bbce418dd8d1fe47d6603984f7ef4ccb994","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-14 09:22:30.000000000","message":"Patch Set 12:\n\n(1 comment)","accounts_in_message":[],"_revision_number":12},{"id":"59d140bfcf755a3d4f3895d2bc52358ad74d8a21","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-14 09:22:32.000000000","message":"Change has been successfully rebased and submitted as 466e6dc2651c3c8536e8570d74bee401c842adb1\n\n11 is the latest approved patch-set.\nThe change was submitted with unreviewed changes in the following files:\n\n```\nThe name of the file: tvix/eval/docs/vm-loop.md\nInsertions: 17, Deletions: 17.\n\n@@ -211,18 +211,18 @@\n    ┏━━━━━━━━┷━━━━━━━━┓                 │\n ──►┃ gen.resume(msg) ┃                 │[Yielded]\n    ┗━━━━━━━━━━━━━━━━━┛                 │\n-            ▲                     ╭────┴─────╮\n-            │          [yes]      │  inline  │\n-            ╰─────────────────────┤ request? │\n-                                  ╰────┬─────╯\n+            ▲                   ╭──────┴─────╮\n+            │          [yes]    │ same-frame │\n+            ╰───────────────────┤  request?  │\n+                                ╰──────┬─────╯\n    ┏━━━━━━━━━━━━━━┓                    │\n ◄──┨ return false ┃ ◄──────────────────╯\n    ┗━━━━━━━━━━━━━━┛                [no]\n ```\n \n On each execution of a generator frame, `resume_with` is called with a\n-[`GeneratorResponse`][] (i.e. a message *from* the VM *to* the generator). For\n-a newly created generator, the initial message is just `Empty`.\n+[`VMResponse`][] (i.e. a message *from* the VM *to* the generator). For a newly\n+created generator, the initial message is just `Empty`.\n \n A generator may then respond by signaling that it has finished execution\n (`Done`), in which case the inner generator loop returns control to the outer\n@@ -230,22 +230,22 @@\n \n A generator may also respond by signaling that it needs some data from the VM.\n This is implemented through a request-response pattern, in which the generator\n-returns a `Yielded` message containing a [`GeneratorRequest`][]. These\n-requests can be very simple (\"Tell me the current store path\") or more complex\n-(\"Call this Nix function with these values\").\n+returns a `Yielded` message containing a [`VMRequest`][]. These requests can be\n+very simple (\"Tell me the current store path\") or more complex (\"Call this Nix\n+function with these values\").\n \n-Requests are divided into two classes: Inline generator requests (requests\n-that can be responded to *without* returning control to the outer loop, i.e.\n-without executing a *different* frame), and other generator requests. Based on\n-the type of request, the inner generator loop will either handle it right away\n-and send the response in a new `resume_with` call, or return `false` to the\n-outer generator loop after setting up the frame stack.\n+Requests are divided into two classes: Same-frame requests (requests that can be\n+responded to *without* returning control to the outer loop, i.e. without\n+executing a *different* frame), and multi-frame generator requests. Based on the\n+type of request, the inner generator loop will either handle it right away and\n+send the response in a new `resume_with` call, or return `false` to the outer\n+generator loop after setting up the frame stack.\n \n Most of this logic is implemented in cl/8148.\n \n [`Gen::resume`]: https://docs.rs/genawaiter/0.99.1/genawaiter/rc/struct.Gen.html#method.resume_with\n-[`GeneratorRequest`]: https://cs.tvl.fyi/depot@2696839770c1ccb62929ff2575a633c07f5c9593/-/blob/tvix/eval/src/vm/generators.rs?L44\n-[`GeneratorResponse`]: https://cs.tvl.fyi/depot@2696839770c1ccb62929ff2575a633c07f5c9593/-/blob/tvix/eval/src/vm/generators.rs?L169\n+[`VMRequest`]: https://cs.tvl.fyi/depot@2696839770c1ccb62929ff2575a633c07f5c9593/-/blob/tvix/eval/src/vm/generators.rs?L44\n+[`VMResponse`]: https://cs.tvl.fyi/depot@2696839770c1ccb62929ff2575a633c07f5c9593/-/blob/tvix/eval/src/vm/generators.rs?L169\n \n ## Advantages \u0026 Disadvantages of the approach\n \n```\n","accounts_in_message":[],"_revision_number":13}],"current_revision_number":13,"current_revision":"466e6dc2651c3c8536e8570d74bee401c842adb1","revisions":{"a70b488561b04bc7fc789996cac3aa879d921213":{"kind":"REWORK","_number":1,"created":"2023-03-07 16:55:14.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/26/8226/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/26/8226/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/26/8226/1"}}},"commit":{"parents":[{"commit":"627978aa03f8983bda700cbcad11dacd50735124","subject":"DEBUG: dump tvix\u0027s derivations to the Nix store","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d627978aa03f8983bda700cbcad11dacd50735124"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 16:54:57.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 16:54:57.000000000","tz":180},"subject":"WIP docs(tvix/eval): document inner workings of the new VM loop","message":"WIP docs(tvix/eval): document inner workings of the new VM loop\n\nChange-Id: I8224bf039f739c401900b5a2ddc839810c87cf6e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da70b488561b04bc7fc789996cac3aa879d921213"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da70b488561b04bc7fc789996cac3aa879d921213"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"627978aa03f8983bda700cbcad11dacd50735124","is_merged_in_target_branch":false,"change_id":"Ib800f06eb262b44e528325aeba15c64dc5476141","change_number":7912,"patch_set_number":22,"change_status":"NEW"}],"branch":"refs/heads/canon"},"223e080913b6af9c0c79743c0a5f964a81cbb007":{"kind":"REWORK","_number":2,"created":"2023-03-07 17:48:43.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/26/8226/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/26/8226/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/26/8226/2"}}},"commit":{"parents":[{"commit":"627978aa03f8983bda700cbcad11dacd50735124","subject":"DEBUG: dump tvix\u0027s derivations to the Nix store","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d627978aa03f8983bda700cbcad11dacd50735124"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 16:54:57.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 17:48:40.000000000","tz":180},"subject":"WIP docs(tvix/eval): document inner workings of the new VM loop","message":"WIP docs(tvix/eval): document inner workings of the new VM loop\n\nChange-Id: I8224bf039f739c401900b5a2ddc839810c87cf6e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d223e080913b6af9c0c79743c0a5f964a81cbb007"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d223e080913b6af9c0c79743c0a5f964a81cbb007"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"627978aa03f8983bda700cbcad11dacd50735124","is_merged_in_target_branch":false,"change_id":"Ib800f06eb262b44e528325aeba15c64dc5476141","change_number":7912,"patch_set_number":22,"change_status":"NEW"}],"branch":"refs/heads/canon"},"71e7de2f03921fcc606203b1c196bf08096dc058":{"kind":"REWORK","_number":3,"created":"2023-03-07 18:16:51.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/26/8226/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/26/8226/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/26/8226/3"}}},"commit":{"parents":[{"commit":"627978aa03f8983bda700cbcad11dacd50735124","subject":"DEBUG: dump tvix\u0027s derivations to the Nix store","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d627978aa03f8983bda700cbcad11dacd50735124"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 16:54:57.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 18:16:48.000000000","tz":180},"subject":"WIP docs(tvix/eval): document inner workings of the new VM loop","message":"WIP docs(tvix/eval): document inner workings of the new VM loop\n\nChange-Id: I8224bf039f739c401900b5a2ddc839810c87cf6e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d71e7de2f03921fcc606203b1c196bf08096dc058"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d71e7de2f03921fcc606203b1c196bf08096dc058"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"627978aa03f8983bda700cbcad11dacd50735124","is_merged_in_target_branch":false,"change_id":"Ib800f06eb262b44e528325aeba15c64dc5476141","change_number":7912,"patch_set_number":22,"change_status":"NEW"}],"branch":"refs/heads/canon"},"2ac9dbf012dea046d3bec2d26a50b3d4340d97f6":{"kind":"REWORK","_number":4,"created":"2023-03-07 18:37:33.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/26/8226/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/26/8226/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/26/8226/4"}}},"commit":{"parents":[{"commit":"627978aa03f8983bda700cbcad11dacd50735124","subject":"DEBUG: dump tvix\u0027s derivations to the Nix store","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d627978aa03f8983bda700cbcad11dacd50735124"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 16:54:57.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 18:37:30.000000000","tz":180},"subject":"WIP docs(tvix/eval): document inner workings of the new VM loop","message":"WIP docs(tvix/eval): document inner workings of the new VM loop\n\nChange-Id: I8224bf039f739c401900b5a2ddc839810c87cf6e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2ac9dbf012dea046d3bec2d26a50b3d4340d97f6"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2ac9dbf012dea046d3bec2d26a50b3d4340d97f6"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"627978aa03f8983bda700cbcad11dacd50735124","is_merged_in_target_branch":false,"change_id":"Ib800f06eb262b44e528325aeba15c64dc5476141","change_number":7912,"patch_set_number":22,"change_status":"NEW"}],"branch":"refs/heads/canon"},"31fb4bd8588a363ce7cf2c76fd9d0c3c37d577d3":{"kind":"REWORK","_number":5,"created":"2023-03-07 18:47:45.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/26/8226/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/26/8226/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/26/8226/5"}}},"commit":{"parents":[{"commit":"b74ffda583d40db8b94b58418f70430687b2eaf0","subject":"feat(tvix/store): add blobservice","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db74ffda583d40db8b94b58418f70430687b2eaf0"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 16:54:57.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 18:47:42.000000000","tz":180},"subject":"WIP docs(tvix/eval): document inner workings of the new VM loop","message":"WIP docs(tvix/eval): document inner workings of the new VM loop\n\nChange-Id: I8224bf039f739c401900b5a2ddc839810c87cf6e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d31fb4bd8588a363ce7cf2c76fd9d0c3c37d577d3"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d31fb4bd8588a363ce7cf2c76fd9d0c3c37d577d3"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b74ffda583d40db8b94b58418f70430687b2eaf0","is_merged_in_target_branch":true,"change_id":"Id6bc1b629195d0b26fc503bd7d2dc9e43c41c317","change_number":8087,"patch_set_number":12,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"24139e11347b50aaef9d8b0ade78e17094851971":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2023-03-07 18:48:13.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/26/8226/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/26/8226/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/26/8226/6"}}},"commit":{"parents":[{"commit":"b74ffda583d40db8b94b58418f70430687b2eaf0","subject":"feat(tvix/store): add blobservice","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db74ffda583d40db8b94b58418f70430687b2eaf0"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 16:54:57.000000000","tz":180},"committer":{"name":"tazjin","email":"tazjin@tvl.su","date":"2023-03-07 18:48:13.000000000","tz":0},"subject":"docs(tvix/eval): document inner workings of the new VM loop","message":"docs(tvix/eval): document inner workings of the new VM loop\n\nChange-Id: I8224bf039f739c401900b5a2ddc839810c87cf6e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d24139e11347b50aaef9d8b0ade78e17094851971"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d24139e11347b50aaef9d8b0ade78e17094851971"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b74ffda583d40db8b94b58418f70430687b2eaf0","is_merged_in_target_branch":true,"change_id":"Id6bc1b629195d0b26fc503bd7d2dc9e43c41c317","change_number":8087,"patch_set_number":12,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Edit commit message"},"1fafed45c0d293a00acde2f4a83a8faf3278a115":{"kind":"REWORK","_number":7,"created":"2023-03-07 19:11:04.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/26/8226/7","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/26/8226/7","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/26/8226/7"}}},"commit":{"parents":[{"commit":"b74ffda583d40db8b94b58418f70430687b2eaf0","subject":"feat(tvix/store): add blobservice","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db74ffda583d40db8b94b58418f70430687b2eaf0"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 16:54:57.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 19:11:01.000000000","tz":180},"subject":"WIP docs(tvix/eval): document inner workings of the new VM loop","message":"WIP docs(tvix/eval): document inner workings of the new VM loop\n\nChange-Id: I8224bf039f739c401900b5a2ddc839810c87cf6e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1fafed45c0d293a00acde2f4a83a8faf3278a115"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1fafed45c0d293a00acde2f4a83a8faf3278a115"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b74ffda583d40db8b94b58418f70430687b2eaf0","is_merged_in_target_branch":true,"change_id":"Id6bc1b629195d0b26fc503bd7d2dc9e43c41c317","change_number":8087,"patch_set_number":12,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"311ad856e2f7559165a5ba94702a0546e36032ef":{"kind":"NO_CODE_CHANGE","_number":8,"created":"2023-03-07 19:11:47.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/26/8226/8","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/26/8226/8","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/26/8226/8"}}},"commit":{"parents":[{"commit":"b74ffda583d40db8b94b58418f70430687b2eaf0","subject":"feat(tvix/store): add blobservice","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db74ffda583d40db8b94b58418f70430687b2eaf0"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 16:54:57.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 19:11:43.000000000","tz":180},"subject":"docs(tvix/eval): document inner workings of the new VM loop","message":"docs(tvix/eval): document inner workings of the new VM loop\n\nChange-Id: I8224bf039f739c401900b5a2ddc839810c87cf6e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d311ad856e2f7559165a5ba94702a0546e36032ef"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d311ad856e2f7559165a5ba94702a0546e36032ef"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b74ffda583d40db8b94b58418f70430687b2eaf0","is_merged_in_target_branch":true,"change_id":"Id6bc1b629195d0b26fc503bd7d2dc9e43c41c317","change_number":8087,"patch_set_number":12,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"b98fd5fd74481c46c91d3d309679138153b5e8c9":{"kind":"REWORK","_number":9,"created":"2023-03-07 22:07:04.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/26/8226/9","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/26/8226/9","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/26/8226/9"}}},"commit":{"parents":[{"commit":"b74ffda583d40db8b94b58418f70430687b2eaf0","subject":"feat(tvix/store): add blobservice","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db74ffda583d40db8b94b58418f70430687b2eaf0"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 16:54:57.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 22:07:02.000000000","tz":180},"subject":"docs(tvix/eval): document inner workings of the new VM loop","message":"docs(tvix/eval): document inner workings of the new VM loop\n\nChange-Id: I8224bf039f739c401900b5a2ddc839810c87cf6e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db98fd5fd74481c46c91d3d309679138153b5e8c9"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db98fd5fd74481c46c91d3d309679138153b5e8c9"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b74ffda583d40db8b94b58418f70430687b2eaf0","is_merged_in_target_branch":true,"change_id":"Id6bc1b629195d0b26fc503bd7d2dc9e43c41c317","change_number":8087,"patch_set_number":12,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"a0b4941cd559fea9a5f3a2042394443775d984e1":{"kind":"REWORK","_number":10,"created":"2023-03-08 12:44:36.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/26/8226/10","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/26/8226/10","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/26/8226/10"}}},"commit":{"parents":[{"commit":"252d8b10dbb9bcda496afae1a420d8b115d58175","subject":"fix: use `depsTargetTargetPropagated` for depot\u0027s gcroot","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d252d8b10dbb9bcda496afae1a420d8b115d58175"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 16:54:57.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-08 12:44:35.000000000","tz":180},"subject":"docs(tvix/eval): document inner workings of the new VM loop","message":"docs(tvix/eval): document inner workings of the new VM loop\n\nChange-Id: I8224bf039f739c401900b5a2ddc839810c87cf6e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da0b4941cd559fea9a5f3a2042394443775d984e1"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da0b4941cd559fea9a5f3a2042394443775d984e1"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"252d8b10dbb9bcda496afae1a420d8b115d58175","is_merged_in_target_branch":true,"change_id":"Ib258c4f3b09d746c3d000d1c7480d2b4101ab75e","change_number":8227,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"9aefe8d8e70709e20c625cb6b45932134ac38b63":{"kind":"TRIVIAL_REBASE","_number":11,"created":"2023-03-11 11:06:26.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/26/8226/11","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/26/8226/11","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/26/8226/11"}}},"commit":{"parents":[{"commit":"799ef5ae4479b18e6b749030606b0e8d41c0dfb2","subject":"refactor(tvix/eval): flatten call stack of VM using generators","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d799ef5ae4479b18e6b749030606b0e8d41c0dfb2"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 16:54:57.000000000","tz":180},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-03-11 10:59:59.000000000","tz":-480},"subject":"docs(tvix/eval): document inner workings of the new VM loop","message":"docs(tvix/eval): document inner workings of the new VM loop\n\nChange-Id: I8224bf039f739c401900b5a2ddc839810c87cf6e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9aefe8d8e70709e20c625cb6b45932134ac38b63"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9aefe8d8e70709e20c625cb6b45932134ac38b63"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"799ef5ae4479b18e6b749030606b0e8d41c0dfb2","is_merged_in_target_branch":false,"change_id":"I39244163ff5bbecd169fe7b274df19262b515699","change_number":8104,"patch_set_number":67,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"b6f374e5203ae42df453eb00f7b968fb159db4f0":{"kind":"REWORK","_number":12,"created":"2023-03-13 21:49:42.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/26/8226/12","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/26/8226/12","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/26/8226/12"}}},"commit":{"parents":[{"commit":"dcddf0cddbf5db1b078a50dd9b19d00a5584824e","subject":"chore(tvix): Generator{Request|Response} -\u003e VM{Request|Response}","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddcddf0cddbf5db1b078a50dd9b19d00a5584824e"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 16:54:57.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-13 21:49:28.000000000","tz":180},"subject":"docs(tvix/eval): document inner workings of the new VM loop","message":"docs(tvix/eval): document inner workings of the new VM loop\n\nChange-Id: I8224bf039f739c401900b5a2ddc839810c87cf6e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db6f374e5203ae42df453eb00f7b968fb159db4f0"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db6f374e5203ae42df453eb00f7b968fb159db4f0"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"dcddf0cddbf5db1b078a50dd9b19d00a5584824e","is_merged_in_target_branch":false,"change_id":"Ic31c45461a842f22aa05f4446123fe3a61dfdbc0","change_number":8291,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"466e6dc2651c3c8536e8570d74bee401c842adb1":{"kind":"NO_CODE_CHANGE","_number":13,"created":"2023-03-14 09:22:32.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/26/8226/13","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/26/8226/13","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/13 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/13 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/26/8226/13 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/26/8226/13"}}},"commit":{"parents":[{"commit":"d4567053523cb3fc0a2b54245c9b25cdc52365aa","subject":"chore(tvix): Generator{Request|Response} -\u003e VM{Request|Response}","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd4567053523cb3fc0a2b54245c9b25cdc52365aa"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-03-07 16:54:57.000000000","tz":180},"committer":{"name":"tazjin","email":"tazjin@tvl.su","date":"2023-03-14 09:22:32.000000000","tz":0},"subject":"docs(tvix/eval): document inner workings of the new VM loop","message":"docs(tvix/eval): document inner workings of the new VM loop\n\nChange-Id: I8224bf039f739c401900b5a2ddc839810c87cf6e\nReviewed-on: https://cl.tvl.fyi/c/depot/+/8226\nTested-by: BuildkiteCI\nReviewed-by: Adam Joseph \u003cadam@westernsemico.com\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d466e6dc2651c3c8536e8570d74bee401c842adb1"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d466e6dc2651c3c8536e8570d74bee401c842adb1"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"d4567053523cb3fc0a2b54245c9b25cdc52365aa","is_merged_in_target_branch":true,"change_id":"Ic31c45461a842f22aa05f4446123fe3a61dfdbc0","change_number":8291,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}
