)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"cf9b42dabee7eb66c7bb2f3f150ae93c33073a6e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"07489085_52f9f431","updated":"2023-03-14 09:50:27.000000000","message":"I\u0027m not sure if we should retain the term \"modulo\" from cppnix here, this seems misnamed to me. Maybe something more straightforward like \"drv_hash_with_fod_replacements\"?","commit_id":"d721f85f3f030828f3325f8d6d5afe9d8e4772ec"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"655d8624f999b4ba93db4761e96f508582c7da69","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b1ca5e6a_c903fdf0","in_reply_to":"07489085_52f9f431","updated":"2023-03-14 10:30:33.000000000","message":"It does do some replacements in both cases. Modulo sure is badly named, but that\u0027s how it\u0027s called in Nix 🤷‍♂️. I was thinking to rename it derivation_modulo_{hash,digest} (have the type at the end) at least.","commit_id":"d721f85f3f030828f3325f8d6d5afe9d8e4772ec"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"2c72eb20a38428e214c29f1e63058ac7e9c6a659","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ef372902_ec0f6ce9","in_reply_to":"a1aaca5f_b017499d","updated":"2023-03-14 11:14:31.000000000","message":"I used this \"replacement string\" terminology before this PR, when this was still using the lower hex representation of the digest, and then, when reading the Nix source again, realized it would make more sense to stay a bit closer to the way Nix names it.\n\nI did another pass, called this `derivation_or_fod_hash`, and updated the docs a bit more. PTAL.","commit_id":"d721f85f3f030828f3325f8d6d5afe9d8e4772ec"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"37c612e02bf8c78940dbfd3d1231b26fda5a68ff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a1aaca5f_b017499d","in_reply_to":"b1ca5e6a_c903fdf0","updated":"2023-03-14 10:50:48.000000000","message":"How would you name it if you had never seen the C++ Nix function?","commit_id":"d721f85f3f030828f3325f8d6d5afe9d8e4772ec"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"c2397d29af425cd1f610ff7e688af06b5f0eec41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fe95226f_c1b149ec","updated":"2023-03-14 11:48:54.000000000","message":"Other than the naming, LGTM.","commit_id":"4fdf0644d207a2e76b0f6f6513ab55c0c17f3957"}],"tvix/cli/src/known_paths.rs":[{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"c2397d29af425cd1f610ff7e688af06b5f0eec41","unresolved":true,"context_lines":[{"line_number":71,"context_line":"    /// All known hash derivation modulos for derivations."},{"line_number":72,"context_line":"    ///"},{"line_number":73,"context_line":"    /// Keys are derivation paths, values is the NixHash."},{"line_number":74,"context_line":"    hash_derivation_modulos: HashMap\u003cString, NixHash\u003e,"},{"line_number":75,"context_line":"}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"impl Index\u003c\u0026PathName\u003e for KnownPaths {"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"13b86c60_420ad9cf","line":74,"range":{"start_line":74,"start_character":4,"end_line":74,"end_character":27},"updated":"2023-03-14 11:48:54.000000000","message":"here, too","commit_id":"4fdf0644d207a2e76b0f6f6513ab55c0c17f3957"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"1c322f2c3ac8c0c9781533eeefafe308b5224f9c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    /// All known hash derivation modulos for derivations."},{"line_number":72,"context_line":"    ///"},{"line_number":73,"context_line":"    /// Keys are derivation paths, values is the NixHash."},{"line_number":74,"context_line":"    hash_derivation_modulos: HashMap\u003cString, NixHash\u003e,"},{"line_number":75,"context_line":"}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"impl Index\u003c\u0026PathName\u003e for KnownPaths {"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"01b3af0d_2833c6a0","line":74,"range":{"start_line":74,"start_character":4,"end_line":74,"end_character":27},"in_reply_to":"13b86c60_420ad9cf","updated":"2023-03-14 17:57:58.000000000","message":"Done","commit_id":"4fdf0644d207a2e76b0f6f6513ab55c0c17f3957"}],"tvix/nix-compat/src/derivation/mod.rs":[{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"c2397d29af425cd1f610ff7e688af06b5f0eec41","unresolved":true,"context_lines":[{"line_number":186,"context_line":"            // input_derivation paths replaced by a recursive call to this function."},{"line_number":187,"context_line":"            // We use fn_get_derivation_or_fod_hash here, so callers can precompute this."},{"line_number":188,"context_line":"            None \u003d\u003e {"},{"line_number":189,"context_line":"                // This is a new map from hash_derivation_modulo (as nix hash string) to list of output names"},{"line_number":190,"context_line":"                let mut replaced_input_derivations: BTreeMap\u003cString, BTreeSet\u003cString\u003e\u003e \u003d"},{"line_number":191,"context_line":"                    BTreeMap::new();"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"988b1f28_6ed8a841","line":189,"range":{"start_line":189,"start_character":42,"end_line":189,"end_character":64},"updated":"2023-03-14 11:48:54.000000000","message":"here and below some mentions of the old name","commit_id":"4fdf0644d207a2e76b0f6f6513ab55c0c17f3957"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"1c322f2c3ac8c0c9781533eeefafe308b5224f9c","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            // input_derivation paths replaced by a recursive call to this function."},{"line_number":187,"context_line":"            // We use fn_get_derivation_or_fod_hash here, so callers can precompute this."},{"line_number":188,"context_line":"            None \u003d\u003e {"},{"line_number":189,"context_line":"                // This is a new map from hash_derivation_modulo (as nix hash string) to list of output names"},{"line_number":190,"context_line":"                let mut replaced_input_derivations: BTreeMap\u003cString, BTreeSet\u003cString\u003e\u003e \u003d"},{"line_number":191,"context_line":"                    BTreeMap::new();"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"f539ee59_c1bd4729","line":189,"range":{"start_line":189,"start_character":42,"end_line":189,"end_character":64},"in_reply_to":"988b1f28_6ed8a841","updated":"2023-03-14 17:57:58.000000000","message":"Done","commit_id":"4fdf0644d207a2e76b0f6f6513ab55c0c17f3957"}]}