)]}'
{"id":"depot~8293","triplet_id":"depot~canon~Iebf5355f08ed5c9a044844739350f829f874f0ce","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2023-03-14 18:26:19.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2023-03-14 17:57:58.000000000","reason":"removed on reply"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2023-03-14 18:26:19.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iebf5355f08ed5c9a044844739350f829f874f0ce","subject":"refactor(tvix/nix-compat): replace calculate_drv_replacement_str","status":"MERGED","created":"2023-03-13 23:55:04.000000000","updated":"2023-03-14 18:26:19.000000000","submitted":"2023-03-14 18:26:19.000000000","submitter":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8293","meta_rev_id":"e38104935107930f1d29b1a1339f41af27309120","_number":8293,"virtual_id_number":8293,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-03-14 18:26:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-14 18:26:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-13 23:55:04.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2023-03-13 23:55:04.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2023-03-13 23:55:06.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-03-13 23:57:53.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d7b9a539c3c0eeb130bb67a99d2558926a45b350","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-03-13 23:55:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bdab956f481f1eeafbd17a55a8642d18cac37155","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-03-13 23:55:04.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* tvix/cli/src/derivation.rs\n* tvix/cli/src/known_paths.rs\n* tvix/nix-compat/src/derivation/mod.rs\n* tvix/nix-compat/src/derivation/tests/mod.rs\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":1},{"id":"9e649ba89686ccd9d211f723c37de42c9b326d26","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-13 23:55:06.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/23745","accounts_in_message":[],"_revision_number":1},{"id":"c081e98dc20fc8471cc63938630b3229e33741ab","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-13 23:57:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/23745","accounts_in_message":[],"_revision_number":1},{"id":"cf9b42dabee7eb66c7bb2f3f150ae93c33073a6e","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-14 09:50:27.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"655d8624f999b4ba93db4761e96f508582c7da69","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-03-14 10:30:33.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"37c612e02bf8c78940dbfd3d1231b26fda5a68ff","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-14 10:50:48.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"48defbdaa0a2a81c94c2c7ce04d2631b88871cfd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-03-14 11:14:31.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"2c72eb20a38428e214c29f1e63058ac7e9c6a659","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-03-14 11:14:31.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"222f1de47385781dfd3e237257be9869ef4b9bae","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-14 11:14:32.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/23753","accounts_in_message":[],"_revision_number":2},{"id":"33e1c58632f0701cd10f1d8692d763fa0f554a74","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-14 11:17:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/23753","accounts_in_message":[],"_revision_number":2},{"id":"c2397d29af425cd1f610ff7e688af06b5f0eec41","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-14 11:48:54.000000000","message":"Patch Set 2: Code-Review+2\n\n(3 comments)\n\nBy voting Code-Review+2 the following files are now code-owner approved by \u003cGERRIT_ACCOUNT_1000001\u003e:\n* tvix/cli/src/derivation.rs\n* tvix/cli/src/known_paths.rs\n* tvix/nix-compat/src/derivation/mod.rs\n* tvix/nix-compat/src/derivation/tests/mod.rs\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":2},{"id":"935a4128fb89dd874c1471f45dcbd73b79af4e9b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-03-14 17:57:58.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"((is:ANY AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"1c322f2c3ac8c0c9781533eeefafe308b5224f9c","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-03-14 17:57:58.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"420793efde92785f841aa863f4b02687ec5abd4f","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-14 17:57:59.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/23756","accounts_in_message":[],"_revision_number":3},{"id":"69124e2cb3bbb52c354d30f090fd5252fca2ebf2","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-14 18:01:46.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/23756","accounts_in_message":[],"_revision_number":3},{"id":"e38104935107930f1d29b1a1339f41af27309120","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-03-14 18:26:19.000000000","message":"Change has been successfully rebased and submitted as 5f260edf7fba9a6ad1e0ee16779df11d92686828\n\n2 is the latest approved patch-set.\nThe change was submitted with unreviewed changes in the following files:\n\n```\nThe name of the file: tvix/cli/src/known_paths.rs\nInsertions: 4, Deletions: 4.\n\n@@ -68,10 +68,10 @@\n     /// path used for reference scanning.\n     paths: HashMap\u003cPathName, KnownPath\u003e,\n \n-    /// All known hash derivation modulos for derivations.\n+    /// All known derivation or FOD hashes.\n     ///\n     /// Keys are derivation paths, values is the NixHash.\n-    hash_derivation_modulos: HashMap\u003cString, NixHash\u003e,\n+    derivation_or_fod_hashes: HashMap\u003cString, NixHash\u003e,\n }\n \n impl Index\u003c\u0026PathName\u003e for KnownPaths {\n@@ -160,7 +160,7 @@\n     pub fn get_hash_derivation_modulo(\u0026self, drv_path: \u0026str) -\u003e NixHash {\n         // TODO: we rely on an invariant that things *should* have\n         // been calculated if we get this far.\n-        self.hash_derivation_modulos[drv_path].clone()\n+        self.derivation_or_fod_hashes[drv_path].clone()\n     }\n \n     pub fn add_hash_derivation_modulo\u003cD: ToString\u003e(\n@@ -170,7 +170,7 @@\n     ) {\n         #[allow(unused_variables)] // assertions on this only compiled in debug builds\n         let old \u003d self\n-            .hash_derivation_modulos\n+            .derivation_or_fod_hashes\n             .insert(drv.to_string(), hash_derivation_modulo.to_owned());\n \n         #[cfg(debug_assertions)]\n```\n```\nThe name of the file: tvix/nix-compat/src/derivation/mod.rs\nInsertions: 10, Deletions: 7.\n\n@@ -186,12 +186,15 @@\n             // input_derivation paths replaced by a recursive call to this function.\n             // We use fn_get_derivation_or_fod_hash here, so callers can precompute this.\n             None \u003d\u003e {\n-                // This is a new map from hash_derivation_modulo (as nix hash string) to list of output names\n+                // This is a new map from derivation_or_fod_hash.digest (as lowerhex)\n+                // to list of output names\n                 let mut replaced_input_derivations: BTreeMap\u003cString, BTreeSet\u003cString\u003e\u003e \u003d\n                     BTreeMap::new();\n \n-                // For each input_derivation, look up the hash_derivation_modulo, and replace the derivation path with that.\n-                // This is not the [NixHash::to_nix_hash_string], but only the digest in data_encoding::HEXLOWER (without the sha256: prefix).\n+                // For each input_derivation, look up the\n+                // derivation_or_fod_hash, and replace the derivation path with it\u0027s HEXLOWER\n+                // digest.\n+                // This is not the [NixHash::to_nix_hash_string], but without the sha256: prefix).\n                 for (drv_path, output_names) in \u0026self.input_derivations {\n                     replaced_input_derivations.insert(\n                         data_encoding::HEXLOWER\n@@ -221,7 +224,7 @@\n     /// and self.environment[$outputName] needs to be an empty string.\n     ///\n     /// Output path calculation requires knowledge of the\n-    /// hash_derivation_modulo [NixHash], which (in case of non-fixed-output\n+    /// derivation_or_fod_hash [NixHash], which (in case of non-fixed-output\n     /// derivations) also requires knowledge of other hash_derivation_modulo\n     /// [NixHash]es.\n     ///\n@@ -234,7 +237,7 @@\n     pub fn calculate_output_paths(\n         \u0026mut self,\n         name: \u0026str,\n-        hash_derivation_modulo: \u0026NixHash,\n+        derivation_or_fod_hash: \u0026NixHash,\n     ) -\u003e Result\u003c(), DerivationError\u003e {\n         // Check if the Derivation is fixed output, because they cause\n         // different fingerprints to be hashed.\n@@ -257,7 +260,7 @@\n                     let s \u003d \u0026format!(\n                         \"output:{}:{}:{}:{}\",\n                         output_name,\n-                        hash_derivation_modulo.to_nix_hash_string(),\n+                        derivation_or_fod_hash.to_nix_hash_string(),\n                         store_path::STORE_DIR,\n                         output_path_name,\n                     );\n@@ -290,7 +293,7 @@\n                     } else {\n                         s.push_str(\"output:out:\");\n                         // This is drv_replacement for FOD, with an empty fixed_output_path.\n-                        s.push_str(\u0026hash_derivation_modulo.to_nix_hash_string());\n+                        s.push_str(\u0026derivation_or_fod_hash.to_nix_hash_string());\n                     }\n                     s.push_str(\u0026format!(\":{}:{}\", store_path::STORE_DIR, name));\n                     s\n```\n","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"5f260edf7fba9a6ad1e0ee16779df11d92686828","revisions":{"d721f85f3f030828f3325f8d6d5afe9d8e4772ec":{"kind":"REWORK","_number":1,"created":"2023-03-13 23:55:04.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/93/8293/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/93/8293/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/93/8293/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/93/8293/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/93/8293/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/93/8293/1"}}},"commit":{"parents":[{"commit":"1e80b9ea8b9a28588a90a0835988bb3b3067e7d6","subject":"chore(tvix/eval): mark async functions which are called by the VM","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1e80b9ea8b9a28588a90a0835988bb3b3067e7d6"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-03-13 22:52:23.000000000","tz":60},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-03-13 23:52:38.000000000","tz":60},"subject":"refactor(tvix/nix-compat): replace calculate_drv_replacement_str","message":"refactor(tvix/nix-compat): replace calculate_drv_replacement_str\n\nCall this function hash_derivation_modulo, and return a NixHash.\n\nThis is more in line with how cppnix calls this, and allows using\nto_nix_hash_string() in some places.\n\nChange-Id: Iebf5355f08ed5c9a044844739350f829f874f0ce\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd721f85f3f030828f3325f8d6d5afe9d8e4772ec"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd721f85f3f030828f3325f8d6d5afe9d8e4772ec"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1e80b9ea8b9a28588a90a0835988bb3b3067e7d6","is_merged_in_target_branch":true,"change_id":"Id15945d5a92bf52c16d93456e3437f91d93bdc57","change_number":8290,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"4fdf0644d207a2e76b0f6f6513ab55c0c17f3957":{"kind":"REWORK","_number":2,"created":"2023-03-14 11:14:31.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/93/8293/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/93/8293/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/93/8293/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/93/8293/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/93/8293/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/93/8293/2"}}},"commit":{"parents":[{"commit":"1e80b9ea8b9a28588a90a0835988bb3b3067e7d6","subject":"chore(tvix/eval): mark async functions which are called by the VM","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1e80b9ea8b9a28588a90a0835988bb3b3067e7d6"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-03-13 22:52:23.000000000","tz":60},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-03-14 11:14:01.000000000","tz":60},"subject":"refactor(tvix/nix-compat): replace calculate_drv_replacement_str","message":"refactor(tvix/nix-compat): replace calculate_drv_replacement_str\n\nCall this function derivation_or_fod_hash, and return a NixHash.\n\nThis is more in line with how cppnix calls this, and allows using\nto_nix_hash_string() in some places.\n\nChange-Id: Iebf5355f08ed5c9a044844739350f829f874f0ce\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4fdf0644d207a2e76b0f6f6513ab55c0c17f3957"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4fdf0644d207a2e76b0f6f6513ab55c0c17f3957"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1e80b9ea8b9a28588a90a0835988bb3b3067e7d6","is_merged_in_target_branch":true,"change_id":"Id15945d5a92bf52c16d93456e3437f91d93bdc57","change_number":8290,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"a9780f6ba9455d63846bdea37432a95783d98d60":{"kind":"REWORK","_number":3,"created":"2023-03-14 17:57:58.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/93/8293/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/93/8293/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/93/8293/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/93/8293/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/93/8293/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/93/8293/3"}}},"commit":{"parents":[{"commit":"1e80b9ea8b9a28588a90a0835988bb3b3067e7d6","subject":"chore(tvix/eval): mark async functions which are called by the VM","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1e80b9ea8b9a28588a90a0835988bb3b3067e7d6"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-03-13 22:52:23.000000000","tz":60},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-03-14 17:57:39.000000000","tz":60},"subject":"refactor(tvix/nix-compat): replace calculate_drv_replacement_str","message":"refactor(tvix/nix-compat): replace calculate_drv_replacement_str\n\nCall this function derivation_or_fod_hash, and return a NixHash.\n\nThis is more in line with how cppnix calls this, and allows using\nto_nix_hash_string() in some places.\n\nChange-Id: Iebf5355f08ed5c9a044844739350f829f874f0ce\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da9780f6ba9455d63846bdea37432a95783d98d60"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da9780f6ba9455d63846bdea37432a95783d98d60"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1e80b9ea8b9a28588a90a0835988bb3b3067e7d6","is_merged_in_target_branch":true,"change_id":"Id15945d5a92bf52c16d93456e3437f91d93bdc57","change_number":8290,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"5f260edf7fba9a6ad1e0ee16779df11d92686828":{"kind":"REWORK","_number":4,"created":"2023-03-14 18:26:19.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/93/8293/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/93/8293/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/93/8293/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/93/8293/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/93/8293/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/93/8293/4"}}},"commit":{"parents":[{"commit":"32999cb6f60ec89099f1f5295038cfeca2fb106a","subject":"docs(tvix/eval): suggested layout adjustment to VM loop diagram","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d32999cb6f60ec89099f1f5295038cfeca2fb106a"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-03-13 22:52:23.000000000","tz":60},"committer":{"name":"flokli","email":"flokli@flokli.de","date":"2023-03-14 18:26:19.000000000","tz":0},"subject":"refactor(tvix/nix-compat): replace calculate_drv_replacement_str","message":"refactor(tvix/nix-compat): replace calculate_drv_replacement_str\n\nCall this function derivation_or_fod_hash, and return a NixHash.\n\nThis is more in line with how cppnix calls this, and allows using\nto_nix_hash_string() in some places.\n\nChange-Id: Iebf5355f08ed5c9a044844739350f829f874f0ce\nReviewed-on: https://cl.tvl.fyi/c/depot/+/8293\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5f260edf7fba9a6ad1e0ee16779df11d92686828"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5f260edf7fba9a6ad1e0ee16779df11d92686828"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"32999cb6f60ec89099f1f5295038cfeca2fb106a","is_merged_in_target_branch":true,"change_id":"I5467cd66801ad8fe6c4ec0ae337763f1762cea1c","change_number":8252,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}