)]}'
{"id":"depot~8351","triplet_id":"depot~canon~I50bfd4a0d9eb11832847329b78c587ec7c9dc7b1","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2023-03-27 09:00:23.000000000","reason":"removed on reply"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2023-03-27 09:03:34.000000000","reason":"Change was submitted"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2023-03-27 09:03:34.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I50bfd4a0d9eb11832847329b78c587ec7c9dc7b1","subject":"feat(tvix/store/directorysvc): add DirectoryService::get_recursive()","status":"MERGED","created":"2023-03-26 15:26:19.000000000","updated":"2023-03-27 09:03:34.000000000","submitted":"2023-03-27 09:03:34.000000000","submitter":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8352","meta_rev_id":"ad469f65caaaecee2375f44678d8d6a5366d7a4a","_number":8351,"virtual_id_number":8351,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-03-27 09:03:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-27 09:03:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-03-27 09:03:34.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-26 15:26:19.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2023-03-26 15:26:19.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2023-03-26 15:26:22.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-03-26 15:30:12.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ed7210e23e0b110636dc48d7259af8a3d392c30d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-03-26 15:26:19.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"94f1a505f60667fc8877789736bc01e6cfd5fffe","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-03-26 15:26:19.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* tvix/store/src/directoryservice/grpc.rs\n* tvix/store/src/directoryservice/memory.rs\n* tvix/store/src/directoryservice/mod.rs\n* tvix/store/src/directoryservice/sled.rs\n* tvix/store/src/proto/grpc_directoryservice_wrapper.rs\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":1},{"id":"2257e06011c7797b451bcf046bf35d519d5cbbd9","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-26 15:26:22.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/23928","accounts_in_message":[],"_revision_number":1},{"id":"396197c2774fff1b5248dea32b417e12039850f7","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-26 15:30:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/23928","accounts_in_message":[],"_revision_number":1},{"id":"1530b6b38e61d5a70ce5f0888b29ea4f6bf072dc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-03-26 15:31:12.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent tree, and commit message as Patch Set 1.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"90cacc72b2d281ef75c432e17c39652afc4d1c59","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-03-27 08:29:41.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"106b9ea0e0a5b6a2059574963b76b865294e2a77","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-27 08:29:43.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/23935","accounts_in_message":[],"_revision_number":3},{"id":"9f618249d26731db754c23b7e511df16caed1a2e","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-27 08:33:30.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/23935","accounts_in_message":[],"_revision_number":3},{"id":"a7da9b41a979c9f8d05f1dfe41e2716e51b97f12","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-03-27 09:00:23.000000000","message":"Patch Set 3: Code-Review+2\n\nBy voting Code-Review+2 the following files are now code-owner approved by \u003cGERRIT_ACCOUNT_1000001\u003e:\n* tvix/store/src/directoryservice/grpc.rs\n* tvix/store/src/directoryservice/memory.rs\n* tvix/store/src/directoryservice/mod.rs\n* tvix/store/src/directoryservice/sled.rs\n* tvix/store/src/proto/grpc_directoryservice_wrapper.rs\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":3},{"id":"d2b7e69446e0573eec5934504465188cb2a807d6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2023-03-27 09:00:44.000000000","message":"Patch Set 4: Patch Set 3 was rebased\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n* Code-Review+2 (copy condition: \"((is:ANY AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"300d7e1d06515ff4997992fba9c3d9b03b80c963","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-27 09:00:45.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/23947","accounts_in_message":[],"_revision_number":4},{"id":"82896532aa8a8e611bb7ad072991f4e2a81b61c6","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-03-27 09:02:54.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/23947","accounts_in_message":[],"_revision_number":4},{"id":"ad469f65caaaecee2375f44678d8d6a5366d7a4a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-03-27 09:03:34.000000000","message":"Change has been successfully rebased and submitted as 2fe53cce40af94d9c8e6971cbf32073ecc77d4a1\n\n3 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"2fe53cce40af94d9c8e6971cbf32073ecc77d4a1","revisions":{"ebd4f85eb6b034c37e13b9b4c0f89b75ae870f4a":{"kind":"REWORK","_number":1,"created":"2023-03-26 15:26:19.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/51/8351/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/51/8351/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/51/8351/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/51/8351/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/51/8351/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/51/8351/1"}}},"commit":{"parents":[{"commit":"c72450a30788e296a03914d1f7396390d985aa91","subject":"feat(tvix/store/directorysvc): add gRPC client","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc72450a30788e296a03914d1f7396390d985aa91"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-03-26 11:51:48.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-03-26 15:25:57.000000000","tz":120},"subject":"feat(tvix/store/directorysvc): add DirectoryService::get_recursive()","message":"feat(tvix/store/directorysvc): add DirectoryService::get_recursive()\n\nThis moves the recursive BFS traversal of Directory closures from the\nGRPCDirectoryServiceWrapper out into a a DirectoryTraverser struct\nimplementing Iterator.\n\nIt is then used from various implementors of DirectoryService in the\n`get_recursive()` method.\n\nThis allows distinguishing between recursive requests and non-recursive\nrequests in the gRPC client trait implementation.\n\nChange-Id: I50bfd4a0d9eb11832847329b78c587ec7c9dc7b1\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003debd4f85eb6b034c37e13b9b4c0f89b75ae870f4a"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003debd4f85eb6b034c37e13b9b4c0f89b75ae870f4a"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c72450a30788e296a03914d1f7396390d985aa91","is_merged_in_target_branch":false,"change_id":"I7ffec791610b72c0960cf5307cefbb12ec946dc9","change_number":8336,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"04ea895fb60435fd984393eb5a88ec27cdae3707":{"kind":"NO_CHANGE","_number":2,"created":"2023-03-26 15:31:12.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/51/8351/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/51/8351/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/51/8351/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/51/8351/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/51/8351/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/51/8351/2"}}},"commit":{"parents":[{"commit":"7e299c5cadd4031b0586ee3167d4700997926f87","subject":"feat(tvix/store/directorysvc): add gRPC client","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7e299c5cadd4031b0586ee3167d4700997926f87"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-03-26 11:51:48.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-03-26 15:30:36.000000000","tz":120},"subject":"feat(tvix/store/directorysvc): add DirectoryService::get_recursive()","message":"feat(tvix/store/directorysvc): add DirectoryService::get_recursive()\n\nThis moves the recursive BFS traversal of Directory closures from the\nGRPCDirectoryServiceWrapper out into a a DirectoryTraverser struct\nimplementing Iterator.\n\nIt is then used from various implementors of DirectoryService in the\n`get_recursive()` method.\n\nThis allows distinguishing between recursive requests and non-recursive\nrequests in the gRPC client trait implementation.\n\nChange-Id: I50bfd4a0d9eb11832847329b78c587ec7c9dc7b1\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d04ea895fb60435fd984393eb5a88ec27cdae3707"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d04ea895fb60435fd984393eb5a88ec27cdae3707"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"7e299c5cadd4031b0586ee3167d4700997926f87","is_merged_in_target_branch":false,"change_id":"I7ffec791610b72c0960cf5307cefbb12ec946dc9","change_number":8336,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"701760e7b0462f9d929d9a4d8419e78cc0d24949":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-03-27 08:29:41.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/51/8351/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/51/8351/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/51/8351/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/51/8351/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/51/8351/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/51/8351/3"}}},"commit":{"parents":[{"commit":"c5c611885e2dada619d8d8dee3191ce23fa1af64","subject":"feat(tvix/store/directorysvc): add gRPC client","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc5c611885e2dada619d8d8dee3191ce23fa1af64"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-03-26 11:51:48.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-03-27 08:29:36.000000000","tz":120},"subject":"feat(tvix/store/directorysvc): add DirectoryService::get_recursive()","message":"feat(tvix/store/directorysvc): add DirectoryService::get_recursive()\n\nThis moves the recursive BFS traversal of Directory closures from the\nGRPCDirectoryServiceWrapper out into a a DirectoryTraverser struct\nimplementing Iterator.\n\nIt is then used from various implementors of DirectoryService in the\n`get_recursive()` method.\n\nThis allows distinguishing between recursive requests and non-recursive\nrequests in the gRPC client trait implementation.\n\nChange-Id: I50bfd4a0d9eb11832847329b78c587ec7c9dc7b1\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d701760e7b0462f9d929d9a4d8419e78cc0d24949"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d701760e7b0462f9d929d9a4d8419e78cc0d24949"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c5c611885e2dada619d8d8dee3191ce23fa1af64","is_merged_in_target_branch":false,"change_id":"I7ffec791610b72c0960cf5307cefbb12ec946dc9","change_number":8336,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f7b6d3c4da5c15531ec5f028f284c23ffc12c56e":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2023-03-27 09:00:44.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/51/8351/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/51/8351/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/51/8351/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/51/8351/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/51/8351/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/51/8351/4"}}},"commit":{"parents":[{"commit":"367a5e9922264b787667fd5e750c8eadf8a7796f","subject":"feat(tvix/store/directorysvc): add gRPC client","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d367a5e9922264b787667fd5e750c8eadf8a7796f"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-03-26 11:51:48.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2023-03-27 09:00:44.000000000","tz":0},"subject":"feat(tvix/store/directorysvc): add DirectoryService::get_recursive()","message":"feat(tvix/store/directorysvc): add DirectoryService::get_recursive()\n\nThis moves the recursive BFS traversal of Directory closures from the\nGRPCDirectoryServiceWrapper out into a a DirectoryTraverser struct\nimplementing Iterator.\n\nIt is then used from various implementors of DirectoryService in the\n`get_recursive()` method.\n\nThis allows distinguishing between recursive requests and non-recursive\nrequests in the gRPC client trait implementation.\n\nChange-Id: I50bfd4a0d9eb11832847329b78c587ec7c9dc7b1\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df7b6d3c4da5c15531ec5f028f284c23ffc12c56e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df7b6d3c4da5c15531ec5f028f284c23ffc12c56e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"367a5e9922264b787667fd5e750c8eadf8a7796f","is_merged_in_target_branch":true,"change_id":"I7ffec791610b72c0960cf5307cefbb12ec946dc9","change_number":8336,"patch_set_number":8,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"},"2fe53cce40af94d9c8e6971cbf32073ecc77d4a1":{"kind":"REWORK","_number":5,"created":"2023-03-27 09:03:34.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/51/8351/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/51/8351/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/51/8351/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/51/8351/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/51/8351/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/51/8351/5"}}},"commit":{"parents":[{"commit":"2d305fd5b37fa7bf5a0512e8992b4557a1745296","subject":"refactor(tvix/eval): retain call frames when entering calls","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2d305fd5b37fa7bf5a0512e8992b4557a1745296"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-03-26 11:51:48.000000000","tz":120},"committer":{"name":"flokli","email":"flokli@flokli.de","date":"2023-03-27 09:03:34.000000000","tz":0},"subject":"feat(tvix/store/directorysvc): add DirectoryService::get_recursive()","message":"feat(tvix/store/directorysvc): add DirectoryService::get_recursive()\n\nThis moves the recursive BFS traversal of Directory closures from the\nGRPCDirectoryServiceWrapper out into a a DirectoryTraverser struct\nimplementing Iterator.\n\nIt is then used from various implementors of DirectoryService in the\n`get_recursive()` method.\n\nThis allows distinguishing between recursive requests and non-recursive\nrequests in the gRPC client trait implementation.\n\nChange-Id: I50bfd4a0d9eb11832847329b78c587ec7c9dc7b1\nReviewed-on: https://cl.tvl.fyi/c/depot/+/8351\nAutosubmit: flokli \u003cflokli@flokli.de\u003e\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2fe53cce40af94d9c8e6971cbf32073ecc77d4a1"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2fe53cce40af94d9c8e6971cbf32073ecc77d4a1"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2d305fd5b37fa7bf5a0512e8992b4557a1745296","is_merged_in_target_branch":true,"change_id":"I89f058ef31979edacf4667775d460b60704ce4d7","change_number":8334,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}